GNU bug report logs - #78297
[PATCH electronics-team] gnu: Add python-pydigitalwavetools.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78297 <at> debbugs.gnu.org, Gabriel Wicki <gabriel <at> erlikon.ch>, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: [bug#78297] [PATCH electronics-team] gnu: Add python-pydigitalwavetools.
Date: Mon, 12 May 2025 21:34:49 +0900

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> writes:

> From: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
>
> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.

[...]

> +    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
> +    (synopsis "Library to manipulate digital wave files.")
> +    (description
> +     "Pydigitalwavetools is a Python library to parse, write and format
> +@acronym{VCD, Value Champ Dump} and other digital wave files.")
> +    (license license:expat)))

Are you sure about VCD being 'Value Champ Dump' and not Video CD as I
thought?  The later seemed more sensical to me, this being about some
digital audio files :-).

You missed my earlier suggestion to turn 'wave' or 'wav' into WAV'.

The synopsis should not end with a '.'; please run './pre-inst-env guix
lint python-pydigitalwavetools' to catch these things.

Could you send a v3?

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.