GNU bug report logs - #78297
[PATCH electronics-team] gnu: Add python-pydigitalwavetools.

Previous Next

Full log

Message #11 received at 78297 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78297 <at> debbugs.gnu.org, Gabriel Wicki <gabriel <at> erlikon.ch>,
 Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78297: [PATCH electronics-team] gnu: Add
 python-pydigitalwavetools.
Date: Thu, 08 May 2025 16:52:32 +0900

Hi,

Cayetano Santos <csantosb <at> inventati.org> writes:

> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.
>
> Change-Id: Iff4d12231b366cff20b386fb1d1ae121ef50e51e
> ---
>  gnu/packages/electronics.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
> index 4df7064243..db9459ac03 100644
> --- a/gnu/packages/electronics.scm
> +++ b/gnu/packages/electronics.scm
> @@ -551,6 +551,30 @@ (define-public python-edalize
>  some tool-specific options are set.")
>      (license license:bsd-2)))
>  
> +(define-public python-pydigitalwavetools
> +  (package
> +    (name "python-pydigitalwavetools")
> +    (version "1.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/Nic30/pyDigitalWaveTools/")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1zbk4ndpwm4h8vdv9f567bpsizpy6q4jf0xmma77h0gsnnaqkwis"))))
> +    (build-system pyproject-build-system)
> +    (native-inputs
> +     (list python-pytest
> +           python-setuptools
> +           python-wheel))
> +    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
> +    (synopsis "Library to manipulate digital wave files.")
> +    (description
> +     "Pydigitalwavetools is a python library to parse, write and format VCD and other digital wave files.")

Please M-x fill-paragraph (M-q) or equivalent in your editor to meet our
80 columns maximum width guideline.  Also,

s/python/Python/
s/wav/WAV/

I'd also use @acronym{VCD, Video CD}, and @acronym{WAV, Waveform Audio
File Format} in the description.

Could you please send a v2 with these small suggested improvements?

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.