Subject: Re: bug#78297: [PATCH electronics-team] gnu: Add python-pydigitalwavetools.

From: Cayetano Santos <[email-masked]>
Date: Mon, 12 May 2025 14:54:19 +0200

>lun. 12 mai 2025 at 21:34, Maxim Cournoyer <[email-masked]> wrote:

> Hi Cayetano,
>
> Cayetano Santos <[email-masked]> writes:
>
>> From: Cayetano Santos via Guix-patches via <[email-masked]>
>>
>> * gnu/packages/electronics.scm (python-pydigitalwavetools): New variable.
>
> [...]
>
>> +    (home-page "https://github.com/Nic30/pyDigitalWaveTools/")
>> +    (synopsis "Library to manipulate digital wave files.")
>> +    (description
>> +     "Pydigitalwavetools is a Python library to parse, write and format
>> +@acronym{VCD, Value Champ Dump} and other digital wave files.")
>> +    (license license:expat)))
>
> Are you sure about VCD being 'Value Champ Dump' and not Video CD as I
> thought?  The later seemed more sensical to me, this being about some
> digital audio files :-).

Yes. Where exactly do you see any reference to audio in here ?

See, for example

    https://github.com/Nic30/pyDigitalWaveTools/?tab=readme-ov-file#related-open-source

This is what VCD is all about:

    https://pyvcd.readthedocs.io/en/latest/vcd.gtkw.html

> You missed my earlier suggestion to turn 'wave' or 'wav' into WAV'.

Yes, just because this has nothing to do with WAV audio format. Is this
comment still relevant for v3 ?

> The synopsis should not end with a '.'; please run './pre-inst-env guix
> lint python-pydigitalwavetools' to catch these things.

You’re right, my bad !

C.