GNU bug report logs - #78291
[PATCH] Add new gv place definitions

Previous Next

Full log

Message #14 received at 78291 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: monnier <at> iro.umontreal.ca, Zach Shaftel <zach <at> shaf.tel>
Cc: 78291 <at> debbugs.gnu.org
Subject: Re: bug#78291: [PATCH] Add new gv place definitions
Date: Sat, 24 May 2025 12:09:17 +0300

Ping!  Can we please make some progress with this?

> Cc: 78291 <at> debbugs.gnu.org
> Date: Tue, 13 May 2025 13:38:33 -0400
> From:  Zach Shaftel via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> >> @@ -427,6 +434,14 @@ window-dedicated-p
> >>  (gv-define-setter window-hscroll (v &optional w) `(set-window-hscroll ,w ,v))
> >>  (gv-define-setter window-point (v &optional w) `(set-window-point ,w ,v))
> >>  (gv-define-setter window-start (v &optional w) `(set-window-start ,w ,v))
> >> +(gv-define-setter window-prev-buffers (v &optional w) `(set-window-prev-buffers ,w ,v))
> >> +(gv-define-setter window-next-buffers (v &optional w) `(set-window-next-buffers ,w ,v))
> >> +(gv-define-setter window-new-normal (v &optional w) `(set-window-new-normal ,w ,v))
> >> +(gv-define-simple-setter font-get font-put)
> >> +(gv-define-simple-setter charset-plist set-charset-plist)
> >> +(gv-define-simple-setter get-charset-property put-charset-property t)
> >> +(gv-define-setter lookup-key (val keymap key &optional _accept-default)
> >> +  `(define-key ,keymap ,key ,val))
> >
> > I'd have to check some of them, but at least the last doesn't look like
> > a good idea to me, because they don't quite match.  E.g. if you
> >
> >     (define-key MAP KEY '(menu-item TEXT CMD))
> >
> > The corresponding `lookup-key` will return just CMD rather than
> > (menu-item TEXT CMD).
> >
> >
> >         Stefan
> 
> yeah I knew that one was questionable, and considering the keymap-*
> functions are now the standard interface to key bindings it probably
> wouldn't get much use anyway. as far as i could tell, the other setters
> all accept the same values that the getter would return, but there may
> be other idiosyncrasies i'm not aware of. let me know what ought to be
> removed and i can submit a new patch.
> 
> 
> 
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.