GNU bug report logs - #78263
[PATCH 1/3] Ignore OSC sequences in term instead of printing them

Previous Next

Package: emacs;

Reported by: Stephane Zermatten <szermatt <at> gmail.com>

Date: Mon, 5 May 2025 15:21:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78263: closed ([PATCH 1/3] Ignore OSC sequences in term
 instead of printing them)
Date: Thu, 12 Jun 2025 08:41:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 12 Jun 2025 11:40:03 +0300
with message-id <86plf9fj4s.fsf <at> gnu.org>
and subject line Re: bug#78263: [PATCH 1/3] Ignore OSC sequences in term instead of printing them
has caused the debbugs.gnu.org bug report #78263,
regarding [PATCH 1/3] Ignore OSC sequences in term instead of printing them
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78263: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78263
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Stephane Zermatten <szermatt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH 1/3] Ignore OSC sequences in term instead of printing them
Date: Mon, 05 May 2025 17:30:35 +0300
[Message part 3 (text/plain, inline)]
Tags: patch


This change detects OSC sequences and ignores them. This is what's
normally expected and avoids strange outputs.

Starting with version 4, the fish shell has started sending out OSC
sequences by default, which looks pretty bad on term. This change avoids
this particular problem.

This is PATCH 1/3, because I'd like to propose making it possible to
handle OSC sequences in term in follow-up changes. Emacs already has
handlers for OSC sequences in ansi-osc, why not make use of them?

In GNU Emacs 31.0.50 (build 5, x86_64-apple-darwin23.6.0, NS
 appkit-2487.70 Version 14.7.5 (Build 23H527)) of 2025-05-02 built on
 boomer.zia
Repository revision: 99ca41b6ef300653a0d15b73a0c0d446a9a9e059
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2487
System Description:  macOS 14.7.5

Configured using:
 'configure --program-suffix=-head --with-tree-sitter
 --with-native-compilation=aot'

[0001-Ignore-OSC-sequences-in-term-instead-of-printing-the.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Stéphane Zermatten <szermatt <at> gmail.com>
Cc: 78263-done <at> debbugs.gnu.org, per <at> bothner.com,
 Jared Finder <jared <at> finder.org>
Subject: Re: bug#78263: [PATCH 1/3] Ignore OSC sequences in term instead of
 printing them
Date: Thu, 12 Jun 2025 11:40:03 +0300
> From: Stéphane Zermatten <szermatt <at> gmail.com>
> Date: Thu, 12 Jun 2025 11:25:15 +0300
> 
> I’m sorry I messed up the patch. I thought I had been careful, but not enough 🙁 My workflow needs work. 
> 
> I attached a patch that fixes the breaking test on the main branch. The unicode characters hardcoded in the test file were messed up somehow, so in the patch I propose using the \u notation instead of hardcoding “αβ”. 

Thanks, the test now passes.  Installed on the master branch, and
closing the bug.


This bug report was last modified 3 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.