GNU bug report logs - #78263
[PATCH 1/3] Ignore OSC sequences in term instead of printing them

Previous Next

Full log

Message #53 received at 78263 <at> debbugs.gnu.org (full text, mbox):

From: Jared Finder <jared <at> finder.org>
To: Stéphane Zermatten <szermatt <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Per Bothner <per <at> bothner.com>,
 78263 <at> debbugs.gnu.org
Subject: Re: bug#78263: [PATCH 1/3] Ignore OSC sequences in term instead of
 printing them
Date: Wed, 04 Jun 2025 22:44:20 -0700

On 2025-06-04 11:04, Stéphane Zermatten wrote:
>> On 3 Jun 2025, at 14:09, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> 
>>> From: Stéphane Zermatten <szermatt <at> gmail.com>
>>> Date: Mon, 2 Jun 2025 20:01:32 +0300
>>> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>>> Per Bothner <per <at> bothner.com>,
>>> 78263 <at> debbugs.gnu.org
>>> 
>>> I updated the change, see the new version attached.

One additional comment -- why is term-osc-handlers a defcustom at all?  
It seems to me like a variable that is used just to implement the OSC 
handlers and not something I'd expect users to customize.  Looking at 
ansi-osc-handlers, it's just a defvar.  I can't think of a case where I 
would expect a user to add or remove a custom handler.  I do think users 
may want to enable or disable certain features, but that would affect 
multiple handlers like if a user wanted to not allow changing dynamic 
colors (OSC 10 to 19).  That seems better served with separate defcustom 
variables for each feature, like a term-allow-color-ops defcustom.

I'm otherwise ok with the patch.

  -- MJF

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.