Subject: bug#78263: [PATCH 1/3] Ignore OSC sequences in term instead of printing them

From: Eli Zaretskii <[email-masked]>
Date: Thu, 05 Jun 2025 08:29:25 +0300

> From: Stéphane Zermatten <[email-masked]>
> Date: Wed, 4 Jun 2025 21:04:58 +0300
> Cc: Jared Finder <[email-masked]>,
>  Per Bothner <[email-masked]>,
>  [email-masked]
> 
> > Please reformat the log message according to our conventions: function
> > and variable names in parentheses, 2 spaces between sentences, etc.
> > For the details see CONTRIBUTE and also consult the many examples of
> > log messages in Git.
> 
> Done (Correctly, this time, hopefully)

Yes, thanks.

> >> +(defcustom term-osc-handlers nil
> >> +  "Terminal-specific OSC sequence handler function alist.
> >> +
> >> +OSC (Operating System Command) is a category of ANSI escape sequence
> >> +used in terminal application to introduce custom commands. Terminals
> >> +ignore unknown OSC sequences by default. Handlers can be registered here
> >> +to add support for new OSC sequences to `term'.
> > 
> > Two spaces between sentences, here and elsewhere.
> 
> Done 

Not in all the cases.  Here's one:

> +(defcustom term-osc-handlers nil
> +  "Terminal-specific OSC sequence handler function alist.
> +
> +OSC (Operating System Command) is a category of ANSI escape sequence
> +used in terminal application to introduce custom commands. Terminals
                                                            ^^
Here's another:

> +   ;; OSC (see [ECMA-48] section 8.3.89 "Operation System Command") The
                                                                     ^^^
Here, a period is missing as well.

> >> +FUNCTION is called with two arguments CODE and TEXT with the term buffer
> >> +active and its point and state active at the time the OSC sequence
> >> +appeared in the stream.
> > 
> > This should clarify what is TEXT in this context.
> 
> A rephrased it a bit. Hopefully it is clearer.

It is, thanks.

Please fix those nits, and then we should wait for your
copyright-assignment paperwork to be completed, and for Jared to
respond to your previous message.