GNU bug report logs - #78262
30.1; comint-delchar-or-maybe-eof doesn't respect delete-active-region

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: sebastian <at> sebasmonia.com, Eli Zaretskii <eliz <at> gnu.org>, 78262 <at> debbugs.gnu.org
Subject: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect delete-active-region
Date: Mon, 12 May 2025 20:46:35 +0300

>>>> PS: this still requires
>>>>
>>>>   (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)
>>>>
>>>> that could be added later.
>>>
>>> Hmm... sorry my `delete-selection`-fu is rusty, what would this
>>> do/fix, again?
>>
>> This is a copy from delsel.el
>>
>>   ;; delete-backward-char and delete-forward-char already delete the selection by
>>   ;; default, but not delete-char.
>>   (put 'delete-char 'delete-selection 'supersede)
>>
>> that will do the same for 'comint-delchar-or-maybe-eof'
>> that uses 'delete-char' by default.
>
> Ah.  I consider this part of delsel.el to be obsolete (made obsolete
> back in Emacs-24 by the `delete-active-region` variable).

It seems the primary reason people are rebinding `C-d` from `delete-char`
to `delete-forward-char` is to be able to delete the region with it.

> If `delsel.el` wants to make `C-d` delete the active region, it should
> preferably do it by remapping `delete-char` to `delete-forward-char`, IMO.

Not sure if `delsel.el` should rebind the global keybindings.

Anyway, your latest patch is sufficient for closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.