GNU bug report logs - #78262
30.1; comint-delchar-or-maybe-eof doesn't respect delete-active-region

Previous Next

Full log

Message #29 received at 78262 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: sebastian <at> sebasmonia.com, 78262 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#78262: 30.1; comint-delchar-or-maybe-eof doesn't respect
 delete-active-region
Date: Sun, 11 May 2025 08:55:38 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Juri Linkov <juri <at> linkov.net>,  sebastian <at> sebasmonia.com,
>   78262 <at> debbugs.gnu.org
> Date: Sun, 11 May 2025 00:14:16 -0400
> 
> > This assumes that everyone will want the same command bound to C-d
> > globally to be invoked by C-d in comint-mode.  But is that assumption
> > necessarily true?
> 
> It's hard to handle all possible worlds at the same time, so I think
> we have to presume the answer is "yes".  If they want something
> different, they'll have to rebind it explicitly in `comint-mode-map`.

The issue here is whether to support active region (which C-d does).
Are we sure users of comint want that in respective modes?

> -(defun comint-delchar-or-maybe-eof (arg)
> -  "Delete ARG characters forward or send an EOF to subprocess.
> +(defun comint-delchar-or-maybe-eof ()
> +  "Do like the global binding or send an EOF to subprocess.

I think we need to leave ARG in place, at least as an optional
argument, since otherwise this would be a breaking change.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.