GNU bug report logs - #78231
[PATCH] ocaml: binsec: Wrap program to set OCAMLPATH

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 78231 in the body.
You can then email your comments to 78231 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: soeren <at> soeren-tempel.net
To: guix-patches <at> gnu.org
Cc: jgart <at> dismail.de
Subject: [PATCH] ocaml: binsec: Wrap program to set OCAMLPATH
Date: Sat,  3 May 2025 16:38:26 +0200

From: Sören Tempel <soeren <at> soeren-tempel.net>

Otherwise, dune plugins cannot be loaded which results in some command
line options to not work correctly. For example, binsec --help errors
with "The library "binsec.sse.checkct" can't be found in the search
paths". To fix this, this patch adds a wrap-programs phase.

Fixes https://issues.guix.gnu.org/69996

* gnu/packages/ocaml.scm (binsec) <arguments>: Add wrap-programs phase.
---
 gnu/packages/ocaml.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index a5632c6ad1..e86f59d2b3 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -1419,6 +1419,17 @@ (define-public binsec
        (sha256
         (base32 "1szfqb6rj19w2jdyaxdgy3plhgr7picijf7l4k5qq80kna2h0zm8"))))
     (build-system dune-build-system)
+    (arguments
+      (list #:phases
+            #~(modify-phases %standard-phases
+                (add-after 'install 'wrap-programs
+                  (lambda _
+                    (let ((ocamlpath
+                            `(,(string-append #$output "/lib/ocaml/site-lib")
+                               ,@(search-path-as-string->list (getenv "OCAMLPATH")))))
+                      (wrap-program (string-append #$output "/bin/" "binsec")
+                                    `("OCAMLPATH" ":" prefix ,ocamlpath))))))))
+    (inputs (list bash-minimal))
     (native-inputs (list gmp ocaml-qcheck ocaml-ounit2))
     (propagated-inputs (list dune-site
                              ocaml-base

base-commit: 415e3d98d6faf5fd3d1b7b3daa2f20636e4ff822

Message #10 received at 78231-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: soeren <at> soeren-tempel.net
Cc: 69996-done <at> debbugs.gnu.org, jgart <at> dismail.de, 78231-done <at> debbugs.gnu.org
Subject: Re: [PATCH] ocaml: binsec: Wrap program to set OCAMLPATH
Date: Sat, 7 Jun 2025 16:40:07 +0200

Am Sat, May 03, 2025 at 04:38:26PM +0200 schrieb soeren <at> soeren-tempel.net:
> From: Sören Tempel <soeren <at> soeren-tempel.net>
> Otherwise, dune plugins cannot be loaded which results in some command
> line options to not work correctly. For example, binsec --help errors
> with "The library "binsec.sse.checkct" can't be found in the search
> paths". To fix this, this patch adds a wrap-programs phase.
> Fixes https://issues.guix.gnu.org/69996
> * gnu/packages/ocaml.scm (binsec) <arguments>: Add wrap-programs phase.

Pushed, thanks!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.