GNU bug report logs - #78222
package-vc-from-checkout generates incorrect package summaries

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78222: closed (package-vc-from-checkout generates incorrect
 package summaries)
Date: Sat, 24 May 2025 10:39:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 24 May 2025 10:37:58 +0000
with message-id <875xhqmgzd.fsf <at> posteo.net>
and subject line Re: bug#78222: package-vc-from-checkout generates incorrect package summaries
has caused the debbugs.gnu.org bug report #78222,
regarding package-vc-from-checkout generates incorrect package summaries
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78222: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78222
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: JD Smith <jdtsmith <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: package-vc-from-checkout generates incorrect package summaries
Date: Fri, 2 May 2025 20:16:52 -0400

`package-vc-install-from-checkout' fails to generate correct package summaries in the package files it generates, always using "No description available."  

The issue is as follows:

    • `package-vc-install-from-checkout' uses `package-desc-create' to create a description structure based on the directory name of the installed package.
    • This constructor includes a default `summary' slot of `package--default-summary' ("No description available.")
    • During unpacking, `package-vc--generate-description-file' is called with this pre-populated description structure.
    • It notices the existence of the (default) `package-desc-summary', and simply skips reading the main package file to derive the summary from its header line.

The solution may be to alter the test logic in  `package-vc--generate-description-file', or let-bind `package--default-summary=nil' during structure creation.

[Message part 3 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 78222-done <at> debbugs.gnu.org, JD Smith <jdtsmith <at> gmail.com>
Subject: Re: bug#78222: package-vc-from-checkout generates incorrect package
 summaries
Date: Sat, 24 May 2025 10:37:58 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: JD Smith <jdtsmith <at> gmail.com>
>> Date: Sat, 17 May 2025 08:53:16 -0400
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>>  78222 <at> debbugs.gnu.org
>> 
>> 
>> 
>> > On May 17, 2025, at 5:03 AM, Philip Kaludercic <philipk <at> posteo.net> wrote:
>> > 
>> > That is enough information, the fix I mentioned was applied onto the
>> > master branch.  Do you want to build the master branch yourself and
>> > check if the bug has been resolved, or should we just close the bug
>> > directly as a duplicate?
>> 
>> Unfortunately I don't have a master build setup right now; can you
>> confirm that packages in the package listing with archive "source"
>> say something more interesting than "No description available."?
>> Can be closed if so.
>
> Philip, should we close this bug?

Sorry, yes the issue that JD is describing has been resolved.  I am
marking the bug report as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.