GNU bug report logs - #78221
31.0.50; Improving *-change-functions notifications

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 78221 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, yantar92 <at> posteo.net, joaotavora <at> gmail.com
Subject: bug#78221: 31.0.50; Improving *-change-functions notifications
Date: Sat, 03 May 2025 12:45:18 -0400

> ../lisp/progmodes/verilog-mode.el:3558:      (run-hook-with-args
> 'before-change-functions (point-min) (point-max))
> ../lisp/progmodes/verilog-mode.el:3570:        (run-hook-with-args
> 'after-change-functions (point-min) (point-max)

I think these are OK.
It's doing something similar to `combine*change-functions`.

> ../lisp/cedet/srecode/insert.el:132:       (run-hook-with-args 'after-change-functions

This one looks quite wrong.

> ../lisp/subr.el:5414:        (run-hook-with-args 'before-change-functions beg end))
> ../lisp/subr.el:5471:        (run-hook-with-args 'after-change-functions

These are for `combine*change-functions`.

> ../lisp/emulation/viper-cmd.el:139:  (run-hook-with-args 'viper-after-change-functions beg end len))
> ../lisp/emulation/viper-cmd.el:143:  (run-hook-with-args 'viper-before-change-functions beg end))

False positives.

> ../lisp/format.el:472:      (run-hook-with-args 'after-change-functions (point) (+ (point) size) 0))

Looks wrong as well.

> ../test/lisp/emacs-lisp/track-changes-tests.el:141:
> (run-hook-with-args 'after-change-functions
> ../test/lisp/emacs-lisp/track-changes-tests.el:143:
> (run-hook-with-args 'before-change-functions beg end))))

These are purposefully wrong (to check that `track-changes` is able to
withstand such occurrences).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.