GNU bug report logs - #78215
[PATCH electronics-team] gnu: symbiyosys: Use abc-yosyshq.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Enge <andreas <at> enge.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78215: closed ([PATCH electronics-team] gnu: symbiyosys: Use
 abc-yosyshq.)
Date: Sat, 03 May 2025 16:09:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 3 May 2025 18:08:17 +0200
with message-id <aBY_cTNSxWmjXb0N <at> jurong>
and subject line Re: [PATCH electronics-team] gnu: symbiyosys: Use abc-yosyshq.
has caused the debbugs.gnu.org bug report #78215,
regarding [PATCH electronics-team] gnu: symbiyosys: Use abc-yosyshq.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78215: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78215
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH electronics-team] gnu: symbiyosys: Use abc-yosyshq.
Date: Fri,  2 May 2025 16:52:04 +0200

* gnu/packages/electronics.scm (symbiyosis): Use abc-yosyshq.

Change-Id: I7cc78cbf8cff232996bdb243cbd2585b593b2c89
---

Symbiyosys, by YosysHQ, uses a fork of abc from Berkeley, that guix packages as abc-yosyshq. Using it fixes previous errors in some of the tests, and we can reactivate them.

[arguments] <#:phases> {disable-abc-tests}: Remove.
[inputs]: Replace abc by abc-yosyshq.

 gnu/packages/electronics.scm | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index d63511ff22..4df7064243 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -724,19 +724,9 @@ (define-public symbiyosys
               (substitute* "sbysrc/sby.py"
                 (("/usr/bin/env python")
                  (search-input-file inputs "bin/python3")))))
-          ;; The tests related to abc (berkeley) binary used currently produce
-          ;; errors.  The abc-yosyshq fork would make the tests pass, but
-          ;; cannot be packaged due to the fork's non-free licensing (see the
-          ;; README, which specifies a non-commercial restriction).
-          (add-after 'patch-/usr/bin/env 'disable-abc-tests
-            (lambda _
-              (delete-file "tests/keepgoing/keepgoing_multi_step.sby")
-              (delete-file-recursively "docs/examples/demos")
-              (delete-file
-               "tests/regression/aim_vs_smt2_nonzero_start_offset.sby")))
           (add-after 'install 'python:wrap
             (assoc-ref python:%standard-phases 'wrap)))))
-    (inputs (list abc
+    (inputs (list abc-yosyshq
                   boolector
                   git-minimal/pinned
                   python

base-commit: 5d5c0dfcdaff9205b3fe8f7822f16ad55743df8a
--
2.49.0

[Message part 3 (message/rfc822, inline)]

From: Andreas Enge <andreas <at> enge.fr>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78215-done <at> debbugs.gnu.org, 78214-done <at> debbugs.gnu.org
Subject: Re: [PATCH electronics-team] gnu: symbiyosys: Use abc-yosyshq.
Date: Sat, 3 May 2025 18:08:17 +0200

Hello Cayetano,

Am Fri, May 02, 2025 at 08:07:11PM +0200 schrieb Cayetano Santos:
> You need to apply my previous patch before, #78214, to fix yosys (used
> by symbiyosys)
> Sorry, I though it was clear. I should have sent a single patch with the
> two commits instead.

maybe it would have been clear had I seen the first patch, but I just
picked a random one from the list of untreated issues :)

Both are pushed now, thanks!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.