GNU bug report logs - #78195
[PATCH] Remove unused use-module that can lead to circular dependencies

Previous Next

Package: guix-patches;

Reported by: "Dan Khodabakhsh" <d <at> niel.khodabakh.sh>

Date: Thu, 1 May 2025 16:56:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "Dan Khodabakhsh" <d <at> niel.khodabakh.sh>
To: "78195" <78195 <at> debbugs.gnu.org>
Subject: [bug#78195] [PATCH] Remove unused use-module that can lead to circular dependencies
Date: Thu, 1 May 2025 17:55:31 +0000
[Message part 1 (text/plain, inline)]
Apologies, thought I sent it as plaintext, here's another shot:

This change removes the use-module (gnu packages node-xyz) import from (gnu packages node).
node-xyz is not actually used in node and seems to have been accidentally added in f540ee5ef845946228c0e2e4cffadccd36069922.
Keeping it in can lead to circular dependency issues.

---
 gnu/packages/node.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 018a6b1bd0..4cad70a179 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2021, 2022 Philip McGrath <philip <at> philipmcgrath.com>
 ;;; Copyright © 2022 Hilton Chain <hako <at> ultrarare.space>
 ;;; Copyright © 2024 Efraim Flashner <efraim <at> flashner.co.il>
-;;; Copyright © 2024 Daniel Khodabakhsh <d.khodabakhsh <at> gmail.com>
+;;; Copyright © 2024, 2025 Daniel Khodabakhsh <d <at> niel.khodabakh.sh>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -50,7 +50,6 @@ (define-module (gnu packages node)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages networking)
-  #:use-module (gnu packages node-xyz)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)

base-commit: a6b40f7a2f2db3107319d1a5e099b269a462a723
-- 
2.49.0
[0001-Remove-use-module-gnu-packages-node-xyz-from-node.patch (application/octet-stream, attachment)]

This bug report was last modified 1 day ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.