GNU bug report logs - #78195
[PATCH] Remove unused use-module that can lead to circular dependencies

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78195: closed ([PATCH] Remove unused use-module that can lead
 to circular dependencies)
Date: Sun, 18 May 2025 21:04:06 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 18 May 2025 22:35:21 +0200
with message-id <87bjrplks6.fsf_-_ <at> gnu.org>
and subject line Re: [bug#78195] [PATCH] Remove unused use-module that can lead to circular dependencies, [PATCH] Remove use-module (gnu packages node-xyz) from (gnu packages node).
has caused the debbugs.gnu.org bug report #78195,
regarding [PATCH] Remove unused use-module that can lead to circular dependencies
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78195: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78195
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Dan Khodabakhsh" <d <at> niel.khodabakh.sh>
To: "guix-patches" <guix-patches <at> gnu.org>
Subject: [PATCH] Remove unused use-module that can lead to circular
 dependencies
Date: Thu, 1 May 2025 16:11:03 +0000

[Message part 3 (text/plain, inline)]

This change removes the use-module (gnu packages node-xyz) import from (gnu packages node).
node-xyz is not actually used in node and seems to have been accidentally added in f540ee5ef845946228c0e2e4cffadccd36069922.
Keeping it in can lead to circular dependency issues.


---
 gnu/packages/node.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 018a6b1bd0..4cad70a179 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -13,7 +13,7 @@
&nbsp;;;; Copyright © 2021, 2022 Philip McGrath <philip <at> philipmcgrath.com&gt;
&nbsp;;;; Copyright © 2022 Hilton Chain <hako <at> ultrarare.space&gt;
&nbsp;;;; Copyright © 2024 Efraim Flashner <efraim <at> flashner.co.il&gt;
-;;; Copyright © 2024 Daniel Khodabakhsh <d.khodabakhsh <at> gmail.com&gt;
+;;; Copyright © 2024, 2025 Daniel Khodabakhsh <d <at> niel.khodabakh.sh&gt;
&nbsp;;;;
&nbsp;;;; This file is part of GNU Guix.
&nbsp;;;;
@@ -50,7 +50,6 @@ (define-module (gnu packages node)
&nbsp; &nbsp;#:use-module (gnu packages libevent)
&nbsp; &nbsp;#:use-module (gnu packages linux)
&nbsp; &nbsp;#:use-module (gnu packages networking)
- &nbsp;#:use-module (gnu packages node-xyz)
&nbsp; &nbsp;#:use-module (gnu packages perl)
&nbsp; &nbsp;#:use-module (gnu packages pkg-config)
&nbsp; &nbsp;#:use-module (gnu packages python)


base-commit: a6b40f7a2f2db3107319d1a5e099b269a462a723
--&nbsp;
2.49.0

[Message part 4 (text/html, inline)]

[0001-Remove-use-module-gnu-packages-node-xyz-from-node.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Dan Khodabakhsh" <d <at> niel.khodabakh.sh>
Cc: 78195 <78195-done <at> debbugs.gnu.org>
Subject: Re: [bug#78195] [PATCH] Remove unused use-module that can lead to
 circular dependencies, [PATCH] Remove use-module (gnu packages node-xyz)
 from (gnu packages node).
Date: Sun, 18 May 2025 22:35:21 +0200

Hi,

"Dan Khodabakhsh" <d <at> niel.khodabakh.sh> writes:

> From: Daniel Khodabakhsh <d <at> niel.khodabakh.sh>
> Date: Thu, 1 May 2025 08:55:41 -0700
> Subject: [PATCH] Remove use-module (gnu packages node-xyz) from (gnu packages
>  node).
>
> This change removes the use-module (gnu packages node-xyz) import from (gnu
>  packages node).
> node-xyz is not actually used in node and seems to have been accidentally
>  added in f540ee5ef845946228c0e2e4cffadccd36069922.
> Keeping it in can lead to circular dependency issues.
>
> Change-Id: I292323510b918a5e5c154a06f06cc608997557d6
> Signed-off-by: Daniel Khodabakhsh <d <at> niel.khodabakh.sh>

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.