Subject: bug#78195: closed (Re: [bug#78195] [PATCH] Remove unused use-module that can lead to circular dependencies, [PATCH] Remove use-module (gnu packages node-xyz) from (gnu packages node).)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 18 May 2025 21:04:06 +0000

Your bug report

#78195: [PATCH] Remove unused use-module that can lead to circular dependencies

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
78195: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78195
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#78195] [PATCH] Remove unused use-module that can lead to circular dependencies, [PATCH] Remove use-module (gnu packages node-xyz) from (gnu packages node).
From: Ludovic Courtès <[email-masked]>
To: "Dan Khodabakhsh" <[email-masked]>
Cc: 78195 <[email-masked]>
Date: Sun, 18 May 2025 22:35:21 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

"Dan Khodabakhsh" <[email-masked]> writes:

> From: Daniel Khodabakhsh <[email-masked]>
> Date: Thu, 1 May 2025 08:55:41 -0700
> Subject: [PATCH] Remove use-module (gnu packages node-xyz) from (gnu packages
>  node).
>
> This change removes the use-module (gnu packages node-xyz) import from (gnu
>  packages node).
> node-xyz is not actually used in node and seems to have been accidentally
>  added in f540ee5ef845946228c0e2e4cffadccd36069922.
> Keeping it in can lead to circular dependency issues.
>
> Change-Id: I292323510b918a5e5c154a06f06cc608997557d6
> Signed-off-by: Daniel Khodabakhsh <[email-masked]>

Applied, thanks!

Ludo’.

Subject: [PATCH] Remove unused use-module that can lead to circular dependencies
From: "Dan Khodabakhsh" <[email-masked]>
To: "guix-patches" <[email-masked]>
Date: Thu, 1 May 2025 16:11:03 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

This change removes the use-module (gnu packages node-xyz) import from (gnu packages node).
node-xyz is not actually used in node and seems to have been accidentally&nbsp;added in f540ee5ef845946228c0e2e4cffadccd36069922.
Keeping it in can lead to circular dependency issues.

---
&nbsp;gnu/packages/node.scm | 3 +--
&nbsp;1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 018a6b1bd0..4cad70a179 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -13,7 +13,7 @@
&nbsp;;;; Copyright © 2021, 2022 Philip McGrath <[email-masked]&gt;
&nbsp;;;; Copyright © 2022 Hilton Chain <[email-masked]&gt;
&nbsp;;;; Copyright © 2024 Efraim Flashner <[email-masked]&gt;
-;;; Copyright © 2024 Daniel Khodabakhsh <[email-masked]&gt;
+;;; Copyright © 2024, 2025 Daniel Khodabakhsh <[email-masked]&gt;
&nbsp;;;;
&nbsp;;;; This file is part of GNU Guix.
&nbsp;;;;
@@ -50,7 +50,6 @@ (define-module (gnu packages node)
&nbsp; &nbsp;#:use-module (gnu packages libevent)
&nbsp; &nbsp;#:use-module (gnu packages linux)
&nbsp; &nbsp;#:use-module (gnu packages networking)
- &nbsp;#:use-module (gnu packages node-xyz)
&nbsp; &nbsp;#:use-module (gnu packages perl)
&nbsp; &nbsp;#:use-module (gnu packages pkg-config)
&nbsp; &nbsp;#:use-module (gnu packages python)

base-commit: a6b40f7a2f2db3107319d1a5e099b269a462a723
--&nbsp;
2.49.0