GNU bug report logs - #78190
[PATCH go-team] gnu: lyrebird: Add version info.

Previous Next

Package: guix-patches;

Reported by: André Batista <nandre <at> riseup.net>

Date: Thu, 1 May 2025 14:55:01 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: André Batista <nandre <at> riseup.net>
Subject: bug#78190: closed ([PATCH go-team] gnu: lyrebird: Add version info.)
Date: Wed, 14 May 2025 18:56:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#78190: [PATCH go-team] gnu: lyrebird: Add version info.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 78190 <at> debbugs.gnu.org.

-- 
78190: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78190
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 78190-done <at> debbugs.gnu.org
Subject: [PATCH go-team] gnu: lyrebird: Add version info.
Date: Wed, 14 May 2025 19:54:52 +0100
[Message part 3 (text/plain, inline)]
Hi,

Thanks for the patch.

Pushed to go-team branch, which is about to be merged soon.

https://issues.guix.gnu.org/76654

--
Oleg
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: André Batista <nandre <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: André Batista <nandre <at> riseup.net>
Subject: [PATCH go-team] gnu: lyrebird: Add version info.
Date: Thu,  1 May 2025 11:54:03 -0300
See the project's Makefile.  Without this flag, version info defaults
to 'devel'.

* gnu/packages/golang-web.scm (lyrebird)[arguments]<#:build-flags>: Add
ldflag required for building with version information; append default
ldflags in case they are shadowed.

Change-Id: Iaa94c205244b3028b7e935b5ff83cf16b67f1b95
---
 gnu/packages/golang-web.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/golang-web.scm b/gnu/packages/golang-web.scm
index 892bd25fd67..20ba7e663b1 100644
--- a/gnu/packages/golang-web.scm
+++ b/gnu/packages/golang-web.scm
@@ -10756,6 +10756,9 @@ (define-public lyrebird
     (arguments
      (list
       #:go go-1.22
+      #:build-flags #~(list (string-append "-ldflags="
+                                           "-X main.lyrebirdVersion="
+                                           #$version " -s -w"))
       #:install-source? #f
       #:unpack-path "gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/lyrebird"
       #:import-path "gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/lyrebird/cmd/lyrebird"))

base-commit: f58462958d29e0fa1e391790385a929f26702b7b
-- 
2.49.0




This bug report was last modified 5 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.