From unknown Wed Jun 18 23:03:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7819 <7819@debbugs.gnu.org> To: bug#7819 <7819@debbugs.gnu.org> Subject: Status: automake does not really automatically distribute all the files it's advertised to. Reply-To: bug#7819 <7819@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:03:41 +0000 retitle 7819 automake does not really automatically distribute all the file= s it's advertised to. reassign 7819 automake submitter 7819 Stefano Lattarini severity 7819 normal tag 7819 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 10 14:45:10 2011 Received: (at submit) by debbugs.gnu.org; 10 Jan 2011 19:45:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcNfy-0001hu-20 for submit@debbugs.gnu.org; Mon, 10 Jan 2011 14:45:10 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcNfv-0001hK-0l for submit@debbugs.gnu.org; Mon, 10 Jan 2011 14:45:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcNn5-0007RR-FA for submit@debbugs.gnu.org; Mon, 10 Jan 2011 14:52:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RFC_ABUSE_POST, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:45687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcNn5-0007RL-CK for submit@debbugs.gnu.org; Mon, 10 Jan 2011 14:52:31 -0500 Received: from [140.186.70.92] (port=34160 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcNn4-0000K3-40 for bug-automake@gnu.org; Mon, 10 Jan 2011 14:52:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcNn2-0007Qw-PG for bug-automake@gnu.org; Mon, 10 Jan 2011 14:52:29 -0500 Received: from mail-wy0-f169.google.com ([74.125.82.169]:61080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcNn2-0007Ql-Ko for bug-automake@gnu.org; Mon, 10 Jan 2011 14:52:28 -0500 Received: by wyj26 with SMTP id 26so20625491wyj.0 for ; Mon, 10 Jan 2011 11:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:subject:date:user-agent :mime-version:to:content-type:content-transfer-encoding:message-id; bh=ooBolWkgNKpCFyNCIw2DCpGp5d3qG+3nz2BFLZmZpDU=; b=ju9uD8hcgyZWpwV1anPcPvkNxKXpgBENb6cl6u1QimXAgIPe4NtVbF67amjron4qo8 2xqXRxDsWq8CBKltvoZleB1ZQmHGqqRund54JuIfybwpgdW+lPjI4D2g9UIdqGrhmTlz Cmou83AKXWWkk8fkmRn9fB9+potTFMAVqear0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:subject:date:user-agent:mime-version:to:content-type :content-transfer-encoding:message-id; b=T+7E5ihCiU8E8cBdd6hzlNG+7hEUY7HJSHK9R+pnHQlmrNprPMXAAk+bzmCnuF4pFo UyBUuiSdLYSskQ6I53nvf8EqD6eCzpDOJWJOQ/RE+IsjJtP9Qgw9HrxjqS+IZoYZSEM9 mAB5fYryQY4HXlNAGjZipFI93c9U9z4IQsMFo= Received: by 10.227.182.142 with SMTP id cc14mr3244295wbb.215.1294689067730; Mon, 10 Jan 2011 11:51:07 -0800 (PST) Received: from bigio.localnet (host22-93-dynamic.10-79-r.retail.telecomitalia.it [79.10.93.22]) by mx.google.com with ESMTPS id f35sm20333256wbf.8.2011.01.10.11.51.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 10 Jan 2011 11:51:06 -0800 (PST) From: Stefano Lattarini Subject: automake does not really automatically distribute all the files it's advertised to. Date: Mon, 10 Jan 2011 20:50:13 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) MIME-Version: 1.0 To: bug-automake@gnu.org Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Message-Id: <201101102050.14046.stefano.lattarini@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) Hello automakers. =46rom the automake manual, section 14.1 "Basics of Distribution": ``Automake also has a built-in list of commonly used files that are automatically included if they are found in the current directory (either physically, or as the target of a Makefile.am rule). This list is printed by "automake --help". '' And here is the current list of files automake should distribute automatically: $ automake --help Usage: /usr/bin/automake [OPTION] ... [Makefile]... ... Files which are automatically distributed, if found: ABOUT-GNU README config.rpath ltcf-gcj.sh ABOUT-NLS THANKS config.sub ltconfig AUTHORS TODO configure ltmain.sh BACKLOG acconfig.h configure.ac mdate-sh COPYING aclocal.m4 configure.in missing COPYING.DOC ansi2knr.1 depcomp mkinstalldi= rs COPYING.LESSER ansi2knr.c elisp-comp py-compile COPYING.LIB compile install-sh stamp-vti ChangeLog config.guess libversion.in texinfo.tex INSTALL config.h.bot ltcf-c.sh ylwrap NEWS config.h.top ltcf-cxx.sh ... But the above is not always correct, as some of these files are distributed *only* if other conditions are met. For example, acconfig.h and aclocal.m4 are distributed only if they really exists at automake runtime (having them as targets in Makefile.am won't work), config.h.bot and config.h.top are distributed only if the AC_CONFIG_HEADERS macro is used, and stamp-vti is distributed only if info_TEXINFOS and version.texi are used. So, either the automake script or the automake help screen should be adjusted. IMHO the current behaviour of automake is good enough, so I think we should adjust the automake help screen to read something like: Files automatically distributed if found: ... Files automatically distributed if found (under certain conditions): ... I will attempt a patch soonish (I already have half-cooked testcases, and the relevant code in automake.in seems quite clear); but as usual, having the issue registered in the bug tracker "JFTR" won't hurt. Regards, Stefano From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 10 15:04:32 2011 Received: (at 7819) by debbugs.gnu.org; 10 Jan 2011 20:04:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcNyh-00027L-PA for submit@debbugs.gnu.org; Mon, 10 Jan 2011 15:04:32 -0500 Received: from mail.lysator.liu.se ([130.236.254.3]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcNyf-000278-CA for 7819@debbugs.gnu.org; Mon, 10 Jan 2011 15:04:30 -0500 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 2CC7340029; Mon, 10 Jan 2011 21:11:54 +0100 (CET) Received: from [192.168.0.33] (h57n3fls301o1095.telia.com [81.230.178.57]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTP id D72C140022; Mon, 10 Jan 2011 21:11:53 +0100 (CET) Message-ID: <4D2B6807.2080405@lysator.liu.se> Date: Mon, 10 Jan 2011 21:11:51 +0100 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Stefano Lattarini Subject: Re: bug#7819: automake does not really automatically distribute all the files it's advertised to. References: <201101102050.14046.stefano.lattarini@gmail.com> In-Reply-To: <201101102050.14046.stefano.lattarini@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7819 Cc: 7819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Den 2011-01-10 20:50 skrev Stefano Lattarini: > Hello automakers. > > From the automake manual, section 14.1 "Basics of Distribution": > > ``Automake also has a built-in list of commonly used files that are > automatically included if they are found in the current directory > (either physically, or as the target of a Makefile.am rule). This > list is printed by "automake --help". '' > > And here is the current list of files automake should distribute > automatically: > > $ automake --help > Usage: /usr/bin/automake [OPTION] ... [Makefile]... > ... > Files which are automatically distributed, if found: > ABOUT-GNU README config.rpath ltcf-gcj.sh > ABOUT-NLS THANKS config.sub ltconfig > AUTHORS TODO configure ltmain.sh > BACKLOG acconfig.h configure.ac mdate-sh > COPYING aclocal.m4 configure.in missing > COPYING.DOC ansi2knr.1 depcomp mkinstalldirs > COPYING.LESSER ansi2knr.c elisp-comp py-compile > COPYING.LIB compile install-sh stamp-vti > ChangeLog config.guess libversion.in texinfo.tex > INSTALL config.h.bot ltcf-c.sh ylwrap > NEWS config.h.top ltcf-cxx.sh > ... > ar-lib is missing (perhaps because it's not in the branch you tested?). Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 10 15:15:30 2011 Received: (at 7819) by debbugs.gnu.org; 10 Jan 2011 20:15:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcO9J-0002MM-8O for submit@debbugs.gnu.org; Mon, 10 Jan 2011 15:15:29 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcO9H-0002M5-7V for 7819@debbugs.gnu.org; Mon, 10 Jan 2011 15:15:28 -0500 Received: by wwj40 with SMTP id 40so21853351wwj.15 for <7819@debbugs.gnu.org>; Mon, 10 Jan 2011 12:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:message-id :content-type:content-transfer-encoding; bh=s3R4Wg7mP3Mw23Aq4qfpnIfGkQsnJM1AP31NRMDkAnQ=; b=os7l6nEbzEK0+DlN7aHWDq7m8V7Ts9bVrXFYv7PeTh3wC6iZcBEg+bR88QmT3PYNUf 4P7rBPTnZ+XLr+5KLw0wCxINW14yVRNMmxu1VZm5l/tZiph1hfR6XXze3nwN3PootI2s eT1pPCDUGJ1M63+1UXoyfoRLYeacF3HKAO9L8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:message-id:content-type:content-transfer-encoding; b=xHZoUhvxstk4/iam3M+ESZh8FOK8cv+6JKfJfcXWivcfuFH5QHDWg1lzKeNLlsoCDU MmfjvgzTLdmkztnpvz6J+Z2bjfYt3Y5RXFo/M5h0bKN6bs3aSsHBa6yJhSwzcoMFQKV5 EsfHYzcpNsdTlaO2GtVMQUh01OiG8K0brp27M= Received: by 10.227.133.10 with SMTP id d10mr19274064wbt.82.1294690892587; Mon, 10 Jan 2011 12:21:32 -0800 (PST) Received: from bigio.localnet (host22-93-dynamic.10-79-r.retail.telecomitalia.it [79.10.93.22]) by mx.google.com with ESMTPS id 11sm20352707wbi.6.2011.01.10.12.21.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 10 Jan 2011 12:21:31 -0800 (PST) From: Stefano Lattarini To: Peter Rosin Subject: Re: bug#7819: automake does not really automatically distribute all the files it's advertised to. Date: Mon, 10 Jan 2011 21:20:33 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201101102050.14046.stefano.lattarini@gmail.com> <4D2B6807.2080405@lysator.liu.se> In-Reply-To: <4D2B6807.2080405@lysator.liu.se> MIME-Version: 1.0 Message-Id: <201101102120.34255.stefano.lattarini@gmail.com> Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 7819 Cc: 7819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) On Monday 10 January 2011, Peter Rosin wrote: > Den 2011-01-10 20:50 skrev Stefano Lattarini: > > Hello automakers. > > > > From the automake manual, section 14.1 "Basics of Distribution": > > > > ``Automake also has a built-in list of commonly used files that are > > automatically included if they are found in the current directory > > (either physically, or as the target of a Makefile.am rule). This > > list is printed by "automake --help". '' > > > > And here is the current list of files automake should distribute > > automatically: > > > > $ automake --help > > Usage: /usr/bin/automake [OPTION] ... [Makefile]... > > ... > > Files which are automatically distributed, if found: > > ABOUT-GNU README config.rpath ltcf-gcj.sh > > ABOUT-NLS THANKS config.sub ltconfig > > AUTHORS TODO configure ltmain.sh > > BACKLOG acconfig.h configure.ac mdate-sh > > COPYING aclocal.m4 configure.in missing > > COPYING.DOC ansi2knr.1 depcomp mkinstalldirs > > COPYING.LESSER ansi2knr.c elisp-comp py-compile > > COPYING.LIB compile install-sh stamp-vti > > ChangeLog config.guess libversion.in texinfo.tex > > INSTALL config.h.bot ltcf-c.sh ylwrap > > NEWS config.h.top ltcf-cxx.sh > > ... > > > > ar-lib is missing (perhaps because it's not in the branch you tested?). > I guess so, as I tested only with the maint branch. Anyway, the testcase I'm preparing takes the list of automatically-distributed files from automake's own help screen, and thus should remain automatically in sync with what is documented there. Regards, Stefano From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 10 15:37:01 2011 Received: (at 7819) by debbugs.gnu.org; 10 Jan 2011 20:37:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcOU9-0002pI-Cg for submit@debbugs.gnu.org; Mon, 10 Jan 2011 15:37:01 -0500 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PcOU6-0002p4-Rq for 7819@debbugs.gnu.org; Mon, 10 Jan 2011 15:37:00 -0500 Received: (qmail invoked by alias); 10 Jan 2011 20:44:23 -0000 Received: from xdsl-89-0-104-73.netcologne.de (EHLO localhost.localdomain) [89.0.104.73] by mail.gmx.net (mp052) with SMTP; 10 Jan 2011 21:44:23 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX19DFdYa8rxDIY6pGRpXUdwls3nZREvpTFC0IQ3Xb4 /bVFKu+QNF4DMw Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1PcObH-0004Ni-0H; Mon, 10 Jan 2011 21:44:23 +0100 Date: Mon, 10 Jan 2011 21:44:22 +0100 From: Ralf Wildenhues To: Stefano Lattarini Subject: Re: bug#7819: automake does not really automatically distribute all the files it's advertised to. Message-ID: <20110110204422.GC15241@gmx.de> References: <201101102050.14046.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201101102050.14046.stefano.lattarini@gmail.com> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7819 Cc: 7819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Hi Stefano, * Stefano Lattarini wrote on Mon, Jan 10, 2011 at 08:50:13PM CET: > Files which are automatically distributed, if found: > ABOUT-GNU README config.rpath ltcf-gcj.sh > ABOUT-NLS THANKS config.sub ltconfig > AUTHORS TODO configure ltmain.sh > BACKLOG acconfig.h configure.ac mdate-sh [...] > ... > > But the above is not always correct, as some of these files are distributed > *only* if other conditions are met. For example, acconfig.h and aclocal.m4 > are distributed only if they really exists at automake runtime (having them > as targets in Makefile.am won't work), config.h.bot and config.h.top are > distributed only if the AC_CONFIG_HEADERS macro is used, and stamp-vti is > distributed only if info_TEXINFOS and version.texi are used. > > So, either the automake script or the automake help screen should be > adjusted. > > IMHO the current behaviour of automake is good enough, so I think we > should adjust the automake help screen to read something like: Agreed. With many of the names, I have been wondering though whether we should distribute them at all in arbitrary directories. For example, most scripts don't make that much sense outside of the toplevel or the build-aux directories. Then again, changing the current behavior here is quite likely to break some existing package setups, and even silently and only upon 'make dist' (so it might never show up for the developer), so that I'm not inclined to change this lightly. Documenting the existing behavior better sounds like a good idea to me. Thanks for the report, Ralf From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 10 16:42:20 2011 Received: (at 7819) by debbugs.gnu.org; 10 Jan 2011 21:42:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcPVL-0004It-T2 for submit@debbugs.gnu.org; Mon, 10 Jan 2011 16:42:20 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PcPVJ-0004If-8e for 7819@debbugs.gnu.org; Mon, 10 Jan 2011 16:42:18 -0500 Received: by wwj40 with SMTP id 40so21913070wwj.15 for <7819@debbugs.gnu.org>; Mon, 10 Jan 2011 13:49:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=Q1YivI9rpYBNevTHBz+1rznOWCoMIJQ2AZGzaPsTO/U=; b=uMgkLUL7NUPxiuFEBi1xm/s2o789GvVOhPb3D+BVehwwLZYhGEUO4XCysmukckzGQU MEATYounnACl9WWBl7tHW3BsLvt3caRh+kYi8lBSqWz3NJ3nLqAF0h+K4rlzqMCMMeAa 1FTPgHAbd+LWrjt9deXTXVzSdSezYGfF3HECA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=fJzHyQgBhhgQap8HUUYffGYdQSbZcSdQnyN5B+icWf5atlLoM/E1RW3hAHGAZ7tpgC u1aetPjso6daam2C9sfHh3FJUQjkRVjvqesGNYS3ciriQ7HJTEpp8Jd4kLMe/Y5wUKbt y6xqvFwRMBheP7kh6u+BGIMOuOtBifFUEuMjU= Received: by 10.227.151.193 with SMTP id d1mr14774413wbw.201.1294695626267; Mon, 10 Jan 2011 13:40:26 -0800 (PST) Received: from bigio.localnet (host22-93-dynamic.10-79-r.retail.telecomitalia.it [79.10.93.22]) by mx.google.com with ESMTPS id 11sm20407244wbj.7.2011.01.10.13.40.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 10 Jan 2011 13:40:25 -0800 (PST) From: Stefano Lattarini To: Ralf Wildenhues Subject: Re: bug#7819: automake does not really automatically distribute all the files it's advertised to. Date: Mon, 10 Jan 2011 22:40:13 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201101102050.14046.stefano.lattarini@gmail.com> <20110110204422.GC15241@gmx.de> In-Reply-To: <20110110204422.GC15241@gmx.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201101102240.14016.stefano.lattarini@gmail.com> X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 7819 Cc: 7819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) On Monday 10 January 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Mon, Jan 10, 2011 at 08:50:13PM CET: > > Files which are automatically distributed, if found: > > ABOUT-GNU README config.rpath ltcf-gcj.sh > > ABOUT-NLS THANKS config.sub ltconfig > > AUTHORS TODO configure ltmain.sh > > BACKLOG acconfig.h configure.ac mdate-sh > [...] > > ... > > > > But the above is not always correct, as some of these files are distributed > > *only* if other conditions are met. For example, acconfig.h and aclocal.m4 > > are distributed only if they really exists at automake runtime (having them > > as targets in Makefile.am won't work), config.h.bot and config.h.top are > > distributed only if the AC_CONFIG_HEADERS macro is used, and stamp-vti is > > distributed only if info_TEXINFOS and version.texi are used. > > > > So, either the automake script or the automake help screen should be > > adjusted. > > > > IMHO the current behaviour of automake is good enough, so I think we > > should adjust the automake help screen to read something like: > > Agreed. With many of the names, I have been wondering though whether we > should distribute them at all in arbitrary directories. For example, > most scripts don't make that much sense outside of the toplevel or the > build-aux directories. > Ouch. I thought that the files listed above were distributed only when found in the top-level directory, but now I see that they are in fact distributed if found in the same directory of the being-processed Makefile.am (and this is even documented, albeit not very clearly). Maybe we should deprecate this behaviour in the manual, add an XFAILing testcase, and change the behaviour after the next release. But then you say ... > Then again, changing the current behavior here is quite likely to break > some existing package setups, and even silently and only upon 'make > dist' (so it might never show up for the developer), so that I'm not > inclined to change this lightly. > Oh, OK. Your call -- I won't push you in any direction about this issue. > Documenting the existing behavior better sounds like a good idea to me. > > Thanks for the report, > Ralf > Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 11 14:45:42 2011 Received: (at 7819) by debbugs.gnu.org; 11 Jan 2011 19:45:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PckA1-0005PG-UZ for submit@debbugs.gnu.org; Tue, 11 Jan 2011 14:45:42 -0500 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Pck9z-0005P1-BF for 7819@debbugs.gnu.org; Tue, 11 Jan 2011 14:45:40 -0500 Received: (qmail invoked by alias); 11 Jan 2011 19:53:06 -0000 Received: from xdsl-89-0-102-250.netcologne.de (EHLO localhost.localdomain) [89.0.102.250] by mail.gmx.net (mp041) with SMTP; 11 Jan 2011 20:53:06 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX18/sl5Y6TA/fvLttc9wrNhJJRudfA3IaqA9+DRnHr wC8RimkXUN8hNa Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1PckHB-0004us-H9; Tue, 11 Jan 2011 20:53:05 +0100 Date: Tue, 11 Jan 2011 20:53:05 +0100 From: Ralf Wildenhues To: Stefano Lattarini Subject: Re: bug#7819: automake does not really automatically distribute all the files it's advertised to. Message-ID: <20110111195305.GD18620@gmx.de> References: <201101102050.14046.stefano.lattarini@gmail.com> <20110110204422.GC15241@gmx.de> <201101102240.14016.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201101102240.14016.stefano.lattarini@gmail.com> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7819 Cc: 7819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) * Stefano Lattarini wrote on Mon, Jan 10, 2011 at 10:40:13PM CET: > On Monday 10 January 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Mon, Jan 10, 2011 at 08:50:13PM CET: > > > But the above is not always correct, as some of these files are distributed > > > *only* if other conditions are met. For example, acconfig.h and aclocal.m4 > > > are distributed only if they really exists at automake runtime (having them > > > as targets in Makefile.am won't work), I didn't fully realize this when reading it last time. That's an ugly inconsistency. :-/ Luckily most of these are typically not generated only after automake (still; see e.g., ChangeLog, THANKS, in coreutils). More generally though, I get suspicious for any external stuff which influences the result of 'automake', because it makes writing rebuild rules harder or impossible. These automatically-distributed files can cause build or distribution problems for projects which embed optional subprojects (and try to share files, for example). There has been a report to this end not too long ago, I think, but we've seen more than just one. But even just having a distribution "magically" fixed by rerunning 'automake' (after all files are in place) is very unintuitive, and has been source for questions from users. > > Agreed. With many of the names, I have been wondering though whether we > > should distribute them at all in arbitrary directories. For example, > > most scripts don't make that much sense outside of the toplevel or the > > build-aux directories. > > > Ouch. I thought that the files listed above were distributed only when > found in the top-level directory, but now I see that they are in fact > distributed if found in the same directory of the being-processed > Makefile.am (and this is even documented, albeit not very clearly). > > Maybe we should deprecate this behaviour in the manual, add an XFAILing > testcase, and change the behaviour after the next release. But then > you say ... > > > Then again, changing the current behavior here is quite likely to break > > some existing package setups, and even silently and only upon 'make > > dist' (so it might never show up for the developer), so that I'm not > > inclined to change this lightly. > > > Oh, OK. Your call -- I won't push you in any direction about this issue. Well, I must confess I'm not totally sure on this one. For the documentation files (README, ChangeLog, ...) it would probably make sense to do so though. Hmm. Cheers, Ralf From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 15:03:12 2011 Received: (at 7819) by debbugs.gnu.org; 15 Jan 2011 20:03:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PeCL8-0003Bs-CM for submit@debbugs.gnu.org; Sat, 15 Jan 2011 15:03:11 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PeCL1-0003BK-Tq for 7819@debbugs.gnu.org; Sat, 15 Jan 2011 15:03:09 -0500 Received: by wwj40 with SMTP id 40so4208499wwj.15 for <7819@debbugs.gnu.org>; Sat, 15 Jan 2011 12:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:message-id; bh=rigWTSysOioQ3HJKkavkjFVkBXN+aFtOpFyLGrFtoQg=; b=VxlkcqBXzs8KSr8ODDwi2HySiZa8yRJv/LO9K/nx3PSqUxbx2zhzBBXyMSkPYIHDZl bf/BeaHY2uUmxBqNy/5DsznQEuDrYc3RoPXl1gQv6XcQEt6djglwea1ko4nGcZKuCaa3 fRYl+UbUVN2OgjCg/vceTU2Gd+qYKzPr5Nhbk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; b=kpKrmN9APJ5zUwHSNxbPfaQQPhiykCRLrC02UiQihD+8KpDKLI2SC7zZRJC1+hzV5n kzpMFXArZtgxAVhZf51qDyW01H7blyknvLiHsBCt+vgY48IeVTIYtChOpTaS7Jn8kKuS /ZOLTxQuo8TMIfPYUQP/WWkM99dU13POWTWvo= Received: by 10.227.176.134 with SMTP id be6mr2216594wbb.147.1295122187977; Sat, 15 Jan 2011 12:09:47 -0800 (PST) Received: from bigio.localnet (host156-94-dynamic.0-79-r.retail.telecomitalia.it [79.0.94.156]) by mx.google.com with ESMTPS id 11sm1974176wbj.1.2011.01.15.12.09.45 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 15 Jan 2011 12:09:46 -0800 (PST) From: Stefano Lattarini To: automake-patches@gnu.org Subject: Re: bug#7819: automake does not really automatically distribute all the files it's advertised to. Date: Sat, 15 Jan 2011 21:09:35 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201101102050.14046.stefano.lattarini@gmail.com> <20110110204422.GC15241@gmx.de> In-Reply-To: <20110110204422.GC15241@gmx.de> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_A8fMNsnVKMEniTT" Message-Id: <201101152109.36521.stefano.lattarini@gmail.com> X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 7819 Cc: Ralf Wildenhues , 7819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) --Boundary-00=_A8fMNsnVKMEniTT Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Reference: On Monday 10 January 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Mon, Jan 10, 2011 at 08:50:13PM CET: > > Files which are automatically distributed, if found: > > ABOUT-GNU README config.rpath ltcf-gcj.sh > > ABOUT-NLS THANKS config.sub ltconfig > > AUTHORS TODO configure ltmain.sh > > BACKLOG acconfig.h configure.ac mdate-sh > [...] > > ... > > > > But the above is not always correct, as some of these files are distributed > > *only* if other conditions are met. For example, acconfig.h and aclocal.m4 > > are distributed only if they really exists at automake runtime (having them > > as targets in Makefile.am won't work), config.h.bot and config.h.top are > > distributed only if the AC_CONFIG_HEADERS macro is used, and stamp-vti is > > distributed only if info_TEXINFOS and version.texi are used. > > > > So, either the automake script or the automake help screen should be > > adjusted. > > > > IMHO the current behaviour of automake is good enough, so I think we > > should adjust the automake help screen to read something like: > > Agreed. With many of the names, I have been wondering though whether we > should distribute them at all in arbitrary directories. For example, > most scripts don't make that much sense outside of the toplevel or the > build-aux directories. > > Then again, changing the current behavior here is quite likely to break > some existing package setups, and even silently and only upon 'make > dist' (so it might never show up for the developer), so that I'm not > inclined to change this lightly. > > Documenting the existing behavior better sounds like a good idea to me. > > Thanks for the report, > Ralf > The attached two-patch series should fix the bug, by making it clear in the documentation and in the help screen that certain files are automatically distributed only under certain conditions or in certain situations (without fully specifying which conditions or situations, as that would be too detailed IMHO and make suboptimal behaviour more difficult to be changed in future). OK for maint? Regards, Stefano -*-*- refactor: split 'usage' subroutine in automake This change is related to automake bug#7819. * automake.in (print_autodist_files): New subroutine, extracted from ... (usage): ... this, which now uses it. * tests/autodist-no-duplicate.test: New test. * tests/Makefile.am (TESTS): Update. --- ChangeLog | 10 ++++ automake.in | 89 +++++++++++++++++++------------------- tests/Makefile.am | 1 + tests/Makefile.in | 1 + tests/autodist-no-duplicate.test | 40 +++++++++++++++++ 5 files changed, 97 insertions(+), 44 deletions(-) create mode 100755 tests/autodist-no-duplicate.test -*-*- help: improve text about automatically-distributed files This change fixes automake bug#7819. * automake.in (usage): Distinguish between files that are always automatically distributed when found, and those which are only "under certain conditions". * doc/automake.texi (Basics of Distribution): Update accordingly. * tests/autodist-subdir.test: Update. * tests/autodist-no-duplicate.test: Likewise. * tests/autodist.test: Likewise. (configure.in): Remove useless call to AM_MAINTAINER_MODE. --- ChangeLog | 11 +++++++++++ automake.in | 8 ++++++-- doc/automake.texi | 4 +++- tests/autodist-no-duplicate.test | 32 +++++++++++++++++++++----------- tests/autodist-subdir.test | 27 +-------------------------- tests/autodist.test | 29 +---------------------------- 6 files changed, 43 insertions(+), 68 deletions(-) --Boundary-00=_A8fMNsnVKMEniTT Content-Type: text/x-patch; charset="us-ascii"; name="0001-refactor-split-usage-subroutine-in-automake.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0001-refactor-split-usage-subroutine-in-automake.patch" =46rom 486824c88082cc9d9a66dfce3eb5a8e793669f5f Mon Sep 17 00:00:00 2001 =46rom: Stefano Lattarini Date: Wed, 12 Jan 2011 01:06:33 +0100 Subject: [PATCH 1/2] refactor: split 'usage' subroutine in automake This change is related to automake bug#7819. * automake.in (print_autodist_files): New subroutine, extracted from ... (usage): ... this, which now uses it. * tests/autodist-no-duplicate.test: New test. * tests/Makefile.am (TESTS): Update. =2D-- ChangeLog | 10 ++++ automake.in | 89 +++++++++++++++++++---------------= =2D--- tests/Makefile.am | 1 + tests/Makefile.in | 1 + tests/autodist-no-duplicate.test | 40 +++++++++++++++++ 5 files changed, 97 insertions(+), 44 deletions(-) create mode 100755 tests/autodist-no-duplicate.test diff --git a/ChangeLog b/ChangeLog index be35937..4e1e093 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2011-01-15 Stefano Lattarini + + refactor: split 'usage' subroutine in automake + This change is related to automake bug#7819. + * automake.in (print_autodist_files): New subroutine, + extracted from ... + (usage): ... this, which now uses it. + * tests/autodist-no-duplicate.test: New test. + * tests/Makefile.am (TESTS): Update. + 2011-01-15 Ralf Wildenhues =20 docs: ensure example are separated with empty lines in the input diff --git a/automake.in b/automake.in index d56fbf7..3a214e0 100755 =2D-- a/automake.in +++ b/automake.in @@ -8308,6 +8308,50 @@ sub generate_makefile ($$) =20 ################################################################ =20 +# Helper function for usage(). +sub print_autodist_files (@) +{ + my @lcomm =3D sort (&uniq (@_)); + + my @four; + format USAGE_FORMAT =3D + @<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<<<<<<<<= <<<<< + $four[0], $four[1], $four[2], $four[3] +. + local $~ =3D "USAGE_FORMAT"; + + my $cols =3D 4; + my $rows =3D int(@lcomm / $cols); + my $rest =3D @lcomm % $cols; + + if ($rest) + { + $rows++; + } + else + { + $rest =3D $cols; + } + + for (my $y =3D 0; $y < $rows; $y++) + { + @four =3D ("", "", "", ""); + for (my $x =3D 0; $x < $cols; $x++) + { + last if $y + 1 =3D=3D $rows && $x =3D=3D $rest; + + my $idx =3D (($x > $rest) + ? ($rows * $rest + ($rows - 1) * ($x - $rest)) + : ($rows * $x)); + + $idx +=3D $y; + $four[$x] =3D $lcomm[$idx]; + } + write; + } +} + + # Print usage information. sub usage () { @@ -8341,51 +8385,8 @@ Library files: "; Automake::ChannelDefs::usage; =20 =2D my ($last, @lcomm); =2D $last =3D ''; =2D foreach my $iter (sort ((@common_files, @common_sometimes))) =2D { =2D push (@lcomm, $iter) unless $iter eq $last; =2D $last =3D $iter; =2D } =2D =2D my @four; print "\nFiles which are automatically distributed, if found:\n"; =2D format USAGE_FORMAT =3D =2D @<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<<<<<<= <<<<<<< =2D $four[0], $four[1], $four[2], $four[3] =2D. =2D $~ =3D "USAGE_FORMAT"; =2D =2D my $cols =3D 4; =2D my $rows =3D int(@lcomm / $cols); =2D my $rest =3D @lcomm % $cols; =2D =2D if ($rest) =2D { =2D $rows++; =2D } =2D else =2D { =2D $rest =3D $cols; =2D } =2D =2D for (my $y =3D 0; $y < $rows; $y++) =2D { =2D @four =3D ("", "", "", ""); =2D for (my $x =3D 0; $x < $cols; $x++) =2D { =2D last if $y + 1 =3D=3D $rows && $x =3D=3D $rest; =2D =2D my $idx =3D (($x > $rest) =2D ? ($rows * $rest + ($rows - 1) * ($x - $rest)) =2D : ($rows * $x)); =2D =2D $idx +=3D $y; =2D $four[$x] =3D $lcomm[$idx]; =2D } =2D write; =2D } + print_autodist_files (@common_files, @common_sometimes); =20 print ' Report bugs to <@PACKAGE_BUGREPORT@>. diff --git a/tests/Makefile.am b/tests/Makefile.am index 890e69b..63ad4d9 100644 =2D-- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -101,6 +101,7 @@ autodist-acconfig-no-subdir.test \ autodist-aclocal-m4.test \ autodist-config-headers.test \ autodist-configure-no-subdir.test \ +autodist-no-duplicate.test \ autodist-stamp-vti.test \ autohdr.test \ autohdr2.test \ diff --git a/tests/Makefile.in b/tests/Makefile.in index 7600c14..0f88916 100644 =2D-- a/tests/Makefile.in +++ b/tests/Makefile.in @@ -368,6 +368,7 @@ autodist-acconfig-no-subdir.test \ autodist-aclocal-m4.test \ autodist-config-headers.test \ autodist-configure-no-subdir.test \ +autodist-no-duplicate.test \ autodist-stamp-vti.test \ autohdr.test \ autohdr2.test \ diff --git a/tests/autodist-no-duplicate.test b/tests/autodist-no-duplicate= =2Etest new file mode 100755 index 0000000..e2b7da0 =2D-- /dev/null +++ b/tests/autodist-no-duplicate.test @@ -0,0 +1,40 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check that there are no duplicates in the list of files automatically +# distributed by automake. + +. ./defs || Exit 1 + +set -e + +# The automake manual states that the list of automatically-distributed +# files should be given by `automake --help'. +list=3D`$AUTOMAKE --help \ + | sed -n '/^Files .*automatically distributed.*if found/,/^ *$/p' \ + | sed 1d` + +list=3D`echo $list` +test -n "$list" # sanity check + +for f in $list; do echo $f; done | sort > files.lst +uniq files.lst > files.uniq + +cat files.lst +cat files.uniq +diff files.lst files.uniq + +: =2D-=20 1.7.2.3 --Boundary-00=_A8fMNsnVKMEniTT Content-Type: text/x-patch; charset="us-ascii"; name="0002-help-improve-text-about-automatically-distributed-fi.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0002-help-improve-text-about-automatically-distributed-fi.patch" =46rom 60370a87d28b0c3e7ddddc24c7da904a69b71d5b Mon Sep 17 00:00:00 2001 =46rom: Stefano Lattarini Date: Wed, 12 Jan 2011 01:27:07 +0100 Subject: [PATCH 2/2] help: improve text about automatically-distributed fil= es This change fixes automake bug#7819. * automake.in (usage): Distinguish between files that are always automatically distributed when found, and those which are only "under certain conditions". * doc/automake.texi (Basics of Distribution): Update accordingly. * tests/autodist-subdir.test: Update. * tests/autodist-no-duplicate.test: Likewise. * tests/autodist.test: Likewise. (configure.in): Remove useless call to AM_MAINTAINER_MODE. =2D-- ChangeLog | 11 +++++++++++ automake.in | 8 ++++++-- doc/automake.texi | 4 +++- tests/autodist-no-duplicate.test | 32 +++++++++++++++++++++----------- tests/autodist-subdir.test | 27 +-------------------------- tests/autodist.test | 29 +---------------------------- 6 files changed, 43 insertions(+), 68 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4e1e093..b532fcf 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,16 @@ 2011-01-15 Stefano Lattarini =20 + help: improve text about automatically-distributed files + This change fixes automake bug#7819. + * automake.in (usage): Distinguish between files that are always + automatically distributed when found, and those which are only + "under certain conditions". + * doc/automake.texi (Basics of Distribution): Update accordingly. + * tests/autodist-subdir.test: Update. + * tests/autodist-no-duplicate.test: Likewise. + * tests/autodist.test: Likewise. + (configure.in): Remove useless call to AM_MAINTAINER_MODE. + refactor: split 'usage' subroutine in automake This change is related to automake bug#7819. * automake.in (print_autodist_files): New subroutine, diff --git a/automake.in b/automake.in index 3a214e0..2603e44 100755 =2D-- a/automake.in +++ b/automake.in @@ -8385,8 +8385,12 @@ Library files: "; Automake::ChannelDefs::usage; =20 =2D print "\nFiles which are automatically distributed, if found:\n"; =2D print_autodist_files (@common_files, @common_sometimes); + print "\nFiles automatically distributed if found " . + "(always):\n"; + print_autodist_files @common_files; + print "\nFiles automatically distributed if found " . + "(under certain conditions):\n"; + print_autodist_files @common_sometimes; =20 print ' Report bugs to <@PACKAGE_BUGREPORT@>. diff --git a/doc/automake.texi b/doc/automake.texi index 73c0e51..cb1445f 100644 =2D-- a/doc/automake.texi +++ b/doc/automake.texi @@ -8289,7 +8289,9 @@ as are all @file{Makefile.am}s and @file{Makefile.in}= s. Automake also has a built-in list of commonly used files that are automatically included if they are found in the current directory (either physically, or as the target of a @file{Makefile.am} rule). This list is printed by =2D@samp{automake --help}. Also, files that are read by @command{configure} +@samp{automake --help}@footnote{Note that some of these files are actually +distributed only when other certain conditions hold}. Also, files that +are read by @command{configure} (i.e.@: the source files corresponding to the files specified in various Autoconf macros such as @code{AC_CONFIG_FILES} and siblings) are automatically distributed. Files included in @file{Makefile.am}s (using diff --git a/tests/autodist-no-duplicate.test b/tests/autodist-no-duplicate= =2Etest index e2b7da0..65fe034 100755 =2D-- a/tests/autodist-no-duplicate.test +++ b/tests/autodist-no-duplicate.test @@ -21,20 +21,30 @@ =20 set -e =20 +re=3D'Files .*automatically distributed.*if found' + # The automake manual states that the list of automatically-distributed # files should be given by `automake --help'. =2Dlist=3D`$AUTOMAKE --help \ =2D | sed -n '/^Files .*automatically distributed.*if found/,/^ *$/p= ' \ +list1=3D`$AUTOMAKE --help \ + | sed -n "/^$re.*always/,/^ *$/p" \ | sed 1d` +list1=3D`echo $list1` =20 =2Dlist=3D`echo $list` =2Dtest -n "$list" # sanity check =2D =2Dfor f in $list; do echo $f; done | sort > files.lst =2Duniq files.lst > files.uniq =2D =2Dcat files.lst =2Dcat files.uniq =2Ddiff files.lst files.uniq +list2=3D`$AUTOMAKE --help \ + | sed -n "/^$re.*under certain conditions/,/^ *$/p" \ + | sed 1d` +list2=3D`echo $list2` + +# Sanity checks. +test -n "$list1" +test -n "$list2" + +for i in 1 2; do + eval "for f in \${list$i}; do echo \$f; done | sort > files$i.lst" + uniq files$i.lst > files$i.uniq + cat files$i.lst + cat files$i.uniq + diff files$i.lst files$i.uniq +done =20 : diff --git a/tests/autodist-subdir.test b/tests/autodist-subdir.test index db694f8..83b293e 100755 =2D-- a/tests/autodist-subdir.test +++ b/tests/autodist-subdir.test @@ -39,33 +39,8 @@ $AUTOCONF # The automake manual states that the list of automatically-distributed # files should be given by `automake --help'. list=3D`$AUTOMAKE --help \ =2D | sed -n '/^Files .*automatically distributed.*if found/,/^ *$/p= ' \ + | sed -n '/^Files.*automatically distributed.*if found.*always/,/^= *$/p' \ | sed 1d` =2Dlist=3D`for f in $list; do =2D case $f in =2D configure|configure.in|configure.ac) =2D # See test 'autodist-configure-no-subdir.test'. =2D ;; =2D aclocal.m4) =2D # This file should be distributed only when it is a real =2D # dependency for configure. Anyway, not a check to be =2D # performed in this test. =2D ;; =2D acconfig.h) =2D # Works only when it really exists, not when it is a =2D # target in Makefile.am. =2D ;; =2D stamp-vti) =2D # Works only when using info_TEXINFOS and version.texi. =2D ;; =2D config.h.bot|config.h.top) =2D # Works only when the AC_CONFIG_HADERS macro is used. =2D ;; =2D *) =2D echo $f =2D ;; =2D esac =2D done` # Normalize whitespace, just in case. list=3D`echo $list` =20 diff --git a/tests/autodist.test b/tests/autodist.test index 34b9526..7992608 100755 =2D-- a/tests/autodist.test +++ b/tests/autodist.test @@ -32,8 +32,6 @@ cat > configure.in <) id 1PfajT-0004Lp-My for submit@debbugs.gnu.org; Wed, 19 Jan 2011 11:18:03 -0500 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PfajM-0004Ld-UN for control@debbugs.gnu.org; Wed, 19 Jan 2011 11:17:57 -0500 Received: by bwz12 with SMTP id 12so956404bwz.3 for ; Wed, 19 Jan 2011 08:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:mime-version :content-type:content-transfer-encoding:message-id; bh=sFcT/P/y2NeC1eY8cfAfP/tcFcE7IUOH0lc7Ce1U9ZU=; b=M+yJqjcjHcjIGMen7yrgb8rYeMG2L17o0IhGoUJLvrNm+dmwHu5yGQ/cb4fBwwrTi/ DlXBzniThrhNxq9ZYqD/iLJFg6G9S9pA5zAXvwU0g+lA4XrSuU1K5m63bG3rAoMMG4lc ZhQZ09VWRbkxoXiCDugPjpCAhKlKhgLfS+e8o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:mime-version:content-type :content-transfer-encoding:message-id; b=OG79uxG6LIhSk46ro6fe0zkEz8aqcHUNOzj4MCYDKvDi1xpHYA6uni+tpSe+gt/SjE cGHB/jzPcfznroFk+iW08Mp4QV6JIswr4yrhq/V266lRF1crZ37cm676qlkz3Ij8p30u WDwdnf0t9QIOB/bUMOnd5SqYxtAWO+rEzFxdc= Received: by 10.204.76.131 with SMTP id c3mr805692bkk.110.1295454308361; Wed, 19 Jan 2011 08:25:08 -0800 (PST) Received: from bigio.localnet (host2-33-dynamic.52-82-r.retail.telecomitalia.it [82.52.33.2]) by mx.google.com with ESMTPS id rc9sm1974172bkb.2.2011.01.19.08.25.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 19 Jan 2011 08:25:07 -0800 (PST) From: Stefano Lattarini To: control@debbugs.gnu.org Subject: bug#7819 Date: Wed, 19 Jan 2011 17:24:55 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201101191724.56182.stefano.lattarini@gmail.com> X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) tags 7819 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 23 05:02:54 2011 Received: (at 7819-done) by debbugs.gnu.org; 23 Jun 2011 09:02:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZfoL-0004To-S9 for submit@debbugs.gnu.org; Thu, 23 Jun 2011 05:02:54 -0400 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QZfoG-0004TY-Uf for 7819-done@debbugs.gnu.org; Thu, 23 Jun 2011 05:02:50 -0400 Received: by wyj26 with SMTP id 26so1190846wyj.3 for <7819-done@debbugs.gnu.org>; Thu, 23 Jun 2011 02:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=Pk2HRCzdvTCp1KPo+Pjs8fsN+oisIlKGg5WpGIwQ7ug=; b=ASDHG1U1pvOq7oAG5NYnKTTfJNoMr6ledGiadkMSUtCual84R/dKErdDpf2FDyM4iB f8Nq1OLnM6psiiVTWafVGw9sFBiJr9p7J/2+b1/moQuugERXZyjJEbGJTtgMMT7rKOys Pa78hLffioucwJBrdgL+aJdCrxcmo/UC2dZUs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=nPGD2RbBb9x5q5OwM2oG51cLW924bJOx20ef6DcVHow/q/e1sclPiiB3nNNVWGqJDV 74aXg8IM8OFNArj27hjaqoFBWT+MCQdkaDrKtE192kxCljhoWfBlS3jsR1EcqxABf1Ue 0Sruo6UEr9bNKo/Gls0evCnXHhEmfg6uD6FWQ= Received: by 10.227.37.12 with SMTP id v12mr1756672wbd.20.1308819762885; Thu, 23 Jun 2011 02:02:42 -0700 (PDT) Received: from bigio.localnet (host188-37-dynamic.56-82-r.retail.telecomitalia.it [82.56.37.188]) by mx.google.com with ESMTPS id fm6sm1068846wbb.10.2011.06.23.02.02.38 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Jun 2011 02:02:40 -0700 (PDT) From: Stefano Lattarini To: automake-patches@gnu.org Subject: Re: bug#7819: automake does not really automatically distribute all the files it's advertised to. Date: Thu, 23 Jun 2011 11:02:29 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201101102050.14046.stefano.lattarini@gmail.com> <20110110204422.GC15241@gmx.de> <201101152109.36521.stefano.lattarini@gmail.com> In-Reply-To: <201101152109.36521.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106231102.30092.stefano.lattarini@gmail.com> X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 7819-done Cc: Ralf Wildenhues , 7819-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) References: On Saturday 15 January 2011, Stefano Lattarini wrote: > > On Monday 10 January 2011, Ralf Wildenhues wrote: > > Hi Stefano, > > > > * Stefano Lattarini wrote on Mon, Jan 10, 2011 at 08:50:13PM CET: > > > Files which are automatically distributed, if found: > > > ABOUT-GNU README config.rpath ltcf-gcj.sh > > > ABOUT-NLS THANKS config.sub ltconfig > > > AUTHORS TODO configure ltmain.sh > > > BACKLOG acconfig.h configure.ac mdate-sh > > [...] > > > ... > > > > > > But the above is not always correct, as some of these files are distributed > > > *only* if other conditions are met. For example, acconfig.h and aclocal.m4 > > > are distributed only if they really exists at automake runtime (having them > > > as targets in Makefile.am won't work), config.h.bot and config.h.top are > > > distributed only if the AC_CONFIG_HEADERS macro is used, and stamp-vti is > > > distributed only if info_TEXINFOS and version.texi are used. > > > > > > So, either the automake script or the automake help screen should be > > > adjusted. > > > > > > IMHO the current behaviour of automake is good enough, so I think we > > > should adjust the automake help screen to read something like: > > > > Agreed. With many of the names, I have been wondering though whether we > > should distribute them at all in arbitrary directories. For example, > > most scripts don't make that much sense outside of the toplevel or the > > build-aux directories. > > > > Then again, changing the current behavior here is quite likely to break > > some existing package setups, and even silently and only upon 'make > > dist' (so it might never show up for the developer), so that I'm not > > inclined to change this lightly. > > > > Documenting the existing behavior better sounds like a good idea to me. > > > > Thanks for the report, > > Ralf > > > > The attached two-patch series should fix the bug, by making it clear > in the documentation and in the help screen that certain files are > automatically distributed only under certain conditions or in certain > situations (without fully specifying which conditions or situations, > as that would be too detailed IMHO and make suboptimal behaviour > more difficult to be changed in future). > > OK for maint? > > Regards, > Stefano > > -*-*- > > refactor: split 'usage' subroutine in automake > > This change is related to automake bug#7819. > > * automake.in (print_autodist_files): New subroutine, > extracted from ... > (usage): ... this, which now uses it. > * tests/autodist-no-duplicate.test: New test. > * tests/Makefile.am (TESTS): Update. > --- > ChangeLog | 10 ++++ > automake.in | 89 +++++++++++++++++++------------------- > tests/Makefile.am | 1 + > tests/Makefile.in | 1 + > tests/autodist-no-duplicate.test | 40 +++++++++++++++++ > 5 files changed, 97 insertions(+), 44 deletions(-) > create mode 100755 tests/autodist-no-duplicate.test > > -*-*- > > help: improve text about automatically-distributed files > > This change fixes automake bug#7819. > > * automake.in (usage): Distinguish between files that are always > automatically distributed when found, and those which are only > "under certain conditions". > * doc/automake.texi (Basics of Distribution): Update accordingly. > * tests/autodist-subdir.test: Update. > * tests/autodist-no-duplicate.test: Likewise. > * tests/autodist.test: Likewise. > (configure.in): Remove useless call to AM_MAINTAINER_MODE. > --- > ChangeLog | 11 +++++++++++ > automake.in | 8 ++++++-- > doc/automake.texi | 4 +++- > tests/autodist-no-duplicate.test | 32 +++++++++++++++++++++----------- > tests/autodist-subdir.test | 27 +-------------------------- > tests/autodist.test | 29 +---------------------------- > 6 files changed, 43 insertions(+), 68 deletions(-) > > I've pushed these patches to maint now (after rebasing), and merged to master. Regards, Stefano From unknown Wed Jun 18 23:03:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 21 Jul 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator