From unknown Sun Jun 15 08:31:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78188 <78188@debbugs.gnu.org> To: bug#78188 <78188@debbugs.gnu.org> Subject: Status: [PATCH] Add KWallet service Reply-To: bug#78188 <78188@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:31:59 +0000 retitle 78188 [PATCH] Add KWallet service reassign 78188 guix-patches submitter 78188 Sergio Pastor P=C3=A9rez severity 78188 normal tag 78188 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 09:51:14 2025 Received: (at submit) by debbugs.gnu.org; 1 May 2025 13:51:14 +0000 Received: from localhost ([127.0.0.1]:49925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAUJm-0001pE-6A for submit@debbugs.gnu.org; Thu, 01 May 2025 09:51:14 -0400 Received: from lists.gnu.org ([2001:470:142::17]:47800) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAUJi-0001ou-HX for submit@debbugs.gnu.org; Thu, 01 May 2025 09:51:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAUJZ-0001Ky-6X for guix-patches@gnu.org; Thu, 01 May 2025 09:51:01 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uAUJX-0004gu-Fu for guix-patches@gnu.org; Thu, 01 May 2025 09:51:00 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-43d2d952eb1so4651515e9.1 for ; Thu, 01 May 2025 06:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746107457; x=1746712257; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LSVQQmEUXAD0Ni5bLVRr2P6+wCv/7+9IrW3JTKjoxfU=; b=UYqm2VjunOsoxSmKnlVdqjjVFnBNnW8QdU7s413Gfo8+o1S4ANyYgY9ObsTc8hkfuT F++dxKfrxipksNrieiCQ2EC9eOa1YwHPpw+ga2QGSB7XjT0N11rQy/QflozqvV2bYXDG oc0QxxWcJYJDiJYdU49zxOWX7rggJT4RjGilefl0jB94QSAkwFOAOL8d3hx1zmB7lvQP ZzVz83QogqDKkz40KKnLcJ6mnND7EkYt/z6FiLpNH/Ee/XFOQ2iSpVGJFky2YTC2TDP4 egEE78xao0pVst/PvgKGdTNf4doqgVhwIMf69zgCwGK+Pmx6sXTF361Yv/ROzyW3MRZn yOmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746107457; x=1746712257; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LSVQQmEUXAD0Ni5bLVRr2P6+wCv/7+9IrW3JTKjoxfU=; b=Kz/QuMbhkfC8LijvOufhAx9SiT0ODCeygLJ7KhgGO8By1QgBbRHIMnM56fmi+Mgy4G 3ZGG3T03NulHJNQH8EyxwRucT3e7Xt+tZ6yymr3rCdBZ161F2Co2mAT4saxBQedepSXC d0jf8JkjFvbWvmbQACW7ia4Cv5iynnxmuskC5vcRp/KntrfY13wGaP4/JIEP0Jr67HpQ vNCS/vy5ShYuZE413P5mYhrKQou7PXp+USWrfvesrCLN6Fy0ytRb9IeZK6ss0GCdSNBM GV8Ae6XtC7k16Vn/QwCwjxpjLyrQrrH4eGQV9mhfVEgJ/sQQyMU+RxpRqByw0ThsmMrY 8qWw== X-Gm-Message-State: AOJu0Yxue33v78A+04L2TJga04GKc9mpCS/FTjoblpOCqS3uHB+opOy/ g28upo4p4zo+NzcshDacBk1RvlYdmCyNZ6QZjTxc1R8SDrABMjM2Rq9+3Y1U X-Gm-Gg: ASbGncuIfF8TqHNpKLDDDnsRnxBz/rA2N5sP6p1XG8g3mtW1BbwPgx/imLOEf8DyOO8 pGLoyRmYSBO1Qaa4wMADHF6PXGaPCIaAwGHlb/ES6Rg/rP9mAliPPaSH+RXLSG79kmlx3OmFZUj hpvqVwaxlSZpp9d5riDg7jpWQiZCMppJoTSkO2GD6vTpHV8yqa7ahqh5II8OENWqdaf1Py2Rrw7 Xv8WwLBCjQXw3p1BS62iwY3obeUdCgN+QMy/976sDKlzNzXoVkfmIT5Mow6aLMEUtcQLMWNNW9B /XWt58uHhrxP4LjGWKJX0or+n4fPRrahiNPKOd54vmAs6Ma9XWnxJQ== X-Google-Smtp-Source: AGHT+IFjC51UvEOLS03x70dxvPqGsU6Y/WzPeJwF5Q5hrncmRBv/+2W2ElY/5XR5XPk4I5KL41V70g== X-Received: by 2002:a05:600c:190e:b0:43c:f0ae:da7 with SMTP id 5b1f17b1804b1-441b64ed98emr21697995e9.7.1746107456390; Thu, 01 May 2025 06:50:56 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b391c42bsm52572475e9.39.2025.05.01.06.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 06:50:55 -0700 (PDT) From: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= To: guix-patches@gnu.org Subject: [PATCH] Add KWallet service Date: Thu, 1 May 2025 15:50:24 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Liliana Marie Prikler , Ludovic Courtès , Maxim Cournoyer , Noé Lopez , Vivien Kraus Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=sergio.pastorperez@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This patch series adds `kwallet-service-type'. This service serves the same function as `gnome-keyring-service-type' but for `kwallet'. By default the service configures PAM for SDDM, since this is the expected greeter to use with `kwallet-pam'. The 'libexec/pam_kwallet_init' binary form the `kwallet-pam' package was not properly wrapped and could not access the `socat' input binary. This patch series includes the fix which is required for the correct autostart of the wallet. Sergio Pastor Pérez (2): gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. services: kwallet: New service. doc/guix.texi | 37 ++++++++++++++++++++++ gnu/packages/kde-plasma.scm | 14 +++++++-- gnu/services/desktop.scm | 61 +++++++++++++++++++++++++++++++++++++ 3 files changed, 109 insertions(+), 3 deletions(-) base-commit: 881d46eb386c2de8bc6f1405972ee1e115eeb3a1 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 09:54:29 2025 Received: (at 78188) by debbugs.gnu.org; 1 May 2025 13:54:29 +0000 Received: from localhost ([127.0.0.1]:49955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAUMv-0001xT-El for submit@debbugs.gnu.org; Thu, 01 May 2025 09:54:29 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:44080) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAUMs-0001x9-1A for 78188@debbugs.gnu.org; Thu, 01 May 2025 09:54:26 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-39c1efc4577so383085f8f.0 for <78188@debbugs.gnu.org>; Thu, 01 May 2025 06:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746107659; x=1746712459; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3o6tBd2dtSkv0ls5KHdAT8nTgdEGNhg/85lzZq3JKgU=; b=W7mzE4AaZRn1uAo63j5CcGHL0ajOI/RktUGQ/F0Molhogl0x9U8/exNT0FgcTABfLu UbHr3h+Fb2SL6QppteanY84g7kiie8wuTZmtF2MvgQQsG2OfcM5yEbQAkksoCnHA7WTB 7kYv3g0DSD18krlFYdVwOuhXRj1qBytyE3QdGNCgdgB0qrC//P5j1MN/Q+PGioUB6Jwv 7JEqGPGsUcoPjC97Chkdjlys2S0KaAVmHUVlEFGLRAhahb7fKhkMtE4AcaAgdZ/tMcEa jywH9QkvNnS+rbz1G9Wj3g/i5ZmN6RZMfes/OjNibacVyBYJS95SnwJ7XFr8fPkoJGXs kX7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746107659; x=1746712459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3o6tBd2dtSkv0ls5KHdAT8nTgdEGNhg/85lzZq3JKgU=; b=D/D0DnBqZcxystRapcBjpn2tBwoheI4ruQ2JL0j59urlhjMDmpu72fiF931m87AL+b 0Ti+dyaiGKPNT2M7Ze7W4u9CeP+7k7uWgMiVJzxIp5HJ4Fqdj3PNerRkla+7zFqsuX0j VBnHLbtaP5g73ZRcdj0SjTAHu1QD0vNLfWuxjA+NM5mmPlczwki2OoKOBQ/kUos/uMND 5nxj3KtPBdrzu6BAed9110GO0ahSZyJrZGoGZca7T9febEZB0lgz5LX3Cij2+ZAyxN0/ FfAS2xC8PysOnrjtbqvJMJrDNQ7mdURvGqDJOyEZ3cXcPqXKF1YT5yEWShFnGOs0eUe4 /Fgg== X-Gm-Message-State: AOJu0Yyl6/RRFGAZATN+RnxZAkdGJlewNndbn8b3xiaEl0Zq1ylot0y2 Hgf3bHgH+pJPHGyZYevSpIuXYSkFI6ceGGE6FpvKX0TM1fyoaJFeHFVxju4l X-Gm-Gg: ASbGncvJhYr+VFsyc+M1rzfV8BAwmITWM9MLfXQccSKFIFHEuhjOTaGc5y2WiZz6iBe yRrN8BWg8SQUR++XqtI/Uxm7e8qq4CwE+bbAvH0+1XvYo0vE3fb0f1DCZYouQ5S84uM2sDoURFh vkeLex2aLKTMsNYq/BK9xNiguVLC9W0talAL54UeTdpc024tjGkGjHkYYWlkr2uyYE0nBG2T4s2 hflLxy+nK+Pej2ur7yYbaUAMUl7CIQaMSGVaBRyEvSZm/c1+hCzgahHBXDy/Z8RPpG4vbV4SOTU EaRWKotcifvNqMFw4bx/OkWB9JYpql91qy+5weqxctkb3efFQ3mfcw== X-Google-Smtp-Source: AGHT+IGxMbWdYRowCRfw4N+KfAXbhiCPpZ3jsvwzQbOfLILguOJzr0/+S3D+GgW1wHN4X/upPxTQvg== X-Received: by 2002:a5d:59ae:0:b0:39e:dce8:1c07 with SMTP id ffacd0b85a97d-3a094178889mr1963112f8f.46.1746107658836; Thu, 01 May 2025 06:54:18 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a3dfa8sm926449f8f.13.2025.05.01.06.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 06:54:18 -0700 (PDT) From: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= To: 78188@debbugs.gnu.org Subject: [PATCH] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. Date: Thu, 1 May 2025 15:53:59 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Sughosha , Zheng Junjie Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not setting PATH variable to access 'socat' input. Change-Id: I6e7a421af3dbbc844e319b7852246c89d979609c --- gnu/packages/kde-plasma.scm | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm index 679a68cef6..a15f7ad8a2 100644 --- a/gnu/packages/kde-plasma.scm +++ b/gnu/packages/kde-plasma.scm @@ -1303,9 +1303,17 @@ (define-public kwallet-pam "0dif5y7qbayb2yfgl7940978ayyir948kpjavczvgkr70czb293k")))) (build-system qt-build-system) (arguments - (list - #:qtbase qtbase - #:tests? #f)) ;no tests + `(#:qtbase ,qtbase + #:tests? #f ;no tests + #:phases + (modify-phases %standard-phases + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((socat (search-input-file inputs "bin/socat"))) + (wrap-program (search-input-file outputs + "libexec/pam_kwallet_init") + `("PATH" ":" prefix + ,(list (dirname socat)))))))))) (native-inputs (list extra-cmake-modules pkg-config)) (inputs (list linux-pam kwallet libgcrypt socat)) (synopsis "PAM Integration with KWallet") -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 09:54:33 2025 Received: (at 78188) by debbugs.gnu.org; 1 May 2025 13:54:33 +0000 Received: from localhost ([127.0.0.1]:49957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAUMy-0001xq-Ug for submit@debbugs.gnu.org; Thu, 01 May 2025 09:54:33 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:45387) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAUMv-0001xG-7l for 78188@debbugs.gnu.org; Thu, 01 May 2025 09:54:29 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-43ed8d32a95so7658255e9.3 for <78188@debbugs.gnu.org>; Thu, 01 May 2025 06:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746107662; x=1746712462; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZbInTb/YceLWRdPkUfE85Wqfm04fZ+OiP4w02rPxUhk=; b=Il27GN/nOul3pMSitR47kna1w2/2Rwe81M7xJeQ7CG32QkN0wGfr8gwUJ/u+8VGsnO 20jv528A9b6LuRgjCABT9H8Sm94yOOZayiFKnCJJCWmCFQsQCeoMDiFrNdqDZkEeQxCk E1havmWaha334VvRb9phKlrzJEdP6fZgY6SsBMteOeeriUrAe9J54kkYtKtgfVBUWbM4 omiDz9jBVyz2/yL+bJT6WrvVNU5TxDyIyZGP8CN6cP/C5l3PFVof5gsZYCubRFf3tJD5 wB+Mf7z6SRY9g2YDWmB/qQatM71V4pMc2XqGPXzgkQ7CnQR7PB43HZbcGBqHvxujjFUC Lgdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746107662; x=1746712462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZbInTb/YceLWRdPkUfE85Wqfm04fZ+OiP4w02rPxUhk=; b=iDw9ggR0xFmDSNv2ErENRT08mzaVnOblX8MG94i/+xn5v71fPiY4ovJoRUTRdT6WUZ 4ghGxg8PQ5nAVgtT06w5FPgapjcvQcRCyoksljurtac2x6PRH5nCyRD8gTt3nfVMmvNT Jc7iyYPT1WkR1tnlqCVwRtSZcJ6wkrk7P9fbxf8qnzDy2aN8S8EOTXjCpOeWsfjbmMuH UmB9M4GBCeHuYUh0BogCE02Ph5XfMFocLGfoOv7ZY/rB9g5/8pjbeErojFC4nMqn1zpK 6eOP0JWObPlyRYRZNs6kQ0Dxs3/9i8Qj+QWxycQllPUnv4xeyi8J6dJTw+bR+HaXNjk2 iSKA== X-Gm-Message-State: AOJu0Yz57XVpVdVHRPIruESBDxr2rZiLq8IBBEptw+mL2E04fJza9AN4 ZEHKAbvxdl8pMLFtbWmd/74YmrxAVOPgxCtHB5QC5P1LvIipnUoU0oe580AX X-Gm-Gg: ASbGnct+2GeRW3Q4tkgMdiHFqKkO6T67lxAQJvE8Cs1wcL2bbkIup+jUPiE1X0CFZil L/ubmxf562zt1QKTMOJxk7F/zCX1nKNdHWWvKK3ZD53+7h1bESnk+IHFnkEoY8/ev9RKhlqPTin WP7o3r7Gov4DOQN3NbTdKc0OHnmNc6+7ETdyAJ31XEQOmNfSrJAelSJYEw4UjPyoxzg7cGfXudL U/dryALjyDKeO43xorLh1b/9Ds7IO3VYieO5svnI4oObs7hLMXnC3RC/piUAF6mKFH5nUGIYqY3 /rlEegAHIEwvzSJERbkTnVDn4ZU16+Laz8hxv2Oa+7qx1VpuDxECM9hC7n9L/C6f X-Google-Smtp-Source: AGHT+IFUusoA9ZWqhi7ruaVi5uMgT7o7spOClBXONjWTmZkPZX6Hghkd7dVhMXtQULxorzZnE6bG+Q== X-Received: by 2002:a05:600c:8711:b0:43b:cc3c:60bc with SMTP id 5b1f17b1804b1-441b7034c5cmr24272855e9.15.1746107662373; Thu, 01 May 2025 06:54:22 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b8992b4csm13620215e9.0.2025.05.01.06.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 06:54:21 -0700 (PDT) From: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= To: 78188@debbugs.gnu.org Subject: [PATCH] services: kwallet: New service. Date: Thu, 1 May 2025 15:54:00 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , Ludovic Courtès , Maxim Cournoyer , Noé Lopez , Vivien Kraus Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Change-Id: I1330ce5e1648a8ddf6ddd507255a73335d6baa51 --- doc/guix.texi | 37 ++++++++++++++++++++++++ gnu/services/desktop.scm | 61 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 98 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 7b418a4089..c6861b3182 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -27131,6 +27131,43 @@ Desktop Services @end table @end deftp +@defvar kwallet-service-type +This is the type of the service that adds the +@uref{https://invent.kde.org/plasma/kwallet-pam, KWallet keyring}. Its +value is a @code{kwallet-configuration} object (see below). Note that, +contrary to @code{gnome-desktop-service-type}, +@code{plasma-desktop-service-type} does not include this service. + +This service adds the @code{kwallet-pam} package to the system profile +and extends PAM with entries using @code{pam_kwallet5.so}, +unlocking a user's login keyring when they log in or setting its +password with passwd. +@end defvar + +@deftp {Data Type} kwallet-configuration +Configuration record for the KWallet Keyring service. + +@table @asis +@item @code{keyring} (default: @code{kwallet-pam}) +The KWallet keyring package to use. + +@item @code{pam-services} +A list of @code{(@var{service} . @var{kind})} pairs denoting PAM +services to extend, where @var{service} is the name of an existing +service to extend and @var{kind} is one of @code{login} or +@code{passwd}. + +If @code{login} is given, it adds an optional +@code{pam_kwallet5.so} to the auth block without arguments and to +the session block with @code{auto_start}. If @code{passwd} is given, it +adds an optional @code{pam_kwallet5.so} to the password block +without arguments. + +By default, this field contains ``sddm'' with the value @code{login} +and ``passwd'' is with the value @code{passwd}. +@end table +@end deftp + @defvar seatd-service-type @uref{https://sr.ht/~kennylevinsen/seatd/, seatd} is a minimal seat management daemon. diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index a586746cc5..a3cbf3f397 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -197,6 +197,10 @@ (define-module (gnu services desktop) gnome-keyring-configuration? gnome-keyring-service-type + kwallet-configuration + kwallet-configuration? + kwallet-service-type + seatd-configuration seatd-service-type @@ -2148,6 +2152,63 @@ (define enlightenment-desktop-service-type thumbnails and privileges the programs which enlightenment needs to function as expected."))) + +;;; +;;; kwallet-service-type +;;; + +(define-record-type* kwallet-configuration + make-kwallet-configuration + kwallet-configuration? + (wallet kwallet-package (default kwallet-pam)) + (pam-services kwallet-pam-services (default '(("sddm" . login) + ("passwd" . passwd))))) + +(define (pam-kwallet config) + (match config + (#f '()) ;explicitly disabled by user + (_ + (define (%pam-keyring-entry . arguments) + (pam-entry + (control "optional") + (module (file-append (kwallet-package config) + "/lib/security/pam_kwallet5.so")) + (arguments arguments))) + + (list + (pam-extension + (transformer + (lambda (service) + (case (assoc-ref (kwallet-pam-services config) + (pam-service-name service)) + ((login) + (pam-service + (inherit service) + (auth (append (pam-service-auth service) + (list (%pam-keyring-entry)))) + (session (append (pam-service-session service) + (list (%pam-keyring-entry "auto_start")))))) + ((passwd) + (pam-service + (inherit service) + (password (append (pam-service-password service) + (list (%pam-keyring-entry)))))) + (else service))))))))) + +;; TODO: consider integrating service in `' as +;; done in `'. This requires rewritting the +;; `' as done for `'. +(define kwallet-service-type + (service-type + (name 'kwallet) + (extensions (list + (service-extension pam-root-service-type pam-kwallet))) + (default-value (kwallet-configuration)) + (description "Return a service, that extends PAM with entries using +@code{pam_kwallet5.so}, unlocking a user's login keyring when they log in or +setting its password with passwd."))) + + ;;; ;;; KDE Plasma desktop service. ;;; -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 12:35:17 2025 Received: (at 78188) by debbugs.gnu.org; 1 May 2025 16:35:17 +0000 Received: from localhost ([127.0.0.1]:52608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAWsW-0005k5-Tu for submit@debbugs.gnu.org; Thu, 01 May 2025 12:35:17 -0400 Received: from mail.z572.online ([88.99.160.180]:57404) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAWsR-0005gE-Sh for 78188@debbugs.gnu.org; Thu, 01 May 2025 12:35:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z572.online; s=me; t=1746117714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gibnjrfGV7eMAECvMv8bJhahdUJKjsCMrbLFU/ElIKg=; b=Ns0JRYwWzeOcc13goa6IFbN3u+5llmFNH8z9P/PJdZO8beGkVgK2kHoe5M2OxmcMyREucu ZCWkPltQPiBwy67iITllVbBfE5ov9hI1XJ+HvbRuvpSbXijRIwyUJHekmeo/UBFEECW601 Tj9Jz283ZEUAuxrJD/s00ddTWdhAEM8= Received: from m (mail1.85362086.com [107.174.64.25]) by mail.z572.online (OpenSMTPD) with ESMTPSA id a2eddb1e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 1 May 2025 16:41:53 +0000 (UTC) From: Z572 To: Sergio Pastor =?utf-8?Q?P=C3=A9rez?= Subject: Re: [bug#78188] [PATCH] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. In-Reply-To: ("Sergio Pastor =?utf-8?Q?P=C3=A9rez=22's?= message of "Thu, 1 May 2025 15:53:59 +0200") References: User-Agent: mu4e 1.12.9; emacs 30.0.92 Date: Fri, 02 May 2025 00:34:52 +0800 Message-ID: <87plgs5lxv.fsf@z572.online> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 78188 Cc: 78188@debbugs.gnu.org, Sughosha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sergio Pastor P=C3=A9rez writes: > * gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not set= ting > PATH variable to access 'socat' input. > > Change-Id: I6e7a421af3dbbc844e319b7852246c89d979609c > --- > gnu/packages/kde-plasma.scm | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm > index 679a68cef6..a15f7ad8a2 100644 > --- a/gnu/packages/kde-plasma.scm > +++ b/gnu/packages/kde-plasma.scm > @@ -1303,9 +1303,17 @@ (define-public kwallet-pam > "0dif5y7qbayb2yfgl7940978ayyir948kpjavczvgkr70czb293k"))= )) > (build-system qt-build-system) > (arguments > - (list > - #:qtbase qtbase > - #:tests? #f)) ;no tests > + `(#:qtbase ,qtbase > + #:tests? #f ;no tests > + #:phases > + (modify-phases %standard-phases please use gexp. > + (add-after 'install 'wrap-program > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((socat (search-input-file inputs "bin/socat"))) > + (wrap-program (search-input-file outputs > + "libexec/pam_kwallet_init") > + `("PATH" ":" prefix > + ,(list (dirname socat)))))))))) This is just a sh script, I prefer to replace socat in the pam_kwallet_init file after unpack > (native-inputs (list extra-cmake-modules pkg-config)) > (inputs (list linux-pam kwallet libgcrypt socat)) > (synopsis "PAM Integration with KWallet") --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmgToqwACgkQO1qpk+Gi 3/Ae5Q//ZioydSPsKK3xlu6kWWIUpXgHDx2caMrgsVOvAmcJvabIMTir6GiGBsuT ZZ8Ne0jWPkxzxAzl3bnDOnfppGCbBS4hgwEdHdw3UFjniO3d/nOwTP9Z64Jj/6xQ WTjubWKwgIW9IjMcZULCclwRa+LVKCnMsU632e93b5Ntz53K7M09L3gLZbuS1Zos eZXUjKwjGlLnxKFu5jhdDy8HU1XDp1DjF11lcA8hOxgOMMprzvn3TCOwrO1uf1XA 62I8Iopqois6u23Mx0OWIQqnW2lelGzYFmHc2SMcl+kxwpu1kTdstqhOUgSlHORN Fm4spb0BnnD9/g5hvBskn3k9jHS6dB0XXSegwOqjbF2S4XJ3AHv8esF+/43AE9F/ hziJoCsrYRw5wU6f9ifvqLKv2RYJh44pbCPA18uAqvm2EkicnECoucNCM0QEXkxF 9wg99Ir9DC/vp7EgXo0SRt3o/68eNQzH3bIKs105Eyvwt8bJdfYfLLrokKLmEB/V c3MagCgrvtLu0dI4Byzj+TfUBWmy9cMDWSP5oanYifujeN0uE8CkIEg3SQciYezj VWJZc3IIGm8kp/ncGIPujJbOhEjdNAoVxFpcDgqPFdjnUHsWss2FXcqkWsz1Vc3J Yqsocz3uvKYmQQen7EzppPOGBAWCHmwmMXkpWd2tndF9sJgx/eU= =kCTS -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 13:55:35 2025 Received: (at 78188) by debbugs.gnu.org; 1 May 2025 17:55:35 +0000 Received: from localhost ([127.0.0.1]:53007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAY8E-0001cv-Mg for submit@debbugs.gnu.org; Thu, 01 May 2025 13:55:35 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:47337) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAY8C-0001cZ-LV for 78188@debbugs.gnu.org; Thu, 01 May 2025 13:55:33 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-39149bccb69so820124f8f.2 for <78188@debbugs.gnu.org>; Thu, 01 May 2025 10:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746122126; x=1746726926; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RqtUflHlkaEHJ5F26QlpD4nqLaRF/4ij6L0ZUUr3NRY=; b=kQNPDcxB1qMQhKqoKsm/w5hzRJOlGvrfrnNnU4tKfnB7tvbk3s7FxlPawIOCKTX/R4 aVFIjkcr+boEY7iyrOnopdEI0TACyxrTKX+Mpq4WwZ8yVk31AXjy4eQW1hP5BMiBuX9F sqYpirm5tWS7804F9m+F+tAFMSqHYKyoxRi8eSXLMP15Av2khlWvlFkg4Qq12MK89cVo MnD5EqNuHDD8AyfRgdKBoebmSocyA9xtFzUycmsQfFsW3k6L8HQj9P8pRQUDnNEgZc5c +5aMYq0GjzgZA1/IDHkMNXXkoVHgouYCBqYAgL8eQMjUjv2TvSG5vg8AnhSAkHZdbrK+ +Y8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746122126; x=1746726926; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RqtUflHlkaEHJ5F26QlpD4nqLaRF/4ij6L0ZUUr3NRY=; b=fV+pIDz9bR3BApN6w9zBG+jdgKEVVAd1UrhvHu7aFYHaUK+uQQCzCIBEnRWj7JnES8 EvzU53j+gxD8SmJf4xgZwm8+JYfcOswTB1Rb0ITfm1spmwx+chJIouJTfAluVYaBUUqX W85/hp600OXfTTDripUyjwUULvX/dTYjXlPlDmkcoGSJeCWPUmp5WCmFUEIKSfXl+TAB hNRFatsUe0HqTsVlfD8NvkD0B+3rWQGZpamv2q3yCJh6wdtLXfdShcakU7ZvNBd9dpjI TIypM3jHWnXqwz4vZAV0PDbmpH94Cd7AHBU9UDfBcPfAVPIIZ5gcbPAwx/s+Ssi1WjLS DDEQ== X-Gm-Message-State: AOJu0YxgGZNdVqWSTpwZVq9B5ifaCwT1v+aYIb63rDiwpfpTDtWlIRXM FOfH6z0FvpF4jEHmD3MQDGvaBTT61/kUVH6nY96KdUuab6rCcpzppG5QEqUK X-Gm-Gg: ASbGncuQNByEQasnuyNTYlw+gRpmbg3+lXFfM4vCkMnjMxfoZFB7BYHzwKXefz1//t6 BL8y+AefjwzGjThhbTqzZ32bfbNtoenexKNydSbFgj/vFM2wvH0Yi7u9KxAvN4JqKFcOE/t0PhK zrzpDb1TxWB8Wqq2J3s62S8L7otCSwoZqd743Ta+/EXdn2VHJc+JmeljA6QcDg5VR7W73GUX9Xg vZ7TECxjZnonJRSzYUgoNgrmM2LDf4Kcrlnlrs14VBPIzfosUNpjbdM8tTuxq1T/YDWSE90A/o8 s2g5QELoKYAJtgH6a+F9tNrvngEQKjAa0w2r0KtOCgNYbfjf12vdEcnGn8fKhEAZ X-Google-Smtp-Source: AGHT+IFVlJfE/N2sWtwM50Xqo1xulqflnIvO+7zGIPAVT0axnAPf3SGygBMsIhoSjRuCNvKl9BhoMQ== X-Received: by 2002:a5d:5f4c:0:b0:39f:fcb:3bf6 with SMTP id ffacd0b85a97d-3a08f75265amr6447011f8f.2.1746122126175; Thu, 01 May 2025 10:55:26 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a3e03fsm1416806f8f.11.2025.05.01.10.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 10:55:25 -0700 (PDT) From: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= To: 78188@debbugs.gnu.org Subject: [PATCH v2] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. Date: Thu, 1 May 2025 19:55:06 +0200 Message-ID: <1b8f1e2c24fb227d77a4617635842fb16db5d7f0.1746122107.git.sergio.pastorperez@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Sughosha , Zheng Junjie Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not setting PATH variable to access 'socat' input. Change-Id: I6e7a421af3dbbc844e319b7852246c89d979609c --- gnu/packages/kde-plasma.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm index 679a68cef6..400296f5da 100644 --- a/gnu/packages/kde-plasma.scm +++ b/gnu/packages/kde-plasma.scm @@ -1305,7 +1305,15 @@ (define-public kwallet-pam (arguments (list #:qtbase qtbase - #:tests? #f)) ;no tests + #:tests? #f ;no tests + #:phases + #~(modify-phases %standard-phases + (add-after 'install 'fix-socat-path + (lambda* _ + (substitute* (string-append #$output + "/libexec/pam_kwallet_init") + (("socat") + (string-append #$socat "/bin/socat")))))))) (native-inputs (list extra-cmake-modules pkg-config)) (inputs (list linux-pam kwallet libgcrypt socat)) (synopsis "PAM Integration with KWallet") base-commit: 881d46eb386c2de8bc6f1405972ee1e115eeb3a1 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 13:55:38 2025 Received: (at 78188) by debbugs.gnu.org; 1 May 2025 17:55:38 +0000 Received: from localhost ([127.0.0.1]:53010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAY8I-0001dL-5i for submit@debbugs.gnu.org; Thu, 01 May 2025 13:55:38 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:55676) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAY8F-0001ce-6Z for 78188@debbugs.gnu.org; Thu, 01 May 2025 13:55:36 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso6500015e9.3 for <78188@debbugs.gnu.org>; Thu, 01 May 2025 10:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746122129; x=1746726929; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZbInTb/YceLWRdPkUfE85Wqfm04fZ+OiP4w02rPxUhk=; b=h5n4nhu1ncV8c+9uLrXu7Z4JM0d+XOlEtuNgBQ7PgFBocFbAnZs//pNbkUz7Dkj/dT Fdg3A2nbrQ88oY9zaW6lolrkMweNQMzcAak8Mis/JRpy5nobnpf0AQB+nyCT4MXzrDnX 1rznQC+BkonjH/D5zfGivVY5/Zoil6dYedm/LKfRXbhUBiZIzGnl8Sf1A3GV5+SAyMVg KyCRehpFY9WgtF1FBCSNVmtYGoo68l8h5qvNuGwrQdetrMXPrz/eoaCWBhWIFgCUJW78 CmP8dfrbK7YFLigCpVK+cwpv144zValzEFXCsxTdqtRGq2jV9Uje6bZwAhwtGjDvqg/5 6Ikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746122129; x=1746726929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZbInTb/YceLWRdPkUfE85Wqfm04fZ+OiP4w02rPxUhk=; b=NVnUXjcyJftReWO1DPZHooC5KjT368AQv6sAHl9g29u7AYeufTgajuWgj2dMPvTfcQ 4OI59jlDtfpLuhP3XH4DJ7PIg57w7+VtLSUCHxkgwh9jE/5E41CVcvLtl5inYNe7J2OH vkMtXfL5brZMi/zhJjp0MD5/gahkjyllXsqL5hB1OwLWeNGE169AnltMzuCIsgD/RYon /FRreq1pbfL5CHwSkO/m8rqprL+NPYFKjvwJXJW6GUuALmJYukAUnaQa7rdKqV1kZeRa XpPbFDzqYCY7mzol64XPOSng5Nb5TP7UJgusjIchLcAHX8qWXV4WEZdB+m2RQqEI1e/w kWVA== X-Gm-Message-State: AOJu0Yxbx7UD2wJ06qEO18v0T8h+bpuCW0/oFZTvldkpUyQU6nxN0Eh9 /I1Q0RQQLhauuJO3zP9LZ83OJPY143HVYRojhJ9CYaByX0FHwLLRujdNQuJP X-Gm-Gg: ASbGnctghshnZ704TXE9i+Fzg7TAxzNe/+PNAN4L8308F5oc/WqzrbhePXY0RoHxKfs qQtvOLg1kMmlZSsaYwUVgTOHKWnq6UrLd7OamOPqA3Ughac8Alf89EjJD/GorYN/RT87HY1s8ko AeQ+7dFQtTKeuE+WNVP3cFgSYLIyUwpr43YQpPnQSVGHvjD8wULiIOKkAvuudaNjDdzlc7ymmDS APQiEaEXSSRubr7kPrClAlkpMirWAh9BcxyCum+u5EEmWVVMi76XvJyzoAEJIWA9h8SOKDgqxTa qgDNfl+M2Kwn7nNPlhDo8V9GG+ww06JPQlSsifefjRmJaSa+6/Rxpw== X-Google-Smtp-Source: AGHT+IEamAiV1mf99NUeYOa/S3wd/JSKykxUWPhX/05WnX8Cs34nhKldZcA3vntoRI0XY1y17rbFYw== X-Received: by 2002:a05:600c:1d99:b0:43b:ce36:7574 with SMTP id 5b1f17b1804b1-441b263a250mr67143045e9.11.1746122128647; Thu, 01 May 2025 10:55:28 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2aed5e8sm64664025e9.16.2025.05.01.10.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 10:55:28 -0700 (PDT) From: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= To: 78188@debbugs.gnu.org Subject: [PATCH v2] services: kwallet: New service. Date: Thu, 1 May 2025 19:55:07 +0200 Message-ID: <05d64ca757730e334021a4f68e65dc503acc7bb6.1746122107.git.sergio.pastorperez@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <1b8f1e2c24fb227d77a4617635842fb16db5d7f0.1746122107.git.sergio.pastorperez@gmail.com> References: <1b8f1e2c24fb227d77a4617635842fb16db5d7f0.1746122107.git.sergio.pastorperez@gmail.com> MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , Ludovic Courtès , Maxim Cournoyer , Noé Lopez , Vivien Kraus Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Change-Id: I1330ce5e1648a8ddf6ddd507255a73335d6baa51 --- doc/guix.texi | 37 ++++++++++++++++++++++++ gnu/services/desktop.scm | 61 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 98 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 7b418a4089..c6861b3182 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -27131,6 +27131,43 @@ Desktop Services @end table @end deftp +@defvar kwallet-service-type +This is the type of the service that adds the +@uref{https://invent.kde.org/plasma/kwallet-pam, KWallet keyring}. Its +value is a @code{kwallet-configuration} object (see below). Note that, +contrary to @code{gnome-desktop-service-type}, +@code{plasma-desktop-service-type} does not include this service. + +This service adds the @code{kwallet-pam} package to the system profile +and extends PAM with entries using @code{pam_kwallet5.so}, +unlocking a user's login keyring when they log in or setting its +password with passwd. +@end defvar + +@deftp {Data Type} kwallet-configuration +Configuration record for the KWallet Keyring service. + +@table @asis +@item @code{keyring} (default: @code{kwallet-pam}) +The KWallet keyring package to use. + +@item @code{pam-services} +A list of @code{(@var{service} . @var{kind})} pairs denoting PAM +services to extend, where @var{service} is the name of an existing +service to extend and @var{kind} is one of @code{login} or +@code{passwd}. + +If @code{login} is given, it adds an optional +@code{pam_kwallet5.so} to the auth block without arguments and to +the session block with @code{auto_start}. If @code{passwd} is given, it +adds an optional @code{pam_kwallet5.so} to the password block +without arguments. + +By default, this field contains ``sddm'' with the value @code{login} +and ``passwd'' is with the value @code{passwd}. +@end table +@end deftp + @defvar seatd-service-type @uref{https://sr.ht/~kennylevinsen/seatd/, seatd} is a minimal seat management daemon. diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index a586746cc5..a3cbf3f397 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -197,6 +197,10 @@ (define-module (gnu services desktop) gnome-keyring-configuration? gnome-keyring-service-type + kwallet-configuration + kwallet-configuration? + kwallet-service-type + seatd-configuration seatd-service-type @@ -2148,6 +2152,63 @@ (define enlightenment-desktop-service-type thumbnails and privileges the programs which enlightenment needs to function as expected."))) + +;;; +;;; kwallet-service-type +;;; + +(define-record-type* kwallet-configuration + make-kwallet-configuration + kwallet-configuration? + (wallet kwallet-package (default kwallet-pam)) + (pam-services kwallet-pam-services (default '(("sddm" . login) + ("passwd" . passwd))))) + +(define (pam-kwallet config) + (match config + (#f '()) ;explicitly disabled by user + (_ + (define (%pam-keyring-entry . arguments) + (pam-entry + (control "optional") + (module (file-append (kwallet-package config) + "/lib/security/pam_kwallet5.so")) + (arguments arguments))) + + (list + (pam-extension + (transformer + (lambda (service) + (case (assoc-ref (kwallet-pam-services config) + (pam-service-name service)) + ((login) + (pam-service + (inherit service) + (auth (append (pam-service-auth service) + (list (%pam-keyring-entry)))) + (session (append (pam-service-session service) + (list (%pam-keyring-entry "auto_start")))))) + ((passwd) + (pam-service + (inherit service) + (password (append (pam-service-password service) + (list (%pam-keyring-entry)))))) + (else service))))))))) + +;; TODO: consider integrating service in `' as +;; done in `'. This requires rewritting the +;; `' as done for `'. +(define kwallet-service-type + (service-type + (name 'kwallet) + (extensions (list + (service-extension pam-root-service-type pam-kwallet))) + (default-value (kwallet-configuration)) + (description "Return a service, that extends PAM with entries using +@code{pam_kwallet5.so}, unlocking a user's login keyring when they log in or +setting its password with passwd."))) + + ;;; ;;; KDE Plasma desktop service. ;;; -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 13:56:11 2025 Received: (at 78188) by debbugs.gnu.org; 1 May 2025 17:56:11 +0000 Received: from localhost ([127.0.0.1]:53027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAY8p-0001fT-8j for submit@debbugs.gnu.org; Thu, 01 May 2025 13:56:11 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:53476) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAY8n-0001f0-Ce for 78188@debbugs.gnu.org; Thu, 01 May 2025 13:56:09 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-39ac56756f6so1133555f8f.2 for <78188@debbugs.gnu.org>; Thu, 01 May 2025 10:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746122163; x=1746726963; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=FR3UDg+fwyFj4gteZOZ3iykw+umgTX7e0TncY9kH2kU=; b=J6SZyd3HgYYJNLNFLhV6kf5/HfwS64XBG8yVMRLJ29kKfUccztbOclzjOCGnONfmYS BRQQ4zmGIpRKM+I5sLeg1y7yjzDqIGtNhMWLVmSe9DVrKswOygM6pMk/2H7PTXblaBK4 Bwa2xt+WndAGlFWhKbz0gylLZ769cAjN4iMBOkziS0sBVIG2oA+lXnUJlLo5cc5efHxm UcwtXI0XDSPTrpRO1+A8cr/BHj4PrbXK1rIzO7R0/m44GtaEM/GCBcQtYFWWzjwLN3nX /eeMuN1QE5y34Y5uQqjsfTbs25MzeBPqooBtvbGBT+t2vjnejIJWnUGJUbl6zCcd6h+R 7FIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746122163; x=1746726963; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FR3UDg+fwyFj4gteZOZ3iykw+umgTX7e0TncY9kH2kU=; b=XPFO8KKvXlkNH/SQLD9i3WIFHVZe6b3VjtxSrIPlpqPwY1QJf1WL0/1Mrycag1FRaT 4HNGgctayTm5nRX04IPQseyhM2ORPZEI5LUPFshPa4H8oUJeg3YlTjOnniLKCyOvSZkw Ssq7l71bN5Ee44PrYpfD5xwj6O0P446Jk5mkvpsc62mYEJucXR7jizDwN4eoSfDOncIR oapIAGdcQQbP5hdQVCspAAwHYc7yfDHi/iMB9sjWYJzSfyoASng8QvyUzM2I5ONbVHXS zv69zwdqZ1QuE5cjZp4gsp0UqtRrto1vZZJ2ojxre2LxQbHZ6VH1h5yJSZbihIq2iyRU D4BQ== X-Gm-Message-State: AOJu0YxyXpG05mfRl9Iah3ysc81b325cKxQJd8G2u7cB9IB5m10fls0W Irh7MPUNsoncG27ZN0Q/iXuv5rGqESnOdRgBROJRHjsU2fJWL/KyDUPkk7CC X-Gm-Gg: ASbGnctTmcq4UZ2rIhHNF0WBjWBSScIdBnd+OFE8lLb/dR8mwDwRdXXD3aDozakqhWT nQB2TyFzNBeJ2n2aMouvO7mLj2EgAMoDpFtTISRKYI0UObIrfSj7qDjcjOhYyFoRdfZkyuwAEnj PaVubMvLetHToZQOWei6P40vLuWH36S1JRvVisEN+7T4IWMTYGen4eataLZw1LJBx6SPJsteb8U OCPEcbARw88iP3/wLPyHwW5EL7bfA0RfkDwTspK9X6x7+yonScsjR+gJqLhihMG9aIUhN5QZzLc JC2pNad+wjPB8KZAmeQo2TGpim3wA3jB4+d5zxy+klVNhunDwPVGsnwAvwmyHrUv X-Google-Smtp-Source: AGHT+IF1ocYvgXU77t2FZK6zheTlrsycw/Qul/c84MBWq4IzpeXv5u6Q82qzZNxwiCTgTTzZ6xweMA== X-Received: by 2002:a05:6000:184d:b0:39e:e75b:5cc with SMTP id ffacd0b85a97d-3a08ff37671mr6131319f8f.16.1746122162994; Thu, 01 May 2025 10:56:02 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a095a3df91sm1381624f8f.9.2025.05.01.10.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 10:56:02 -0700 (PDT) From: Sergio Pastor =?utf-8?Q?P=C3=A9rez?= To: Z572 Subject: Re: [bug#78188] [PATCH] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. In-Reply-To: <87plgs5lxv.fsf@z572.online> References: <87plgs5lxv.fsf@z572.online> Date: Thu, 01 May 2025 19:56:01 +0200 Message-ID: <87v7qkw6z2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: 78188@debbugs.gnu.org, Sughosha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Z572 writes: > Sergio Pastor P=C3=A9rez writes: > >> * gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not se= tting >> PATH variable to access 'socat' input. >> >> Change-Id: I6e7a421af3dbbc844e319b7852246c89d979609c >> --- >> gnu/packages/kde-plasma.scm | 14 +++++++++++--- >> 1 file changed, 11 insertions(+), 3 deletions(-) >> >> diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm >> index 679a68cef6..a15f7ad8a2 100644 >> --- a/gnu/packages/kde-plasma.scm >> +++ b/gnu/packages/kde-plasma.scm >> @@ -1303,9 +1303,17 @@ (define-public kwallet-pam >> "0dif5y7qbayb2yfgl7940978ayyir948kpjavczvgkr70czb293k")= ))) >> (build-system qt-build-system) >> (arguments >> - (list >> - #:qtbase qtbase >> - #:tests? #f)) ;no tests >> + `(#:qtbase ,qtbase >> + #:tests? #f ;no tests >> + #:phases >> + (modify-phases %standard-phases > > please use gexp. > >> + (add-after 'install 'wrap-program >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let ((socat (search-input-file inputs "bin/socat"))) >> + (wrap-program (search-input-file outputs >> + "libexec/pam_kwallet_init") >> + `("PATH" ":" prefix >> + ,(list (dirname socat)))))))))) > > This is just a sh script, I prefer to replace socat in the > pam_kwallet_init file after unpack Done! From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 14:17:38 2025 Received: (at 78188) by debbugs.gnu.org; 1 May 2025 18:17:38 +0000 Received: from localhost ([127.0.0.1]:53097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAYTZ-0002lQ-OD for submit@debbugs.gnu.org; Thu, 01 May 2025 14:17:38 -0400 Received: from mail.z572.online ([88.99.160.180]:48056) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAYTW-0002lC-NK for 78188@debbugs.gnu.org; Thu, 01 May 2025 14:17:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z572.online; s=me; t=1746123860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=obFGg5YSJ64g0awchfyzKOhH9r2fWTE9g2qxCydjmuM=; b=ZUtJn8MB4S9PjSSs9W1ROo3mqIHFozkfN0M/mxohGRsb2ZBTk1GpiapRkZ+jlsp9C4ZxcG 1sfizYDbis9Sa+pPrIzMDq5cBbpHblLC9HFxyk4d8jQk4XgVSbtqi5trMqWyqueZHuaWOZ y0JBKpXW6sQEtdEjFEyHQmQosDTH0Hk= Received: from m (mail1.85362086.com [107.174.64.25]) by mail.z572.online (OpenSMTPD) with ESMTPSA id 12e796d6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 1 May 2025 18:24:19 +0000 (UTC) From: Z572 To: Sergio Pastor =?utf-8?Q?P=C3=A9rez?= Subject: Re: [bug#78188] [PATCH v2] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. In-Reply-To: <1b8f1e2c24fb227d77a4617635842fb16db5d7f0.1746122107.git.sergio.pastorperez@gmail.com> ("Sergio Pastor =?utf-8?Q?P=C3=A9rez=22's?= message of "Thu, 1 May 2025 19:55:06 +0200") References: <1b8f1e2c24fb227d77a4617635842fb16db5d7f0.1746122107.git.sergio.pastorperez@gmail.com> User-Agent: mu4e 1.12.9; emacs 30.0.92 Date: Fri, 02 May 2025 02:17:19 +0800 Message-ID: <878qng5h74.fsf@z572.online> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 78188 Cc: 78188@debbugs.gnu.org, Sughosha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sergio Pastor P=C3=A9rez writes: > * gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not set= ting > PATH variable to access 'socat' input. > > Change-Id: I6e7a421af3dbbc844e319b7852246c89d979609c > --- > gnu/packages/kde-plasma.scm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm > index 679a68cef6..400296f5da 100644 > --- a/gnu/packages/kde-plasma.scm > +++ b/gnu/packages/kde-plasma.scm > @@ -1305,7 +1305,15 @@ (define-public kwallet-pam > (arguments > (list > #:qtbase qtbase > - #:tests? #f)) ;no tests > + #:tests? #f ;no tests > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'install 'fix-socat-path > + (lambda* _ > + (substitute* (string-append #$output > + "/libexec/pam_kwallet_init") > + (("socat") > + (string-append #$socat "/bin/socat")))))))) should #~(modify-phases (add-after 'unpack 'fix-socat-path (lambda* (#:key inputs #:allow-other-keys) (substitute* "pam_kwallet_init" (("socat") (search-input-file inputs "bin/socat")))))) > (native-inputs (list extra-cmake-modules pkg-config)) > (inputs (list linux-pam kwallet libgcrypt socat)) > (synopsis "PAM Integration with KWallet") > > base-commit: 881d46eb386c2de8bc6f1405972ee1e115eeb3a1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmgTuq8ACgkQO1qpk+Gi 3/AgHw//TSzA0OfmnDiDZg6JlknrQ6CiYVuqluk+fLBneTH3NTTRU8MXqyI95ekM zEk8zKXrVcO+9NkxPoOhDyOaFTYlGVpjZ05rXSQp4pRIwINX07m+S4/0lsAMbNdI yJ+taRbMUzYvSrPH5byXz7PwaDxfl+GFeD9agvj0f1jiaSl+qUomdQk8EAhA5KTa 5GII/Roj3rJ61Jf0/kE3hM8lMwSjYgLOsp4VpABUFL55gfBvszAWhX/3GtYUe8DB 8HDwsS9PaPjV3XTPf09USxP52PDl390P9GJC6RvTjBkUc5ayF4cShkEOB0MP76i1 soLlP/NNkOS2xybFpfLqRmgX1Q9cFIi8SxzN2+1ojUePNYEIYLruYQOeNLKoJMrK StC1jSLexfk0grQJ2TMQ6ZT7qpKj8pjh4cejHr5vb2DC4NcMuGUmo0Idw1udlbMQ w+CDVZr+t5x6xb6ItAXqWPr+jmO357lXZRHrPboSxahPwOK0hykdQuc9J5pHH5Cg +hDNg0Hd6pk5T08KwHu2Xql4foj8IstDhlopqIQoRGTcDusZfSOYfJVuRWIA9uWR q73ycXjrkAXyCzKR+z2/vZdl6YZ6arZyEV6pHo18rrtHS/GkHafNEtPzMgLplbk4 iJbOkL5Yf2LPs8BP/DO/pmI2h54OBQkXQWzpYbb5pQyolPluo34= =qhh9 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 19:59:27 2025 Received: (at 78188) by debbugs.gnu.org; 1 May 2025 23:59:27 +0000 Received: from localhost ([127.0.0.1]:54284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAdoN-0006cI-6H for submit@debbugs.gnu.org; Thu, 01 May 2025 19:59:27 -0400 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]:52719) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAdoJ-0006bk-GY for 78188@debbugs.gnu.org; Thu, 01 May 2025 19:59:25 -0400 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-af50f56b862so1064615a12.1 for <78188@debbugs.gnu.org>; Thu, 01 May 2025 16:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746143957; x=1746748757; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ec2jEHvZEECVSLJIiXy6dTPcIC+oCLa7OksZVLrsZMs=; b=WZCzJAFWzuB6DBc90LwAIHqFeUyb0x6sYB48RO84VibG6WZL7o4yYEFYwQkEjiqfy7 h+pH7xTYUWdGPE5KzhJ2aGD/TYtJLUSjIFgYDP/wVxNJslRlbdOynVoNvM4uJb83konh J4qUpe6YPNBDXgFoAaJGs/dOitzXfpj3dSt0yonoUyUJgXkXMtPd47fz4Ss8l734zHHE e0czvh189VX6z/gDnk3r5RCmmtzgGeRaaJE5fqoIUiHCfJmc8c2/YQXLMpBlQGFoY0L3 0pUOgDA4dsHwPgNffqudDeNEbsaUiTqM4UB9jFLweKhpZNyyEw9wiiratvFSHDmgx49G z+Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746143957; x=1746748757; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ec2jEHvZEECVSLJIiXy6dTPcIC+oCLa7OksZVLrsZMs=; b=nB3OPgNqYHNDDSjKKdJxEGaLxfDChiQLGEY47m6xw971Z6QDaB9rTa5r7+4c1zjPVb zvv+FnuD21YzfY4/AvfCOfooOraUybwvDr/1dQBiBPgYfHy57G07EcxgXqu6+mWN/WEr U3hP+xfzMKGiZIjHSBalNx23Wljq9WPqaKcs+ggO3ZPhfUFJOUvjlYDdqmTdkCRByMDs KCKSmJ+Q27jBkddXVnqQcanTwyr/mAHnT2i1yHST10WqZmbh9+sqJxvPSW9ZeHq2gOoO d51h5q72FXO66nbZK3YY421l80Y9jJkr1g0qXe4WLOaJHg/YzDtxcylTHdn5u5oCkMEd 28kQ== X-Gm-Message-State: AOJu0Yy2nUyyS1Jon8xxT1tuHiFVjkELCmjSrXoxTuQ260S16hUKSeTO jDF070Cb9+dgRPAByEDh+HVJp+EpvpQOVan6j8oJcfAj0EkqsPBT X-Gm-Gg: ASbGncshjQv2ppX9eFLXnCc4n0WqEkkdDtawSdzcKAnGv7nm6dt3LUuJRrxeyTM1U1/ 6/pH10aKTm9EA9S3+WHo/wuZtO9NusmIOIcWc0iK8F3xbgB/xOkzP8wjEI2mIpt1AVhF1zmjATb vqvJqofchJKNkwihFX02FSzE+6yuhu062nanjeBu6RJgLiZ+IBdnEMx7GbMuG96ezxk4xSZqgpO s3rHGi1YrsDKsvalSMpbdIHCvmSDn7kX2JiHTWK7dwC1A/9KHvG33coG+DnElkECiSpg4xnHnev Eu9/M9di0DR1CUHpqjP+cctTFxYXmeuwq+3N9uY= X-Google-Smtp-Source: AGHT+IHl2nXzxlA5nmeloJmmqXaAIIp2OGWLOKEx9TT/gll6wGr5KAmC6dCpqLG5xWWUkAqqwwzp8Q== X-Received: by 2002:a17:90b:3d45:b0:308:7a70:489a with SMTP id 98e67ed59e1d1-30a4e686d20mr1341027a91.30.1746143957212; Thu, 01 May 2025 16:59:17 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30a47642083sm1536145a91.45.2025.05.01.16.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 16:59:16 -0700 (PDT) From: Maxim Cournoyer To: Sergio Pastor =?utf-8?Q?P=C3=A9rez?= Subject: Re: [bug#78188] [PATCH v2] services: kwallet: New service. In-Reply-To: <05d64ca757730e334021a4f68e65dc503acc7bb6.1746122107.git.sergio.pastorperez@gmail.com> ("Sergio Pastor =?utf-8?Q?P=C3=A9rez=22's?= message of "Thu, 1 May 2025 19:55:07 +0200") References: <1b8f1e2c24fb227d77a4617635842fb16db5d7f0.1746122107.git.sergio.pastorperez@gmail.com> <05d64ca757730e334021a4f68e65dc503acc7bb6.1746122107.git.sergio.pastorperez@gmail.com> Date: Fri, 02 May 2025 08:59:13 +0900 Message-ID: <87wmaz6fxq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: 78188@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , =?utf-8?Q?No=C3=A9?= Lopez , Liliana Marie Prikler , Vivien Kraus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Sergio Pastor P=C3=A9rez writes: > Change-Id: I1330ce5e1648a8ddf6ddd507255a73335d6baa51 > --- > doc/guix.texi | 37 ++++++++++++++++++++++++ > gnu/services/desktop.scm | 61 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 98 insertions(+) > > diff --git a/doc/guix.texi b/doc/guix.texi > index 7b418a4089..c6861b3182 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -27131,6 +27131,43 @@ Desktop Services > @end table > @end deftp >=20=20 > +@defvar kwallet-service-type > +This is the type of the service that adds the > +@uref{https://invent.kde.org/plasma/kwallet-pam, KWallet keyring}. Its > +value is a @code{kwallet-configuration} object (see below). Note that, > +contrary to @code{gnome-desktop-service-type}, > +@code{plasma-desktop-service-type} does not include this service. Does gnome-desktop-service-type include the kwallet-service-type? I wouldn't think so. You probably meant to say it "doesn't include a wallet service in its default configuration." ? Is this the normal expectation for the KDE desktop? I'd assume it comes with kwallet pre-configured, if using Fedora for example. If it does, we should probably do so to avoid breaking users expectations. I've recently made the adjustment in GNOME to have the GNOME keyring unlocked by default for the GNOME desktop, as that's what users expect. > +This service adds the @code{kwallet-pam} package to the system profile > +and extends PAM with entries using @code{pam_kwallet5.so}, > +unlocking a user's login keyring when they log in or setting its > +password with passwd. s/passwd/@command{passwd}/ > +@end defvar > + > +@deftp {Data Type} kwallet-configuration > +Configuration record for the KWallet Keyring service. > + > +@table @asis > +@item @code{keyring} (default: @code{kwallet-pam}) > +The KWallet keyring package to use. > + > +@item @code{pam-services} > +A list of @code{(@var{service} . @var{kind})} pairs denoting PAM > +services to extend, where @var{service} is the name of an existing > +service to extend and @var{kind} is one of @code{login} or > +@code{passwd}. Perhaps mention "is one of the @code{login} or @{passwd} symbols.". I gues the quote is on the alist so individual values should not be quoted, but just to avoid any ambiguity. > + > +If @code{login} is given, it adds an optional > +@code{pam_kwallet5.so} to the auth block without arguments and to > +the session block with @code{auto_start}. If @code{passwd} is given, it > +adds an optional @code{pam_kwallet5.so} to the password block > +without arguments. > + > +By default, this field contains ``sddm'' with the value @code{login} > +and ``passwd'' is with the value @code{passwd}. Does KDE not have its own graphical desktop manager? Perhaps it's not yet ready in Guix? [...] > +;;; > +;;; kwallet-service-type > +;;; nitpick: We conventionally add a '.' after these section names, as in: ;;; ;;; kwallet-service-type. ;;; > + > +(define-record-type* kwallet-configuration > + make-kwallet-configuration > + kwallet-configuration? > + (wallet kwallet-package (default kwallet-pam)) > + (pam-services kwallet-pam-services (default '(("sddm" . login) > + ("passwd" . passwd))))) > + > +(define (pam-kwallet config) Add add a brief docstring here saying this returns a PAM extension for KWallet. > + (match config > + (#f '()) ;explicitly disabled by user > + (_ > + (define (%pam-keyring-entry . arguments) > + (pam-entry > + (control "optional") > + (module (file-append (kwallet-package config) > + "/lib/security/pam_kwallet5.so")) > + (arguments arguments))) > + > + (list > + (pam-extension > + (transformer > + (lambda (service) > + (case (assoc-ref (kwallet-pam-services config) > + (pam-service-name service)) > + ((login) > + (pam-service > + (inherit service) > + (auth (append (pam-service-auth service) > + (list (%pam-keyring-entry)))) > + (session (append (pam-service-session service) > + (list (%pam-keyring-entry "auto_start")))= ))) > + ((passwd) > + (pam-service > + (inherit service) > + (password (append (pam-service-password service) > + (list (%pam-keyring-entry)))))) > + (else service))))))))) > + > +;; TODO: consider integrating service in `= ' as > +;; done in `'. This requires rewritting the > +;; `' as done for `'. Ah, I see my comment above is acknowledged here as a TODO. I'd encourage you to pursue that next! > +(define kwallet-service-type > + (service-type > + (name 'kwallet) > + (extensions (list > + (service-extension pam-root-service-type pam-kwallet))) > + (default-value (kwallet-configuration)) > + (description "Return a service, that extends PAM with entries using I'd drop the first comma. > +@code{pam_kwallet5.so}, unlocking a user's login keyring when they > log in or s/a user's/the user's/ > +setting its password with passwd."))) s/passwd/@command{passwd}/ Otherwise it LGTM. Could you please send a v2? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 03:24:17 2025 Received: (at 78188) by debbugs.gnu.org; 2 May 2025 07:24:17 +0000 Received: from localhost ([127.0.0.1]:56006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAkkq-0005Po-JE for submit@debbugs.gnu.org; Fri, 02 May 2025 03:24:17 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:44455) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAkko-0005PV-Bb for 78188@debbugs.gnu.org; Fri, 02 May 2025 03:24:15 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-39efc1365e4so705400f8f.1 for <78188@debbugs.gnu.org>; Fri, 02 May 2025 00:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746170648; x=1746775448; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=jqetzPRgLbrQAuqHaf41WPnM/CORvMq3G/hkMq+KUCI=; b=L2tSWjOgNcEuSDYBWbRoP/5EI8EVmdcVP5NCTlrZE6CuuPYA0zBsiZkE0lyc+by9mk FOHEo9FCgAqQT5NdYD8eIZTf/vWaG/MU1MWl3qZsPelA6GMV+lrY4VOkRTsCmYFfWNU+ J+Fl98L+4hv4b2QEjBw2mu/qbegGsZEN5M00/P/de4QiTyedbgvaAktXaPaIe9eewhma JU2ddK002NBzcU2kjwzxH72hT8sbuAnBAGg7R4zzrlR119onTs5/GQi0h8KBzlNBaSPR inFuRavREuwKx0LhpQm5xPKbRZB7Rvu3dqHMRv46gyuC/11X966bNnK4P3dK6EAFbW6v UcxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746170648; x=1746775448; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jqetzPRgLbrQAuqHaf41WPnM/CORvMq3G/hkMq+KUCI=; b=d+4sKXsAjLHFtnSqS1gJn1k0ThE41Fpa4GWnh4bW3VjfnyoZZIcvfm3h/t7Me6S/HZ rC4MmPNfXw2WEfHczWl1Gz12YCU7KBjEPEw5B0JjDK9gesuZNccwS6j4yMLtbaE//72s q/I3ndiBOG7jWKTMe+jd2GobfyMbS6fLmnnxIoYQbpUzKOAkcA5WVK6THl2ZTxMlj2Id kacZHt4T9O4079VdvTeLd4zEKaYDpGvCLBfo8R/ISNYPqQpY71p/3/9MLfhOEvBNGhVO uWVcmHm42O1Gj/G3WeBYKhggOvqT7XuMkLlN/Vh4OfhWAAEbJcveTMEDY3m3Anbok41H 5LmA== X-Gm-Message-State: AOJu0Yz6rv6i9IT2Kji9dVNnKMY4YEGiF/kCfUm1doBmSscoLbsCiN7t KiivrvV4saJHozzLTM00CSQMUWseJ4aC8vZuQWGyzPkU6VnxnS2l X-Gm-Gg: ASbGncuSQfwDW5TQwRpB2OBX/E4LAt1xZNyHOoZww0ySNYTBY3sIorm2eog3csBhkxK QXu0lrX3Znsh5uSWIe66W/ya5wOmaAI/2rZLToEkfvXYFhIi36pTRCe2Y2FPwZOYueKZBafHH6E nMFEoYBtw5LcI7wjdweRvNG4VMIJxdhkQRyU2kceqAzaC4eccFO3VuCCdFsjzDkLg3afryMGlOA VjTFK0GHt1S4gvY298Ty+k2qDDYD6F1nVF8Hxfv16MnCsuN0B4FZV5gxmJDIG2BHFnXwYt7hE4o s0sgysmqovLrkrMZf9700UAYS0aGyQGmGWahL2+8e0YYBVOELckcgA== X-Google-Smtp-Source: AGHT+IGSwUyD2gfAho9yx5yoLwSUSBuCB47FzbqKBR1nSfSCHyO1xIOK6dxQRQegt6BrIJVA7lSbWA== X-Received: by 2002:a05:6000:2ad:b0:39f:e3b:406b with SMTP id ffacd0b85a97d-3a099ad1c75mr1183488f8f.5.1746170647931; Fri, 02 May 2025 00:24:07 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b89cc387sm35756755e9.4.2025.05.02.00.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 00:24:07 -0700 (PDT) From: Sergio Pastor =?utf-8?Q?P=C3=A9rez?= To: Maxim Cournoyer Subject: Re: [bug#78188] [PATCH v2] services: kwallet: New service. In-Reply-To: <87wmaz6fxq.fsf@gmail.com> References: <1b8f1e2c24fb227d77a4617635842fb16db5d7f0.1746122107.git.sergio.pastorperez@gmail.com> <05d64ca757730e334021a4f68e65dc503acc7bb6.1746122107.git.sergio.pastorperez@gmail.com> <87wmaz6fxq.fsf@gmail.com> Date: Fri, 02 May 2025 09:24:06 +0200 Message-ID: <874iy3eaqx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: 78188@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , =?utf-8?Q?No=C3=A9?= Lopez , Liliana Marie Prikler , Vivien Kraus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxim Cournoyer writes: > Sergio Pastor P=C3=A9rez writes: >> +@defvar kwallet-service-type >> +This is the type of the service that adds the >> +@uref{https://invent.kde.org/plasma/kwallet-pam, KWallet keyring}. Its >> +value is a @code{kwallet-configuration} object (see below). Note that, >> +contrary to @code{gnome-desktop-service-type}, >> +@code{plasma-desktop-service-type} does not include this service. > > Does gnome-desktop-service-type include the kwallet-service-type? I > wouldn't think so. You probably meant to say it "doesn't include a > wallet service in its default configuration." ? Is this the normal > expectation for the KDE desktop? I'd assume it comes with kwallet > pre-configured, if using Fedora for example. If it does, we should > probably do so to avoid breaking users expectations. I've recently made > the adjustment in GNOME to have the GNOME keyring unlocked by default > for the GNOME desktop, as that's what users expect. I think I made a mistake with the wording. What I meant is that, while the `gnome-desktop-service-type' includes a keyring field which provides the functionality of `gnome-keyring-service-type' making it necessary for a `gnome-desktop-service-type' user to add a `gnome-keyring-service-type' entry to their service list; the `plasma-desktop-service-type' does not provide this functionality by default. Which contrary to what the user may expect, they will need to add the `kwallet-service-type' to their list of services even if they are users of the `plasma-desktop-service-type'. In the v2 of this patch series I've rewrote that bit to make it more clear. Let me know what you think. >> +;; TODO: consider integrating service in `' as >> +;; done in `'. This requires rewritting the >> +;; `' as done for `'. > > Ah, I see my comment above is acknowledged here as a TODO. I'd > encourage you to pursue that next! This will require a major refactor of the `plasma-desktop-service-type' as was done for the `gnome-desktop-service-type' to make it modular. Once we get this merged I will try to join the kde team to help with the refactor. > Otherwise it LGTM. Could you please send a v2? Sure, aside for the things I've mentioned I've also corrected all the typos you noticed. Thanks for the review! Best regards, Sergio. From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 03:50:43 2025 Received: (at 78188) by debbugs.gnu.org; 2 May 2025 07:50:43 +0000 Received: from localhost ([127.0.0.1]:56115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAlAR-0006xX-1a for submit@debbugs.gnu.org; Fri, 02 May 2025 03:50:43 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:42203) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAlAO-0006xG-Di for 78188@debbugs.gnu.org; Fri, 02 May 2025 03:50:41 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43d0359b1fcso10548255e9.0 for <78188@debbugs.gnu.org>; Fri, 02 May 2025 00:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746172234; x=1746777034; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dT8zzwB28EmUb1wKy9PQjyZzhsE/hXMdEViBMlG6mdU=; b=mvxDof+S/xktH8FLbDF+95TExb+MG77fuSCZ7NCDVtn0mk7WjtIIrPMEVi9S8RHH/i LVTehOYcxZpnXJYDLeFG9JKYhjR19Gk68adbyCG1oZ2e60AYEKc9PVhw2UjsFaBWrzZi wHvTEYSQvP8FCFcc8XeSzmfe6epJhmmayQN123/+CHLAyYhIM1FDsYlP8scwTDxE7/2O wijzDEa4uBeSV4m/YkRaaNkpkwlMWEv1MmMUgvYLbW0ZwsxA2eNFLqHOU7Z7DNCgPesN uUXZ7VJCKPTG0UC6U7tda9OAexcu+iy2g3k63yFFS75kToYlCRSArGJy0BJ/5FkAR2Ef C5hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746172234; x=1746777034; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dT8zzwB28EmUb1wKy9PQjyZzhsE/hXMdEViBMlG6mdU=; b=MGSDNhoPdaVisjfr9km9uxOPsu+RiA6gmhQYbdyhfuMiOcVIggTpp1CjuaYLYPPt/i hOnF9UKsEkvV2UZQGK30fwNl0zIbcAoYvG4mJavp2/nGxT6DMUITjSiHFiwQkr3BAzKh rufyw49sWXQW6ADZRxEyrpohYAmb0QmQxT+6rLk91kN9hTNpOUcfv2Hroz6Lwj2NVbYo A+8srwToSPeLnKHk/h1f5riwzoD0hScdQRuNTDPJ5LYwZ32O1qM/WYQovBRfLKYNHiwE N25xcrEaJcAz18pRYAbQf0V09oIoppnfNn7e0wIqKGvXto4Z8tqRRkz8I6xduhmVOqr7 D9kw== X-Gm-Message-State: AOJu0YzGLH2YH8dQeQmFMD6fXpmFuK/ia5aSkOGi1mgCmD8IFwW1wALE WD9ySU4twSyHEInkXsqlVhJyk9enAgim0NUTwLqYDf4f1yYNeNPhGC1Omqu2 X-Gm-Gg: ASbGncvcowwfg/r1Q4GlXdeAoIKdTXQQWo+cCLkc5dTGdIwHHuT9OcF3mKzBmwW60+V LLQWkjPEyhsXHaNE4zxRN/pOC0HaEEDsrn4w2qiTAcO9kvXYwdWMlpecCKnYVH0ztXYcDFsOs43 1q9aKR4UbdvgGeEit0g4mfQyaeJt+a9m5TtTQxQ5T3alnQvIglRZo7yyN7c0zaF0/yO/1dIrx4A P6FLyXzWULWqE4UDWJNSwmz79iSZyGoPrzvQZopjsqYIqzvtO6kv6fByg8Tg3RwdbeJAorP8SjL IciQH+eQ5tnAG2wevny13V2FE0l7jHwNB/AEb7uGBvQqbWTLMM6BAw== X-Google-Smtp-Source: AGHT+IGfgoLezmtsXqPF6zfE0OxM7k1hr3gEO/Wvi9ylELhcAawCYEDZxo2GCSIFWR/7J6vBnfM2ZA== X-Received: by 2002:a05:600c:820f:b0:43b:bfa7:c7d with SMTP id 5b1f17b1804b1-441b72b10dcmr44583855e9.2.1746172233630; Fri, 02 May 2025 00:50:33 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b89d1548sm35856145e9.11.2025.05.02.00.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 00:50:32 -0700 (PDT) From: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= To: 78188@debbugs.gnu.org Subject: [PATCH v3 1/2] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. Date: Fri, 2 May 2025 09:49:48 +0200 Message-ID: <18a91352e08ac5bf800a24f744dc8ed812fa34a0.1746172189.git.sergio.pastorperez@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Sergio Pastor Pérez , Z572 , Maxim Cournoyer , Sughosha , Zheng Junjie Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not setting PATH variable to access 'socat' input. Change-Id: I6e7a421af3dbbc844e319b7852246c89d979609c --- gnu/packages/kde-plasma.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm index 679a68cef6..efaae01aa9 100644 --- a/gnu/packages/kde-plasma.scm +++ b/gnu/packages/kde-plasma.scm @@ -1305,7 +1305,15 @@ (define-public kwallet-pam (arguments (list #:qtbase qtbase - #:tests? #f)) ;no tests + #:tests? #f ;no tests + #:phases + #~(modify-phases %standard-phases + (add-after 'install 'fix-socat-path + (lambda* (#:key inputs #:allow-other-keys) + (substitute* (string-append #$output + "/libexec/pam_kwallet_init") + (("socat") + (search-input-file inputs "bin/socat")))))))) (native-inputs (list extra-cmake-modules pkg-config)) (inputs (list linux-pam kwallet libgcrypt socat)) (synopsis "PAM Integration with KWallet") base-commit: 881d46eb386c2de8bc6f1405972ee1e115eeb3a1 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 03:50:53 2025 Received: (at 78188) by debbugs.gnu.org; 2 May 2025 07:50:53 +0000 Received: from localhost ([127.0.0.1]:56118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAlAa-0006xw-NP for submit@debbugs.gnu.org; Fri, 02 May 2025 03:50:53 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:53676) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAlAX-0006xf-P3 for 78188@debbugs.gnu.org; Fri, 02 May 2025 03:50:50 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so13052815e9.3 for <78188@debbugs.gnu.org>; Fri, 02 May 2025 00:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746172243; x=1746777043; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/XpohwHFoQFJUwuH3cH4hk4S0tZaszclH+58evV98LU=; b=IirKJPPZdzzqKwZjrTkgIhBUSNjY0YQp9bY3R7+1431Ko3mcx9OSBFHzGhbw0FETMj qq+JH3p3CMieK1mI51krLtvf/6jjBlCYLjZ9a6dQ/ooMgE6h1A/hNlJ2FnjjDQBvwXpL EqWR5xPel9nwpR1MPrWa7phcxStdSdhOhue32mV5YQB7ehcCfA0N3e8IHfismhvE4Enc eY0i3yuM62iKVV+x6bWVzyICRvqDVNPcvfemWYyXfqUQYPnWqmCIMkw2EJWqE4TTGMEc DWMcYxV4fKAUiAawPuE9dz1POLFm014Q+WHyz5wMj/WDyWu1H4HOesinPdjl8Zp3SxsS 8BRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746172243; x=1746777043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/XpohwHFoQFJUwuH3cH4hk4S0tZaszclH+58evV98LU=; b=m5DmvkV9EPsUZCYU+ZT4bJO/4U3JQ2eA/AJmP/c3C5fjjdYDyNYrXOJmNcprCqATri q5LeB0iK4vFHbRdPDS3UP/bcITYmqTlBxkt1kd7sTiTeo41wufb91yerDQjI3jv3+Ss/ emRCKsubvfYPLMAjkY5b76w0w69fAi5ZxtgRn1wOimjjOwtmjeIV6WTeL2jxo9JHy/m6 H2vOhabfOlMtBnTWfIx8QFn3J9duyfAW2jYD3bY7XB1e27KeU3DWlc9Xg9isE9cPvmqi 7ZnXl/SOiK5kXg8/D9dg4oAeDksy+bGuwEw5EhS/+wcIXF45G2zH/tdhoca/TNuqH3XU CS+g== X-Gm-Message-State: AOJu0YwbAgpWYrmx7pI7FoVJA1OCzsJ75W/rDXSsSPEc1KqJPYWwoRim dGgabv6hr64UgB5e5KXr5xQuoqjWQ4x7umvTmJCcEJADfMFDlhReOlIIv4v4 X-Gm-Gg: ASbGncsRBtACSVi+CEMlG8PRS/hiyiKxNRZemOHCqYVOrBYQTBuAvwubbfxMBQxXe4w Q/jFMChkVGuRpR5PHoQIuu3zKf8RWB7SNDF3jcBVzu1F6VT+ZhQseXuPlkJXSMuiU+TRiD4EiKq 5Fx3iYKWa80BveEOP0swZ/PNGPseeSz5wXBiPz8sOw/SNH7k/zM+Lw1EzoesezTjpwMo7vNpBw4 M9JAFsefKvWikg+BeAIIfIYoUo8dnwaf1L+J+6UkFKXg8SF/buN0wV4YzoFUpOnwNWTOp5t38BZ YiRITSi2IcHz35Izre8rxMIXBprzf/2tBVeViW8UerhOKqcw7QVCNg== X-Google-Smtp-Source: AGHT+IE98NFZCJvPgquNJZUK4wsPagL0Luint+0mMP8x8GiwDoaMQ9zRvxKfq8fXs5HvMONWuMf95Q== X-Received: by 2002:a05:600c:1da6:b0:43d:fa59:be39 with SMTP id 5b1f17b1804b1-441bbf38afemr12492225e9.33.1746172243159; Fri, 02 May 2025 00:50:43 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a09a7ad055sm613618f8f.11.2025.05.02.00.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 00:50:42 -0700 (PDT) From: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= To: 78188@debbugs.gnu.org Subject: [PATCH v3 2/2] services: kwallet: New service. Date: Fri, 2 May 2025 09:49:49 +0200 Message-ID: <1077ee8d351fbfd51679522ec7673db563a86f8b.1746172189.git.sergio.pastorperez@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <18a91352e08ac5bf800a24f744dc8ed812fa34a0.1746172189.git.sergio.pastorperez@gmail.com> References: <18a91352e08ac5bf800a24f744dc8ed812fa34a0.1746172189.git.sergio.pastorperez@gmail.com> MIME-Version: 1.0 X-Debbugs-Cc: Sergio Pastor Pérez , Z572 , Maxim Cournoyer , Liliana Marie Prikler , Ludovic Courtès , Noé Lopez , Vivien Kraus Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188 Cc: =?UTF-8?q?Sergio=20Pastor=20P=C3=A9rez?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Change-Id: I1330ce5e1648a8ddf6ddd507255a73335d6baa51 --- doc/guix.texi | 39 +++++++++++++++++++++++++ gnu/services/desktop.scm | 63 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 7b418a4089..0df428bb8d 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -27131,6 +27131,45 @@ Desktop Services @end table @end deftp +@defvar kwallet-service-type +This is the type of the service that adds the +@uref{https://invent.kde.org/plasma/kwallet-pam, KWallet keyring}. Its +value is a @code{kwallet-configuration} object (see below). Note that, +contrary to @code{gnome-desktop-service-type}, which includes the +respective keyring for that service, @code{gnome-keyring-service-type}, +@code{plasma-desktop-service-type} does not include +@code{kwallet-service-type}. + +This service adds the @code{kwallet-pam} package to the system profile +and extends PAM with entries using @code{pam_kwallet5.so}, unlocking a +user's login keyring when they log in or setting its password with +@command{passwd}. +@end defvar + +@deftp {Data Type} kwallet-configuration +Configuration record for the KWallet Keyring service. + +@table @asis +@item @code{keyring} (default: @code{kwallet-pam}) +The KWallet keyring package to use. + +@item @code{pam-services} +A list of @code{(@var{service} . @var{kind})} pairs denoting PAM +services to extend, where @var{service} is the name of an existing +service to extend and @var{kind} is one of @code{login} or @code{passwd} +symbols. + +If @code{login} is given, it adds an optional +@code{pam_kwallet5.so} to the auth block without arguments and to +the session block with @code{auto_start}. If @code{passwd} is given, it +adds an optional @code{pam_kwallet5.so} to the password block +without arguments. + +By default, this field contains ``sddm'' with the value @code{login} +and ``passwd'' is with the value @code{passwd}. +@end table +@end deftp + @defvar seatd-service-type @uref{https://sr.ht/~kennylevinsen/seatd/, seatd} is a minimal seat management daemon. diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index a586746cc5..2127c2d389 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -20,6 +20,7 @@ ;;; Copyright © 2024 45mg <45mg.writes@gmail.com> ;;; Copyright © 2024 Raven Hallsby ;;; Copyright © 2025 Jonathan Brielmaier +;;; Copyright © 2025 Sergio Pastor Pérez ;;; ;;; This file is part of GNU Guix. ;;; @@ -197,6 +198,10 @@ (define-module (gnu services desktop) gnome-keyring-configuration? gnome-keyring-service-type + kwallet-configuration + kwallet-configuration? + kwallet-service-type + seatd-configuration seatd-service-type @@ -2148,6 +2153,64 @@ (define enlightenment-desktop-service-type thumbnails and privileges the programs which enlightenment needs to function as expected."))) + +;;; +;;; kwallet-service-type. +;;; + +(define-record-type* kwallet-configuration + make-kwallet-configuration + kwallet-configuration? + (wallet kwallet-package (default kwallet-pam)) + (pam-services kwallet-pam-services (default '(("sddm" . login) + ("passwd" . passwd))))) + +(define (pam-kwallet config) + "Return a PAM extension for KWallet." + (match config + (#f '()) ;explicitly disabled by user + (_ + (define (%pam-keyring-entry . arguments) + (pam-entry + (control "optional") + (module (file-append (kwallet-package config) + "/lib/security/pam_kwallet5.so")) + (arguments arguments))) + + (list + (pam-extension + (transformer + (lambda (service) + (case (assoc-ref (kwallet-pam-services config) + (pam-service-name service)) + ((login) + (pam-service + (inherit service) + (auth (append (pam-service-auth service) + (list (%pam-keyring-entry)))) + (session (append (pam-service-session service) + (list (%pam-keyring-entry "auto_start")))))) + ((passwd) + (pam-service + (inherit service) + (password (append (pam-service-password service) + (list (%pam-keyring-entry)))))) + (else service))))))))) + +;; TODO: consider integrating service in `' as +;; done in `'. This requires rewritting the +;; `' as done for `'. +(define kwallet-service-type + (service-type + (name 'kwallet) + (extensions (list + (service-extension pam-root-service-type pam-kwallet))) + (default-value (kwallet-configuration)) + (description "Return a service that extends PAM with entries using +@code{pam_kwallet5.so}, unlocking the user's login keyring when they log in or +setting its password with @command{passwd}."))) + + ;;; ;;; KDE Plasma desktop service. ;;; -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 09:10:43 2025 Received: (at 78188-done) by debbugs.gnu.org; 2 May 2025 13:10:43 +0000 Received: from localhost ([127.0.0.1]:57408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAqA7-0001dJ-2J for submit@debbugs.gnu.org; Fri, 02 May 2025 09:10:43 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:46095) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAqA2-0001ct-0w for 78188-done@debbugs.gnu.org; Fri, 02 May 2025 09:10:39 -0400 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-739b3fe7ce8so1954750b3a.0 for <78188-done@debbugs.gnu.org>; Fri, 02 May 2025 06:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746191432; x=1746796232; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hsmSz/PmYWKmFW0sXizISB4OoePv6S25xt1zs3oV4W4=; b=Ejh2P1x2ZR6SmSqokIthjT/ruVpE37tN7zl/pGfPdlO/QbGnFznYJuUpwkK0T0Q2qW w7bFfzYtNpzhmrSiwtAukQPOm99ZwKTDNscl92oie1M9XJaoLNIlD7WVYRCKWuci8faq m231OB3MXocgl4jZ4QrRIbzwICX5LlC3ASJPVrWCzSobxJ9RxsP3RwpmCd++ZDbFpE0f su0vuLA4zmrvCDlDrkqKDPqi1H9FpZpYDt3nxOmnuOVlskWPV1HzhGIJKWYBObritleA NeggcwqkjcJrDYY83ivDgPlmI7EFMm0LhtEyQryiKpRCJ9Gp7lPxTKF87uK3vd9CPk/n 7UPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746191432; x=1746796232; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hsmSz/PmYWKmFW0sXizISB4OoePv6S25xt1zs3oV4W4=; b=DrAm9luhomanLia1H6FmrzAdCzJxynXjMzmyR2K41SUOuwYPE2AM9eyNtbBjQgu2ZM 8M/bqdiSzCEiuDRmVzfD3DQ+L+nYF0y85ne/bdHBP5N/ooHIMM1YmQny+HA0lpgTggjM ztiNmrIef9ht71dC+yyBSQBj/ZG/juuXX5sA+0xuKvPwnRkGTS2p/24KUT0S3U2d2r6A j35v8YQNb4f1cEq20+FfGLJcx6699roWMqIToSPVgdVflMqIvErkNRjTpRnB7R2hYgS8 8jdIud55g3rVEUdfxtY2+mK9AF9zp1FU8vzIGS2MefP/xynvLD89zSy8HgRFEvWkueYK z+xg== X-Gm-Message-State: AOJu0Yz+zZYK0TKJct3D+Elx4OFEyqJ7gPc17dzH76Q+m1nL60/WLtJb 5DLdrq6c8FruTTPcKnWQlwHGsgQfArIBteBYDoq/zVyfjeSGm7Z1 X-Gm-Gg: ASbGncsvCy7cjPtK05E3VHRJ9MxXTU9M40g54tQihOp5QeqPsf3F62pO3ghkeliFQ64 ZtausVZqgV3FCc+41UwWBbex3uR+rGZUtyJvkKCOoK/et5R31KRlBuU9k0eoNvqJWTjHhgjBI7q faDAuBYCSZxkpjkOX+p1KYL8gT4huv5qMUjWGtc2olvKl7O6ZTna/FEvPYa2Yk8sWX4pFhvnBUU Ck3qxCKq588cfa2WaqKrhIQ6zh+68omjOQJbULiwUHYGSl8420gQM1ttj03lkb7yyW/dxersiaM YtFqvnjO4ekzXxhPK96f47ywzDRtR0kkEQeRiPw= X-Google-Smtp-Source: AGHT+IFlr9U9qH2aRzaBxMjPrgStn4DSea/uR0q9LWt7s4Pjl7x/yrgQe/vcgclQ3c962cxKkyJ1TQ== X-Received: by 2002:a05:6a20:7d9e:b0:1f5:56fe:b437 with SMTP id adf61e73a8af0-20cdfcfc81amr4837314637.32.1746191431809; Fri, 02 May 2025 06:10:31 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7405909c883sm1449199b3a.165.2025.05.02.06.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 06:10:31 -0700 (PDT) From: Maxim Cournoyer To: Sergio Pastor =?utf-8?Q?P=C3=A9rez?= Subject: Re: [bug#78188] [PATCH v3 1/2] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. In-Reply-To: <18a91352e08ac5bf800a24f744dc8ed812fa34a0.1746172189.git.sergio.pastorperez@gmail.com> ("Sergio Pastor =?utf-8?Q?P=C3=A9rez=22's?= message of "Fri, 2 May 2025 09:49:48 +0200") References: <18a91352e08ac5bf800a24f744dc8ed812fa34a0.1746172189.git.sergio.pastorperez@gmail.com> Date: Fri, 02 May 2025 22:10:28 +0900 Message-ID: <87ecx740qj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188-done Cc: Z572 , 78188-done@debbugs.gnu.org, Sughosha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Sergio Pastor P=C3=A9rez writes: > * gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not set= ting > PATH variable to access 'socat' input. I've taken the liberty to rephrase this changelog and improve (hopefully!) the next commit's documentation text, and pushed, with the first commit being 284c5111db5. Thank you! --=20 Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 12:59:56 2025 Received: (at 78188-done) by debbugs.gnu.org; 2 May 2025 16:59:56 +0000 Received: from localhost ([127.0.0.1]:32854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAtjw-0006k9-5y for submit@debbugs.gnu.org; Fri, 02 May 2025 12:59:56 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:59881) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAtju-0006jj-6i for 78188-done@debbugs.gnu.org; Fri, 02 May 2025 12:59:54 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a064a3e143so942863f8f.3 for <78188-done@debbugs.gnu.org>; Fri, 02 May 2025 09:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746205187; x=1746809987; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8Cd2PjiYozlTpEtPhtnufEPB7HHub3CrPIJBbPaCZBw=; b=LMTsWWRsdtHQm85xukROM4GxfLkN+PIZRUQJMs79oXroOtWleaFTqaddUVenozoUu2 Qvx6bZ1azkEE3BGEjeRr8PosDOM+hpqUj+tJKts4y3bInaTqx8Lf6QMQep5V5kfE7KtX qbitktCHQfsqHSMNEFdUKGre7Cr5M+4K//qseBmWB1I9I2PaweQrM1/uxgpW2zIzJcfR 7JbTgZ3lvwvTCq7VvJcVDWY7B2aXKC/A0OEdA7O2wfN8GCCMPGqpAD02ETIIfmyaDl/n KTTSU2EZFd5ckd4cCFYpeL9NGeQVtMrLf2qweiQs0TMbNS9T6kAngyaYJmVEX91XrHii 1R9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746205187; x=1746809987; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Cd2PjiYozlTpEtPhtnufEPB7HHub3CrPIJBbPaCZBw=; b=YyMRyPgfkz+MsN8kRoUK9VEffuk7hzNrcrtWEMQQzkNUfijPb/JtRAObMTXMSRVm9B LrBNCGjHlpA9+CNrrffCNGw3JNWv8H/X2g+y4JhCS9G0aB2qUdLTuUTmLzBUaQKn1feQ z+izi5Pxr+LG0FJjDZtWNIlgjI7BDnEBwEwVyFRXOJrNHomLhgkkXFKT42mbqAMZEfMB xEvQPfCqa1i1781o5DmhTQngBXLcvS6xTEJRLHFuAa3LDG5ME04dKUA3zdNAhi/bsNuw Isv2yULuKXGZCGPS0J8P1JtRy9r8EvSza4VN8Ay5G3iPvMqhwrsXh0POmo0QvQMRjxkf rWeg== X-Gm-Message-State: AOJu0YznjobKeD5kOpLp70wsHJfOWYLVc2s/Wr3HVadhik068WGidrKB ML1hL1TbtzG+ZHcLFHeWOdxUkRVoYf4GNCgipHH3FhM0IjlPRmSw X-Gm-Gg: ASbGncvbzbxiy3Oviutl1LeHiwZhY5uHHeK+yIv+/n037pb6d0VV64CQC5cwHJSqCkr cYEAYsY3Xcimx4lP2EA/dVr9FjIefcBQUGXkFdhp8VuGgzM7cSOAd/M7KYWgmjMcRbGGC/HYnNQ WeQqWvx3lq4Cqf6Ajk4Dd7xgMtwzntNKd6HV8iXyMYsyVsLEKWIS6Sa3SD+cuK2B5+RgLjfBuk6 NrmBFhINvOmkNk6gCf+qlfbsUKEPItBkoegk+Gc5d5FU0TTYsCy5SawrXXfP/0T/S9REjz2BBcM 1cJqTEh41S4zMoZ4EoNQ8489aG6qBdU88Ad/qaFts8nG6RXxIhBDYw== X-Google-Smtp-Source: AGHT+IHq6Ul+TD7eztiwfGK4vBXoIg0X5a0TQPTYZRZkzr4N9JxDWqRYhduCXJsHjB+whUgx0sTvCQ== X-Received: by 2002:a5d:458e:0:b0:3a0:9c0f:e716 with SMTP id ffacd0b85a97d-3a09c0fe727mr704602f8f.3.1746205187482; Fri, 02 May 2025 09:59:47 -0700 (PDT) Received: from localhost ([2a0c:5a85:d206:4200:cd7d:99ee:cee8:cc4a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099ae3403sm2591424f8f.28.2025.05.02.09.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 09:59:46 -0700 (PDT) From: Sergio Pastor =?utf-8?Q?P=C3=A9rez?= To: Maxim Cournoyer Subject: Re: [bug#78188] [PATCH v3 1/2] gnu: kwallet-pam: Fix socat not in 'libexec/pam_kwallet_init' wrapper path. In-Reply-To: <87ecx740qj.fsf@gmail.com> References: <18a91352e08ac5bf800a24f744dc8ed812fa34a0.1746172189.git.sergio.pastorperez@gmail.com> <87ecx740qj.fsf@gmail.com> Date: Fri, 02 May 2025 18:59:45 +0200 Message-ID: <87a57v2bjy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78188-done Cc: Z572 , 78188-done@debbugs.gnu.org, Sughosha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxim Cournoyer writes: > Hi, > > Sergio Pastor P=C3=A9rez writes: > >> * gnu/packages/kde-plasma.scm (kwallet-pam)[phase]: Wrapper phase not se= tting >> PATH variable to access 'socat' input. > > I've taken the liberty to rephrase this changelog and improve > (hopefully!) the next commit's documentation text, and pushed, with the > first commit being 284c5111db5. > > Thank you! Thanks for merging it so quickly, I hope you have a good weekend! Best regards, Sergio. From unknown Sun Jun 15 08:31:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 31 May 2025 11:24:17 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator