GNU bug report logs - #78180
31.0.50; Since ab71699e5f2, global value of post-command-hook is useless

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ihor Radchenko <yantar92 <at> posteo.net>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 78180 <at> debbugs.gnu.org
Subject: bug#78180: 31.0.50; Since ab71699e5f2, global value of post-command-hook is useless
Date: Fri, 02 May 2025 09:04:22 +0300

> From: Ihor Radchenko <yantar92 <at> posteo.net>
> Cc: 78180 <at> debbugs.gnu.org
> Date: Thu, 01 May 2025 18:23:49 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > May I suggest that you first describe the actual problem you bumped
> > into?
> 
> The problem is rather simple - some of Org's tests make an assumption
> that the value of `post-command-hook' is its global value in Org
> buffers. It is no longer the case after ab71699e5f2.

Isn't that a wrong assumption?  A global minor mode can legitimately
invalidate it, right?

Stefan, am I missing something here?

> What else _might_ be a problem (but I am a bit lost in how things work
> here) is direct invocations of (run-hooks 'post-command-hook) from
> Elisp: in ert-x.el, gnus-msg.el, org-mouse.el. AFAIU, such calls will
> only execute buffer-local post-comman-hook, not global. Maybe I miss
> something.

See Michael's response, I think he answered this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.