GNU bug report logs - #78177
[PATCH] gnu: emacs-fzf: Update to 641aef3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 78177 in the body.
You can then email your comments to 78177 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: nlif-m <m.payunen <at> gumrfradio.ru>
To: guix-patches <at> gnu.org
Cc: nlif-m <m.payunen <at> gmail.com>
Subject: [PATCH] gnu: emacs-fzf: Update to 641aef3
Date: Thu,  1 May 2025 01:16:12 +0300

From: nlif-m <m.payunen <at> gmail.com>

Change-Id: I19ee1a7cfffa45e9d84b112f431cef18884949d8
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6d10fb7737..7c35b059a3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2220,30 +2220,32 @@ (define-public emacs-meyvn
       (license license:gpl3+))))
 
 (define-public emacs-fzf
-  (let ((commit "21912ebc7e1084aa88c9d8b7715e782a3978ed23")
+  (let ((commit "641aef33c88df3733f13d559bcb2acc548a4a0c3")
         (revision "0"))
     (package
       (name "emacs-fzf")
       (version (git-version "0.2" revision commit))
-      (source (origin
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://github.com/bling/fzf.el")
-                      (commit commit)))
-                (file-name (git-file-name name version))
-                (sha256
-                 (base32
-                  "0gdqjh8996hb06bnnyhi94k69mjfrzyfgq00a9s4wwagv28sqmkj"))))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/bling/fzf.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1nyvam5jg4gih0x2rvwr4jn97lyhaic3adpdxpdfx682ckj1k2vp"))))
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #f                     ;no tests
+        #:tests? #f ;no tests
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'patch-fzf-executable
               (lambda* (#:key inputs #:allow-other-keys)
                 (emacs-substitute-variables "fzf.el"
-                  ("fzf/executable" (search-input-file inputs "/bin/fzf"))))))))
+                                            ("fzf/executable" (search-input-file
+                                                               inputs
+                                                               "/bin/fzf"))))))))
       (inputs (list fzf))
       (home-page "https://github.com/bling/fzf.el")
       (synopsis "Emacs front-end for Fzf finder")
-- 
2.49.0

Message #8 received at 78177 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: m.payunen <at> gumrfradio.ru
Cc: m.payunen <at> gmail.com, 78177 <at> debbugs.gnu.org
Subject: Re: [bug#78177] [PATCH] gnu: emacs-fzf: Update to 641aef3
Date: Sat, 03 May 2025 10:11:10 +0200

[Message part 1 (text/plain, inline)]

As a rule, try to avoid unnecessary changes. All in all, your patch
modifies only two lines.

C.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 78177 <at> debbugs.gnu.org (full text, mbox):

From: <m.payunen <at> gumrfradio.ru>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78177 <at> debbugs.gnu.org
Subject: Re: [bug#78177] [PATCH] gnu: emacs-fzf: Update to 641aef3
Date: Sat, 3 May 2025 20:48:27 +0300

On Sat, 03 May 2025 10:11:10 +0200
Cayetano Santos <csantosb <at> inventati.org> wrote:

> As a rule, try to avoid unnecessary changes. All in all, your patch
> modifies only two lines.
> 
> C.

 	Yes, I understand, about the minimum of the changes, I just
 	followed 22.8 Packaging Guidelines, it was recommended to
 	launch the `guix style emacs-fzf`. 
	This is the first time I am sending a patch, so I
 have a question, on my part is something still required for the final
 merge into the main branch? Perhaps removing this excessive
 formatting? 

Message #14 received at 78177 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: <m.payunen <at> gumrfradio.ru>
Cc: 78177 <at> debbugs.gnu.org
Subject: Re: [bug#78177] [PATCH] gnu: emacs-fzf: Update to 641aef3
Date: Sat, 03 May 2025 20:22:50 +0200

[Message part 1 (text/plain, inline)]

>sam. 03 mai 2025 at 20:48, <m.payunen <at> gumrfradio.ru> wrote:

> On Sat, 03 May 2025 10:11:10 +0200
> Cayetano Santos <csantosb <at> inventati.org> wrote:
>
>> As a rule, try to avoid unnecessary changes. All in all, your patch
>> modifies only two lines.
>>
>> C.
>
>       Yes, I understand, about the minimum of the changes, I just
>       followed 22.8 Packaging Guidelines, it was recommended to
>       launch the `guix style emacs-fzf`.
>       This is the first time I am sending a patch, so I
>  have a question, on my part is something still required for the final
>  merge into the main branch? Perhaps removing this excessive
>  formatting?

You can send a v2 with the minimum changes.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 78177 <at> debbugs.gnu.org (full text, mbox):

From: nlif-m <m.payunen <at> gumrfradio.ru>
To: 78177 <at> debbugs.gnu.org
Cc: nlif-m <m.payunen <at> gumrfradio.ru>
Subject: [PATCH v2] gnu: update emacs-fzf to
 641aef33c88df3733f13d559bcb2acc548a4a0c3
Date: Sat,  3 May 2025 22:14:09 +0300

Change-Id: I184057e010f59275941cef67d3a5e658af47814c
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 18a139d997..24ef660b3d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2221,7 +2221,7 @@ (define-public emacs-meyvn
       (license license:gpl3+))))
 
 (define-public emacs-fzf
-  (let ((commit "21912ebc7e1084aa88c9d8b7715e782a3978ed23")
+  (let ((commit "641aef33c88df3733f13d559bcb2acc548a4a0c3")
         (revision "0"))
     (package
       (name "emacs-fzf")
@@ -2234,7 +2234,7 @@ (define-public emacs-fzf
                 (file-name (git-file-name name version))
                 (sha256
                  (base32
-                  "0gdqjh8996hb06bnnyhi94k69mjfrzyfgq00a9s4wwagv28sqmkj"))))
+                  "1nyvam5jg4gih0x2rvwr4jn97lyhaic3adpdxpdfx682ckj1k2vp"))))
       (build-system emacs-build-system)
       (arguments
        (list
-- 
2.49.0

Message #20 received at 78177 <at> debbugs.gnu.org (full text, mbox):

From: Матвей Паюнен
 <m.payunen <at> gumrfradio.ru>
To: csantosb <at> inventati.org
Cc: 78177 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: update emacs-fzf to 641aef33c88df3733f13d559bcb2acc548a4a0c3
Date: Sat, 03 May 2025 22:48:30 +0300

[Message part 1 (text/plain, inline)]

Make a new revision with minimal changes.

On May 3, 2025 22:14:09 GMT+03:00, nlif-m <m.payunen <at> gumrfradio.ru> wrote:
>Change-Id: I184057e010f59275941cef67d3a5e658af47814c
>---
> gnu/packages/emacs-xyz.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>index 18a139d997..24ef660b3d 100644
>--- a/gnu/packages/emacs-xyz.scm
>+++ b/gnu/packages/emacs-xyz.scm
>@@ -2221,7 +2221,7 @@ (define-public emacs-meyvn
>       (license license:gpl3+))))
> 
> (define-public emacs-fzf
>-  (let ((commit "21912ebc7e1084aa88c9d8b7715e782a3978ed23")
>+  (let ((commit "641aef33c88df3733f13d559bcb2acc548a4a0c3")
>         (revision "0"))
>     (package
>       (name "emacs-fzf")
>@@ -2234,7 +2234,7 @@ (define-public emacs-fzf
>                 (file-name (git-file-name name version))
>                 (sha256
>                  (base32
>-                  "0gdqjh8996hb06bnnyhi94k69mjfrzyfgq00a9s4wwagv28sqmkj"))))
>+                  "1nyvam5jg4gih0x2rvwr4jn97lyhaic3adpdxpdfx682ckj1k2vp"))))
>       (build-system emacs-build-system)
>       (arguments
>        (list
>-- 
>2.49.0
>

[Message part 2 (text/html, inline)]

Message #23 received at 78177 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Матвей Паюнен <m.payunen <at> gumrfradio.ru>
Cc: 78177 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: update emacs-fzf to
 641aef33c88df3733f13d559bcb2acc548a4a0c3
Date: Sun, 04 May 2025 10:03:35 +0200

[Message part 1 (text/plain, inline)]

>sam. 03 mai 2025 at 22:48, Матвей Паюнен <m.payunen <at> gumrfradio.ru> wrote:

> Make a new revision with minimal changes.

Thank you !

Don’t forget to increase the revision number, and review your commit
message. You may have a look to similar changes in the guix git log.

C.

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 78177 <at> debbugs.gnu.org (full text, mbox):

From: nlif-m <m.payunen <at> gumrfradio.ru>
To: csantosb <at> inventati.org
Cc: nlif-m <m.payunen <at> gumrfradio.ru>, 78177 <at> debbugs.gnu.org
Subject: [PATCH v3] gnu: emacs-fzf: Update to 0.2-0.641aef3
Date: Thu,  8 May 2025 12:07:21 +0300

* gnu/packages/emacs-xyz.scm (emacs-fzf): Update to 0.2-0.641aef3

Change-Id: I184057e010f59275941cef67d3a5e658af47814c
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 50a6f4c386..d64fe583d7 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2221,7 +2221,7 @@ (define-public emacs-meyvn
       (license license:gpl3+))))
 
 (define-public emacs-fzf
-  (let ((commit "21912ebc7e1084aa88c9d8b7715e782a3978ed23")
+  (let ((commit "641aef33c88df3733f13d559bcb2acc548a4a0c3")
         (revision "0"))
     (package
       (name "emacs-fzf")
@@ -2234,7 +2234,7 @@ (define-public emacs-fzf
                 (file-name (git-file-name name version))
                 (sha256
                  (base32
-                  "0gdqjh8996hb06bnnyhi94k69mjfrzyfgq00a9s4wwagv28sqmkj"))))
+                  "1nyvam5jg4gih0x2rvwr4jn97lyhaic3adpdxpdfx682ckj1k2vp"))))
       (build-system emacs-build-system)
       (arguments
        (list
-- 
2.49.0

Message #31 received at 78177-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 78177-done <at> debbugs.gnu.org
Subject: Close
Date: Thu, 8 May 2025 21:27:59 +0200

Close.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.