GNU bug report logs - #78167
[PATCH] 31.0.50; bash-ts-mode does not fontify varibles used consistently

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Subject: bug#78167: closed (Re: bug#78167: [PATCH] 31.0.50; bash-ts-mode
 does not fontify varibles used consistently)
Date: Sat, 10 May 2025 10:24:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#78167: [PATCH] 31.0.50; bash-ts-mode does not fontify varibles used consistently

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 78167 <at> debbugs.gnu.org.

-- 
78167: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78167
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 78167-done <at> debbugs.gnu.org
Subject: Re: bug#78167: [PATCH] 31.0.50;
 bash-ts-mode does not fontify varibles used consistently
Date: Sat, 10 May 2025 13:23:21 +0300

> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> Date: Wed, 30 Apr 2025 22:43:59 +0200
> 
> Hey everyone.
> 
> When writing bash-scripts one often refers to variables in lots of different syntax variants, like the ones below:
> 
>     echo "${var}"
>     echo "$var"
>     echo ${var}
>     echo $var
> 
> Using bash-ts-mode in Emacs these are all presented inconsistently:
> 
> * as string
> * as variable-declaration
> * as variable-use
> 
> This is due to missing or incorrectly configured selectors in sh-script.el.
> 
> Attached is a patch which makes them consistely fontified as font-lock-variable-use-face and use font-lock-bracket-face for the enclosing brackets.

Thanks, installed on the master branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 31.0.50; bash-ts-mode does not fontify varibles used
 consistently
Date: Wed, 30 Apr 2025 22:43:59 +0200

[Message part 4 (text/plain, inline)]

Hey everyone.

When writing bash-scripts one often refers to variables in lots of different syntax variants, like the ones below:

    echo "${var}"
    echo "$var"
    echo ${var}
    echo $var

Using bash-ts-mode in Emacs these are all presented inconsistently:

* as string
* as variable-declaration
* as variable-use

This is due to missing or incorrectly configured selectors in sh-script.el.

Attached is a patch which makes them consistely fontified as font-lock-variable-use-face and use font-lock-bracket-face for the enclosing brackets.

Cheers!

—
Kind Regards
Jostein Kjønigsen



[Message part 5 (text/html, inline)]

[0001-sh-script.el-Improve-consistency-in-variable-use-fon.patch (application/octet-stream, attachment)]

[Message part 7 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.