Subject: bug#78167: closed (Re: bug#78167: [PATCH] 31.0.50; bash-ts-mode does not fontify varibles used consistently)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 10 May 2025 10:24:02 +0000

Your bug report

#78167: [PATCH] 31.0.50; bash-ts-mode does not fontify varibles used consistently

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
78167: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78167
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#78167: [PATCH] 31.0.50; bash-ts-mode does not fontify varibles used consistently
From: Eli Zaretskii <[email-masked]>
To: Jostein Kjønigsen <[email-masked]>
Cc: [email-masked]
Date: Sat, 10 May 2025 13:23:21 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Jostein Kjønigsen <[email-masked]>
> Date: Wed, 30 Apr 2025 22:43:59 +0200
> 
> Hey everyone.
> 
> When writing bash-scripts one often refers to variables in lots of different syntax variants, like the ones below:
> 
>     echo "${var}"
>     echo "$var"
>     echo ${var}
>     echo $var
> 
> Using bash-ts-mode in Emacs these are all presented inconsistently:
> 
> * as string
> * as variable-declaration
> * as variable-use
> 
> This is due to missing or incorrectly configured selectors in sh-script.el.
> 
> Attached is a patch which makes them consistely fontified as font-lock-variable-use-face and use font-lock-bracket-face for the enclosing brackets.

Thanks, installed on the master branch, and closing the bug.

Subject: [PATCH] 31.0.50; bash-ts-mode does not fontify varibles used consistently
From: Jostein Kjønigsen <[email-masked]>
To: [email-masked]
Date: Wed, 30 Apr 2025 22:43:59 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hey everyone.

When writing bash-scripts one often refers to variables in lots of different syntax variants, like the ones below:

    echo "${var}"
    echo "$var"
    echo ${var}
    echo $var

Using bash-ts-mode in Emacs these are all presented inconsistently:

* as string
* as variable-declaration
* as variable-use

This is due to missing or incorrectly configured selectors in sh-script.el.

Attached is a patch which makes them consistely fontified as font-lock-variable-use-face and use font-lock-bracket-face for the enclosing brackets.

Cheers!

—
Kind Regards
Jostein Kjønigsen

￼