From unknown Sat Jun 21 05:15:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78166: 30.1; describe-input-method does not respect help-window-select Resent-From: Sean Devlin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Apr 2025 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 78166@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174604501818976 (code B ref -1); Wed, 30 Apr 2025 20:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2025 20:30:18 +0000 Received: from localhost ([127.0.0.1]:45861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAE4M-0004uk-2R for submit@debbugs.gnu.org; Wed, 30 Apr 2025 16:30:17 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54654) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAE4G-0004sD-BO for submit@debbugs.gnu.org; Wed, 30 Apr 2025 16:30:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAE4A-0001iI-K5 for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2025 16:30:02 -0400 Received: from mail-qv1-xf29.google.com ([2607:f8b0:4864:20::f29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uAE46-0004Kp-0L for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2025 16:30:02 -0400 Received: by mail-qv1-xf29.google.com with SMTP id 6a1803df08f44-6e8fb83e137so3624626d6.0 for ; Wed, 30 Apr 2025 13:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1746044995; x=1746649795; darn=gnu.org; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=btIEd2fnpANMqOaEFO38MoPS17v4c2XCq9QZypgGrZQ=; b=KYNUe0XKHTnxaWq4mshEmjtlnzGCk5wq3lAH3kldRExTEem6wuJQZAqt8cU2yHmDTV NLnt8vnt1dGmZBMfkTBPdluPGEI1itCd8v5qqTWcuuXh2aA3oLHgM+Y7PCZSqqqEYIZg 6zGLAo06rThG3uqPEfEzvWy9ktjoQlcAbcwiIarQKl6iDv9pjEKfaoHr5tUPNeuXqFDp c+ClkQ6mZfBzuzM2Yf1AuDplhQSGfrAMdrytVIc3Gf0jnohNYaAJrqc/0lvy+zX95L8f /VeMzVbnUU67HZr2cM+4z3IVLJwj0fsdgHRrrxGWH2EVCdMIZqIdreBJYFkIEojrq+/m jTSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746044995; x=1746649795; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=btIEd2fnpANMqOaEFO38MoPS17v4c2XCq9QZypgGrZQ=; b=cJuuTuPmIcdoGxPLdlm67HKWXje1URPBdB1flE1CWuQt53iVEvcP9YQRoq/NwM/0Vp x0exaEwV6FAZLKlgKBQ74kA9Awrpgp2KKxHvbveV2K5PQbtGSIr1tSAZ1HAXIFOdOu78 kYLKPUitC6cONFdNCUFdYhsJjOXxYGWg6vkl8v3f5QiZxzJBIRJhvGZ6JXZPxay/U/bn mibwQmodIsc6zRJb3vo0SyqC/sa0ETqHX3iy2O1wgHy6cx+V+UbZ+DxqZyqmL3Z4gYiB f0ZDx5Em0r3jEMj45PolwTjVIz1CO7eC2dyNy3DiYTFuQg6ztuyWr6ieDbMR0v7MvX3p aQUA== X-Gm-Message-State: AOJu0YwrllZ2RBRxzDbLD+hDaLl0DWh0V/5FMia0wVLtpqfMxvOdlEck RdfBlVjLzsZfU9h1etSyhuYxDn6rJhEPCqq7gps+ffV3ZDQotZ09Ym59qULOdkU0r3dKL/k9b53 W X-Gm-Gg: ASbGncvdwqsPcBBSPABwEVUP+K/8XTytPpl8KzrmywD0QmrmfqNP8YLOdNWCTUSy3Nl 579bsKqQHhnATcXMzDwUZrRQADORU78rMWPUzwCEOKto/7iLIK7cdGgB+Z+yY7TN92C87iGJzU4 0oPupMRfV+MwVaG4pwBydUbYzyTkmESHoqaChA95llgWcyDAH1/ZmkijdK+XRHgEBqUyba+cglD RkeWVGBFkJhLsGdEpUvdwwkxHui9mLxdHmhynHlymYGVr+hJeSFYiIOCObqnkomrNOCXEDocNC8 wJFoBwGnOKv4AfpeV4dXT9+GHGMVdUjg3NXi/2dQYziI6OKWAgems4s3SDE= X-Google-Smtp-Source: AGHT+IHQwXNOe9E25kmAzYnT5RDvUZhAEYsMVWQEqJM+AViiZCSpSqofYPn71YobrvqiJxeNSgF18g== X-Received: by 2002:a05:6214:20ca:b0:6f4:cbcf:5cea with SMTP id 6a1803df08f44-6f5091faad9mr10361216d6.44.1746044993270; Wed, 30 Apr 2025 13:29:53 -0700 (PDT) Received: from smtpclient.apple ([70.107.172.48]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f4fe85d2fdsm12254576d6.97.2025.04.30.13.29.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Apr 2025 13:29:52 -0700 (PDT) From: Sean Devlin Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Message-Id: Date: Wed, 30 Apr 2025 16:29:42 -0400 X-Mailer: Apple Mail (2.3826.600.51.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::f29; envelope-from=spd@toadstyle.org; helo=mail-qv1-xf29.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi folks, It seems that describe-input-method does not respect help-window-select. Here is a recipe: 1. Emacs -Q 2. Evaluate: (setq help-window-select t) 3. C-h I japanese RET Observe that the help window is not selected. In contrast, if you do C-h v help-window-select RET, the help window is selected. Thanks! In GNU Emacs 30.1 (build 1, aarch64-apple-darwin21.6.0, NS appkit-2113.65 Version 12.7.6 (Build 21H1320)) of 2025-02-24 built on armbob.lan Windowing system distributor 'Apple', version 10.3.2575 System Description: macOS 15.5 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules 'CFLAGS=-DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' --with-x-toolkit=no' Configured features: ACL GLIB GMP GNUTLS JPEG LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils pp cl-print byte-opt gv bytecomp byte-compile thingatpt cl-extra help-fns radix-tree japan-util kkc ja-dic-utl quail help-mode cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 63336 10444) (symbols 48 6466 0) (strings 32 19628 2196) (string-bytes 1 470258) (vectors 16 12702) (vector-slots 8 170578 7344) (floats 8 27 2) (intervals 56 267 20) (buffers 992 14)) From unknown Sat Jun 21 05:15:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78166: 30.1; describe-input-method does not respect help-window-select References: In-Reply-To: Resent-From: Sean Devlin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Apr 2025 21:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 78166@debbugs.gnu.org Received: via spool by 78166-submit@debbugs.gnu.org id=B78166.174604689125904 (code B ref 78166); Wed, 30 Apr 2025 21:02:01 +0000 Received: (at 78166) by debbugs.gnu.org; 30 Apr 2025 21:01:31 +0000 Received: from localhost ([127.0.0.1]:45984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAEYc-0006jk-VA for submit@debbugs.gnu.org; Wed, 30 Apr 2025 17:01:31 -0400 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]:49481) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAEYa-0006jS-JP for 78166@debbugs.gnu.org; Wed, 30 Apr 2025 17:01:29 -0400 Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-4811fca8658so3806471cf.3 for <78166@debbugs.gnu.org>; Wed, 30 Apr 2025 14:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1746046882; x=1746651682; darn=debbugs.gnu.org; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=5/Vg40Luum11yNMSqh2q6Ei3G43Ef0AuzjR8WBLDYp0=; b=ExRIQHVLdkeOkAwu/CxV1wqPPRXg3vHZHEoK9efT8/eLYRlnTxpv0t3hBZj4d2DTVD RB8csRnL2rbYw0ypxJ+Nw5v8Q04tYlEZXsu8ne1itS/7jwiKhfQA+oNA+7RBsIK8Ra8T dpCb0N61x1kpMYoz5aVfIXD8eP4PUdgZWoH8pWbbzkYNNAtioQKvFYxJq1KVPBigh2eM qXpkSJxDSysBTanIvKNXZaJEci3Gz+AzJpuzYhvvbr5M0NSBKCSQH8oZtLpxz7she2ei YNPH/774jv6Jz7cUzwyNa+L9EqetM4M2SKL9pL1ee5jPEQstBRmVPu7j7fZGLtsbalFf mugA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746046882; x=1746651682; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5/Vg40Luum11yNMSqh2q6Ei3G43Ef0AuzjR8WBLDYp0=; b=lUzCotZSD67righDEAtas0F7Ckj6p1wfjBdNEVF/JRJgkeBM0L66JiuBHMxpxG5XEB kBmoDeBvBHKRJ2vt+shah3sL02TEgmcddYMtLIrspDCqr1n++VbNDnv3fRL0N9Ra0hV9 C2bC4iqSldy2WIEdF+KfpFIJQL25zqRBp4s87wF6iiOS4reqyER6vgljh2QD2sDwNAM+ GkFfTMFU6MQE5qytLcAY4CB6pF2UJIvf1UOYylLas1QwW7lXtj6DOveR3bKlbUyiuegl bBU0e0Cl/T9DcTN+Fe2vykdBM90lUQlxsU1VVJqprN6SAEYQ1q8OhQKL6Ylb5D65q9Xr 7yiA== X-Gm-Message-State: AOJu0YzNbf2SamXGnTfFXrcMxVIsQDdzOcwYGBCRyNrHEqvfWegqShsU wfMAMglOCkGW3rJ9gVnX4QLnriFyodTg91Xi4dCCiyUvAlPgVrlYGTK8ZEtkxI7DYW9l59YIywp x X-Gm-Gg: ASbGncsDY0VWXjjMRx0p/TLTfKHPD7zywnYeoB2jxASwKUE8RjTLjF3+1yWgcPR7B7n IUtiD04Fji++xBYEhYb74rqBUX33qBJzBKGzW0rEgx7tu4ARmrI1GFbdKcraGDtg/dVKP5HLRjr MJLvRIhi9VrBkPzri3awoXJuW0uc3iIRVH/jB4CGK97iUY6KyvGtwyRqWDOh+RAPt+d6Je/YiOo 4vRd0d3K1uiYMmYRcHys7IS3p9tUnqMZEa76Ak9eAVVAzGcNc5TWgdS0lWvbLLyUIPp3n1k2VEE pVrD+MJFjoHXSgoN8kEhr9ykD5+5bgaLSVoWRDM1xpyZFmLlga6PcT1OwhM= X-Google-Smtp-Source: AGHT+IGwwbDGB2lP1tAQ2FtjI4oOD1Z2/EX7LRX6e6gKjE2Ohnjz+2h2giqwqcIlLoTODtQcWjmySw== X-Received: by 2002:a05:622a:4c15:b0:476:7e6b:d297 with SMTP id d75a77b69052e-48ae90ac88cmr12234691cf.41.1746046882332; Wed, 30 Apr 2025 14:01:22 -0700 (PDT) Received: from smtpclient.apple ([70.107.172.48]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-48b03c8ebffsm813511cf.0.2025.04.30.14.01.21 for <78166@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Apr 2025 14:01:22 -0700 (PDT) From: Sean Devlin Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Message-Id: <13300DAE-8F83-4E50-B52A-3E4974C03CF2@toadstyle.org> Date: Wed, 30 Apr 2025 17:01:11 -0400 X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I see now that the documentation for help-window-select says: This option has effect if and only if the help window was created by =E2=80=98with-help-window=E2=80=99. So maybe this is not a bug per se. Should we improve quail-help to use with-help-window? Thanks!= From unknown Sat Jun 21 05:15:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78166: 30.1; describe-input-method does not respect help-window-select Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 May 2025 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Devlin Cc: 78166@debbugs.gnu.org Received: via spool by 78166-submit@debbugs.gnu.org id=B78166.17461215264243 (code B ref 78166); Thu, 01 May 2025 17:46:02 +0000 Received: (at 78166) by debbugs.gnu.org; 1 May 2025 17:45:26 +0000 Received: from localhost ([127.0.0.1]:52961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAXyQ-00016N-3a for submit@debbugs.gnu.org; Thu, 01 May 2025 13:45:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35984) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAXyM-000161-CA for 78166@debbugs.gnu.org; Thu, 01 May 2025 13:45:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAXyF-0006gu-DJ; Thu, 01 May 2025 13:45:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2b6dTAljCKF+3OKDuELZ4lHqcbE4CR3QytoaqQPMsgs=; b=Ec5AZtxSBCddmY8rbUbS uGGbvuS+TXU/BCqXG+dN+c2POhemnVxoBExZY9ItInH2i6cXArNB0EFhygMkFDhlOwlLr7JxDb5Ml BHH5c2GcQyEx/Ey3YFkn9VajfaiMKJMC+DgOWALL2LL2jYw1NS1097xgGNf9MSx3JXxLXuseigQyL OZ8sgF7hwMsRMjVqJvUrV9STvUVi92eR725c0MWeL5NBn+ZVqOn5lUu+p+zbdT1WDbKX2D9yivcu0 WIHkRUlQwoVAHCYVG7jEaOrBcXwjZrhVbpEJPOS5ors7jTlnK7RB9WQI3flTOFb7w33AM+Aa7jkqB ORv103QButsN3g==; Date: Thu, 01 May 2025 20:45:14 +0300 Message-Id: <86h624mdhx.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <13300DAE-8F83-4E50-B52A-3E4974C03CF2@toadstyle.org> (message from Sean Devlin on Wed, 30 Apr 2025 17:01:11 -0400) References: <13300DAE-8F83-4E50-B52A-3E4974C03CF2@toadstyle.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Devlin > Date: Wed, 30 Apr 2025 17:01:11 -0400 > > I see now that the documentation for help-window-select says: > > This option has effect if and only if the help window was created > by ‘with-help-window’. > > So maybe this is not a bug per se. > > Should we improve quail-help to use with-help-window? Yes, if we want it to heed help-window-select, we should. Patches welcome. But please be careful and test the changes thoroughly: AFAIR input-method help has several features thyat we would not like to lose. Thanks. From unknown Sat Jun 21 05:15:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78166: 30.1; describe-input-method does not respect help-window-select Resent-From: Sean Devlin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 May 2025 01:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 78166@debbugs.gnu.org Received: via spool by 78166-submit@debbugs.gnu.org id=B78166.174615075316022 (code B ref 78166); Fri, 02 May 2025 01:53:02 +0000 Received: (at 78166) by debbugs.gnu.org; 2 May 2025 01:52:33 +0000 Received: from localhost ([127.0.0.1]:54720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAfZp-0004AK-9a for submit@debbugs.gnu.org; Thu, 01 May 2025 21:52:33 -0400 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:43454) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAfZm-0004A3-Te for 78166@debbugs.gnu.org; Thu, 01 May 2025 21:52:31 -0400 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-7c54f67db99so328385685a.1 for <78166@debbugs.gnu.org>; Thu, 01 May 2025 18:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1746150745; x=1746755545; darn=debbugs.gnu.org; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=fXaC+klwrAvCkSeIvP67S22cWdFqZOM5Wz1Y9+9+5d0=; b=3NEk3CAuENOkR63dXDv5CvmxtjC9IEoQTk8OdrDD/JTNRA1Is+b/uTp8NwfLWsA4tP BFsDUzE7dvTGvY8XYF+nDZIeUjDRTQyCCocl5Rwe6QcIpuB/EaPpdDAGOf2UINAJlKFN sQKnMxua6AbgNeck5Zc0AlnWKmLxa/7KuZIfHnRZSbvMi5hqsyLZG/uLBxFKXVXaksJL R9UblKIP6h5iB2iQtWQEQIUhv4KQRw5cLHstaj5vzCRRHhkgn4GQZtYwt0IyOdp1y8W2 YkFGq5saqTkqhSY0aZcnt9eedKjhmsWpzG/r6hsCtJGZvSbxzbRCDuUKCrU7jVlAQVuC UmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746150745; x=1746755545; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fXaC+klwrAvCkSeIvP67S22cWdFqZOM5Wz1Y9+9+5d0=; b=tCHJtbCE1X1QOIYj4awHh2QmHjCMynKQlOxjO8qwPdhxWxq/AWMCiAwge2kX7lUOVo xmY1KF9kVganMYYk5cEBaaaXsgQWzwd3s8jwXPJi0Buhs42UahbUBLcQAx74XlNv4Z0T rOi3uKoYWx8HGeC4wimFhrCikiUAc3FJpUibSsK4m1oQ7IDoh8mm4ChD32jp6JOYcC8P pXanYEXeR4KgXsyvdisKap4yDFPMkRWK9CvWNKKciYImaIvfICogT/QtoxIsQuqfAgCm K+n4apAfMAinHvDRN5/ZFpCoUA+volzOBpXRsFLSdB4y7gSEnce0/KuHjYmTr/V02IzB 036g== X-Gm-Message-State: AOJu0Yww7uCjEvoDsGu1yHhRqAupE68W55xoFO2wk3cdg7xLqskxdGmx SOO7QwgGsMOrm8XoKol+uaxjlGKrPY/AX7Hd+MNy91DEXW8R8nXkVTh+AIQSP6E= X-Gm-Gg: ASbGncv5r0tNGV0hZVVjAhGMG3Uv2Cza7Hh/OvcriBcMpTOHytKB2lxvX4bdeMc4imO e6s07va2WITIeOrJyGCRH1cFi4XLE1DlSKS8K7sjdLSNihWMQBgAZRY9SKKfizWy/LdsCp+NY8/ R70cXGxq86O8NMBv/JwqWtrw/b8x8NNb0nRnpHN1HQY8QM307Khlu2tsieBaNGPwxVPcnDqsSnx dQa3pTZULrF9q1hyK2AurrF78vdg1K3zJY63oa4OqqnAezgC+phK1pgDsgRv+TGrRz/NObSKlcz DWB7piq+1cMFehp/ULRD13auicXM2WGMt6BH6gmhBw70RmEdeEHY4g== X-Google-Smtp-Source: AGHT+IFSjppy6zzOjyBLjoRPqMjvdCobxw42O+MUhNHmtsNZaMCxQ7NBH3x31067hKu31hl2CoYWdw== X-Received: by 2002:a05:6214:5004:b0:6ea:eeb6:c82b with SMTP id 6a1803df08f44-6f50b1e3405mr82118716d6.2.1746150744971; Thu, 01 May 2025 18:52:24 -0700 (PDT) Received: from smtpclient.apple ([70.107.172.48]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f50f3b0556sm12589876d6.17.2025.05.01.18.52.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 May 2025 18:52:24 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Sean Devlin Mime-Version: 1.0 (1.0) Date: Thu, 1 May 2025 21:52:14 -0400 Message-Id: References: <86h624mdhx.fsf@gnu.org> In-Reply-To: <86h624mdhx.fsf@gnu.org> X-Mailer: iPhone Mail (22F5068a) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On May 1, 2025, at 1:45=E2=80=AFPM, Eli Zaretskii wrote: >=20 > =EF=BB=BF >>=20 >> From: Sean Devlin >> Date: Wed, 30 Apr 2025 17:01:11 -0400 >>=20 >> I see now that the documentation for help-window-select says: >>=20 >> This option has effect if and only if the help window was created >> by =E2=80=98with-help-window=E2=80=99. >>=20 >> So maybe this is not a bug per se. >>=20 >> Should we improve quail-help to use with-help-window? >=20 > Yes, if we want it to heed help-window-select, we should. >=20 > Patches welcome. But please be careful and test the changes > thoroughly: AFAIR input-method help has several features thyat we > would not like to lose. Sounds good. I will give it a try. I=E2=80=99ll mail back here if I run into= problems. Thanks! >=20 > Thanks. From unknown Sat Jun 21 05:15:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78166: 30.1; describe-input-method does not respect help-window-select Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 May 2025 08:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Devlin Cc: 78166@debbugs.gnu.org Received: via spool by 78166-submit@debbugs.gnu.org id=B78166.174746900714258 (code B ref 78166); Sat, 17 May 2025 08:04:01 +0000 Received: (at 78166) by debbugs.gnu.org; 17 May 2025 08:03:27 +0000 Received: from localhost ([127.0.0.1]:45109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uGCVy-0003ht-NW for submit@debbugs.gnu.org; Sat, 17 May 2025 04:03:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54004) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uGCVw-0003hY-BP for 78166@debbugs.gnu.org; Sat, 17 May 2025 04:03:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uGCVq-0006XK-Na; Sat, 17 May 2025 04:03:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GadLG/FzpxHU7GnF0jamnR4ki628XscHtsduYaCZxe0=; b=cJ5TEDOmZ7YisZriA2Gl f7YDbqGWc5qZ+nM/pRb6qdkW0a4PgFUvuWioPMWOx00UW1SSbAohHnA7cNJprxTEWEWNvcTXbrngb 21A88qzQxOO92+emXyeqGet1k7pE3CdSeP/KuKA5EbS0Z5DzFrDAOnZTRfuOVloU0MU+FnSdrwH65 D1BpAfm9KJxckr0cecfWdlDW/Ui71Nc+vcTW9pWaD3CqHDnIlQJ5k6lEZCSG0JuGFZNuHPPy5KTgy SfazYfos21pc6KREN8/PhqZDxw9aWwyId/7LayM3oeEDQoQ5vV1sXdyd7GDAH6LNzst8rPjwf1U2T wYGVWWqWebxn1w==; Date: Sat, 17 May 2025 11:03:16 +0300 Message-Id: <86sel3wtob.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Sean Devlin on Thu, 1 May 2025 21:52:14 -0400) References: <86h624mdhx.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Devlin > Date: Thu, 1 May 2025 21:52:14 -0400 > Cc: 78166@debbugs.gnu.org > > > > > On May 1, 2025, at 1:45 PM, Eli Zaretskii wrote: > > > >  > >> > >> From: Sean Devlin > >> Date: Wed, 30 Apr 2025 17:01:11 -0400 > >> > >> I see now that the documentation for help-window-select says: > >> > >> This option has effect if and only if the help window was created > >> by ‘with-help-window’. > >> > >> So maybe this is not a bug per se. > >> > >> Should we improve quail-help to use with-help-window? > > > > Yes, if we want it to heed help-window-select, we should. > > > > Patches welcome. But please be careful and test the changes > > thoroughly: AFAIR input-method help has several features thyat we > > would not like to lose. > > Sounds good. I will give it a try. I’ll mail back here if I run into problems. Did you have an opportunity to make some progress with this issue? From unknown Sat Jun 21 05:15:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78166: 30.1; describe-input-method does not respect help-window-select Resent-From: Sean Devlin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 May 2025 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 78166@debbugs.gnu.org Received: via spool by 78166-submit@debbugs.gnu.org id=B78166.17476728812923 (code B ref 78166); Mon, 19 May 2025 16:42:02 +0000 Received: (at 78166) by debbugs.gnu.org; 19 May 2025 16:41:21 +0000 Received: from localhost ([127.0.0.1]:43300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uH3YG-0000l4-S6 for submit@debbugs.gnu.org; Mon, 19 May 2025 12:41:21 -0400 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]:59887) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uH3YD-0000kU-Vu for 78166@debbugs.gnu.org; Mon, 19 May 2025 12:41:19 -0400 Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-6f8cda1ca6dso10932646d6.3 for <78166@debbugs.gnu.org>; Mon, 19 May 2025 09:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1747672872; x=1748277672; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=jy5tcn92kvdnDGhiOOgCSbxJ2X+yxmkjmDOoYPmz8p0=; b=Tf5KZkLxOZKspc7v0PEy9RuePPCdyJRrIfwHRfXtEyogtXo5egAyN8f3easuta3kjF aZGHz4VYzK/r/9QRpurHaUf9f228H3mIFxxoNjAHEfGqH3QvO+k0x/U8blpkHYeQoB4z 0ZjNAUOV97ovAKWDtqy/bY1F1i+xTf6W0ItMsVj3v4REMLt7r1iy4itA1bf9kBl7eFax HUXKOOAJIdz18KJM2UzBzpkIUqqeG1SkBzQPusU+Y96e0eZVFEJ6tZjdgcTDiekau3kX M78r9q0qwhi5Givh8x7hkMk/d2meneUaPwiKzpnqqvKmLJG6ru9HrJ0UWuWpsqqgmxpL A3xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747672872; x=1748277672; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jy5tcn92kvdnDGhiOOgCSbxJ2X+yxmkjmDOoYPmz8p0=; b=AqKDQqk6LWyJ0JbK8ByGsyC00DYwu/wKOyS43FNqediOgIwhb6cvUpv2jQh9rV3j85 RRjwyr4iQEHGkB1n3HJ6u+D3BWEIDXvKkzcDRotnuTIy1ZPZvPIF+UTQ7m47bdXjgLh9 PXGWkfLZISFU0db+29o12aB3VwsGsmsqvnE9/iOB1ELaxprkJlNnNgXzkwGVUv41ZCLQ 1a/4MnuXTLykKox5V1upTTRukyncXtbt4Dzh9S3/sfppQUTWXFoSZ2Fej8fDOzv9lp12 RjwBSGipEkN+WawQ9+0B2LdhQAjv9U0H/karLSJ9kLxl2TdUvGSSUnXN5SEPEkbi1Yr6 1GBg== X-Gm-Message-State: AOJu0Yyzdx++yfZ0l3PVISP7+A4pKg4+Qi4oP3Rzka4fjH5ZrNCMxO2W rcgAQbj0ffu5perNRjcy/PJLbuSV4pUi8iUP2l68x3JBjQIq8uk8QrW97ZxWsKi7H6BcWr0wt+z 0z44i X-Gm-Gg: ASbGnctKkKRc3wWfJQLcHkQ6lfer8r8A5v49FKjkN0mksXuJyiPWEhizofUPI6rsXaU nnkHZG8/hdr8LYIs2amWSlaRP/KgVKThBOoKTsXvu4bJbGmyQgZPQLg8hJX8Sj8QPZrFEEol4jx En1nSFJj3QJLwiUgIE9fW2XeYPaIAZJcFHGymE7tQzIFdPfimLC5DtntwNFpfuddUzpL6oERcEJ +LXWc6v0QzkeKjhDsTP6F3yJh7IFUZ+KgO8kKKZL4Gn1ijMR37J4Ju6TKtGiv4K7cPzGwep2JXt iyIaY8DtrSUceZ8tsnj/nb58h7MYd+gZzzTvZj7ebyn23IGArUrjQrvmFRnKnhXi X-Google-Smtp-Source: AGHT+IGa3Nvcojz6OrkDDjOVce92vEUHebwTIBC9/aZUVnCqHziKJEmjr3nL/mi13zPrW7qCU3Yvug== X-Received: by 2002:a05:6214:1c8e:b0:6eb:1e80:19fa with SMTP id 6a1803df08f44-6f8b0849240mr177548086d6.1.1747672871829; Mon, 19 May 2025 09:41:11 -0700 (PDT) Received: from smtpclient.apple ([70.107.172.48]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f8b08be302sm58945336d6.54.2025.05.19.09.41.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 May 2025 09:41:11 -0700 (PDT) From: Sean Devlin Message-Id: <115B750C-408A-46ED-A3B2-E641529F6A79@toadstyle.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_3DB45743-5B90-49A9-9A27-6F0349D03F5E" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Date: Mon, 19 May 2025 12:41:00 -0400 In-Reply-To: <86sel3wtob.fsf@gnu.org> References: <86h624mdhx.fsf@gnu.org> <86sel3wtob.fsf@gnu.org> X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_3DB45743-5B90-49A9-9A27-6F0349D03F5E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 17, 2025, at 4:03=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Sean Devlin >> Date: Thu, 1 May 2025 21:52:14 -0400 >> Cc: 78166@debbugs.gnu.org >>=20 >>=20 >>=20 >>> On May 1, 2025, at 1:45=E2=80=AFPM, Eli Zaretskii = wrote: >>>=20 >>> =EF=BB=BF >>>>=20 >>>> From: Sean Devlin >>>> Date: Wed, 30 Apr 2025 17:01:11 -0400 >>>>=20 >>>> I see now that the documentation for help-window-select says: >>>>=20 >>>> This option has effect if and only if the help window was created >>>> by =E2=80=98with-help-window=E2=80=99. >>>>=20 >>>> So maybe this is not a bug per se. >>>>=20 >>>> Should we improve quail-help to use with-help-window? >>>=20 >>> Yes, if we want it to heed help-window-select, we should. >>>=20 >>> Patches welcome. But please be careful and test the changes >>> thoroughly: AFAIR input-method help has several features thyat we >>> would not like to lose. >>=20 >> Sounds good. I will give it a try. I=E2=80=99ll mail back here if I = run into problems. >=20 > Did you have an opportunity to make some progress with this issue? Hi Eli, I did look at this bit, but I think I need some advice on how best to = proceed. I also found a couple other bugs in this code, which I=E2=80=99ll = describe below. As the code stands today, We have the command describe-input-method and = its subroutine describe-current-input-method. These functions do some = basic setup (e.g. binding help-buffer-under-preparation and calling = help-setup-xref), but they delegate the main work to a funcall to = describe-current-input-method-function. The variable describe-current-input-method-function is set by the input = method. For example, the function quail-activate sets this to = quail-help, so all quail-derived input methods share a common = implementation. There are a few other implementations in the Emacs = source in hangul.el, robin.el, and uni-input.el. It seems possible there = could be third-party packages defining input methods that provide yet = more implementations for describe-current-input-method-function, but I = haven=E2=80=99t checked. Since these implementations are all invoked by the common wrapper code = in describe-input-method, it seems like it would be good if that = function could handle more of the common setup, e.g. by wrapping the = funcall to describe-current-input-method-function in a with-help-window = stanza. This way, all implementations of that subroutine would benefit, = i.e. help-window-select would work correctly for all of them. The drawback is that this could be a breaking change. Any work the = describe-current-input-method-function implementations are doing to set = up the help window would become redundant, and it could cause bugs. = Obviously, we can fix the implementations that are in-tree, but I=E2=80=99= m not sure how it would affect third-party packages. I think I see three possible approaches we could take: As described above, set up the help window using with-help-window in the = describe-input-method command and remove any help window setup from the = subroutines. This could cause issues for downstream packages. Instead, we could make a fix directly in quail-help. This would work, = but it wouldn=E2=80=99t benefit other implementations of = describe-current-input-method-function. We could introduce an alternative to = describe-current-input-method-function and call it when it is non-nil. = Otherwise, we would continue to call = describe-current-input-method-function. To expand on the third item, suppose we introduced a new variable called = (for example) describe-input-method-body-function. It would be = responsible for generating the body of the help buffer, but not for the = basic setup of the help buffer or window. In describe-input-method, we=E2=80=99d have some code like the following = (simplified): (cond ((and (symbolp describe-input-method-body-function) (fboundp describe-input-method-body-function)) (with-help-window (help-buffer) (funcall describe-input-method-body-function))) ((and (symbolp describe-current-input-method-function) (fboundp describe-current-input-method-function)) (funcall describe-current-input-method-function)) (t =E2=80=A6)) This way, we could preserve the existing behavior for third-party = packages while also making the help window setup more uniform for = in-tree implementations (and for any third-party packages that choose to = adopt the new variable). Any advice on which approach to take would be greatly appreciated! As to the bugs I mentioned above, they are mainly around the management = of help-setup-xref. If describe-current-input-method is invoked directly = (instead of as a subroutine of describe-input-method), help xrefs will = not be set up at all. To reproduce: Emacs -Q Invoke a couple help commands, e.g. C-h k C-h k C-h k C-h c Check that you can use l and r to go back and forwards between the two = buffers In the scratch buffer, C-\ japanese RET Mouse-3 on the mode line indicator for the input method In the help buffer, use l and r and see that it doesn=E2=80=99t work = correctly: Pressing l will skip back to the first help buffer Pressing r will then bring you back to the second help buffer The input method help buffer is not on the stack at all, so you cannot = retrieve it by any combination of l or r inputs There is a related bug in the error-handling path of = describe-input-method where the help xrefs are set up twice, but I=E2=80=99= m not sure of a good way to trigger this path. Should I file a separate bug for these, or just roll a fix into this = change? Thanks!= --Apple-Mail=_3DB45743-5B90-49A9-9A27-6F0349D03F5E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On May 17, 2025, at 4:03=E2=80=AFAM, Eli Zaretskii = <eliz@gnu.org> wrote:

From: Sean Devlin = <spd@toadstyle.org>
Date: Thu, 1 May 2025 21:52:14 -0400
Cc: = 78166@debbugs.gnu.org



On May 1, = 2025, at 1:45=E2=80=AFPM, Eli Zaretskii <eliz@gnu.org> = wrote:

=EF=BB=BF

From: Sean = Devlin <spd@toadstyle.org>
Date: Wed, 30 Apr 2025 17:01:11 = -0400

I see now that the documentation for help-window-select = says:

This option has effect if and only if the help window was = created
by =E2=80=98with-help-window=E2=80=99.

So maybe this = is not a bug per se.

Should we improve quail-help to use = with-help-window?

Yes, if we want it to heed = help-window-select, we should.

Patches welcome.  But please = be careful and test the changes
thoroughly: AFAIR input-method help = has several features thyat we
would not like to = lose.

Sounds good. I will give it a try. I=E2=80=99ll = mail back here if I run into problems.

Did you have an opportunity to make some = progress with this issue?

Hi = Eli,

I did look at this bit, but I think I need = some advice on how best to proceed.

I also = found a couple other bugs in this code, which I=E2=80=99ll describe = below.

As the code stands today, We have the = command describe-input-method and its subroutine = describe-current-input-method. These functions do some basic setup (e.g. = binding help-buffer-under-preparation and calling help-setup-xref), but = they delegate the main work to a funcall to = describe-current-input-method-function.

The = variable describe-current-input-method-function is set by the input = method. For example, the function quail-activate sets this to = quail-help, so all quail-derived input methods share a common = implementation. There are a few other implementations in the Emacs = source in hangul.el, robin.el, and uni-input.el. It seems possible there = could be third-party packages defining input methods that provide yet = more implementations for describe-current-input-method-function, but I = haven=E2=80=99t checked.

Since these = implementations are all invoked by the common wrapper code in = describe-input-method, it seems like it would be good if that function = could handle more of the common setup, e.g. by wrapping the funcall to = describe-current-input-method-function in a with-help-window stanza. = This way, all implementations of that subroutine would benefit, i.e. = help-window-select would work correctly for all of = them.

The drawback is that this could be a = breaking change. Any work the describe-current-input-method-function = implementations are doing to set up the help window would become = redundant, and it could cause bugs. Obviously, we can fix the = implementations that are in-tree, but I=E2=80=99m not sure how it would = affect third-party packages.

I think I see = three possible approaches we could take:

  1. As described above, set up the help window = using with-help-window in the describe-input-method command and remove = any help window setup from the subroutines. This could cause issues for = downstream packages.
  2. Instead, we could make a fix directly in = quail-help. This would work, but it wouldn=E2=80=99t benefit other = implementations of describe-current-input-method-function.
  3. We = could introduce an alternative to describe-current-input-method-function = and call it when it is non-nil. Otherwise, we would continue to call = describe-current-input-method-function.

To expand on the third item, suppose we introduced a new variable = called (for example) describe-input-method-body-function. It would be = responsible for generating the body of the help buffer, but not for the = basic setup of the help buffer or window.

In = describe-input-method, we=E2=80=99d have some code like the following = (simplified):

(cond
 ((and = (symbolp describe-input-method-body-function)
    =    (fboundp = describe-input-method-body-function))
  (with-help-window = (help-buffer)
    (funcall = describe-input-method-body-function)))
 ((and (symbolp = describe-current-input-method-function)
      =  (fboundp describe-current-input-method-function))
  = (funcall describe-current-input-method-function))
 (t = =E2=80=A6))

This way, we could preserve = the existing behavior for third-party packages while also making the = help window setup more uniform for in-tree implementations (and for any = third-party packages that choose to adopt the new = variable).

Any advice on which approach to take = would be greatly appreciated!

As to the bugs I = mentioned above, they are mainly around the management of = help-setup-xref. If describe-current-input-method is invoked directly = (instead of as a subroutine of describe-input-method), help xrefs will = not be set up at all.

To = reproduce:

  1. Emacs = -Q
  2. Invoke a couple help commands, e.g.
    1. C-h k C-h k
    2. C-h k C-h = c
  3. Check that you can use l and r to go back and forwards = between the two buffers
  4. In the scratch buffer, C-\ japanese = RET
  5. Mouse-3 on the mode line indicator for the input = method
  6. In the help buffer, use l and r and see that it doesn=E2=80= =99t work correctly:
    1. Pressing l will = skip back to the first help buffer
    2. Pressing r will then bring = you back to the second help buffer
    3. The input method help buffer = is not on the stack at all, so you cannot retrieve it by any combination = of l or r inputs

There is a = related bug in the error-handling path of describe-input-method where = the help xrefs are set up twice, but I=E2=80=99m not sure of a good way = to trigger this path.

Should I file a separate = bug for these, or just roll a fix into this = change?

Thanks!
= --Apple-Mail=_3DB45743-5B90-49A9-9A27-6F0349D03F5E-- From unknown Sat Jun 21 05:15:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78166: 30.1; describe-input-method does not respect help-window-select Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 May 2025 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Devlin Cc: 78166@debbugs.gnu.org Received: via spool by 78166-submit@debbugs.gnu.org id=B78166.174790866820506 (code B ref 78166); Thu, 22 May 2025 10:12:01 +0000 Received: (at 78166) by debbugs.gnu.org; 22 May 2025 10:11:08 +0000 Received: from localhost ([127.0.0.1]:60350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uI2tI-0005Kg-AV for submit@debbugs.gnu.org; Thu, 22 May 2025 06:11:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45394) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uI2t9-0005K1-LC for 78166@debbugs.gnu.org; Thu, 22 May 2025 06:11:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uI2t3-0003KV-Vq; Thu, 22 May 2025 06:10:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9B3W+8DIriCbQCHcnL2pZnT4bSP1QyuN2AOqS7+soys=; b=JiVxUw4FjbYNJpJnoPty YmB7Uoqn6jSuHe325r9ydBTOY8KTALeSc0gJBkwGqaDwlG7UrZQk8MeZxmPA8MotMyxxssjcgMI4r B/5178Bv/tXBDO94cYwbldsZpgUdj2OodXayoJddT8gjaSlGzVlOb2iSQcFjuTTN3cr2SFYJiWmDs FnJV2OUvEjl4dxaUsJOhnmdyND9Gl8sjU6FYsjhJoP9K4EkzsEs1otTnMQ63WB5MLME8F4S0eI+Ax /PUVxghdA55kdpJhx7sPSITMICZzI8ndLmz3/29gkD0XRpVhJ5AvyYhffKpJvM0SmAqtSvf0+rlKs LptG6lXA5FNIpA==; Date: Thu, 22 May 2025 13:10:47 +0300 Message-Id: <8634cx6jmg.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <115B750C-408A-46ED-A3B2-E641529F6A79@toadstyle.org> (message from Sean Devlin on Mon, 19 May 2025 12:41:00 -0400) References: <86h624mdhx.fsf@gnu.org> <86sel3wtob.fsf@gnu.org> <115B750C-408A-46ED-A3B2-E641529F6A79@toadstyle.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Devlin > Date: Mon, 19 May 2025 12:41:00 -0400 > Cc: 78166@debbugs.gnu.org > > I think I see three possible approaches we could take: > > 1 As described above, set up the help window using with-help-window in the describe-input-method > command and remove any help window setup from the subroutines. This could cause issues for > downstream packages. > 2 Instead, we could make a fix directly in quail-help. This would work, but it wouldn’t benefit other > implementations of describe-current-input-method-function. > 3 We could introduce an alternative to describe-current-input-method-function and call it when it is non-nil. > Otherwise, we would continue to call describe-current-input-method-function. > > To expand on the third item, suppose we introduced a new variable called (for example) > describe-input-method-body-function. It would be responsible for generating the body of the help buffer, but > not for the basic setup of the help buffer or window. > > In describe-input-method, we’d have some code like the following (simplified): > > (cond > ((and (symbolp describe-input-method-body-function) > (fboundp describe-input-method-body-function)) > (with-help-window (help-buffer) > (funcall describe-input-method-body-function))) > ((and (symbolp describe-current-input-method-function) > (fboundp describe-current-input-method-function)) > (funcall describe-current-input-method-function)) > (t …)) > > This way, we could preserve the existing behavior for third-party packages while also making the help > window setup more uniform for in-tree implementations (and for any third-party packages that choose to > adopt the new variable). > > Any advice on which approach to take would be greatly appreciated! I think I'd prefer #2. > As to the bugs I mentioned above, they are mainly around the management of help-setup-xref. If > describe-current-input-method is invoked directly (instead of as a subroutine of describe-input-method), help > xrefs will not be set up at all. > > To reproduce: > > 1 Emacs -Q > 2 Invoke a couple help commands, e.g. > > 1 C-h k C-h k > 2 C-h k C-h c > > 3 Check that you can use l and r to go back and forwards between the two buffers > 4 In the scratch buffer, C-\ japanese RET > 5 Mouse-3 on the mode line indicator for the input method > 6 In the help buffer, use l and r and see that it doesn’t work correctly: > > 1 Pressing l will skip back to the first help buffer > 2 Pressing r will then bring you back to the second help buffer > 3 The input method help buffer is not on the stack at all, so you cannot retrieve it by any combination of l or > r inputs > > There is a related bug in the error-handling path of describe-input-method where the help xrefs are set up > twice, but I’m not sure of a good way to trigger this path. > > Should I file a separate bug for these, or just roll a fix into this change? It depends: if the fix can be naturally included in the modifications for quail-help, it should be okay to do it together. Otherwise, please submit a separate bug report, and we can take it from there. Thanks. From unknown Sat Jun 21 05:15:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78166: 30.1; describe-input-method does not respect help-window-select Resent-From: Sean Devlin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2025 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 78166@debbugs.gnu.org Received: via spool by 78166-submit@debbugs.gnu.org id=B78166.174809776030073 (code B ref 78166); Sat, 24 May 2025 14:43:02 +0000 Received: (at 78166) by debbugs.gnu.org; 24 May 2025 14:42:40 +0000 Received: from localhost ([127.0.0.1]:33307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIq59-0007ou-1L for submit@debbugs.gnu.org; Sat, 24 May 2025 10:42:40 -0400 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]:57389) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uIq55-0007nZ-Q7 for 78166@debbugs.gnu.org; Sat, 24 May 2025 10:42:37 -0400 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-6f2c45ecaffso6717626d6.2 for <78166@debbugs.gnu.org>; Sat, 24 May 2025 07:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1748097750; x=1748702550; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ybq/g4iHzUweg6WlES7hbx32rM5CHZ9pW0xcieWNSKE=; b=Sh4bAD2ApyKjP9kniE5RnvMRbJ2vtDK/y+0tW1wtmqZ6TR4MpWAh4DYF0Nq1IomhAh REx1TEUuA4apdU1CbV56ZFguzzc62PZN0z4mxFbV8K4nKwe6RX69IoomXVbHaa+i/3O9 VHYvpnFAOCrC+PiolYs9JI/OWrw0PwLGxjoC9BptQf55+2f7RsLcQqk4xnUUtEqCfQaO Ty1/PCta8Hm/6qUfEOfXHuj7o3BoqloIzTRvw9RhXhpLUbQMs8uM+fsX2uUo/M1eFO9G emfFxGNmVkegGnR4LWzB6g9PO+ysf2P4rISZTwwrq20m51urJbzqRGvMzGcVyuHsoWWc aGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748097750; x=1748702550; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ybq/g4iHzUweg6WlES7hbx32rM5CHZ9pW0xcieWNSKE=; b=VNzR5RgZ8RUXmh2zyRpMGTsY7YUeOQyv0TzbFAFF+U6S6FDd0A/nFUpsm7Jx3wtb5e ePKp56WRwHqN+4MLfRbbByGEfkfFSHWOlg2rZkqpnPBUYRVMT0kvEDBoxIhghYOOK4ns 2cu9df6niAihdC98vLyjbCINfsZJKm9tMCF8nye5wnkJb2vXYxQjDi2gldaoFbz827+t 7nucVwEjsTMMu8T1VF0zZ1lrfKc22Sc5IkpbnhwehtI40qO5yGkrAs/fy6BaKuLub7Yw RZ9NkUkk89EYEUsgpJBl1ZftbtAIS/G4aOe48jZXLIJvio0Vx+mfFMZuANuCoUx4BA/T Izow== X-Gm-Message-State: AOJu0YxBWC60/qUIweJfOOzyeafZsOubmnF0SuNzpxWxPPvcxDPIeS6N vX7Okt25wFW9USDKcYZd6iTFgZ+UhlLV19GSaE2PRkbfoVlyc3rWV6hhcvVwdqYQrSKb8uO65BK 9mvxA X-Gm-Gg: ASbGncuN0N+uobJu6ypP43TnBrxS1ZtZMvXJ9QmX11NlHxzmDLHnxNfxkS/8w2cQta5 U44syUHUqnLYPmonnQH/DIW2zXOUq+7ljnBgEC6WY+jyw3LHduOhPVZu1waJE63Hmp67okdWJKA xtG0cn2UYcBCriwglGGn+EcaMMKa9L9G9rtA2gjCR/Cenop/or4Qd+VzeMfc3uvCXnWzEV6v2Qb Y/MS7mBMRGFxYsLfReuzHV2neSTtKEHTuII5QfO404k8VRP9IYbr2vegMMc2nkH+OtYdoo6RXrz xCyFWkOZQEbWlyYQlvTP+zCVEBsbq/6/GiRTpLNaoYqjYtdNPzdNVDjBqDWmNzW9dYfZFA== X-Google-Smtp-Source: AGHT+IGVqxErlb6P9676767A9hI8c+VdWo/oqkSV6OBNLEnYvjysl3mY3F6IqANmYGEwb0DT4GNs1A== X-Received: by 2002:a05:6214:3013:b0:6fa:99f6:ca9a with SMTP id 6a1803df08f44-6fa9d2c8063mr53602346d6.41.1748097749713; Sat, 24 May 2025 07:42:29 -0700 (PDT) Received: from smtpclient.apple ([70.107.172.48]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f8b0883e1fsm129733036d6.12.2025.05.24.07.42.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 May 2025 07:42:29 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) From: Sean Devlin In-Reply-To: <8634cx6jmg.fsf@gnu.org> Date: Sat, 24 May 2025 10:42:18 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <3A296A25-F75E-446D-A5D1-D63DF514D17E@toadstyle.org> References: <86h624mdhx.fsf@gnu.org> <86sel3wtob.fsf@gnu.org> <115B750C-408A-46ED-A3B2-E641529F6A79@toadstyle.org> <8634cx6jmg.fsf@gnu.org> X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On May 22, 2025, at 6:10=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Sean Devlin >> Date: Mon, 19 May 2025 12:41:00 -0400 >> Cc: 78166@debbugs.gnu.org >>=20 >> I think I see three possible approaches we could take: >>=20 >> 1 As described above, set up the help window using with-help-window = in the describe-input-method >> command and remove any help window setup from the subroutines. This = could cause issues for >> downstream packages. >> 2 Instead, we could make a fix directly in quail-help. This would = work, but it wouldn=E2=80=99t benefit other >> implementations of describe-current-input-method-function. >> 3 We could introduce an alternative to = describe-current-input-method-function and call it when it is non-nil. >> Otherwise, we would continue to call = describe-current-input-method-function. >>=20 >> To expand on the third item, suppose we introduced a new variable = called (for example) >> describe-input-method-body-function. It would be responsible for = generating the body of the help buffer, but >> not for the basic setup of the help buffer or window. >>=20 >> In describe-input-method, we=E2=80=99d have some code like the = following (simplified): >>=20 >> (cond >> ((and (symbolp describe-input-method-body-function) >> (fboundp describe-input-method-body-function)) >> (with-help-window (help-buffer) >> (funcall describe-input-method-body-function))) >> ((and (symbolp describe-current-input-method-function) >> (fboundp describe-current-input-method-function)) >> (funcall describe-current-input-method-function)) >> (t =E2=80=A6)) >>=20 >> This way, we could preserve the existing behavior for third-party = packages while also making the help >> window setup more uniform for in-tree implementations (and for any = third-party packages that choose to >> adopt the new variable). >>=20 >> Any advice on which approach to take would be greatly appreciated! >=20 > I think I'd prefer #2. Sounds good. I=E2=80=99ll make an attempt in this direction. >=20 >> As to the bugs I mentioned above, they are mainly around the = management of help-setup-xref. If >> describe-current-input-method is invoked directly (instead of as a = subroutine of describe-input-method), help >> xrefs will not be set up at all. >>=20 >> To reproduce: >>=20 >> 1 Emacs -Q >> 2 Invoke a couple help commands, e.g. >>=20 >> 1 C-h k C-h k >> 2 C-h k C-h c >>=20 >> 3 Check that you can use l and r to go back and forwards between the = two buffers >> 4 In the scratch buffer, C-\ japanese RET >> 5 Mouse-3 on the mode line indicator for the input method >> 6 In the help buffer, use l and r and see that it doesn=E2=80=99t = work correctly: >>=20 >> 1 Pressing l will skip back to the first help buffer >> 2 Pressing r will then bring you back to the second help buffer >> 3 The input method help buffer is not on the stack at all, so you = cannot retrieve it by any combination of l or >> r inputs >>=20 >> There is a related bug in the error-handling path of = describe-input-method where the help xrefs are set up >> twice, but I=E2=80=99m not sure of a good way to trigger this path. >>=20 >> Should I file a separate bug for these, or just roll a fix into this = change? >=20 > It depends: if the fix can be naturally included in the modifications > for quail-help, it should be okay to do it together. Otherwise, > please submit a separate bug report, and we can take it from there. >=20 > Thanks. Thanks, I=E2=80=99ll see how it goes and proceed from there.=