GNU bug report logs - #78162
[PATCH] hash-table-contains-p: Avoid creating a symbol on every call

Previous Next

Package: emacs;

Reported by: Daniel Mendler <mail <at> daniel-mendler.de>

Date: Wed, 30 Apr 2025 10:04:02 UTC

Severity: normal

Tags: patch

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78162: closed ([PATCH] hash-table-contains-p: Avoid creating
 a symbol on every call)
Date: Mon, 12 May 2025 21:22:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 12 May 2025 17:20:54 -0400
with message-id <jwv8qn1y19b.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#78162: [PATCH] hash-table-contains-p: Avoid creating a symbol on every call
has caused the debbugs.gnu.org bug report #78162,
regarding [PATCH] hash-table-contains-p: Avoid creating a symbol on every call
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78162: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78162
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Kangas <stefankangas <at> gmail.com>
Subject: [PATCH] hash-table-contains-p: Avoid creating a symbol on every call
Date: Wed, 30 Apr 2025 12:03:27 +0200
[Message part 3 (text/plain, inline)]
Tags: patch

For performance reasons avoid creating a symbol on every call to
`hash-table-contains-p'.  See also https://github.com/emacs-compat/compat/issues/71.

[0001-hash-table-contains-p-Avoid-creating-a-symbol-on-eve.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 78162-done <at> debbugs.gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#78162: [PATCH] hash-table-contains-p: Avoid creating a
 symbol on every call
Date: Mon, 12 May 2025 17:20:54 -0400
>> Then an alternative would be the simpler patch below?
> I tried hard to find something wrong with it, but couldn't.

Push to `master`, closing,


        Stefan



This bug report was last modified 12 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.