From unknown Fri Jun 13 10:10:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#78137] [PATCH electronics-team] gnu: gtkwave: Update to 3.4.0-0.bb978d9. Resent-From: Cayetano Santos Original-Sender: "Debbugs-submit" Resent-CC: csantosb@inventati.org, ekaitz@elenq.tech, maxim.cournoyer@gmail.com, guix-patches@gnu.org Resent-Date: Tue, 29 Apr 2025 14:20:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78137 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 78137@debbugs.gnu.org Cc: Cayetano Santos , Cayetano Santos , Ekaitz Zarraga , Maxim Cournoyer X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Cayetano Santos , Ekaitz Zarraga , Maxim Cournoyer Received: via spool by submit@debbugs.gnu.org id=B.174593634321399 (code B ref -1); Tue, 29 Apr 2025 14:20:06 +0000 Received: (at submit) by debbugs.gnu.org; 29 Apr 2025 14:19:03 +0000 Received: from localhost ([127.0.0.1]:56764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9lnZ-0005Yp-Rj for submit@debbugs.gnu.org; Tue, 29 Apr 2025 10:19:03 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38844) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9lnU-0005Wz-E3 for submit@debbugs.gnu.org; Tue, 29 Apr 2025 10:18:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9lnK-0007Gx-1N for guix-patches@gnu.org; Tue, 29 Apr 2025 10:18:46 -0400 Received: from devianza.investici.org ([198.167.222.108]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9lnH-0008PP-A8 for guix-patches@gnu.org; Tue, 29 Apr 2025 10:18:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1745936320; bh=bzm+2shFZqDN2T/xHTPkO1FIcS/2Y4fHWxkd/KcLqFA=; h=From:To:Cc:Subject:Date:From; b=rR5SkKdeNjG/5F/TnI3oGsY4kmoq5bVDeYTkvNY6ht0MAo6pYEnkHxznodYArOmBX Siu0GO2yUdW/zKK8md2wlx/NdV2Wgpd7+7+ZD9bwMzk4yoRtVth1ufHr0z6Ps7UVcN IxYi5rcQcd0hNvQ4WVjuy5dBXlD+N/KkUgNkall0= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4Zn2VS4s6cz6vGs; Tue, 29 Apr 2025 14:18:40 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4Zn2VS2Xnsz6vGN; Tue, 29 Apr 2025 14:18:40 +0000 (UTC) From: Cayetano Santos Date: Tue, 29 Apr 2025 16:10:40 +0200 Message-ID: <637fef4126c2b44d8fc82ce17e065e491d5eb686.1745935840.git.csantosb@inventati.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=198.167.222.108; envelope-from=csantosb@inventati.org; helo=devianza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/fpga.scm (gtkwave): Update to 3.4.0-0.bb978d9. Change-Id: I38aabca14c2789ad7b3bc304b7018644dc6d0fa6 --- Update package and fetch from its new home at github, branch master. Note that branch lts comprises the v3.x series. [source]: Switch to git-fetch, new uri. [version]: Switch to branch master, version 3.4. [build-system]: Switch to meson-build-system. [native-inputs]: Add new requirements. [inputs]: Add libfst and tcllib. [homepage]: Update URL. gnu/packages/fpga.scm | 68 +++++++++++++++++++++++-------------------- 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm index 4fcd6a47a6..fc44166bff 100644 --- a/gnu/packages/fpga.scm +++ b/gnu/packages/fpga.scm @@ -53,6 +53,7 @@ (define-module (gnu packages fpga) #:use-module (gnu packages cpp) #:use-module (gnu packages elf) #:use-module (gnu packages flex) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages gawk) #:use-module (gnu packages gdb) #:use-module (gnu packages gettext) @@ -77,6 +78,7 @@ (define-module (gnu packages fpga) #:use-module (gnu packages ruby) #:use-module (gnu packages qt) #:use-module (gnu packages readline) + #:use-module (gnu packages shells) #:use-module (gnu packages sphinx) #:use-module (gnu packages tcl) #:use-module (gnu packages texinfo) @@ -434,39 +436,41 @@ (define-public nextpnr-ice40 (license license:expat)))) (define-public gtkwave - (package - (name "gtkwave") - (version "3.3.121") - (source - (origin - (method url-fetch) - (uri (list (string-append "mirror://sourceforge/gtkwave/" - "gtkwave-gtk3-" version "/" - "gtkwave-gtk3-" version ".tar.gz") - (string-append "https://gtkwave.sourceforge.net/" - "gtkwave-" version ".tar.gz"))) - (sha256 - (base32 "0ikk49zyar5aiq7pg9whi4nfzq7xm8sz7bn3b6vaylkdimw4bajl")))) - (build-system glib-or-gtk-build-system) - (native-inputs - (list gperf pkg-config)) - (inputs - (list gtk+ tcl tk)) - (arguments - (list #:configure-flags - #~(list "--enable-gtk3" - (string-append "--with-tcl=" - (assoc-ref %build-inputs "tcl") - "/lib") - (string-append "--with-tk=" - (assoc-ref %build-inputs "tk") - "/lib")))) - (synopsis "Waveform viewer for FPGA simulator trace files") - (description "This package is a waveform viewer for FPGA + ;; there are no releases in master branch, which includes 3.4.0 + (let ((commit "bb978d9d667d569b9153ffa34007e300302907dc") + (revision "0")) + (package + (name "gtkwave") + (version (git-version "3.4.0" revision commit)) ; version from meson.build + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/gtkwave/gtkwave") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1nv27cpz5937cb6bkhpw8w0ji6hm9xr8f0znvfwzfl1fwwypf23y")))) + (build-system meson-build-system) + (native-inputs (list desktop-file-utils + flex + `(,glib "bin") + gobject-introspection + gperf + perl + pkg-config + tcsh)) + (inputs (list gtk + gtk+ + `(,gtk+ "bin") + libfst + tcllib)) + (synopsis "Waveform viewer for FPGA simulator trace files") + (description "This package is a waveform viewer for FPGA simulator trace files (@dfn{FST}).") - (home-page "https://gtkwave.sourceforge.net/") - ;; Exception against free government use in tcl_np.c and tcl_np.h. - (license (list license:gpl2+ license:expat license:tcl/tk)))) + (home-page "https://github.com/gtkwave/gtkwave") + ;; Exception against free government use in tcl_np.c and tcl_np.h. + (license (list license:gpl2+ license:expat license:tcl/tk))))) (define-public python-migen ;; XXX: The latest version tag (0.9.2) was placed in 2019, there are latest base-commit: 881d46eb386c2de8bc6f1405972ee1e115eeb3a1 prerequisite-patch-id: d0bc54cf519652d6da310bfa99fe88c37275c298 prerequisite-patch-id: 445cfff048522cbeff4f72a4fc26088b591d0eb2 prerequisite-patch-id: cfb57a770c5842c09a09babb7e0a8db1b7af3426 prerequisite-patch-id: e8a09c6bf1ac37d125a3353a8535880866796309 prerequisite-patch-id: 3a61467968b32892273f687c17983450a368cc94 prerequisite-patch-id: 21b2f5649dd576054bd09b705eedc0d3f9a0ad40 prerequisite-patch-id: 11c1a4c6255b9ec68fc2dac4a8e6a4d3fb57c65f prerequisite-patch-id: 6b9c8a416da71858be3d7993b265348728fbc05d prerequisite-patch-id: 5dea2248b3d1c5f73c23e2a9baf6ddcc80bcb08d prerequisite-patch-id: ba8b325464becfb2d07b744ea7dbc641e45d8706 prerequisite-patch-id: 01a405a7f983be361c4136012366098c34331d3d prerequisite-patch-id: a86f79363080611b53d31c07a5811a1a8b4c836e prerequisite-patch-id: cbd7ce8e4c113b13ace6585d10c286b74696f15f prerequisite-patch-id: 8ed48edd220dea035ebdc7250488277a101e54b1 prerequisite-patch-id: 40d90dbaf56a83ab21d256c3b61b15ab069ca3be prerequisite-patch-id: 26c764ced5719f25db5e6d6bbf7b8cf1b0556b75 prerequisite-patch-id: ffb488bdef37ca0e7fca5252d732c6eea9cb9272 prerequisite-patch-id: 10568bc6c8a0d9713505a3ac375ffc424b06615d prerequisite-patch-id: a7360a53edf94070f1589ea6bddceaeaaccd3c90 prerequisite-patch-id: 48698cd40d9ef43b8b646660f2e18141681792ed prerequisite-patch-id: cc1917ae421a9d5e5e737ab0d7d64eafb80c66ea prerequisite-patch-id: f25b46e1e08ed9a23bafd4547b30559e87aafc83 prerequisite-patch-id: ebfbf78c71e216e14009a9c619502d515bd301e9 prerequisite-patch-id: 4debf0c53a034e80221112c95ed3572f436ed5b6 prerequisite-patch-id: 4e2979d172c82620e1f423201034aa00610ea22f prerequisite-patch-id: c411a74b430b78540a70d5516623bd92508e1505 prerequisite-patch-id: eb5d2e8f4679f970898c2b0f1a0caf6dc941712a prerequisite-patch-id: 1ad337c9c9741592793782f97db490bba02d3c4b -- 2.49.0 From unknown Fri Jun 13 10:10:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Cayetano Santos Subject: bug#78137: closed (Re: [bug#78137] [PATCH electronics-team] gnu: gtkwave: Update to 3.4.0-0.bb978d9.) Message-ID: References: <87cyc8hfo3.fsf@gmail.com> <637fef4126c2b44d8fc82ce17e065e491d5eb686.1745935840.git.csantosb@inventati.org> X-Gnu-PR-Message: they-closed 78137 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 78137@debbugs.gnu.org Date: Fri, 16 May 2025 13:03:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1747400582-16115-1" This is a multi-part message in MIME format... ------------=_1747400582-16115-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #78137: [PATCH electronics-team] gnu: gtkwave: Update to 3.4.0-0.bb978d9. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 78137@debbugs.gnu.org. --=20 78137: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78137 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1747400582-16115-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 78137-done) by debbugs.gnu.org; 16 May 2025 13:02:54 +0000 Received: from localhost ([127.0.0.1]:37071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uFuiA-0004AI-Vq for submit@debbugs.gnu.org; Fri, 16 May 2025 09:02:53 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:56649) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uFui7-00049X-VW for 78137-done@debbugs.gnu.org; Fri, 16 May 2025 09:02:48 -0400 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-73bf5aa95e7so2010522b3a.1 for <78137-done@debbugs.gnu.org>; Fri, 16 May 2025 06:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747400562; x=1748005362; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=UNqJX7K2IJAq2njiv3Qt+7N9xzjDEu9eFP0TntLYurI=; b=DoYjO7WczG/nFZCKwQTTQoVd3vNxai9CzU166kPhyY5ktF3WUOTHfb8F2eiyFMVlIB uJyGTk7/a5KJC5y8jj9Qv2VZUP9cgUiV5ZhbTTV0p+8xkjCm/dm5S6w+cdO0T+e/441P spI3bukkZjQvslh4k9pcI29VZRvFfB4DmYP4CFSpJambL/fGQ8jDfOAuClZBW2cjDopc BlQj0THsacMFyFg6DkolQJQ/HtATkoZ0zPhRXP4hcUYiFlZ+sWCII9iPu9DE6AyUwoE8 JKsz3nCuodJmbVwjrGie5i0xzirlR4PA9uB2fi93ORiFTMGURDVeHzPjDlIGHukNt7d7 5IjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747400562; x=1748005362; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UNqJX7K2IJAq2njiv3Qt+7N9xzjDEu9eFP0TntLYurI=; b=vB1Fi8RoVlUZl6WQF0iZ7AZrYBCgtab+wr1XaSaOcphLSWL6DBowQvh9vzYdxv2Fii gnOPEae8pGbFCRlhGrtZ/puruKvidRpJdEHb4Xh24XSoHrgFTpg71tc9GkcU3iF478nn jNnYDb70jXKUY2DiF8FzmEUD7ok3SGDLoxcwHWylgQU0GORI7AGZruTPg5guDWpnN57b VGCrP+jx/MaXq5rQM0Z4OsGWg72nA+dRnn0+ZRn+L2mzLgHJzrgBx5IetxcW9rFMXnxV q6yoK6lQfbVUpjl0zkoeQvDce26vpUc6gXhH5Dfpnt78/UXp2r3yhv87QryG8TsK6lEv c8bA== X-Gm-Message-State: AOJu0YxQlbIcfLoic1kEJkn3brwoV7N1PUgIKx+pBu6FqemJIPOEyZcW VTD6IwzMsHM77URrZbJB07y1m9zOKokxGgxdPL5QaeTNIjARUG1kp6a2 X-Gm-Gg: ASbGncsh2JVrvXvTv4vtsMBCafb4LML42GvpjR3XgQ7br1JySA39gGghDGUSyBzvjgJ 8uQg1R1JD4Z2hjAgNL5aKvwCVj0ARhOr37j7hDEG0JLJ5EomMqApPz28SpiS63+iV5Z1FXpdlj+ jllfVn7CQhGAQIgwirnh0EqIL1ui7zg3r/VWRgD6z5K9KI9Xa9WjKPRVrDYnws6hI48ozHj+2RW rxiSsDuiauz6tQ9bjG4IaG/Mgr6CtpnpynP6CEGGTjvMot5XPss4bO4JMdoh0wrRx9b2jgy8ctU 2FdWo1Z4EaqrByp+b65GvMfsvpR/ilqoXeZ753fVU1j7IhIOYg== X-Google-Smtp-Source: AGHT+IE0BAC0WCMgCDWutLMnL8cE07x7QEUDqkBeoTpQQTvG2LxkCDRIBkQRCPRhM3eGDGKoZFbyOg== X-Received: by 2002:a05:6a00:3985:b0:739:3f55:b23f with SMTP id d2e1a72fcca58-742a97eb638mr4502697b3a.14.1747400561118; Fri, 16 May 2025 06:02:41 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-742a970d7c5sm1503795b3a.67.2025.05.16.06.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 May 2025 06:02:40 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: [bug#78137] [PATCH electronics-team] gnu: gtkwave: Update to 3.4.0-0.bb978d9. In-Reply-To: <637fef4126c2b44d8fc82ce17e065e491d5eb686.1745935840.git.csantosb@inventati.org> (Cayetano Santos's message of "Tue, 29 Apr 2025 16:10:40 +0200") References: <637fef4126c2b44d8fc82ce17e065e491d5eb686.1745935840.git.csantosb@inventati.org> Date: Fri, 16 May 2025 22:02:36 +0900 Message-ID: <87cyc8hfo3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78137-done Cc: 78137-done@debbugs.gnu.org, Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Cayetano Santos writes: > * gnu/packages/fpga.scm (gtkwave): Update to 3.4.0-0.bb978d9. > > Change-Id: I38aabca14c2789ad7b3bc304b7018644dc6d0fa6 > --- > > Update package and fetch from its new home at github, branch master. Note that branch lts comprises the v3.x series. > > [source]: Switch to git-fetch, new uri. > [version]: Switch to branch master, version 3.4. > [build-system]: Switch to meson-build-system. > [native-inputs]: Add new requirements. Please explicit the inputs added. > [inputs]: Add libfst and tcllib. > [homepage]: Update URL. The change log should be part of the commit message proper. > gnu/packages/fpga.scm | 68 +++++++++++++++++++++++-------------------- > 1 file changed, 36 insertions(+), 32 deletions(-) > > diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm > index 4fcd6a47a6..fc44166bff 100644 > --- a/gnu/packages/fpga.scm > +++ b/gnu/packages/fpga.scm > @@ -53,6 +53,7 @@ (define-module (gnu packages fpga) > #:use-module (gnu packages cpp) > #:use-module (gnu packages elf) > #:use-module (gnu packages flex) > + #:use-module (gnu packages freedesktop) > #:use-module (gnu packages gawk) > #:use-module (gnu packages gdb) > #:use-module (gnu packages gettext) > @@ -77,6 +78,7 @@ (define-module (gnu packages fpga) > #:use-module (gnu packages ruby) > #:use-module (gnu packages qt) > #:use-module (gnu packages readline) > + #:use-module (gnu packages shells) > #:use-module (gnu packages sphinx) > #:use-module (gnu packages tcl) > #:use-module (gnu packages texinfo) > @@ -434,39 +436,41 @@ (define-public nextpnr-ice40 > (license license:expat)))) > > (define-public gtkwave > - (package > - (name "gtkwave") > - (version "3.3.121") > - (source > - (origin > - (method url-fetch) > - (uri (list (string-append "mirror://sourceforge/gtkwave/" > - "gtkwave-gtk3-" version "/" > - "gtkwave-gtk3-" version ".tar.gz") > - (string-append "https://gtkwave.sourceforge.net/" > - "gtkwave-" version ".tar.gz"))) > - (sha256 > - (base32 "0ikk49zyar5aiq7pg9whi4nfzq7xm8sz7bn3b6vaylkdimw4bajl")))) > - (build-system glib-or-gtk-build-system) > - (native-inputs > - (list gperf pkg-config)) > - (inputs > - (list gtk+ tcl tk)) > - (arguments > - (list #:configure-flags > - #~(list "--enable-gtk3" > - (string-append "--with-tcl=" > - (assoc-ref %build-inputs "tcl") > - "/lib") > - (string-append "--with-tk=" > - (assoc-ref %build-inputs "tk") > - "/lib")))) > - (synopsis "Waveform viewer for FPGA simulator trace files") > - (description "This package is a waveform viewer for FPGA > + ;; there are no releases in master branch, which includes 3.4.0 > + (let ((commit "bb978d9d667d569b9153ffa34007e300302907dc") > + (revision "0")) > + (package > + (name "gtkwave") > + (version (git-version "3.4.0" revision commit)) ; version from meson.build > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/gtkwave/gtkwave") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1nv27cpz5937cb6bkhpw8w0ji6hm9xr8f0znvfwzfl1fwwypf23y")))) > + (build-system meson-build-system) > + (native-inputs (list desktop-file-utils > + flex > + `(,glib "bin") > + gobject-introspection > + gperf > + perl > + pkg-config > + tcsh)) > + (inputs (list gtk > + gtk+ > + `(,gtk+ "bin") > + libfst > + tcllib)) > + (synopsis "Waveform viewer for FPGA simulator trace files") > + (description "This package is a waveform viewer for FPGA > simulator trace files (@dfn{FST}).") > - (home-page "https://gtkwave.sourceforge.net/") > - ;; Exception against free government use in tcl_np.c and tcl_np.h. > - (license (list license:gpl2+ license:expat license:tcl/tk)))) > + (home-page "https://github.com/gtkwave/gtkwave") > + ;; Exception against free government use in tcl_np.c and tcl_np.h. > + (license (list license:gpl2+ license:expat license:tcl/tk))))) I've taken the liberty to make these changes locally: --8<---------------cut here---------------start------------->8--- modified gnu/packages/fpga.scm @@ -82,7 +82,6 @@ (define-module (gnu packages fpga) #:use-module (gnu packages ruby) #:use-module (gnu packages qt) #:use-module (gnu packages readline) - #:use-module (gnu packages shells) #:use-module (gnu packages sphinx) #:use-module (gnu packages tcl) #:use-module (gnu packages texinfo) @@ -481,7 +480,9 @@ (define-public nextpnr-ice40 (deprecated-package "nextpnr-ice40" nextpnr)) (define-public gtkwave - ;; There are no recent tag releases + ;; The last release is more than 2 years old, and there are improvements in + ;; the master branch, such as GTK 4 support: pick the latest commit that + ;; passes their CI. (let ((commit "bb978d9d667d569b9153ffa34007e300302907dc") (revision "0")) (package @@ -500,20 +501,17 @@ (define-public gtkwave (build-system meson-build-system) + (arguments (list #:glib-or-gtk? #t)) (native-inputs (list desktop-file-utils flex - `(,glib "bin") + `(,glib "bin") ;for glib-mkenums gobject-introspection gperf - perl - pkg-config - tcsh)) + pkg-config)) (inputs (list gtk gtk+ - `(,gtk+ "bin") - libfst - tcllib)) + `(,gtk "bin") + libfst)) (synopsis "Waveform viewer for FPGA simulator trace files") - (description "This package is a waveform viewer for FPGA -simulator trace files (@dfn{FST}).") + (description "This package is a waveform viewer for @acronym{FST, FPGA +Simulator Trace} files.") (home-page "https://github.com/gtkwave/gtkwave") ;; Exception against free government use in tcl_np.c and tcl_np.h. (license (list license:gpl2+ license:expat license:tcl/tk))))) --8<---------------cut here---------------end--------------->8--- I've tried making more explicit the comment explaining why we use a snapshot from git. I've removed inputs that were not detected by the build systems and apparently unused: perl, tcsh and tcllib. I've used the #:glib-or-gtk? argument, to wrap the binaries and ensure they could run by themselves from a pure environment. I've fixed the description to use @acronym and not @dfn. Adjusted the change log message a bit and pushed! -- Thanks, Maxim ------------=_1747400582-16115-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Apr 2025 14:19:03 +0000 Received: from localhost ([127.0.0.1]:56764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9lnZ-0005Yp-Rj for submit@debbugs.gnu.org; Tue, 29 Apr 2025 10:19:03 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38844) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9lnU-0005Wz-E3 for submit@debbugs.gnu.org; Tue, 29 Apr 2025 10:18:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9lnK-0007Gx-1N for guix-patches@gnu.org; Tue, 29 Apr 2025 10:18:46 -0400 Received: from devianza.investici.org ([198.167.222.108]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9lnH-0008PP-A8 for guix-patches@gnu.org; Tue, 29 Apr 2025 10:18:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1745936320; bh=bzm+2shFZqDN2T/xHTPkO1FIcS/2Y4fHWxkd/KcLqFA=; h=From:To:Cc:Subject:Date:From; b=rR5SkKdeNjG/5F/TnI3oGsY4kmoq5bVDeYTkvNY6ht0MAo6pYEnkHxznodYArOmBX Siu0GO2yUdW/zKK8md2wlx/NdV2Wgpd7+7+ZD9bwMzk4yoRtVth1ufHr0z6Ps7UVcN IxYi5rcQcd0hNvQ4WVjuy5dBXlD+N/KkUgNkall0= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4Zn2VS4s6cz6vGs; Tue, 29 Apr 2025 14:18:40 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4Zn2VS2Xnsz6vGN; Tue, 29 Apr 2025 14:18:40 +0000 (UTC) From: Cayetano Santos To: guix-patches@gnu.org Subject: [PATCH electronics-team] gnu: gtkwave: Update to 3.4.0-0.bb978d9. Date: Tue, 29 Apr 2025 16:10:40 +0200 Message-ID: <637fef4126c2b44d8fc82ce17e065e491d5eb686.1745935840.git.csantosb@inventati.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Cayetano Santos , Ekaitz Zarraga , Maxim Cournoyer Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=198.167.222.108; envelope-from=csantosb@inventati.org; helo=devianza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Cayetano Santos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/fpga.scm (gtkwave): Update to 3.4.0-0.bb978d9. Change-Id: I38aabca14c2789ad7b3bc304b7018644dc6d0fa6 --- Update package and fetch from its new home at github, branch master. Note that branch lts comprises the v3.x series. [source]: Switch to git-fetch, new uri. [version]: Switch to branch master, version 3.4. [build-system]: Switch to meson-build-system. [native-inputs]: Add new requirements. [inputs]: Add libfst and tcllib. [homepage]: Update URL. gnu/packages/fpga.scm | 68 +++++++++++++++++++++++-------------------- 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm index 4fcd6a47a6..fc44166bff 100644 --- a/gnu/packages/fpga.scm +++ b/gnu/packages/fpga.scm @@ -53,6 +53,7 @@ (define-module (gnu packages fpga) #:use-module (gnu packages cpp) #:use-module (gnu packages elf) #:use-module (gnu packages flex) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages gawk) #:use-module (gnu packages gdb) #:use-module (gnu packages gettext) @@ -77,6 +78,7 @@ (define-module (gnu packages fpga) #:use-module (gnu packages ruby) #:use-module (gnu packages qt) #:use-module (gnu packages readline) + #:use-module (gnu packages shells) #:use-module (gnu packages sphinx) #:use-module (gnu packages tcl) #:use-module (gnu packages texinfo) @@ -434,39 +436,41 @@ (define-public nextpnr-ice40 (license license:expat)))) (define-public gtkwave - (package - (name "gtkwave") - (version "3.3.121") - (source - (origin - (method url-fetch) - (uri (list (string-append "mirror://sourceforge/gtkwave/" - "gtkwave-gtk3-" version "/" - "gtkwave-gtk3-" version ".tar.gz") - (string-append "https://gtkwave.sourceforge.net/" - "gtkwave-" version ".tar.gz"))) - (sha256 - (base32 "0ikk49zyar5aiq7pg9whi4nfzq7xm8sz7bn3b6vaylkdimw4bajl")))) - (build-system glib-or-gtk-build-system) - (native-inputs - (list gperf pkg-config)) - (inputs - (list gtk+ tcl tk)) - (arguments - (list #:configure-flags - #~(list "--enable-gtk3" - (string-append "--with-tcl=" - (assoc-ref %build-inputs "tcl") - "/lib") - (string-append "--with-tk=" - (assoc-ref %build-inputs "tk") - "/lib")))) - (synopsis "Waveform viewer for FPGA simulator trace files") - (description "This package is a waveform viewer for FPGA + ;; there are no releases in master branch, which includes 3.4.0 + (let ((commit "bb978d9d667d569b9153ffa34007e300302907dc") + (revision "0")) + (package + (name "gtkwave") + (version (git-version "3.4.0" revision commit)) ; version from meson.build + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/gtkwave/gtkwave") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1nv27cpz5937cb6bkhpw8w0ji6hm9xr8f0znvfwzfl1fwwypf23y")))) + (build-system meson-build-system) + (native-inputs (list desktop-file-utils + flex + `(,glib "bin") + gobject-introspection + gperf + perl + pkg-config + tcsh)) + (inputs (list gtk + gtk+ + `(,gtk+ "bin") + libfst + tcllib)) + (synopsis "Waveform viewer for FPGA simulator trace files") + (description "This package is a waveform viewer for FPGA simulator trace files (@dfn{FST}).") - (home-page "https://gtkwave.sourceforge.net/") - ;; Exception against free government use in tcl_np.c and tcl_np.h. - (license (list license:gpl2+ license:expat license:tcl/tk)))) + (home-page "https://github.com/gtkwave/gtkwave") + ;; Exception against free government use in tcl_np.c and tcl_np.h. + (license (list license:gpl2+ license:expat license:tcl/tk))))) (define-public python-migen ;; XXX: The latest version tag (0.9.2) was placed in 2019, there are latest base-commit: 881d46eb386c2de8bc6f1405972ee1e115eeb3a1 prerequisite-patch-id: d0bc54cf519652d6da310bfa99fe88c37275c298 prerequisite-patch-id: 445cfff048522cbeff4f72a4fc26088b591d0eb2 prerequisite-patch-id: cfb57a770c5842c09a09babb7e0a8db1b7af3426 prerequisite-patch-id: e8a09c6bf1ac37d125a3353a8535880866796309 prerequisite-patch-id: 3a61467968b32892273f687c17983450a368cc94 prerequisite-patch-id: 21b2f5649dd576054bd09b705eedc0d3f9a0ad40 prerequisite-patch-id: 11c1a4c6255b9ec68fc2dac4a8e6a4d3fb57c65f prerequisite-patch-id: 6b9c8a416da71858be3d7993b265348728fbc05d prerequisite-patch-id: 5dea2248b3d1c5f73c23e2a9baf6ddcc80bcb08d prerequisite-patch-id: ba8b325464becfb2d07b744ea7dbc641e45d8706 prerequisite-patch-id: 01a405a7f983be361c4136012366098c34331d3d prerequisite-patch-id: a86f79363080611b53d31c07a5811a1a8b4c836e prerequisite-patch-id: cbd7ce8e4c113b13ace6585d10c286b74696f15f prerequisite-patch-id: 8ed48edd220dea035ebdc7250488277a101e54b1 prerequisite-patch-id: 40d90dbaf56a83ab21d256c3b61b15ab069ca3be prerequisite-patch-id: 26c764ced5719f25db5e6d6bbf7b8cf1b0556b75 prerequisite-patch-id: ffb488bdef37ca0e7fca5252d732c6eea9cb9272 prerequisite-patch-id: 10568bc6c8a0d9713505a3ac375ffc424b06615d prerequisite-patch-id: a7360a53edf94070f1589ea6bddceaeaaccd3c90 prerequisite-patch-id: 48698cd40d9ef43b8b646660f2e18141681792ed prerequisite-patch-id: cc1917ae421a9d5e5e737ab0d7d64eafb80c66ea prerequisite-patch-id: f25b46e1e08ed9a23bafd4547b30559e87aafc83 prerequisite-patch-id: ebfbf78c71e216e14009a9c619502d515bd301e9 prerequisite-patch-id: 4debf0c53a034e80221112c95ed3572f436ed5b6 prerequisite-patch-id: 4e2979d172c82620e1f423201034aa00610ea22f prerequisite-patch-id: c411a74b430b78540a70d5516623bd92508e1505 prerequisite-patch-id: eb5d2e8f4679f970898c2b0f1a0caf6dc941712a prerequisite-patch-id: 1ad337c9c9741592793782f97db490bba02d3c4b -- 2.49.0 ------------=_1747400582-16115-1-- From unknown Fri Jun 13 10:10:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#78137] [PATCH electronics-team] gnu: gtkwave: Update to 3.4.0-0.bb978d9. Resent-From: Cayetano Santos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 May 2025 08:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78137 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 78137-done@debbugs.gnu.org, Ekaitz Zarraga Received: via spool by 78137-done@debbugs.gnu.org id=D78137.174764233920927 (code D ref 78137); Mon, 19 May 2025 08:13:02 +0000 Received: (at 78137-done) by debbugs.gnu.org; 19 May 2025 08:12:19 +0000 Received: from localhost ([127.0.0.1]:37097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uGvbf-0005RT-F3 for submit@debbugs.gnu.org; Mon, 19 May 2025 04:12:19 -0400 Received: from latitanza.investici.org ([2001:888:2000:56::19]:25099) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uGvbb-0005R8-Aq for 78137-done@debbugs.gnu.org; Mon, 19 May 2025 04:12:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1747642333; bh=BqK2vlgcf4cKRIk1KbVQ3g9MDLXuQDOROEzcn/UHxjs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WiKPXNReIXl4mKu/Yz3TpJ4ineCtRedNp5scX0X5E8SDr+clR4pJSKz8i6EXeEBmd t7izZrYMAAcXieqEBD25pkW7FGPazDM1HAQa5X/pacsF0XkZqoPKSdyEu8lEWTLRjW y+JCRSyEps38JKfE/DYXUEbDwG1DdCleaVAsw9ME= Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4b19QP11wGzGprN; Mon, 19 May 2025 08:12:13 +0000 (UTC) Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4b19QN6KzYzGp71; Mon, 19 May 2025 08:12:12 +0000 (UTC) From: Cayetano Santos In-Reply-To: <87cyc8hfo3.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 16 May 2025 22:02:36 +0900") References: <637fef4126c2b44d8fc82ce17e065e491d5eb686.1745935840.git.csantosb@inventati.org> <87cyc8hfo3.fsf@gmail.com> User-Agent: mu4e 1.12.9; emacs 29.4 Date: Mon, 19 May 2025 10:12:11 +0200 Message-ID: <875xhxf290.fsf@inventati.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >ven. 16 mai 2025 at 22:02, Maxim Cournoyer wro= te: Hi Maxim, Thanks again for your improvements ! > The change log should be part of the commit message proper. Just for me to know next time, I=E2=80=99m a bit confused: the change log= must appear below commit message itself, or be part of the patches ? C. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaCrn2xccY3NhbnRvc2JA aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgmiOAQDQj9rUOYd1yygyQPnEbTcyIn1m nchIkn+DXQ1nEuAOBgD/TxcrvGPXy3db7ytkXJ46cbO214q41PiWoDXmGbP/4wc= =Cbk0 -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Jun 13 10:10:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#78137] [PATCH electronics-team] gnu: gtkwave: Update to 3.4.0-0.bb978d9. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 May 2025 23:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78137 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cayetano Santos Cc: 78137-done@debbugs.gnu.org, Ekaitz Zarraga Received: via spool by 78137-done@debbugs.gnu.org id=D78137.174769624110509 (code D ref 78137); Mon, 19 May 2025 23:11:02 +0000 Received: (at 78137-done) by debbugs.gnu.org; 19 May 2025 23:10:41 +0000 Received: from localhost ([127.0.0.1]:47482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uH9d2-0002jN-NB for submit@debbugs.gnu.org; Mon, 19 May 2025 19:10:41 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:55531) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uH9cz-0002iV-HD for 78137-done@debbugs.gnu.org; Mon, 19 May 2025 19:10:38 -0400 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-7fd35b301bdso5622771a12.2 for <78137-done@debbugs.gnu.org>; Mon, 19 May 2025 16:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747696231; x=1748301031; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1hzrJZ9EYde4YZDlwPQ0tF0NM0R0i2tGlCuzP9X8+tQ=; b=OGyJPD8D2lYlPhko06WhVkP5iUPM2R65Pzb8Wwak//MqZhvnkr2n/PfxFqcggeAE0Y KJG3+I4caV+vB2okt5cyd7HqpmjZKWptf6onXYcv1iKmd3IvwLhFXbSnBx6wHCcJ/ML+ L2nij94nKtkxCt0O5BYehvPOsmXDdOVn6of+oLdLVSNEDjCOo6CLmGrKjOWX2HxJiH2f BD0fcHGJjcUQ5PcP0KtrBPNQA6VDk4nadhOdNOlRx/Z9j9uUeZ3O1jPWzAXfDieNixwM K/wDviwWfM/oa4abpfO9n9SoHfLuUqNN1qY+v9qbCUu5oUeyYcZIRul+dE/OkfD75JBG SuaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747696231; x=1748301031; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1hzrJZ9EYde4YZDlwPQ0tF0NM0R0i2tGlCuzP9X8+tQ=; b=cTMMJCnAxEUCdZPjvZ4GwIKi0FpvmXzfBP2/mriugeYv9YIgS1fngllVg6gWIdNPwA U6uk4KAroCVAXEZ1mS15NBKQkHpgR7z4qKpYLDRUU4qCh6+j2SgiMnPE8vdIMk5+7Slz oPg37JZuy0vh9Z36zCSxMB40W3eO1CdqHqXm3zsqcqRPPTRSELJi6RJg02BJyk2QvG02 3wKcVck8nw8SjMundCEdW8NdAWwkXZyFrCHhnDuWwiWdLHqfGjeyfyd4UPlStnJMFDq0 P/wMYy3KhN4ma7muBgDRm9MlMrb2WgnGX91iGfXwabAWOYvWdAT/Zv8TT+I6RCgU/YOg gNMw== X-Gm-Message-State: AOJu0YziX5xD2lQiKkLrhYM2UuymaeseWgsqwD6JQ1qCvc3RjBCMQzyN 7jKk4gkHi4NAY7wPj77kklXyFFlTfxhaiLWwCB1OUcZH/e9fcNHWvF1X X-Gm-Gg: ASbGncsc5X+esPmQbdKdeSnUh/Djizh/txOYkoahnxTQLUQCdjum4EpK/k2bZ0317MO DwZR+H7XsSKZ4V3rI3hyI91HrgMDlIT5Pz0ivoNq69WzGf9U7h9R7zCy4KUQOaUL2myZgcolUPe E5ViyrXdYVxAljlF3ZcZPF9tZ1xfUqH7m7QVkPdgAjHSulENWgoJsCdaGP42fVnI6dTi7HSMwXz G0d/FT23OKcRzUWit6O/7dzLGRgGubkGo3so3kDpHr+CFzweMsEn7YtPpRJSM6I+3u4Q41dVJpJ upvVROGqHC32t6qq1P09/G59JrSGk4+qpJ1Yz+QH+fBTRD1wmQ== X-Google-Smtp-Source: AGHT+IGvUeh3y5odMVRkD5ATVGQb06rblkrf2uuB8xWu9zjUJSHViSMBO1C8oK/lnPmKzbiO68O2gw== X-Received: by 2002:a17:902:e808:b0:22e:3eb9:471b with SMTP id d9443c01a7336-231de36ba47mr174326675ad.23.1747696231050; Mon, 19 May 2025 16:10:31 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-231d4ebb100sm65325355ad.189.2025.05.19.16.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 May 2025 16:10:30 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <875xhxf290.fsf@inventati.org> (Cayetano Santos's message of "Mon, 19 May 2025 10:12:11 +0200") References: <637fef4126c2b44d8fc82ce17e065e491d5eb686.1745935840.git.csantosb@inventati.org> <87cyc8hfo3.fsf@gmail.com> <875xhxf290.fsf@inventati.org> Date: Tue, 20 May 2025 08:10:27 +0900 Message-ID: <87o6voci3g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Cayetano, Cayetano Santos writes: >>ven. 16 mai 2025 at 22:02, Maxim Cournoyer wr= ote: > > Hi Maxim, > > Thanks again for your improvements ! > >> The change log should be part of the commit message proper. > > Just for me to know next time, I=E2=80=99m a bit confused: the change l= og must > appear below commit message itself, or be part of the patches ? The complete git log message has to look something like this: --8<---------------cut here---------------start------------->8--- Summary line Optional explanatory text (rationale, etc.) paragraph. * some/file.scm (compute-something): New procedure. <-- This is where the GNU change log starts [...] any git trailer (such as the automatically created 'Change-Id:') --8<---------------cut here---------------end--------------->8--- I hope that helps! --=20 Thanks, Maxim