GNU bug report logs - #78128
[PATCH] 31.0.50; csharp-mode compilation-mode incorrectly matches filenames when output contains leading spaces

Previous Next

Package: emacs;

Reported by: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>

Date: Tue, 29 Apr 2025 09:32:02 UTC

Severity: normal

Tags: patch

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 78128-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 78128-done <at> debbugs.gnu.org
Subject: Re: bug#78128: [PATCH] 31.0.50; csharp-mode compilation-mode
 incorrectly matches filenames when output contains leading spaces
Date: Thu, 1 May 2025 00:53:59 -0700

> On Apr 29, 2025, at 2:31 AM, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
> 
> Hey everyone
> 
> When using csharp-mode (or csharp-ts-mode) in Emacs, and you invoke M-x compile with "dotnet build", sometimes errors in the compiler output will contain leading whitespace (especially for nuget errors).
> 
> The expressions defined in csharp-mode.el does not account for this leading whitespace, and in those cases will capture it as part of the filename where the error occurred. This leads to failure to navigate to the point of error.
> 
> Attached is a patch which corrects this bug.

Thanks! I applied the patch to emacs-30 since it’s a bug fix. BTW, checkout the CONTRIBUTE file under emacs repo root for the commit message convention. You can also just take a look at the commit messages in git history. If you use magit, you can just press C with point in a hunk to automatically insert the correct commit message entry to the commit message buffer.

Yuan



This bug report was last modified 17 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.