Subject: bug#78128: closed (Re: bug#78128: [PATCH] 31.0.50; csharp-mode compilation-mode incorrectly matches filenames when output contains leading spaces)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 01 May 2025 07:55:02 +0000

Your bug report

#78128: [PATCH] 31.0.50; csharp-mode compilation-mode incorrectly matches filenames when output contains leading spaces

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
78128: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78128
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#78128: [PATCH] 31.0.50; csharp-mode compilation-mode incorrectly matches filenames when output contains leading spaces
From: Yuan Fu <[email-masked]>
To: Jostein Kjønigsen <[email-masked]>
Cc: [email-masked]
Date: Thu, 1 May 2025 00:53:59 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

> On Apr 29, 2025, at 2:31 AM, Jostein Kjønigsen <[email-masked]> wrote:
> 
> Hey everyone
> 
> When using csharp-mode (or csharp-ts-mode) in Emacs, and you invoke M-x compile with "dotnet build", sometimes errors in the compiler output will contain leading whitespace (especially for nuget errors).
> 
> The expressions defined in csharp-mode.el does not account for this leading whitespace, and in those cases will capture it as part of the filename where the error occurred. This leads to failure to navigate to the point of error.
> 
> Attached is a patch which corrects this bug.

Thanks! I applied the patch to emacs-30 since it’s a bug fix. BTW, checkout the CONTRIBUTE file under emacs repo root for the commit message convention. You can also just take a look at the commit messages in git history. If you use magit, you can just press C with point in a hunk to automatically insert the correct commit message entry to the commit message buffer.

Yuan

Subject: [PATCH] 31.0.50; csharp-mode compilation-mode incorrectly matches filenames when output contains leading spaces
From: Jostein Kjønigsen <[email-masked]>
To: [email-masked]
Date: Tue, 29 Apr 2025 11:31:02 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hey everyone

When using csharp-mode (or csharp-ts-mode) in Emacs, and you invoke M-x compile with "dotnet build", sometimes errors in the compiler output will contain leading whitespace (especially for nuget errors).

The expressions defined in csharp-mode.el does not account for this leading whitespace, and in those cases will capture it as part of the filename where the error occurred. This leads to failure to navigate to the point of error.

Attached is a patch which corrects this bug.

—
Kind Regards
Jostein Kjønigsen

￼