Subject: bug#78118: closed (Re: bug#78118: [PATCH] ; Isearch: Fix key bindings in documentation string)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 29 Apr 2025 01:12:04 +0000

Your bug report

#78118: [PATCH] ; Isearch: Fix key bindings in documentation string

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
78118: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78118
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#78118: [PATCH] ; Isearch: Fix key bindings in documentation string
From: Sean Whitton <[email-masked]>
To: Jake Forster <[email-masked]>
Cc: [email-masked]
Date: Tue, 29 Apr 2025 09:10:56 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Thanks, installed on emacs-30 and closing the bug.  I added the bug
number to your commit message and fixed some typos.

-- 
Sean Whitton

Subject: [PATCH] ; Isearch: Fix key bindings in documentation string
From: Jake Forster <[email-masked]>
To: [email-masked]
Date: Mon, 28 Apr 2025 13:31:55 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello

The documentation string for `isearch-allow-motion' describes commands to
be invoked during Isearch, but the key bindings shown are for the
help-key-map, not for the isearch-mode-map.  This patch specifies the
keymap to fix the key bindings.

Kind regards
Jake

In GNU Emacs 30.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.43, cairo version 1.18.2)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101015
System Description: Guix System

Configured using:
 'configure
 CONFIG_SHELL=/gnu/store/m0xdsa8cfq6mq1kxgxmpmpg71la4f0b9-bash-minimal-5.1.16/bin/bash
 SHELL=/gnu/store/m0xdsa8cfq6mq1kxgxmpmpg71la4f0b9-bash-minimal-5.1.16/bin/bash
 --prefix=/gnu/store/rk4ayiybm76qz0g96v3wa5xkmzfayryg-emacs-next-30.0.92-0.881d593
 --enable-fast-install --with-cairo --with-modules
 --with-native-compilation=aot --disable-build-details'

<#part type="text/patch"
filename="~/emacs-local/0001-Isearch-Fix-key-bindings-in-documentaion-string.patch"
disposition=attachment>
<#/part>
From 7d1749ed7358503fad59079e0b7df937f63a20f6 Mon Sep 17 00:00:00 2001
From: Jake Forster <[email-masked]>
Date: Mon, 28 Apr 2025 22:22:18 +0930
Subject: [PATCH] ; Isearch: Fix key bindings in documentaion string

* lisp/isearch.el (isearch-allow-motion): Use isearch-mode-map for
commands in documentation string.
---
 lisp/isearch.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/isearch.el b/lisp/isearch.el
index e37d1814eb7..ea7c5f23dec 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -3051,7 +3051,8 @@ See also the related option `isearch-allow-motion'."
 
 (defcustom isearch-allow-motion nil
   "Whether to allow movement between isearch matches by cursor motion commands.
-If non-nil, the four motion commands \\[beginning-of-buffer], \\[end-of-buffer], \
+If non-nil, the four motion commands
+\\<isearch-mode-map>\\[beginning-of-buffer], \\[end-of-buffer], \
 \\[scroll-up-command] and \\[scroll-down-command], when invoked during
 Isearch, move respectively to the first occurrence of the current search string
 in the buffer, the last one, the first one after the current window, and the
-- 
2.49.0