From unknown Wed Jun 18 23:06:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78106 <78106@debbugs.gnu.org> To: bug#78106 <78106@debbugs.gnu.org> Subject: Status: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks Reply-To: bug#78106 <78106@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:06:02 +0000 retitle 78106 [Feature Request] EGLOT: Optionally make code action indicati= ons use mouse clicks reassign 78106 emacs submitter 78106 Jo=C3=A3o T=C3=A1vora severity 78106 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 28 03:21:23 2025 Received: (at submit) by debbugs.gnu.org; 28 Apr 2025 07:21:23 +0000 Received: from localhost ([127.0.0.1]:52114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9Inq-0007xk-T2 for submit@debbugs.gnu.org; Mon, 28 Apr 2025 03:21:23 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53794) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9Ink-0007wD-Dr for submit@debbugs.gnu.org; Mon, 28 Apr 2025 03:21:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9Ine-0002hG-RT for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2025 03:21:10 -0400 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9Inc-0007QB-3E for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2025 03:21:10 -0400 Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-72c172f1de1so2800942a34.3 for ; Mon, 28 Apr 2025 00:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745824866; x=1746429666; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6VKrebhmS8zHChlIpO0QyM2v+9JEqU42F3hyeNCL3xM=; b=EVV7eEdq+1zB1PhVMS66kfstjsboH0iQYQ+fZUpOYX06Zq8VAuZPVTEkh88f8cg7bX doa1sV0eOiz7KhL/atbw7bD+XbzeIiRwAE3RKZETwW+6QtvwZYNJb00Iy4NX+cD670V8 LLrc3FjM+bbqY3Vzu6X3nJ0DTkzaNby2tJvgDvyr9UA13pkPznD3dStiVTjYWLwmj9Wz JZvr4jtUastEafOGJzifXRGav+zXE67JCUkQDgT6iMs3m61sqlYAEJF567AsIILbJlOL 1YJ/1mQkRIJXa+pN3DYdz2yGJaTDTSdwnsaOtMOYTHAf+OS5Nnyj0n30xKtjqr+snJDE a5Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745824866; x=1746429666; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6VKrebhmS8zHChlIpO0QyM2v+9JEqU42F3hyeNCL3xM=; b=lU+SpEmAHEgyjdaa3wP7Fa6Q1u4i9sWNfTCj9vAC8MnUfsIl1u0ghcBQCOLT2NNi2R 9kdWaAkusU+LrLL4TcfG3HloAOUJx1t7SAhI88GfhM7jnxBBp63x4xsvLl1t98qEiG4R Xc8m+bp98IHrQAYA+qHqRQeIdYpHfPhXktcXnh5zs1CZWa1roqBMq03rszRRR4wpX9/T ZqqeYw5JdIlogVportbzMH7WjWygXR4KNG6phaRh3Ifcgjn2+L6aHrBTdPFOoQFQ5qzx eyyKITXLdb1EDyCocDcOItM6i5zXTOxdj7QaORVxWZO3J9x+Jotdicv/8fGOxwavLLAF mGVg== X-Gm-Message-State: AOJu0Yy2nml+gZH/pfABQz+3MKYNl907TDDWtfNjxgAHlGviaKgnBPkc SQ+xI0tKRyE0GLXKjUC3QB2aHFb5657C9LaRrmOVoPz3TNzh+P9lqs25P2DvpfzMVjMlvWALjle QxswBknA8jsOo5g7QcIb/PQESub0= X-Gm-Gg: ASbGncu/C2GnBRzFJX2Tb1Pu1lizm3QEXjCy0J7PFOpxzuSsVMLAFo43mhN65/IMAvC iCZczqxi4OEtEb31+R3rU+KPwI7HYhgMZvcESoR/87wzAJ/MNZ3IMa5tryB7UagTD3VA1QB7K80 +ONjkqt3plXkhSX9/aHgqJTg== X-Google-Smtp-Source: AGHT+IF+YT0yTIZPTpANDbDU7PtKGs3SE3dMCZ4x/XU9dt0nVcaRH5ykIWFN8jsiDipibKjokEBY7LjODC8JoURg1Ac= X-Received: by 2002:a05:6870:70aa:b0:2c8:340d:1076 with SMTP id 586e51a60fabf-2d99de66b68mr6013469fac.32.1745824866134; Mon, 28 Apr 2025 00:21:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 28 Apr 2025 08:20:55 +0100 X-Gm-Features: ATxdqUGMFZY9ogxxilipFOBWapoiSBHqyCBVGdqU5RgtEthXaW8JtZlN0onjJOc Message-ID: Subject: Re: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= Content-Type: multipart/alternative; boundary="000000000000fc70ac0633d186d1" Received-SPF: pass client-ip=2607:f8b0:4864:20::334; envelope-from=joaotavora@gmail.com; helo=mail-ot1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "simon254--- via Bug reports for GNU Emacs, the Swiss army knife of text editors" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000fc70ac0633d186d1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable They should be mouse clickable, though the margin and fringe are contested for multiple functions (like opening the Flymake diagnostics buffer when theres a diagnostic on the line). So please provide an Emacs -Q recipe for reproducing your problem exactly. Jo=C3=A3o On Mon, Apr 28, 2025, 05:21 Elijah Gabe P=C3=A9rez wro= te: > In the current branch (master), i've noticed the > addition of `eglot-code-action-indications`. > However, the indications cannot be clicked, > for example: If i click any indicator (margins, > modeline, and others) it should execute > `eglot-code-actions'. > > Maybe there should be an option in > =CB=8Beglot-code-action-indications` for enable mouse clicks? > > Thanks. > -- > - E.G via GNU Emacs Android port. > > --000000000000fc70ac0633d186d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
They should be mouse clickable, th= ough the margin and fringe are contested for multiple functions (like openi= ng the Flymake diagnostics buffer when theres a diagnostic on the line).

So please provide an Emacs= -Q recipe for reproducing your problem exactly.=C2=A0

Jo=C3=A3o

On Mon, Apr 28, 2025, 05:21 E= lijah Gabe P=C3=A9rez <eg642616@gmail.com> wrote:
In the curren= t branch (master), i've noticed the
addition of `eglot= -code-action-indications`.
However, the indications = cannot be clicked,
for example: If i click any indic= ator (margins,
modeline, and others) it should execu= te
`eglot-code-actions'.
=
Maybe there should be an option in
=CB=8Beglot-code-action-indications` for enable mouse clicks?

Thanks.
--=C2=A0
- E.G via GNU Emacs Android port.

--000000000000fc70ac0633d186d1-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 28 19:33:09 2025 Received: (at 78106) by debbugs.gnu.org; 28 Apr 2025 23:33:09 +0000 Received: from localhost ([127.0.0.1]:39231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9XyG-0006gR-Rr for submit@debbugs.gnu.org; Mon, 28 Apr 2025 19:33:09 -0400 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:47175) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9XyA-0006eS-M8 for 78106@debbugs.gnu.org; Mon, 28 Apr 2025 19:33:05 -0400 Received: by mail-oi1-x244.google.com with SMTP id 5614622812f47-3fb3f4bf97aso1646504b6e.2 for <78106@debbugs.gnu.org>; Mon, 28 Apr 2025 16:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745883176; x=1746487976; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4VI7VPZUXjXNN6alrBJajsSAA4urQ5w0O7D1dbRl9U=; b=HKLGZ/IG2GgTfPHV2cWVpmdtBewEgp/jcwDNG+DVkcpUOeraQi0j3ddXdJmU3Gtb6a WaCyHzuKG8t+F5B3xmATiuZwizYrnmxjRwt1g/sZXVu34yM9uy6XNzjfiHtWTSuAa5X9 ZGrCvJA1ax585i34N/dElmtpdf1W2ip9konXhEbMdcxEw2o7kzQqNCFYvISaJzn9l5M0 ciE8Rr+uO1luwqbNA9pLQwvR1fjGFAIQy2h3Ut9u+nKu6WBUG9zdQzI3fRPQO6YtWbY+ Wezv5heDxm8yZByKTjDxytwo0U4nu+bShGwAa6NXXWJ7lDjE9OJeLet3KToybeswtlV+ XSHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745883176; x=1746487976; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U4VI7VPZUXjXNN6alrBJajsSAA4urQ5w0O7D1dbRl9U=; b=EJqLThhFkHAwrNcga1y9MGarv860yzosLMYHUsFkpt0JgVlJ5Yqs2Jr2Mb9dUTK6YF YtwcfGJYk89JTdpBDjhXQcVtCB9z929yALSjtMIVTkAlJqxic2Rs28OvLts6+w/Fltxf ftHrXJ84z57SDdUleviF6gx+PEMSZRVSgDOXHc/IsND9EDAru49aptYnpyflVLvTmxXQ JBFMxPejuYzcs0b8s2t4PO8R3P2NIi7nsCV5DM9SGwM0CR1xkqQVbzQzqGqS1QWH/udz TzmZBlkV9ptWG7wWDUsdf8+nKJYqcIHp6T9UDdU5C09fkkPq0IcyTv0dNH3At82+MEBL IjyQ== X-Gm-Message-State: AOJu0YxOX/DUHDGUpF05l0/MyMmKHi3zY6j61p94LuT9nLkHETPxQ1wh dUzLKosJzx0JBMJo0cIXXprBl+GKn3wklzSu+vk1mn2rwX43IVD0EnKAll9U X-Gm-Gg: ASbGncspPgD5WMwae4bjEKE3a0uOEE5DI+fFmKTPqOMfeZiM/f/+mA20aV1kviMGx98 4e14xIM/znqsZTgQCK8SXzH3OuyKxH74Ki2w8JifUR4f9rVBrf2TOrDN30LWoHMlvX4lPfr+ZGw Z2rsWC3BKv84l5jhAOnTtD9+xm2NhiI6SQ1QUOLOjrNk3K1MrGVJbfEIyHwKwkNFqzaQlNTOTtq WNamiFlhMSSJ2dI83XdX3OWFryB9FYJmO27y5AU9UnVJljRdEoAqMAtf/R/7Rx9o3UKAzcUyEMr L03FWUvIPa3t3FB33pA= X-Google-Smtp-Source: AGHT+IF/PAfYn7yL/VrgkkdbDwfGLLLfVtsjSOBlkNUCoz3oYfVQ6qBdGqlQ4QjJ+Erv2r/2PLLd+w== X-Received: by 2002:a05:6808:3a14:b0:3f6:6a86:d0ce with SMTP id 5614622812f47-4021154c0f3mr542188b6e.2.1745883176185; Mon, 28 Apr 2025 16:32:56 -0700 (PDT) Received: from fedora ([2806:10ae:e:8863::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-402124f84e6sm41783b6e.0.2025.04.28.16.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 16:32:55 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: References: Date: Mon, 28 Apr 2025 17:32:54 -0600 Message-ID: <87frhrzwt5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jo=C3=A3o T=C3=A1vora writes: > They should be mouse clickable, though the margin and fringe are conteste= d for multiple functions (like > opening the Flymake diagnostics buffer when theres a diagnostic on the li= ne). > > So please provide an Emacs -Q recipe for reproducing your problem exactly= .=20 1. Run emacs -Q 2. eval: (set-window-margins (get-buffer-window) 3) (setopt eglot-code-action-indications '(eldoc-hint margin nearby mode-line)) 3. Open a file which supports eglot (example: any Emacs C source file) and enable eglot. 4. Move cursor/point to where there is any code action available. (for example in any Emacs C source file, move to any DEFUN or macro) 5. And click the =F0=9F=92=A1 icon where it appears (margin/mode-line/befor= e point). It doesn't nothing, something curious is that with mode-line/nearby options the lightbulb icon have a `mouse-face' property, which gives the impression that you can click it. --=20 - E.G via GNU Emacs and Org. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 30 10:07:13 2025 Received: (at 78106) by debbugs.gnu.org; 30 Apr 2025 14:07:14 +0000 Received: from localhost ([127.0.0.1]:43455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uA85h-00065J-DC for submit@debbugs.gnu.org; Wed, 30 Apr 2025 10:07:13 -0400 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]:61740) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uA85e-00064z-1K for 78106@debbugs.gnu.org; Wed, 30 Apr 2025 10:07:10 -0400 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-2c769da02b0so6170721fac.3 for <78106@debbugs.gnu.org>; Wed, 30 Apr 2025 07:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746022023; x=1746626823; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+ac8cmGIYZ5fWQhcBOKXK8Iql1gGCpNVVl7GsPBUOZc=; b=CcRy0gm4PsC/ZpG+DJisIfDR1y0bFBclSk9hL/MOgX3WC5dvplXf+xFlttqlTlcX2f 4T5+waBoOwpns8ASfwA8Twql0FcdKg7SZ2l7SYpOKSR7M62BPqo7FmH7wDiA1Rv/hl2o PBP37j7RCtVAmDO4zDp3qSojFCrz9tqZmDINdfMntpjYtZVpHKcLVHeL2eUDTaqrPLyu H+S5fmJutJHa3ND+s4oWOvbfqloR65EM23BFcewBNDegClLzYLjuomB8q+h5eT5cT2+W 5Q5Wam+Ly3Zfe6cGrDDWCXCaaz4mXiVjYBp71lujDW8f/nfYhBWdiFVafGZ/HUWhMFgt tQsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746022023; x=1746626823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+ac8cmGIYZ5fWQhcBOKXK8Iql1gGCpNVVl7GsPBUOZc=; b=LZEf6/+btbL6AotMdeO/U8n1SuIdEkFlfT2VEWMMckzBNVutUQ2wHnprDecO5nYBjl l3zs8qzzNOKRO4jxaWk6iYYBB6lTrRdn/+N9n7QZMmerzhfV5vpLz3SLY0jsMy/cd8/h FzZmKEuPAB/bFOTA9NH+kLvP4ll2oM1gQApFP3aEXS2lIqzBTV6d3jh2WQw9WiP0OTpZ 2NDDdC9i7gC9I3ukd5e4hCrLN0jBHn/PTI2x7i7ZVqlqivkpDuIdJy5BLzHIOuIJCRyO yOour/hgxye3UWjTawI2ye+a6Pw/tSlWQDEhxnFRDPK60A+jy3JTOcUAuwxZZtgcz42A tQDA== X-Gm-Message-State: AOJu0YwbiHmRgY+80Bw33945rGZD34Snun+VdoS6/WWFdVBP/YYIn5YP wcKJsiYFGaEhwKzxvLxu3MsXEarft4E3njiwJhggv1i/Jpit5CrtTkiNBWQ0lcDMs81v1hT2z4L 94cN0JmuPkhWz7wjmU2lwLUZKVkY= X-Gm-Gg: ASbGncvn08Fo3UCq+qJNCKDYFjIHvYyMwMvCn7blaxRprlMxN/wyFsa0VyemePQKF9r bAbZZvncOv4Bd9y5byV2TDVXiuAJzW7W2ncj2wMYT3Tbqp1cqLxgEDm7QQPsTuYN0CRXaf5idpZ HqfVV6eGyFtmOpSZimmW2fuQ== X-Google-Smtp-Source: AGHT+IGcfag/Qq0evCFfXP2En6ykNfPXLaV0jvILYgUt1kDu6qH+o0jBbiAs98J0UZxEJrHhYEi/xMRUe6FwP9mrtB4= X-Received: by 2002:a05:6870:888b:b0:2bc:69d8:a39e with SMTP id 586e51a60fabf-2da6a3ace81mr1749874fac.33.1746022023298; Wed, 30 Apr 2025 07:07:03 -0700 (PDT) MIME-Version: 1.0 References: <87frhrzwt5.fsf@gmail.com> In-Reply-To: <87frhrzwt5.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 30 Apr 2025 15:06:52 +0100 X-Gm-Features: ATxdqUEoOPhIWFd46ij18LhMVRWOw6zTkRtVSvJFhLiLc8mWlUnLTNlw8WVQxp0 Message-ID: Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= Content-Type: multipart/alternative; boundary="00000000000078031f0633ff6eb0" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000078031f0633ff6eb0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Try clicking with the middle mouse button. It's the same button you use when clicking a diagnostic that has an action. Jo=C3=A3o T=C3=A1vora On Tue, Apr 29, 2025, 00:32 Elijah Gabe P=C3=A9rez wro= te: > Jo=C3=A3o T=C3=A1vora writes: > > > They should be mouse clickable, though the margin and fringe are > contested for multiple functions (like > > opening the Flymake diagnostics buffer when theres a diagnostic on the > line). > > > > So please provide an Emacs -Q recipe for reproducing your problem > exactly. > > 1. Run emacs -Q > 2. eval: > (set-window-margins (get-buffer-window) 3) > (setopt eglot-code-action-indications > '(eldoc-hint margin nearby mode-line)) > 3. Open a file which supports eglot (example: any Emacs C source file) an= d > enable eglot. > 4. Move cursor/point to where there is any code action available. > (for example in any Emacs C source file, move to any DEFUN or macro) > 5. And click the =F0=9F=92=A1 icon where it appears (margin/mode-line/bef= ore point). > > It doesn't nothing, something curious is that with mode-line/nearby > options the lightbulb icon have a `mouse-face' property, which gives t= he > impression that you can click it. > > -- > - E.G via GNU Emacs and Org. > --00000000000078031f0633ff6eb0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Try clicking with the middle mouse button. It's = the same button you use when clicking a diagnostic that has an action.=C2= =A0=C2=A0

Jo=C3= =A3o T=C3=A1vora

On Tue, Apr 29, 2025, 00:32 Eli= jah Gabe P=C3=A9rez <eg642616@gmai= l.com> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:

> They should be mouse clickable, though the margin and fringe are conte= sted for multiple functions (like
> opening the Flymake diagnostics buffer when theres a diagnostic on the= line).
>
> So please provide an Emacs -Q recipe for reproducing your problem exac= tly.

1. Run emacs -Q
2. eval:
=C2=A0 =C2=A0 (set-window-margins (get-buffer-window) 3)
=C2=A0 =C2=A0 (setopt eglot-code-action-indications
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(eldoc-hint margin nearby mo= de-line))
3. Open a file which supports eglot (example: any Emacs C source file) and<= br> =C2=A0 =C2=A0enable eglot.
4. Move cursor/point to where there is any code action available.
=C2=A0 =C2=A0(for example in any Emacs C source file, move to any DEFUN or = macro)
5. And click the =F0=9F=92=A1 icon where it appears (margin/mode-line/befor= e point).

=C2=A0 =C2=A0It doesn't nothing, something curious is that with mode-li= ne/nearby
=C2=A0 =C2=A0options the lightbulb icon have a `mouse-face' property, w= hich gives the
=C2=A0 =C2=A0impression that you can click it.

--
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -= E.G via GNU Emacs and Org.
--00000000000078031f0633ff6eb0-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 30 14:08:44 2025 Received: (at 78106) by debbugs.gnu.org; 30 Apr 2025 18:08:44 +0000 Received: from localhost ([127.0.0.1]:36141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uABrQ-00015y-Fp for submit@debbugs.gnu.org; Wed, 30 Apr 2025 14:08:44 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:54409) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uABrO-00015k-Ne for 78106@debbugs.gnu.org; Wed, 30 Apr 2025 14:08:43 -0400 Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-7403f3ece96so324797b3a.0 for <78106@debbugs.gnu.org>; Wed, 30 Apr 2025 11:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746036516; x=1746641316; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4BFEsVhOXBTLH0tGPzPog8rypRxxQFyWLO6VgjfrCoA=; b=Gva3qxzcQouaXzhPakHMJSQbyoR/0Tcrp94p1Wb6+ItN3UZPM8id1BcjszW1v/xpMR /AeqzetkK1FEk1STOp7+9UhOkp16ZNgdb8jqHiX0zZKk5ZcPgA2BrjLElekNZNc1Svgk E+G9AT0FbHK65+CUbF9ud+77Jed2Kojqi4pw5PjXu3Tvq4P63AedEuJhQKTTo1LznXWz ROjalsJhL1iQvZX4tihQBJGmQZPqgB/rkl8AGOBiZ+54XzSW1t6d9oU2iv+iIM2fVluF MDGeETB4BL5X4WMWEQDgDJJLudc2b3P4tYiMsbzedv7cw6/2eVP6WGL3UyfFUagjlKhj VpnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746036516; x=1746641316; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4BFEsVhOXBTLH0tGPzPog8rypRxxQFyWLO6VgjfrCoA=; b=aUqlbFevJ3eQIdHgh5+2LZR0JCPwBiBDXuk3EfYVIuzDjwE5+YUJx//WqbcvR5pVWc GL4tjYLQ0bH1FnZ9UjeVVdYWhaMuLbpH8fe1UiaMvtu0kR1D+F534Ck38Ux4Hd+QdclT 1KS1/KCeBZU+DctgUzglEJv7xEnh9ezoAYctcHEzY2xhbfJXH8ZijICPpYETzuZOzNEh HU+gnLfr60s2S9f+0RIFivk4VGnzWN9YuZnM94tE+frjOHAqMwR8UGqAHO4kbNHCJU9L qp3VrOAIQVqrTyX0Pfh/54j00ULKKfzAtaSwedZOdwPGJtvUj2wGhZet+9/ddrGsArH+ 7mgQ== X-Gm-Message-State: AOJu0YxMhNmz/j+d9hnqXjdEjuczsMLHRkfdlPtUwiXCP6ajE8OrO5vN tooR1tZA27o5qa39i8t8/IGD9UP/EyYDKet33YfH6xWjmPj7SxJLy91Yto+b X-Gm-Gg: ASbGnct7tkSDnyFZGJeEH59x5arwQDwx/o9DZFGLrctjTbQet+EOuMkfLWihw4RciqK 2bADxT+S5mlXTYVZOk4+NDZWQnMc7iDRTIN68yZbcvuQT9D5i8BruK2fT+py0CZkqxLHuQllchQ b6t8lS+xCwpEFQIjdBKrpIMlwCSUby+n7OwbNK2slsXT7A0jM38lrUj0qyMIj1Nqp3zPaV//Aic kxjfuY4JAWssLPhlaA+igsaBxZjzSF2IGf5K8SHaUdpbQJZuXypxlWlrjLVuYxcIY7UwmC59CXi tRRPDlLkZzUGnPxs/o0= X-Google-Smtp-Source: AGHT+IGsIvFIuYANHDKhh3ECCJiMOXp2bJGIjZUdD/nxgSBjoMQyZPGO2+WP9FALPs4yoBk9BYmlTQ== X-Received: by 2002:a05:6808:3988:b0:400:fa6a:d9f6 with SMTP id 5614622812f47-402d1971945mr2114141b6e.25.1746032218949; Wed, 30 Apr 2025 09:56:58 -0700 (PDT) Received: from fedora ([2806:10ae:e:8863::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40212a59abbsm902590b6e.34.2025.04.30.09.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 09:56:58 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: References: <87frhrzwt5.fsf@gmail.com> Date: Wed, 30 Apr 2025 10:56:57 -0600 Message-ID: <87selppoyu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jo=C3=A3o T=C3=A1vora writes: > Try clicking with the middle mouse button. It's the same button you use w= hen clicking a diagnostic that > has an action.=20=20 But it doesn't work for the mode-line if i set `eglot-code-action-indications' to '(mode-line), mouse-1/2/3 does nothing there. Also should not the indicators `help-echo' say something like: "or mouse-2 for execute code actions at point" too? --=20 - E.G via GNU Emacs and Org. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 30 14:58:33 2025 Received: (at 78106) by debbugs.gnu.org; 30 Apr 2025 18:58:33 +0000 Received: from localhost ([127.0.0.1]:56942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uACdc-00039v-Qz for submit@debbugs.gnu.org; Wed, 30 Apr 2025 14:58:33 -0400 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:61445) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uACda-00039J-HX for 78106@debbugs.gnu.org; Wed, 30 Apr 2025 14:58:31 -0400 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3f6dccdcadaso179422b6e.2 for <78106@debbugs.gnu.org>; Wed, 30 Apr 2025 11:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746039504; x=1746644304; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hTnsYbWiJZimks9JwFXFSo3hv/8qXOViHbeJHlNhV44=; b=XcTanoH2Y9Mq3J0hKUa1DYYcydqRBLMiSdLXVFuPS2ddeXqbVGSNoptscSQqXv86s9 aE2OA9zS7C2OeZqcdXY/gETnMLKrU1piyqhynDWVifV6weM49w/2l4hoUQcVkPGielOI k+EDcfaJXacFi4bmNbhXE8b264urKn01IB7UACSXGLotb6BZL33eoZPhPAvVITdvHRfL UxG9UzPNry79lla/+UCp0F7PwpEsqTsdd1A7bHks4BhVCUZgX5Odj0gy7cDlQa9TAB6X 3VTMhSL9CQpRmv/PP8FL6WPl6wB4lhxI3bd+6W6bchHyU6mVJ7HK/CAYE2vNfU+K4xjF XUkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746039504; x=1746644304; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hTnsYbWiJZimks9JwFXFSo3hv/8qXOViHbeJHlNhV44=; b=krq21oWn74SnELPqtDHmq9JKxJ24mAjAwfiUCvJ2suQAlhSBATKBFaoh7F0npHnzEd hhbWDvaIX+l6D7U9b6SFOaXGymY56lVhGo5SGkG6284x8IX3YSycXMAOC5ZErCfwSGcJ coGIpRUvP2i/F40a2XlHTY0lLPAYVbwn2ATdoRtYpwJNaPCbSIoCMoDJvqXj2xW8VTnO 7fAWLKhP0i8xgpXLhsbNkIuvit5/dptf2xbzzCZepzVJHf3rE8iBvJU7zs8VSwS2CDss NdGE/gojosd3q6OjXiLOAiB7TQbHRpRHIjrU7meudi8veNw7oOOM3FOVwj3+ezE/zqZo rvIA== X-Gm-Message-State: AOJu0Yz/YYbkHgBWVNkLqr7AOVTK4/tYpPxG7qk1yM31ZtRKpk21bbZE 8GIrBhbFr0e0psECV/qb9Hj5LqIyFcTeg0IAA4w+5eNMfc17jQH2wqlirW3m3+eXgicJ6u6Z6Sp 58OmzWSxozYfQbY/I9vI9RZaGCoaLHg== X-Gm-Gg: ASbGnct84FTPmITbiKP1Ly0Y0l8tyh04L/k3K4Kl59ahZhsu3wiyGgVBy2K32136Miz NaNtH3fL2LZaAcXLzyhhpagCKlc9NdGc/trwzNeP4GiyLI0mcevQJFL2qzmw3tfEd2gvRb4eaE8 dTiJQln6FZ4cvSDr756ngp X-Google-Smtp-Source: AGHT+IEFM1a8NqdNnh+5/yxHM7ti4gW7Zp334wJ5GqzFgbRCg70ZcBRC2BkvTgo5PAqMmNUyD1BqJCKDcKnajtWUpCM= X-Received: by 2002:a05:6870:8983:b0:2d5:ba2d:80ed with SMTP id 586e51a60fabf-2da6a34229dmr2034964fac.25.1746032659884; Wed, 30 Apr 2025 10:04:19 -0700 (PDT) MIME-Version: 1.0 References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> In-Reply-To: <87selppoyu.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 30 Apr 2025 18:04:08 +0100 X-Gm-Features: ATxdqUHEKCeUkZFpe238si825Q428qLOXhLkGrCiny215T6FPBn93Dl3eFkbiqY Message-ID: Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= Content-Type: multipart/alternative; boundary="000000000000756de4063401e8ff" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000756de4063401e8ff Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Good ideas. Patches welcome, the shorter the better, of course. Jo=C3=A3o On Wed, Apr 30, 2025, 17:56 Elijah Gabe P=C3=A9rez wro= te: > Jo=C3=A3o T=C3=A1vora writes: > > > Try clicking with the middle mouse button. It's the same button you use > when clicking a diagnostic that > > has an action. > > But it doesn't work for the mode-line if i set > `eglot-code-action-indications' to '(mode-line), mouse-1/2/3 does > nothing there. > > Also should not the indicators `help-echo' say something like: > "or mouse-2 for execute code actions at point" too? > > -- > - E.G via GNU Emacs and Org. > --000000000000756de4063401e8ff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Good ideas. Patches welcome, the shorter the better,= of course.

Jo= =C3=A3o

On Wed, Apr 30, 2025, 17:56 Elijah Gabe = P=C3=A9rez <eg642616@gmail.com= > wrote:
Jo= =C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:

> Try clicking with the middle mouse button. It's the same button yo= u use when clicking a diagnostic that
> has an action.=C2=A0

But it doesn't work for the mode-line if i set
`eglot-code-action-indications' to '(mode-line), mouse-1/2/3 does nothing there.

Also should not the indicators `help-echo' say something like:
"or mouse-2 for execute code actions at point" too?

--
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -= E.G via GNU Emacs and Org.
--000000000000756de4063401e8ff-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 30 15:40:31 2025 Received: (at 78106) by debbugs.gnu.org; 30 Apr 2025 19:40:31 +0000 Received: from localhost ([127.0.0.1]:45453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uADIF-0000em-42 for submit@debbugs.gnu.org; Wed, 30 Apr 2025 15:40:31 -0400 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:58388) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uADIB-0000eZ-Pw for 78106@debbugs.gnu.org; Wed, 30 Apr 2025 15:40:29 -0400 Received: by mail-oi1-x244.google.com with SMTP id 5614622812f47-4033201367bso207098b6e.0 for <78106@debbugs.gnu.org>; Wed, 30 Apr 2025 12:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746042022; x=1746646822; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=YL9yU8D9PCtICt25/BsZFPm28w+sZAGTOEZC0nef8Js=; b=hXYhh+E7s+hsIOX1dPIH8Fv7bqmrQnEdZjyHyPlAltiXzp0TIMlPT7kNmygTAx/Pq1 n+7mRK7cUaFmxitz5mV9IE/i4/BTPNTluDYe4Xwc9Up34DmXWAVsSYOCF+0w/wzwun7P 0WQQD3mW0GNm+7AQ7lHxmcZyHpeNJPUYUb5CHP93MVky8tZu+yRzcJAyQ4n5b2zFP34C jMbLgFnRi5ChGiWSY+zGAqO+uRQFSNBZCAFqs5BoyXM53Mp20MiGupecsxmnAXOr1Rw7 q6dD30AkVmZcBgkJjKVpw9+1/KzY0v0lR+tAB4b3/b76+q+ArUtgH8QrkKiRul+np7AN Av6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746042022; x=1746646822; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YL9yU8D9PCtICt25/BsZFPm28w+sZAGTOEZC0nef8Js=; b=B9LDTpPhHfIQzILtSlQMcNKdNzo1MscgvcmImxOiusbzAx1WzHRcXrQgu7A+sCoOgQ KNkMEnIprMyJcvmF8D6To7zdt9rJV/eb49bTc1LOdGs/8wEGoJ0b74/2JIEt4utRboZI houT/XitTbqN2BPCX2iDnh3OABUHB6qf4HB1A9S+BGPzshe9PaObNX3E4y4jI/2KmzlZ H+ZD8HtOM7R0ZA6ZDliym7IgHz+u9Z5f+Gg0VBdexgF1BZ6OxOS3RvCH+QPY0ICuTuCY ergrBJZwKZ88ZabgaINrW0Rj9RqwUvqlulLYGBL18wjiI23O2yoRIPIQKnXcg9uTpUWW bSUg== X-Gm-Message-State: AOJu0Yzc/3/CRBQUjmM0xaSJfhiM77SapaIpgDnkVddNWM7UK2SK2gp6 F46n7ffkFj2AcCbDaa9fbWqsvGdi4grmMJ8xwTRoThlkSJnUiXAPXT9pmdga X-Gm-Gg: ASbGncu8JzYaNxe306MthxwEIrs0HzEg/6FQ5V+hUWpxzQw3qPQAUsb03SCwpSxHmyf QsPGwrx/e4ldpbmymdzWg74vzJSedm3Dx1bfV9AS5hvoqE//E6vlO429Hyeig7562+eIwrIzFTK zCllX0sslYHB8NU4w6E17yJNqcsVop8E7UGHPvV6/iV6uJ0CI9TCyGDbbVkjwtg7p3yRfw8Dm3W v436hxjDZ4LY1e1K6tC/09ee+5pitDmQeR1tlsel6WerPnxPVlOSF6RKS4HYvRLGnhM/Ih4AZyW gi8Ousa1 X-Google-Smtp-Source: AGHT+IEOb9WQMKR9mZEdvSmuzAEA2t+A7p4e96plhJQZRPM7RAudNPmKsB12NfToP8cWecJoXAmIUw== X-Received: by 2002:a05:6808:4444:b0:401:e838:2bb8 with SMTP id 5614622812f47-40239e779d6mr3049578b6e.19.1746042021700; Wed, 30 Apr 2025 12:40:21 -0700 (PDT) Received: from fedora ([2806:10ae:e:8863::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40212a59800sm958181b6e.39.2025.04.30.12.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 12:40:20 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> Date: Wed, 30 Apr 2025 13:40:19 -0600 Message-ID: <87frhpphek.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jo=C3=A3o T=C3=A1vora writes: > Good ideas. Patches welcome, the shorter the better, of course. Done: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-keybinding-to-eglot-code-actions-help-echo.patch >From f295ce56b91ba0bde4e711a740bdf0db11ed5cd5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Wed, 30 Apr 2025 13:21:29 -0600 Subject: [PATCH] Add keybinding to eglot code actions help-echo. * lisp/progmodes/eglot.el (eglot-mode-line-action-suggestion): Allow mouse-clicks in mode line for code actions. (eglot-code-action-suggestion): Add `eglot-code-actions-at-mouse' keybinding to help-echo. --- lisp/progmodes/eglot.el | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 530fd4aa5b8..ea01859425a 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -2531,7 +2531,13 @@ eglot-mode-line-action-suggestion '(:eval (when (and (memq 'mode-line eglot-code-action-indications) (overlay-buffer eglot--suggestion-overlay)) - (overlay-get eglot--suggestion-overlay 'eglot--suggestion-tooltip))) + (eglot--mode-line-props + eglot-code-action-indicator + 'help-echo + `((mouse-1 + eglot-code-actions-at-mouse + ,(plist-get (aref (overlay-get eglot--suggestion-overlay 'eglot--actions) 0) :title))) + "Execute code actions at point\n"))) "Eglot mode line construct for at-point code actions.") (add-to-list @@ -4130,7 +4136,7 @@ eglot-code-action-suggestion (when (cl-plusp (length actions)) (setq blurb (substitute-command-keys - (eglot--format "\\[eglot-code-actions]: %s" + (eglot--format "\\[eglot-code-actions] or \\[eglot-code-actions-at-mouse]: %s" (plist-get (aref actions 0) :title)))) (if (>= (length actions) 2) (setq blurb (concat blurb (format " (and %s more actions)" -- 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 06:03:18 2025 Received: (at 78106) by debbugs.gnu.org; 1 May 2025 10:03:18 +0000 Received: from localhost ([127.0.0.1]:48775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAQlB-0008SY-Lz for submit@debbugs.gnu.org; Thu, 01 May 2025 06:03:18 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:61453) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAQl8-0008S7-Cv for 78106@debbugs.gnu.org; Thu, 01 May 2025 06:03:15 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5f728aeedacso1177826a12.2 for <78106@debbugs.gnu.org>; Thu, 01 May 2025 03:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746093788; x=1746698588; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/6iT7fA3rGPypI8UW3JIPIeasoVa8ARNlH1UKrHSbgs=; b=eSPY5SPl+sAOm7zzOf72LpFhypiwQ9wdNVIxLgH/B6PegUsasSvI6WiB20+TdVeSm/ KbEs6nQdk/DH3NmN2JOgiFnIAar85msUtMyHg0+nQFOiZ8SWr1rYIwP8xi2xj84zYdjs Y3L1nHOPdnDvKYWfe0Skh9CfEhSOXmwJB8vZHtx7x/MzqiQjbDvZOHTGWAENCvnob76V n6jHgvSyP0TwWsut00rHWh+zIYU9QCkyU5TlZ8DG5ktVNPb3f2qSnm1DnQjGSLUZiDDL 1srV5wQT9nShNYpctEWisL7GqtYv5CeSiN3aI4T/wOwK5DxVPsIO/g8foIBGdX1JWS+C kzPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746093788; x=1746698588; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/6iT7fA3rGPypI8UW3JIPIeasoVa8ARNlH1UKrHSbgs=; b=g2nQZ1D6+YC9KM6fMxOPd1FRZ0HyjgRxYUGGLTn1Q85PSDrDLeC8zzdix6Isw0sc7+ PQJkcyzHQyofUF+cBgIo0HMYxhyCQAw5nGWc19B2QfqsCbRCMfAhHjRpjISaPomTjbDe ySy5D1NQF8BoExTBPqvmszboSvVwYeutSVvwMFqu3o+xEdPJW5pKaJy0Gwp8j0le888O vRvOHzGi3MSQXLLq8Vq3ijRvw9yQcit5l0m3wfla0+KMV5DFNYXMAM242/0lVas9TqcR HI7Bkocu0O+8GZeL4m2C2RIrs9pVSprIfbV5j2MWfFWf6Cn8GVj5z7OhWIWiYRmfAhbC 45AQ== X-Gm-Message-State: AOJu0YzSqcFwmEJNTeUTGbiuyOCrMLlcfKjm6lXH3FY5mkKcfdvkY0u4 dQ0hans8mNG/6sMsGr1ahsMMzNY4MhRCLLXNQUOS2+6KXVp3KE8SaKxGfw== X-Gm-Gg: ASbGncsZdim/VqfZgBISFoO2ps3EslJ9wGzs5NtAFcCMY/gEyWWacJfke4OU01//5Z1 kcuypw/f+JYkKw7JwQrcxf7xi9u1BKb7rxAAekjtcl1y00eRvWc7ovT61+aoWd7inyRhL/kZoIv xVgjP9KgZii3nQzK/h81+5lznvunYiTNUWRHj/py9z8Hb24pguL4URejNMfxZiWiCzkKLls1ZAa rE226ih+O8JWoCaxAUkzfn7MXEDgFSEgnRv3DQ539lIFl5XaYGob4ufUEdXbjO2+inluB9udQqc RxJFdD7bAxwpJVhON49RoOftqQhWI1HtVl1qg51+uuTln4wO1CjVoeE= X-Google-Smtp-Source: AGHT+IHFQcREHmDLcBBrPBdyKWnlImwTAkdnUr5e0tBwBxLJhT2f5jG8IRhgWZg1eiImQ4m7py6hgg== X-Received: by 2002:a05:6402:520c:b0:5f4:d5d2:dd47 with SMTP id 4fb4d7f45d1cf-5f91943a76cmr1433861a12.25.1746093787452; Thu, 01 May 2025 03:03:07 -0700 (PDT) Received: from krug (87-196-82-27.net.novis.pt. [87.196.82.27]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f92febd4d1sm208454a12.57.2025.05.01.03.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 03:03:06 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: <87frhpphek.fsf@gmail.com> References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> <87frhpphek.fsf@gmail.com> Date: Thu, 01 May 2025 11:03:38 +0100 Message-ID: <87bjscfy11.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Elijah Gabe P=C3=A9rez writes: > Jo=C3=A3o T=C3=A1vora writes: > >> Good ideas. Patches welcome, the shorter the better, of course. > > Done: Your ideas are good, but did you test your patch thoroughly? I did, see comments below. > (overlay-buffer eglot--suggestion-overlay)) > - (overlay-get eglot--suggestion-overlay 'eglot--suggestion-tooltip)= )) > + (eglot--mode-line-props > + eglot-code-action-indicator > + 'help-echo > + `((mouse-1 > + eglot-code-actions-at-mouse > + ,(plist-get (aref (overlay-get eglot--suggestion-overlay 'eglo= t--actions) 0) :title))) > + "Execute code actions at point\n"))) This removes the face from the mode-line indication and uses 'help-echo. Probably should be eglot-code-action-indicator-face. Also the blurb looks like. Execute code actions at point. mouse-1: extract subexpression to variable Maybe it should be: mouse-1: execute code actions at point since your second sentence is misleading, as it will actually pop a menu, not execute the actual action right away. > (add-to-list > @@ -4130,7 +4136,7 @@ eglot-code-action-suggestion > (when (cl-plusp (length actions)) > (setq blurb > (substitute-command-keys > - (eglot--format "\\[eglot-code-actions]: %s" > + (eglot--format "\\[eglot-code-actions] or > \\[eglot-code-actions-at-mouse]: %s" This isn't right, did you test this? The second part shows the user instructions that when followed do not do what they say they do. For me it says: or M-x eglot-code-actions-at-mouse: extract subexpression to variab= le I have M-x eglot-code-actions bound to of course. In my case it should say 'mouse-2' as that is the (default) button that pops up a menu. So it should be : extract subexpression to variable, mouse-2: execute code actions at point Needless to say if I press 'M-x eglot-code-actions-at-mouse' it doesn't work, and I get an error saying there is no mouse event when invoking the command. So substitute-command-keys might not be a solution here, as you can't easily get it to be aware of the special map and not say anything if nothing is bound there. Even more problematic is the fact that it shows the changed blurb in the ElDoc area, in situations where the mouse (if there even is one!) is not hovering on the margin or fringe (if there even are fringes). So this isn't a straightforward problem to solve, which probably explains why I left this minor detail out. I also feel that if the code to do this grows too complicated, it's better to add generic utility to Emacs to solve these problems and conditionally use it in eglot.el with a 'fboundp' check. Good luck! Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 20:04:39 2025 Received: (at 78106) by debbugs.gnu.org; 2 May 2025 00:04:39 +0000 Received: from localhost ([127.0.0.1]:54304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAdtO-0006uL-Hv for submit@debbugs.gnu.org; Thu, 01 May 2025 20:04:39 -0400 Received: from mail-oo1-xc42.google.com ([2607:f8b0:4864:20::c42]:59604) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAdtL-0006ts-LA for 78106@debbugs.gnu.org; Thu, 01 May 2025 20:04:36 -0400 Received: by mail-oo1-xc42.google.com with SMTP id 006d021491bc7-6060a70ba80so775408eaf.2 for <78106@debbugs.gnu.org>; Thu, 01 May 2025 17:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746144269; x=1746749069; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=f6tM2V2L4vQy6mf5rSNCzJwHjvQSPoXGcigIYTaNf0U=; b=AZplzfWXXLi+HxUgiNmlrjkv2RuIrYdWFs9Odmv8dHFjaaSxV6Ex3AmdZGXgb1q1f1 A7kpv0nfEgcabZIk8i0n5QBzTSE0o+u0QpMzY+ajGwWGB/6hKH0r7/9AuPvta7qTPXdC RSYhCKAv/MVqloDIXyHTXgyswdXSd4V+6k4GyNnBE8yzXKUnMT4Y+HttriQyLhFX+ON/ y5BmfmaDkZs3zFlj2qwFdUmR5MZMnQGc+9Yeh/AgKqcXnUbXysVOCdtNQqbYSXMe5PQW Yxg63sW0ngD7Fn8fLmkZ0NAO4Qj8qxchoiZnmZEiu+NZ3Xy/8cEF3r2Xsb/1FlqDOeR7 DMfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746144269; x=1746749069; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f6tM2V2L4vQy6mf5rSNCzJwHjvQSPoXGcigIYTaNf0U=; b=mBINitPF/62xdaXIjIToEgYl9C2rZNsZ52H66WDElXkm0LF3hvovrMxVQ1m/YhLi2W oq61dwhkXagsBe05r5IQgjpm+lxuM042JfoPAO58eFdDC1Dl9M54MNsI2gfaPYfPlCbY NIMt9sgNH6VMg91t8zpK3c5ybSHbb90fHz+gSBNTKa+zWvUrwl6hcKpzPE2FlZmeodHg G6z0PnPJlb5Uc+Tffsn5qSIdjcwt7yzdAP/L0oT8hWVwNURQTQhaZozLdEZIEOptyRZ8 sKVrdVEGl3rReEpGOZAYYViaVd0sxO0rNzsvF6BInylCeozab9kwW+VP21Lvumdc+Rtq ERSQ== X-Gm-Message-State: AOJu0Yw9+QxMl6NUtjjA2K8i6qfQ8Q8urJCa2awuuly0LHCkRQVC2yOa RANGX3PVhqDWa2Crkr63+q1V1AMBl2nCQeNGa6Ai2VE8v5ySA12sM+xU3TL0 X-Gm-Gg: ASbGncuUTj8aLiBFRXLTWJlD2w6u5phmWybVnnBRv6uEVEVyq9qxaQgvUn79B2E6PUY HrQFZPkze+rFSyGVUVGjIS7DQFkwQXTKRIWIqvNJH2rgacyCA7X/gRb8l5OxU7dhLptmYh+855g wPFMSc1+et6CASQ+9TYWqIVXRRV7cwWYntX/bdTHS0wjJnDjIE9L5uadoBpyQn4xRDIbFZxc/25 bMsuemHuwtsMIXekGybzAbsTld/X8pp5cRZtfj5QDjZ/k0lhBJZOiD2kHB98kCShVfAHRoR7SsG Jp8b74wO X-Google-Smtp-Source: AGHT+IEH3kv07BlfCMOr2NAQbfivDJO8DxR+Py3EuWJDFOoRwiBKkz/WuIYEbwtOB0OKhLRHlMCyKQ== X-Received: by 2002:a05:6820:310c:b0:603:f820:7be4 with SMTP id 006d021491bc7-607ee874d96mr460952eaf.8.1746144268925; Thu, 01 May 2025 17:04:28 -0700 (PDT) Received: from fedora ([2806:10ae:e:8863::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4033d9a5e2asm351714b6e.2.2025.05.01.17.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 17:04:28 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: <87bjscfy11.fsf@gmail.com> References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> <87frhpphek.fsf@gmail.com> <87bjscfy11.fsf@gmail.com> Date: Thu, 01 May 2025 18:04:26 -0600 Message-ID: <87cycr514l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jo=C3=A3o T=C3=A1vora writes: > Elijah Gabe P=C3=A9rez writes: > Your ideas are good, but did you test your patch thoroughly? I did, see > comments below. > >> (overlay-buffer eglot--suggestion-overlay)) >> - (overlay-get eglot--suggestion-overlay 'eglot--suggestion-tooltip= ))) >> + (eglot--mode-line-props >> + eglot-code-action-indicator >> + 'help-echo >> + `((mouse-1 >> + eglot-code-actions-at-mouse >> + ,(plist-get (aref (overlay-get eglot--suggestion-overlay 'egl= ot--actions) 0) :title))) >> + "Execute code actions at point\n"))) > > This removes the face from the mode-line indication and uses 'help-echo. > Probably should be eglot-code-action-indicator-face. Oops, sorry, I thought that function was a kind of `propertize'. > Also the blurb looks like. > > Execute code actions at point. mouse-1: extract subexpression to varia= ble > > Maybe it should be: > > mouse-1: execute code actions at point > > since your second sentence is misleading, as it will actually pop a > menu, not execute the actual action right away. I agree, fixed. >> (add-to-list >> @@ -4130,7 +4136,7 @@ eglot-code-action-suggestion >> (when (cl-plusp (length actions)) >> (setq blurb >> (substitute-command-keys >> - (eglot--format "\\[eglot-code-actions]: %s" >> + (eglot--format "\\[eglot-code-actions] or >> \\[eglot-code-actions-at-mouse]: %s" > > This isn't right, did you test this? The second part shows the user > instructions that when followed do not do what they say they do. For me > it says: > > or M-x eglot-code-actions-at-mouse: extract subexpression to vari= able > > I have M-x eglot-code-actions bound to of course. In my case it > should say 'mouse-2' as that is the (default) button that pops up a > menu. So it should be > > : extract subexpression to variable, mouse-2: execute code actions > at point > > Needless to say if I press 'M-x eglot-code-actions-at-mouse' it doesn't > work, and I get an error saying there is no mouse event when invoking > the command. So substitute-command-keys might not be a solution here, > as you can't easily get it to be aware of the special map and not say > anything if nothing is bound there. > > Even more problematic is the fact that it shows the changed blurb in the > ElDoc area, in situations where the mouse (if there even is one!) is not > hovering on the margin or fringe (if there even are fringes). > > So this isn't a straightforward problem to solve, which probably > explains why I left this minor detail out. > > I also feel that if the code to do this grows too complicated, it's > better to add generic utility to Emacs to solve these problems and > conditionally use it in eglot.el with a 'fboundp' check. A way I found for achieve this is only (re)propertizing the blurb help-echo for `margin' and `nearby' options (like the patch below). This let eldoc area unchanged (i tested it). I used `substitute-command-keys' only for get the mouse-1/2/3 button for margin, but since i see this is problematic, I've changed it to only display `mouse-2'. The help-echo for `margin' and `nearby' now should be displayed as: "M-x eglot-code-actions: remove #include directive (and 1 more actions), mouse-2: execute code actions at point" and for the mode-line: "mouse-1: Execute code actions at point." --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-Add-keybinding-to-eglot-code-actions-help-echo.patch Content-Transfer-Encoding: quoted-printable >From bf06dd9db04e433f72f635cd18e64443ce29c0b9 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Wed, 30 Apr 2025 13:21:29 -0600 Subject: [PATCH] Add keybinding to eglot code actions help-echo. * lisp/progmodes/eglot.el (eglot-mode-line-action-suggestion): Allow mouse-clicks in mode line for code actions. (eglot-code-action-suggestion): Add "mouse-1" to help-echo only in `margin' and `nearby' options. --- lisp/progmodes/eglot.el | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 530fd4aa5b8..ff8769dd5d2 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -2531,7 +2531,11 @@ eglot-mode-line-action-suggestion '(:eval (when (and (memq 'mode-line eglot-code-action-indications) (overlay-buffer eglot--suggestion-overlay)) - (overlay-get eglot--suggestion-overlay 'eglot--suggestion-tooltip))) + (eglot--mode-line-props + eglot-code-action-indicator 'eglot-code-action-indicator-face + `((mouse-1 + eglot-code-actions-at-mouse + "execute code actions at point"))))) "Eglot mode line construct for at-point code actions.") =20 (add-to-list @@ -4143,19 +4147,25 @@ eglot-code-action-suggestion 'keymap eglot-diagnostics-map)) (save-excursion (goto-char (car bounds)) - (let ((ov (make-overlay (car bounds) (cadr bounds)))) + (let ((ov (make-overlay (car bounds) (cadr bounds))) + (tooltip-1 (propertize + tooltip + 'help-echo + (concat + blurb + ",\nmouse-2: execute code actions at poi= nt")))) (overlay-put ov 'eglot--actions actions) (overlay-put ov 'eglot--suggestion-tooltip tooltip) (overlay-put ov 'before-string (cond ((memq 'nearby eglot-code-action-indications) - tooltip) + tooltip-1) ((memq 'margin eglot-code-action-indications) (propertize "=E2=9A=A1" 'display `((margin left-margin) - ,tooltip))))) + ,tooltip-1))))) (setq eglot--suggestion-overlay ov))))) (when use-text-p (funcall cb blurb))) :hint :textDocument/codeAction) --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 10:00:40 2025 Received: (at 78106) by debbugs.gnu.org; 2 May 2025 14:00:40 +0000 Received: from localhost ([127.0.0.1]:59959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAqwR-00059e-LW for submit@debbugs.gnu.org; Fri, 02 May 2025 10:00:40 -0400 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:54310) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAqwM-000596-NG for 78106@debbugs.gnu.org; Fri, 02 May 2025 10:00:37 -0400 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5eb92df4fcbso3881086a12.0 for <78106@debbugs.gnu.org>; Fri, 02 May 2025 07:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746194428; x=1746799228; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OO0jAOf4EXnt65tU/RL0GpUa/Sj+awEm69nkPScjEl0=; b=I4RjEPwnKih42iNluDIiBcw1VGBWg9WKGXkPTbwG5hWs8KqIXdiF/ykgyijIzi/c9I 6D5Nky2InVxqUBn88auzpBgcoTff4KrTa8+yuh6wcx6jR3tQXBf8imTd40HOr+Omcns2 R0LQPxAs1vrpq+dNJQKZf16CQzYU79xAnj6P1QDby1W8mjPwZXT3yhHA3zZ0R1Is01mB SPlg2IoJpSQpep4OCzHAIGB5N30++xR/ec/wymepZzqWtm3gPK2TTy90ektCUBcFczAJ dnuD9610x+70MA6Q3auPKbPmRKuralj18ZmGjaM/p1PhZylvvvFuy1koGitnk80CcRSx F1pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746194428; x=1746799228; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OO0jAOf4EXnt65tU/RL0GpUa/Sj+awEm69nkPScjEl0=; b=fjId7+zCJy2jfn93h2xv0aCdixm9huy7JFPje/TkrVrHEhV0qYO9bMVsHjlvRbBtV+ srBV/46s4qP2CEfYExyurBpaO3/kyBRgg6sCAE2FK6Sg+Rr4hPiINlYcnjDg2Y7fdBKS bDyE6TNdY6D9K+wgymZATbPkFXR2ZSe5evEk3KXolUZWVsVI6yenS8Qli/WUcXyGX1FP QTBmQLH9pnmy2Y85/b/MVoBCdiA8iWvN16lUwYU4eICmUTs3UiD03GCqXPkzo9NVfBmW tvUK7CHCv97OklHNNHPxTWbpXWuTfOPta+bruWix1g/ejOrQd3tUlOYo79FMwEU1oXQb msKA== X-Gm-Message-State: AOJu0YzpUKEP2Yo156ppBYaBq4gv4563CGiqslNDIasO9fc9hHHxVEng rpNmZz1x9Y9ZOaUOcJNC1ZZIhJ/4Q5Kfpck1PeioqvwJOvXrnIKq6zh2rQ== X-Gm-Gg: ASbGncs/yuU4s3YViV9UDa0mLECozv05OVTw6p1jCNjBqovQoJHb1NFiD1PGVGg/LGM wQjiRrKC96zVcuWfbzpPQI3qrRR2lBOy94guzjDdSevZ+q8/1SHQ8E+mM6jQCaZRe2zXzK5QCp0 yKjYnnMgRE8VBT5dQZgil6N6Yb1TU0wz6svP2A/eXuG2NCTJRgkw92OynnJsklGvYLNcH0KTv/J kqd4sGJ2/cNwzmiqtiQA4fvSXxr2hm85IhJmBM4r56POU+ZMzAUfpT+ohSqIEholXaYtzYo62Rv 8mI6erYlz777H6QmF91HvnR7GfAO8GeK8eGkPl1qa3xdr1HR339f3rjeNA== X-Google-Smtp-Source: AGHT+IH9orMPxAvjnQJEyJWGqMKnlZQW2MdcChVP6W48ohEOY3Y8ckgwxzFSiJjuiQYB8d06oK/ViQ== X-Received: by 2002:a05:6402:1e92:b0:5e7:b02b:5ae with SMTP id 4fb4d7f45d1cf-5fa7890e6b5mr2290084a12.31.1746194427530; Fri, 02 May 2025 07:00:27 -0700 (PDT) Received: from krug (87-196-83-203.net.novis.pt. [87.196.83.203]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fa77bf289esm1252167a12.69.2025.05.02.07.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 07:00:24 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: <87cycr514l.fsf@gmail.com> References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> <87frhpphek.fsf@gmail.com> <87bjscfy11.fsf@gmail.com> <87cycr514l.fsf@gmail.com> Date: Fri, 02 May 2025 15:01:02 +0100 Message-ID: <8734dnf6xt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Elijah Gabe P=C3=A9rez writes: > A way I found for achieve this is only (re)propertizing the blurb > help-echo for `margin' and `nearby' options (like the patch below). > This let eldoc area unchanged (i tested it). Good, I think we're getting closer. > I used `substitute-command-keys' only for get the mouse-1/2/3 button for > margin, but since i see this is problematic, I've changed it to only > display `mouse-2'. Yes, this is a problem. Maybe we should just let the hardcoded mouse-2 be there, or maybe there is a better way. Anyway, please proceed from the simpler patch after my sig. I noticed the 'tooltip' (sans "1") variable wasn't being used for anything. I think that -- ideally, at least on Emacs master -- there should be a way to tell substitute-command-keys which parts of the Emacs layout to consider when constructing its strings. Feel free to ask about this on emacs-devel and then bring any results back to Eglot. If we can't find anything better I'll commit some version of your patch (with due credit to you, of course). Do you have an Emacs copyright assignment? Your patch is "trivial", but it would be good it you had one of these. Jo=C3=A3o diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index d796c9fc802..8d2934391d6 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -2531,7 +2531,11 @@ eglot-mode-line-action-suggestion '(:eval (when (and (memq 'mode-line eglot-code-action-indications) (overlay-buffer eglot--suggestion-overlay)) - (overlay-get eglot--suggestion-overlay 'eglot--suggestion-tooltip))) + (eglot--mode-line-props + eglot-code-action-indicator 'eglot-code-action-indicator-face + `((mouse-1 + eglot-code-actions-at-mouse + "execute code actions at point"))))) "Eglot mode line construct for at-point code actions.") =20 (add-to-list @@ -4146,14 +4150,13 @@ eglot-code-action-suggestion (setq tooltip (propertize eglot-code-action-indicator 'face 'eglot-code-action-indicator-face - 'help-echo blurb + 'help-echo "mouse-2: execute code actions a= t point" 'mouse-face 'highlight 'keymap eglot-diagnostics-map)) (save-excursion (goto-char (car bounds)) (let ((ov (make-overlay (car bounds) (cadr bounds)))) (overlay-put ov 'eglot--actions actions) - (overlay-put ov 'eglot--suggestion-tooltip tooltip) (overlay-put ov 'before-string From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 10:19:46 2025 Received: (at 78106) by debbugs.gnu.org; 2 May 2025 14:19:46 +0000 Received: from localhost ([127.0.0.1]:60075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uArEv-0006DL-ML for submit@debbugs.gnu.org; Fri, 02 May 2025 10:19:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47952) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uArEs-0006Cu-7H for 78106@debbugs.gnu.org; Fri, 02 May 2025 10:19:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uArEk-0006u6-4r; Fri, 02 May 2025 10:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5GwkxZamvapEXBP2uUiwknLL4cmWV/FV890Q1fPPcUQ=; b=Z5oMQAMzY1gLYa7Oku8U oz4FkKgS74EQIDDa7O6ea6bkwndWy6FOUNv41me3ZVUAoPRdVlvQ2dJdP5ZpJ+TJ4DYPf0e2R45U9 YLeIJvk4D8wa36WselVlFdeiJS7+oF87i7DNDkI6f2Ey3zeEmLO5PZd0MOYd24h4I5HAN7hVd7ilJ 3cEeDLCqkBeHYFseOsO6XsDDe0A1XoDTWdjsZ0RX2td0RV3JW/snlcBSxfsZEnTy27bcz7eNjE13v NsNK7+/6wXbRQj5zx9erBM2qI/FZtE/a7WsNoelH4JZkMNq7sqN8eFM+9h+V7rfUKe1bsUwaDL86v ybv1QVrN5mCqDw==; Date: Fri, 02 May 2025 17:19:31 +0300 Message-Id: <86ikmjkscs.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: <8734dnf6xt.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Fri, 02 May 2025 15:01:02 +0100) Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> <87frhpphek.fsf@gmail.com> <87bjscfy11.fsf@gmail.com> <87cycr514l.fsf@gmail.com> <8734dnf6xt.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78106 Cc: eg642616@gmail.com, 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 78106@debbugs.gnu.org > From: João Távora > Date: Fri, 02 May 2025 15:01:02 +0100 > > Do you have an Emacs copyright assignment? He does. From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 21:55:02 2025 Received: (at 78106) by debbugs.gnu.org; 3 May 2025 01:55:02 +0000 Received: from localhost ([127.0.0.1]:35644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uB25l-0001Dv-CW for submit@debbugs.gnu.org; Fri, 02 May 2025 21:55:01 -0400 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:52409) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uB25c-0001DU-Tg for 78106@debbugs.gnu.org; Fri, 02 May 2025 21:54:57 -0400 Received: by mail-oi1-x241.google.com with SMTP id 5614622812f47-40337dd3847so1360846b6e.0 for <78106@debbugs.gnu.org>; Fri, 02 May 2025 18:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746237287; x=1746842087; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e9Y1qDipaN5Q3VbNV3hGDAwDIbKVonGOtl0QRVGkD8s=; b=aPLDVQaGXwGr9RT/17ZYmS/X1gMeOrt1DW/TNrqNqMGVDlsNUYLOO/fwGizeHT7aGp AHTMJrTSMprbZ8152gQzIsC2l7qWkaOrnIX/7rBRJY56mzJqbrVOCwxT5RNmUS1rmx/T Vjde/Xb5Qy1JD5JMq0p4sO+JTfjaVSdaDPu2kxcpj0MgE37DO9A0XMhVIBPDjWLki8B9 /06/j6yuM/xTlhfySRHcV5M/CN3Z1totzB6WrSUiRwxEypxdsDKtW13WHU+RVosTfBD2 dnZHvhyJrne+BZblffeJxDRMy4d3RP9tfiNyxHRTMBqyN04zjrcvJiu1RBSoFqAJUBTF ZeVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746237287; x=1746842087; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e9Y1qDipaN5Q3VbNV3hGDAwDIbKVonGOtl0QRVGkD8s=; b=S8XmzHB7ARXXWUR2353ZsAS64r5OwMcTQPc/UifLpodHvMbYDarfKa4aJiNVhwA9KG muOk+gHNIkEZe6wd3LtnqeNlNxfwgmr52kAKtXWjJuGzbI8ul/cySXsYWjvmBbGf8gNR 962K+rlQaC8YFIMvvWIpFE3vOyj2b6ugEAz3qgyY5xrNmigg+HlEbqzZNbCnlfHV/Jn/ ZG4JIt/JIwz4XNBhP61vjkNFUVmmByxizulehkHsvJM7JvkuOqs9+yoNe5OKWzhqs11B WsPZ01wmfiLYoxnnqTY+cy+zACpXTJIPU+hJUoWvvxryd3hcan3rHpoGXCj9VAGD8Y8q VKZQ== X-Gm-Message-State: AOJu0Yzo6uujad+XZf2xcKphOMF3/kL7JeIaZ22havEQ1AuzM1Nbs/Cg du67pRkrJ1os5tBBeEBP7ZnE5s3jOL5fCGvRGIk0d3SmzIoh3+2nRiI1w23W X-Gm-Gg: ASbGnctE/VT1x7DaTmqjaXrbeQu3KvcHVY7nxZJPzUysmIy56CvMVzDlGjRy4JkFWyz dcdIskW+Y1wTCcByjSKyBGR8jnMImC3+nZN8zdkWxpLheES3OqmakJBxc83DkOBZUTQJfkHxraA LUy5qIiB2rpTlbbub5+FslRqJ8C0nwDztRlA3+aIUhsCF4kPRdHR6Z/bLQR05QQWAJGOcr/f7DS FgPjKK6WtVYcolSvDdUQ+DVVjnwjufafhgwtPp1CuuOD1V+t7nWg5djy/shThRCjuZFyQTF0q24 4nVgZYz8 X-Google-Smtp-Source: AGHT+IGowl8S7mTPB04Raz92q7ifMJfBieD/VVcRf6OPhSaVdRSy+vL0RI5VaIwg51fkcw8aU5GS/Q== X-Received: by 2002:a05:6808:4495:b0:401:e9e:9da7 with SMTP id 5614622812f47-4034143b89dmr3079033b6e.25.1746237286741; Fri, 02 May 2025 18:54:46 -0700 (PDT) Received: from fedora ([2806:10ae:e:b33c::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-403470daa39sm508098b6e.7.2025.05.02.18.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 18:54:46 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: <8734dnf6xt.fsf@gmail.com> References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> <87frhpphek.fsf@gmail.com> <87bjscfy11.fsf@gmail.com> <87cycr514l.fsf@gmail.com> <8734dnf6xt.fsf@gmail.com> Date: Fri, 02 May 2025 19:54:44 -0600 Message-ID: <871pt6cvbv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jo=C3=A3o T=C3=A1vora writes: >> I used `substitute-command-keys' only for get the mouse-1/2/3 button for >> margin, but since i see this is problematic, I've changed it to only >> display `mouse-2'. > > Yes, this is a problem. Maybe we should just let the hardcoded mouse-2 > be there, or maybe there is a better way. Anyway, please proceed from > the simpler patch after my sig. > I noticed the 'tooltip' (sans "1") variable wasn't being used for > anything. It's used only for nearby and margin options: >> (goto-char (car bounds)) >> - (let ((ov (make-overlay (car bounds) (cadr bounds)))) >> + (let ((ov (make-overlay (car bounds) (cadr bounds))) >> + (tooltip-1 (propertize >> + tooltip >> + 'help-echo >> + (concat >> + blurb >> + ",\nmouse-2: execute code actions at = point")))) >> (overlay-put ov 'eglot--actions actions) >> (overlay-put ov 'eglot--suggestion-tooltip tooltip) >> (overlay-put >> ov >> 'before-string >> (cond ((memq 'nearby eglot-code-action-indications) >> - tooltip) >> + tooltip-1) ^ >> ((memq 'margin eglot-code-action-indications) >> (propertize "=E2=9A=A1" >> 'display >> `((margin left-margin) >> - ,tooltip))))) >> + ,tooltip-1))))) ^ >> (setq eglot--suggestion-overlay ov))))) Thus, Eldoc will not display "mouse-2: execute code actions at point", which can be confusing. > I think that -- ideally, at least on Emacs master -- there should be a > way to tell substitute-command-keys which parts of the Emacs layout to > consider when constructing its strings. Feel free to ask about this on > emacs-devel and then bring any results back to Eglot. If we can't find > anything better I'll commit some version of your patch. For now i think that the hardcoded mouse-2 would be the best choice, also I've seen in other packages (including built-in) that they does the same. > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index d796c9fc802..8d2934391d6 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -2531,7 +2531,11 @@ eglot-mode-line-action-suggestion > '(:eval > (when (and (memq 'mode-line eglot-code-action-indications) > (overlay-buffer eglot--suggestion-overlay)) > - (overlay-get eglot--suggestion-overlay 'eglot--suggestion-tooltip)= )) > + (eglot--mode-line-props > + eglot-code-action-indicator 'eglot-code-action-indicator-face > + `((mouse-1 > + eglot-code-actions-at-mouse > + "execute code actions at point"))))) > "Eglot mode line construct for at-point code actions.") No problem with this. > (add-to-list > @@ -4146,14 +4150,13 @@ eglot-code-action-suggestion > (setq tooltip > (propertize eglot-code-action-indicator > 'face 'eglot-code-action-indicator-face > - 'help-echo blurb > + 'help-echo "mouse-2: execute code actions= at point" "mouse-2: execute code actions at point" will appear also in ElDoc. > 'mouse-face 'highlight > 'keymap eglot-diagnostics-map)) > (save-excursion > (goto-char (car bounds)) > (let ((ov (make-overlay (car bounds) (cadr bounds)))) > (overlay-put ov 'eglot--actions actions) > - (overlay-put ov 'eglot--suggestion-tooltip tooltip) What was 'eglot--suggestion-tooltip' used for? Are you sure it should be removed? > (overlay-put > ov > 'before-string > --=20 - E.G via GNU Emacs and Org. From debbugs-submit-bounces@debbugs.gnu.org Sun May 04 03:57:18 2025 Received: (at 78106) by debbugs.gnu.org; 4 May 2025 07:57:18 +0000 Received: from localhost ([127.0.0.1]:50502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBUDt-0000dD-AK for submit@debbugs.gnu.org; Sun, 04 May 2025 03:57:18 -0400 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:58726) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uBUDm-0000bC-05 for 78106@debbugs.gnu.org; Sun, 04 May 2025 03:57:13 -0400 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-ac2902f7c2aso544288966b.1 for <78106@debbugs.gnu.org>; Sun, 04 May 2025 00:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746345423; x=1746950223; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LNEy9lEju46VtCcrpBzhvFsqnuA4L5mDSKgLkQdX91Y=; b=aKjyPqC6pHFs2DX5gQ91bJY65jMuUC3L2luV2yavUJRcuLaOt75pa7ZK+OaFiM+jka d0DVocQ5L9Y4hcr1v7ruIhubtCTC00D8RCOaNkkg4rZYHBDrlnuRzNZlOnktTTyfj7aj n+Pc3K/bLvBG1TU3hXCg5JSZro3HQQBj66Uy2+A7IR8l3+gElmbvBkxUUsHgO2JwqfgV S2asGR+aSPTJRwWErAt0VRez9khckC2goIctO5Yivt1zXrfKab6f55SuSekkGThlDgRH fkT0NTHw7uFHs+VJd5FeSGaV53mnafyJOsuiSJfVJrPhCvfTAzJDBSA1NcMlWijDAaS8 inGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746345423; x=1746950223; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LNEy9lEju46VtCcrpBzhvFsqnuA4L5mDSKgLkQdX91Y=; b=NZHDFj6SZdLZtRWXmwSeVIZdtEJuXTVoUHbMxTdnLxLamppywjnq5IsQ05civnSLNd TDuUYTA0M5MGl1l0yp4erynez4C5B7vitqbrfHLIYVZLa8GKF9+sWidcRNafzcZ/t7P1 JtKyCxi2HuXylyY9UquE9mX4Kf5FXQGZrJd5vhjm/Lr9jkeECkDIzOJqKyPLSFJtU76J bYIj9bOCx27eSBC4QZGuR1p6NLbU5mZYXEfiBmY/5RArH4lSBAxKGYgXEEh7CTwia4z8 PJ+uksqVAtzIqB3Y2mFgLSe2qER3bfNVbct9o9LuTA1cnLDqxL2yvtiniT7Fttso8/K5 66jw== X-Gm-Message-State: AOJu0Yw84VIP11O/f7m5PCdMCbj9NFLXjfIQZ+OzW/pWowEoZ2VkGaMP /Yh2XgpG1Q1WJHqI24/PlkKBqjDbX0eY45FjJJSP8JXBXgtWSCJ+v3nNLg== X-Gm-Gg: ASbGncuUx3Zazza2tYCgpBA5g7KxWVBoHkpN9ZK6kN+Crv1hJXI03V8PdOZrg3FzSfc U01dQozGsqmJvvKcbT5vt178lfFARh6vAuQ7VgqAeOKcgcnCfGgo3HzSnrvgYNzqM1EsOLEXJb1 zfuMgjY3wgbVCcnBNVb9cASIz7n7TASt8yzPww2qFD75gf8WMBycrP+W2ZDqvS1dXVobwmOesF7 o+Uwd2oi65bA3SpT/wmtmdlzPPKQeKuUaD1gR5w99bOQ1q5RpJJm/OOHZ9Db/1PEWiLxW5oY183 C0kTunEhCMN6dxc1pZVZJkjGdKujBFLN2KC1oVZNaomG5O9G1aWyD+4= X-Google-Smtp-Source: AGHT+IEuu9HL2aWxFTiDoU776kctjRuXhi97ep8O8avl9oKcGTJQUhFK3hnvGNYN4mjVG3dMaSq3mA== X-Received: by 2002:a17:907:2d25:b0:ac2:842c:8d04 with SMTP id a640c23a62f3a-ad1a4913675mr293270766b.17.1746345422840; Sun, 04 May 2025 00:57:02 -0700 (PDT) Received: from krug (87-196-82-27.net.novis.pt. [87.196.82.27]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad1894c01f2sm294318966b.119.2025.05.04.00.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 00:57:02 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: <871pt6cvbv.fsf@gmail.com> References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> <87frhpphek.fsf@gmail.com> <87bjscfy11.fsf@gmail.com> <87cycr514l.fsf@gmail.com> <8734dnf6xt.fsf@gmail.com> <871pt6cvbv.fsf@gmail.com> Date: Sun, 04 May 2025 08:57:42 +0100 Message-ID: <87y0vcerk9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Elijah Gabe P=C3=A9rez writes: > Jo=C3=A3o T=C3=A1vora writes: > It's used only for nearby and margin options: Yes, and that's where it needs fixing, so no need for a second variable. >>> + ,tooltip-1))))) > ^ >>> (setq eglot--suggestion-overlay ov))))) > > Thus, Eldoc will not display "mouse-2: execute code actions at point", > which can be confusing. Perhaps, but it's even more confusing that if displays that blurb and the mouse cursor is nowhere near, or there isn't a mouse cursor at all. > For now i think that the hardcoded mouse-2 would be the best choice, > also I've seen in other packages (including built-in) that they does the > same. I suppose. In fact it's better to have mouse-1, not mouse-2, for the margin and mode-line, so I changed that. The reason we use mouse-2 for in-buffer diagnostics overlays is because it's bad practice to rebind mouse-1 there, whose meaning in an editable buffer should always be "place point here". >> (add-to-list >> @@ -4146,14 +4150,13 @@ eglot-code-action-suggestion >> (setq tooltip >> (propertize eglot-code-action-indicator >> 'face 'eglot-code-action-indicator-face >> - 'help-echo blurb >> + 'help-echo "mouse-2: execute code action= s at point" > > "mouse-2: execute code actions at point" will appear also in ElDoc. How? I don't see that happening in my testing. >> 'mouse-face 'highlight >> 'keymap eglot-diagnostics-map)) >> (save-excursion >> (goto-char (car bounds)) >> (let ((ov (make-overlay (car bounds) (cadr bounds)))) >> (overlay-put ov 'eglot--actions actions) >> - (overlay-put ov 'eglot--suggestion-tooltip tooltip) > > What was 'eglot--suggestion-tooltip' used for? Are you sure it should be > removed? I'm fairly sure. It's an internal symbol (as per the '--') and I didn't catch any references to it. Some left over of the original implementation. See patch after my sig. If you're content, I can push it: Jo=C3=A3o diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 474245352d6..d33b0b05fd4 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -2531,7 +2531,11 @@ eglot-mode-line-action-suggestion '(:eval (when (and (memq 'mode-line eglot-code-action-indications) (overlay-buffer eglot--suggestion-overlay)) - (overlay-get eglot--suggestion-overlay 'eglot--suggestion-tooltip))) + (eglot--mode-line-props + eglot-code-action-indicator 'eglot-code-action-indicator-face + `((mouse-1 + eglot-code-actions-at-mouse + "execute code actions at point"))))) "Eglot mode line construct for at-point code actions.") =20 (add-to-list @@ -2578,7 +2582,7 @@ eglot--diag-to-lsp-diag (defvar eglot-diagnostics-map (let ((map (make-sparse-keymap))) (define-key map [mouse-2] #'eglot-code-actions-at-mouse) - (define-key map [left-margin mouse-2] #'eglot-code-actions-at-mouse) + (define-key map [left-margin mouse-1] #'eglot-code-actions-at-mouse) map) "Keymap active in Eglot-backed Flymake diagnostic overlays.") =20 @@ -4146,14 +4150,13 @@ eglot-code-action-suggestion (setq tooltip (propertize eglot-code-action-indicator 'face 'eglot-code-action-indicator-face - 'help-echo blurb + 'help-echo "mouse-1: execute code actions a= t point" 'mouse-face 'highlight 'keymap eglot-diagnostics-map)) (save-excursion (goto-char (car bounds)) (let ((ov (make-overlay (car bounds) (cadr bounds)))) (overlay-put ov 'eglot--actions actions) - (overlay-put ov 'eglot--suggestion-tooltip tooltip) (overlay-put ov 'before-string From debbugs-submit-bounces@debbugs.gnu.org Sun May 04 17:35:58 2025 Received: (at 78106) by debbugs.gnu.org; 4 May 2025 21:35:58 +0000 Received: from localhost ([127.0.0.1]:33973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uBh0A-0004MU-Bt for submit@debbugs.gnu.org; Sun, 04 May 2025 17:35:58 -0400 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:60472) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uBh04-0004Ko-9F for 78106@debbugs.gnu.org; Sun, 04 May 2025 17:35:55 -0400 Received: by mail-oi1-x241.google.com with SMTP id 5614622812f47-3f6eaa017d0so3082951b6e.0 for <78106@debbugs.gnu.org>; Sun, 04 May 2025 14:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746394546; x=1746999346; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rwcXpaaHp5BHjWPq0SozT9CQjl5JFMiFzPJdKBBabuk=; b=g9Xst8PQPHuGLUhcethSHW8gsT5bTj3mzrPAyHJC2uAchYlP4iB6JKefcpbP37lfXa +G1ZIe8588N+Kb0gtz3vWPYIo4RKMl5xuGscTXqB3tWzR+A4AZi38qZdNa4OzF4123IY Die1JwYY2XiRjAQ9Y6YNaoN3gh0kKzqHA8SbqcPakwRgiNfnVGBhZBcZTvqJfosVtXjG ssuVTOZL8hSuw9EsNteXEddpRv/72ThYG1tq+PavoOUmot/upVAk3r/koiDYEnknwG2+ SQgAFDVxYB+QSLUzLlNOdAPqmtiy5ESjWMSmEwiPqTsfO1iybxPPt4RNdQ76l5/v9pXP pjqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746394546; x=1746999346; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rwcXpaaHp5BHjWPq0SozT9CQjl5JFMiFzPJdKBBabuk=; b=rFrgfAinoo8TxBaJDeXiRXAfB1yNxmmoODw4JTi4EzaloePxcOpcT+3qzC4v5I5iUH d2FC9YaezUDvUKZSRT36A+du5r06tIHiEFR7ptmV5/SBUn1a7bYBGa5MVznFE9duindA uppf0Z3q4ZIT945a1vsHg0jsBIUS0OLjC5vuu/ayqR03of7Z18v1B0bFtbBQA8g/RniG QaRSQxWQvztyXuCrunedY3kGp8W+4yv5cclMLUOkkZV8GP7ccHyjdvhkOQWQ9BxjyH2z tRXTTdoM9xgCrXPvnVxIhi9zdLzus9X4Zn9fRm2QCFHEUaVP2UGGCQX5oBm2d3D8hbQD DZ0A== X-Gm-Message-State: AOJu0YxDy/PslQsfNluB2GR5Ua6fybZ68GyW16aKWMHArQp6vkex/K32 ehEYKiHj4Y3/oTo3pZ8OQkZ8NaXw0bWeBWy4+t2y6ZYY9/v7kKwlB7gktOWs X-Gm-Gg: ASbGncuZphoeDAK+l4rUarUlHMD1ko0nPIVIGnuMAnuwOdRpzdv2BCE0rHpvqpCfeSa zT+CUmmyTKVWF7yuNzn/e/Fh+HwwV+QnteI3fZD1Mj6Z0eYUyfM9DsK8LUYhTu8cl+SAXR5ALoE 6kVR/D+ZCaMYzM/7IQ1ITQMoql5JIwJlR0I08oJJE/xVaceUtMgFGUH1NxTc+/KDV3Yaks6WZ0m +R1RGDIV2qerjqAQF/zCCdoTfW9jLThyonuJQBxidZCJVo8N7UyanOPPUxHDR2TNwADx7MA7jaj CY58tCozvciRQJnusm0= X-Google-Smtp-Source: AGHT+IHOkA7B4CBUnXmuM2/HY5Ocl7DCx0TNxVuUAfl0RrYPBkBw9RKK3LpqJnlb8hijFCqHgRuoWA== X-Received: by 2002:a05:6808:6f8b:b0:3fa:55c7:2497 with SMTP id 5614622812f47-4035a5d0ed3mr3336554b6e.38.1746394546037; Sun, 04 May 2025 14:35:46 -0700 (PDT) Received: from fedora ([2806:10ae:e:b33c::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40349a8f7cbsm1207776b6e.50.2025.05.04.14.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 14:35:45 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: <87y0vcerk9.fsf@gmail.com> References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> <87frhpphek.fsf@gmail.com> <87bjscfy11.fsf@gmail.com> <87cycr514l.fsf@gmail.com> <8734dnf6xt.fsf@gmail.com> <871pt6cvbv.fsf@gmail.com> <87y0vcerk9.fsf@gmail.com> Date: Sun, 04 May 2025 15:35:44 -0600 Message-ID: <875xigkqj3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 78106 Cc: 78106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jo=C3=A3o T=C3=A1vora writes: > Elijah Gabe P=C3=A9rez writes: > >> For now i think that the hardcoded mouse-2 would be the best choice, >> also I've seen in other packages (including built-in) that they does the >> same. > > I suppose. In fact it's better to have mouse-1, not mouse-2, for the > margin and mode-line, so I changed that. The reason we use mouse-2 for > in-buffer diagnostics overlays is because it's bad practice to rebind > mouse-1 there, whose meaning in an editable buffer should always be > "place point here". I don't have problem with rebinding mouse-2 to mouse-1, so this is fine. >>> (add-to-list >>> @@ -4146,14 +4150,13 @@ eglot-code-action-suggestion >>> (setq tooltip >>> (propertize eglot-code-action-indicator >>> 'face 'eglot-code-action-indicator-face >>> - 'help-echo blurb >>> + 'help-echo "mouse-2: execute code actio= ns at point" >> >> "mouse-2: execute code actions at point" will appear also in ElDoc. > > How? I don't see that happening in my testing. Then i test it wrongly, I've tested it again, and now it works fine. > See patch after my sig. If you're content, I can push it: > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 474245352d6..d33b0b05fd4 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -2531,7 +2531,11 @@ eglot-mode-line-action-suggestion > '(:eval > (when (and (memq 'mode-line eglot-code-action-indications) > (overlay-buffer eglot--suggestion-overlay)) > - (overlay-get eglot--suggestion-overlay 'eglot--suggestion-tooltip)= )) > + (eglot--mode-line-props > + eglot-code-action-indicator 'eglot-code-action-indicator-face > + `((mouse-1 > + eglot-code-actions-at-mouse > + "execute code actions at point"))))) > "Eglot mode line construct for at-point code actions.") >=20=20 > (add-to-list > @@ -2578,7 +2582,7 @@ eglot--diag-to-lsp-diag > (defvar eglot-diagnostics-map > (let ((map (make-sparse-keymap))) > (define-key map [mouse-2] #'eglot-code-actions-at-mouse) > - (define-key map [left-margin mouse-2] #'eglot-code-actions-at-mouse) > + (define-key map [left-margin mouse-1] #'eglot-code-actions-at-mouse) > map) > "Keymap active in Eglot-backed Flymake diagnostic overlays.") >=20=20 > @@ -4146,14 +4150,13 @@ eglot-code-action-suggestion > (setq tooltip > (propertize eglot-code-action-indicator > 'face 'eglot-code-action-indicator-face > - 'help-echo blurb > + 'help-echo "mouse-1: execute code actions= at point" > 'mouse-face 'highlight > 'keymap eglot-diagnostics-map)) > (save-excursion > (goto-char (car bounds)) > (let ((ov (make-overlay (car bounds) (cadr bounds)))) > (overlay-put ov 'eglot--actions actions) > - (overlay-put ov 'eglot--suggestion-tooltip tooltip) > (overlay-put > ov > 'before-string > Nothing wrong here, so this can be pushed. --=20 - E.G via GNU Emacs and Org. From debbugs-submit-bounces@debbugs.gnu.org Tue May 06 05:59:31 2025 Received: (at 78106-done) by debbugs.gnu.org; 6 May 2025 09:59:31 +0000 Received: from localhost ([127.0.0.1]:52176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uCF5G-0006WM-TB for submit@debbugs.gnu.org; Tue, 06 May 2025 05:59:31 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:48469) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uCF5E-0006Uk-73 for 78106-done@debbugs.gnu.org; Tue, 06 May 2025 05:59:29 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-ac2a81e41e3so1009459366b.1 for <78106-done@debbugs.gnu.org>; Tue, 06 May 2025 02:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746525562; x=1747130362; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iPVZPVNniGnohICrNkq4IGXagt1qSdPvPvK1tDEulW4=; b=T6LM8L1Hqbxd40GIc+gLT4OGoCxstja8q/ylArOqkWhEXDK+PZ9nKLlHb7Va9VHQDJ O0gV5V5JG16Az7AoQ6oaYxOmd9iar5ZhpmQI6BnYewpl4h1DJxjSvrJM/FXolX3Ssh15 l2s8QFUJPU2GlvP1pup7pXGpKaprsG+DCBWx72jvb1bYJxRuSwmZdsGzn89ZOKu6Iltg TxPEC2ShTz/sn4YA8FjUc5DbfP8fLbMoY/YYPMAjaAsFKJVGwx6vckU8EcmpqpWCHFX1 9Cs2bajkQB0wVm1caU+VqAwX0mSgdlVfq3zUFJx1guNiR6UXcfeGZqrwwy8kqEtZpUcn Kt2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746525562; x=1747130362; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iPVZPVNniGnohICrNkq4IGXagt1qSdPvPvK1tDEulW4=; b=l+/JMCRBKud620z3urgp6P6bO+cztbCH89jeRN0713ILqJtwdlR67y5JVpPq+NEKhd JscmXzKKkXQzk6D1DtHwH7ovnCgmMn1AAMiYTCUNsK8TnDIhdQNrJl4edDg/HB1WTvjy 69XVxA+HA+PGc9CKzVvbpbf8oHXScLb6pWUdb6Job83rU7V76TZAJVGepcZCRAxwMAJ7 begdGmZmSk5HrDSIYVVdG9f9aOeKKMKZmlexTtLtM+wGEW5wKkx2IHhd10gvhnVmCGtO IochaK1MZxhS7oyRYt4Lut1MDc+3QoXbmblYKLC31Jc6xMLjfJ6xwbi3RPW8ihE6UvVL SEOQ== X-Gm-Message-State: AOJu0YzXzMQZuwqeOZunljogSxYe2U05qSpjc81zVoGwA5G9hmizWti8 O8GoTmxWMXcN8UQhDAI20qYjf5HP0Ac2euZfzODto+JJ3aZoA/q4BmPjTQ== X-Gm-Gg: ASbGncvtHVstOv53cZDjK1NkPxEDdIJFd9GY0jWuHcxGstWBn6Sesg8/tnHpMZLKUUh sSlUDNuHtNM8qMhGhQLzoCh2/XrnZLukDFRzk7Uc4qDXZ05pKSLKGBZSy+1BSmuZmy8ukcnoEcp vNOyhGenKGmi0c44JR/9OYzxvfawqcD3bYHgsG22XwbBSJb7D3ldhVjOpSS9q2mxxNlFJH09bQF MhTaN1nu/2uzovdmZjokQp8uaDqf+APVPnvUS3KLy1kLiJs6SblgobixOkmn+ED1RnbDkhlY3+s 0jQQuXcLK84yWZ8AGtwzHdzxWZZaHANuUrJHRlNmEMRTlT2/cmf4AE0= X-Google-Smtp-Source: AGHT+IFGmdelUahVt+4N+Z2+rK9GFM4m65yVn+2DY6yyB9Ekl1/60n6bUjcMaX8BaqJJ4rSz5BprBg== X-Received: by 2002:a17:907:980a:b0:ace:c2ab:a728 with SMTP id a640c23a62f3a-ad1d44fc16fmr206781366b.9.1746525561374; Tue, 06 May 2025 02:59:21 -0700 (PDT) Received: from krug (87-196-82-27.net.novis.pt. [87.196.82.27]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad18950acb3sm667208566b.156.2025.05.06.02.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:59:20 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= Subject: Re: bug#78106: [Feature Request] EGLOT: Optionally make code action indications use mouse clicks In-Reply-To: <875xigkqj3.fsf@gmail.com> References: <87frhrzwt5.fsf@gmail.com> <87selppoyu.fsf@gmail.com> <87frhpphek.fsf@gmail.com> <87bjscfy11.fsf@gmail.com> <87cycr514l.fsf@gmail.com> <8734dnf6xt.fsf@gmail.com> <871pt6cvbv.fsf@gmail.com> <87y0vcerk9.fsf@gmail.com> <875xigkqj3.fsf@gmail.com> Date: Tue, 06 May 2025 11:00:01 +0100 Message-ID: <87tt5ydppa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78106-done Cc: 78106-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Elijah Gabe P=C3=A9rez writes: > Nothing wrong here, so this can be pushed. Done, and closing. From unknown Wed Jun 18 23:06:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 03 Jun 2025 11:24:20 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator