GNU bug report logs - #78102
[PATCH] gnu: Add redumper.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 78102 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Gabriel Wicki <gabriel <at> erlikon.ch>
Subject: [bug#78102] [PATCH v2 1/3] build/cmake: Add #:implicit-inputs? and #:implicit-cross-inputs? arguments.
Date: Wed, 30 Apr 2025 00:31:37 +0900

* guix/build-system/cmake.scm (lower) <#:implicit-inputs?>
<#:implicit-cross-inputs?>: New arguments.

Change-Id: I1f077f78f5836ce325827e7ef8d58ba554a8ed4f
---
 guix/build-system/cmake.scm | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/guix/build-system/cmake.scm b/guix/build-system/cmake.scm
index 9d757c0d061..8b1889e36bc 100644
--- a/guix/build-system/cmake.scm
+++ b/guix/build-system/cmake.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2013 Cyril Roelandt <tipecaml <at> gmail.com>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2025 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -65,12 +66,14 @@ (define (default-cmake target)
 
 (define* (lower name
                 #:key source inputs native-inputs outputs system target
+                (implicit-inputs? #t) (implicit-cross-inputs? #t)
                 (cmake (default-cmake target))
                 #:allow-other-keys
                 #:rest arguments)
   "Return a bag for NAME."
   (define private-keywords
     `(#:cmake #:inputs #:native-inputs
+      #:implicit-inputs? #:implicit-cross-inputs?
       ,@(if target '() '(#:target))))
 
   (bag
@@ -83,13 +86,15 @@ (define* (lower name
                     ,@`(("cmake" ,cmake))
                     ,@native-inputs
                     ,@(if target '() inputs)
-                    ,@(if target
+                    ,@(if (and target implicit-cross-inputs?)
                           ;; Use the standard cross inputs of
                           ;; 'gnu-build-system'.
                           (standard-cross-packages target 'host)
                           '())
                     ;; Keep the standard inputs of 'gnu-build-system'.
-                    ,@(standard-packages)))
+                    ,@(if implicit-inputs?
+                          (standard-packages system)
+                          '())))
     (host-inputs (if target inputs '()))
 
     ;; The cross-libc is really a target package, but for bootstrapping
@@ -97,7 +102,7 @@ (define* (lower name
     ;; native package, so it would end up using a "native" variant of
     ;; 'cross-libc' (built with 'gnu-build'), whereas all the other packages
     ;; would use a target variant (built with 'gnu-cross-build'.)
-    (target-inputs (if target
+    (target-inputs (if (and target implicit-cross-inputs?)
                        (standard-cross-packages target 'target)
                        '()))
     (outputs outputs)

base-commit: 2b4680c6c17bd6470f78a1f39d2f7af8b05e279f
-- 
2.49.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.