From unknown Fri Jun 20 07:25:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#78102 <78102@debbugs.gnu.org> To: bug#78102 <78102@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add redumper. Reply-To: bug#78102 <78102@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:25:43 +0000 retitle 78102 [PATCH] gnu: Add redumper. reassign 78102 guix-patches submitter 78102 Maxim Cournoyer severity 78102 normal tag 78102 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 27 22:49:24 2025 Received: (at submit) by debbugs.gnu.org; 28 Apr 2025 02:49:24 +0000 Received: from localhost ([127.0.0.1]:47858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9EYd-0000d2-Nr for submit@debbugs.gnu.org; Sun, 27 Apr 2025 22:49:24 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44188) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9EYY-0000bd-RR for submit@debbugs.gnu.org; Sun, 27 Apr 2025 22:49:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9EYT-0007Ai-6r for guix-patches@gnu.org; Sun, 27 Apr 2025 22:49:13 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9EYR-0002O1-D8 for guix-patches@gnu.org; Sun, 27 Apr 2025 22:49:12 -0400 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-879d2e419b9so3561503a12.2 for ; Sun, 27 Apr 2025 19:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745808548; x=1746413348; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FPfXuSOCvAlTbVl01BLSAIFJd0bcHRnfivYXzwzMokU=; b=h2St2gIWLL7RmP+pWAzyJzunm7epYlTaeXlVk+BLrgCsIKB12OlOb8qjduyMve3MbW bLe+kIslCYqLIz6LyRwMyi6gifw1irnteSnpTO8sY9mtRg465siynlYABFY52u3AQ316 tO76m2VVAdDyO563psQT/rCxxYjqI996iFei1Fbvenm937D+HM1A8GrIiZqeml32mhQJ tgjaU+ksgM8Pk4Rr75CTkzz49Yw25VCovc1D+BWuJQKZgxghnMe1oS//ZOBDexXnJmgP D/+QPROADzIYHz38E0IuMF/OGmj1yZmKcni9xU7cVyBjbmFlp5JfX412khh9fJEjkBgr eHLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745808548; x=1746413348; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FPfXuSOCvAlTbVl01BLSAIFJd0bcHRnfivYXzwzMokU=; b=dKS5vhswn4dXialjpfpat3zReIq5Datl8SDt13f/oK3x3h6fHnjs99h9dunrMjorRz 2/DkNR+t6HYDH/TbTb+OalwQ70gO8StF2LYf+U0iglTGMl2UpPA3M9mFSkbIBzgRNUJd JH9hkACYUQ+YexmAuA9dKCniP0cm1/cpljZ2OjXHMKjE1vxXNINaMYf0fsT6I+f64PYQ ajTMajU61JL35hqzcxEt7mPAF6ZO3UDQfjYgAPmc/dwhQ4erNyv8e8DvByYjfJvfMeBO 53SR08bUwXLIshj8RZVm1QROjpxsq47RWAgDCitqI5sL8GsgwXdnM5LZ4HdjLlWtwPq3 gunQ== X-Gm-Message-State: AOJu0Yy21Cj8i245llkDys8QyItqMGaH6WHJgSwZRFvR0P2i7etYeHN5 Ly7HAgbr9zhpGtIskN3wH4OxdFLtHOWphE1D2zkT0TCyAhHNtIWJeNehUg== X-Gm-Gg: ASbGncsOpR/2TbosZMfRyevPtauXypGHYb+x9SEK4UgxQbPGr1QuSS4KrHaRH/TQDmn 75/tZMw99IH2Rc6VgpmhHcXiWDa+y+2FPB8I4pWWJYTDOqzMXW2p88MunshMTch9cQEd0Bfybc0 nqFNapQkNb91tcO8dGNzDsaWiNy59rCFSQML883PUr2TjVP/HBzieunqSp402jI4iDj/EHUOciy VqeXTzbqoEES2TBhdnTzIhu7tvt+5SjpY8Vj9byxqvHfdrNQdI2KmUT6cAw+uRaUS5qePlRo6VH sXol1sDtzeyidjjJ3mEIGWPU0FFu3grkbh12Jfe1enulTp3qOtasloiu8aBiOpqzVdPHsME= X-Google-Smtp-Source: AGHT+IGuLo8jpQLmKBkQorC41XneKCK3wdSxib/8jf+Kbbj2utYNVixd1+ssSKkbZG8M8gK0v4l07w== X-Received: by 2002:a05:6a20:c991:b0:1ee:d8c8:4b82 with SMTP id adf61e73a8af0-2045b99e143mr16374219637.31.1745808548367; Sun, 27 Apr 2025 19:49:08 -0700 (PDT) Received: from localhost.localdomain ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b15f8597f5csm6236562a12.43.2025.04.27.19.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 19:49:07 -0700 (PDT) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: [PATCH] gnu: Add redumper. Date: Mon, 28 Apr 2025 11:49:01 +0900 Message-ID: <9966a347ee398a118b13a1febfcf62d7f77d0cc8.1745808541.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Gabriel Wicki Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=maxim.cournoyer@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/audio.scm (redumper): New variable. Change-Id: I3740c6941d1ab11ac38993775a8004618636513c --- gnu/packages/audio.scm | 71 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 03867b2da36..178818d1f68 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -126,6 +126,7 @@ (define-module (gnu packages audio) #:use-module (gnu packages music) #:use-module (gnu packages ncurses) #:use-module (gnu packages networking) + #:use-module (gnu packages ninja) #:use-module (gnu packages onc-rpc) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) @@ -4082,6 +4083,76 @@ (define-public libshout-idjc ;; GNU Library (not Lesser) General Public License. (license license:lgpl2.0+))) +(define-public redumper + (package + (name "redumper") + (version "561") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/superg/redumper") + (commit (string-append "build_" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1r0wfi0fn3rq7s28p89rkgpgf567akd8z25l8r9sj7p4p3xp9m91")))) + (build-system cmake-build-system) + (arguments + (list + #:cmake cmake-next + #:build-type "Release" + ;; The build system uses CMake modules features that are only available + ;; when using Ninja. + #:configure-flags #~(list "-GNinja" + "-DREDUMPER_CLANG_USE_LIBCPP=ON" + (string-append "-DREDUMPER_VERSION_BUILD=" + #$version) + "-DCMAKE_BUILD_TYPE=Release") + #:phases + #~(modify-phases %standard-phases + (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH + ;; The libcxx include/c++/v1 directory is not exposed via + ;; CPLUS_INCLUDE_PATH by default, causing errors like + ;; "fatal error: 'format' file not found". + (lambda* (#:key native-inputs inputs #:allow-other-keys) + (let ((gcc (assoc-ref (or native-inputs inputs) "gcc"))) + (setenv "CPLUS_INCLUDE_PATH" + (string-append + (search-input-directory inputs + "/include/c++/v1") ":" + (getenv "CPLUS_INCLUDE_PATH")))))) + (replace 'build + (lambda* (#:key parallel-build? #:allow-other-keys) + (invoke "cmake" "--build" "." + "-j" (number->string + (if parallel-build? + (parallel-job-count) + 1))))) + (replace 'check + (lambda* (#:key build-type parallel-tests? tests? + #:allow-other-keys) + (when tests? + (invoke "ctest" "-C" build-type + "-j" (number->string + (if parallel-tests? + (parallel-job-count) + 1)))))) + (replace 'install + (lambda _ + ;; There is no CMake install target; manually install the + ;; binary. + (install-file "redumper" + (string-append #$output "/bin"))))))) + (native-inputs (list ninja clang-toolchain-19)) + (inputs (list libcxx)) + (home-page "https://github.com/superg/redumper") + (synopsis "Low-level CD/DVD dumper") + (description "@command{redumper} is a low-level byte perfect CD disc +dumper. It supports incremental dumps, advanced SCSI/C2 repair, intelligent +audio CD offset detection, among other features. @command{redumper} is also a +general purpose DVD/HD-DVD/Blu-ray disc dumper.") + (license license:gpl3+))) + (define-public resample (package (name "resample") base-commit: 56999614a45449c4b93c8614540210b609c2b356 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 03:58:15 2025 Received: (at 78102) by debbugs.gnu.org; 29 Apr 2025 07:58:16 +0000 Received: from localhost ([127.0.0.1]:47744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9fr3-000558-G5 for submit@debbugs.gnu.org; Tue, 29 Apr 2025 03:58:15 -0400 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]:42983) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9fqz-00053s-2y for 78102@debbugs.gnu.org; Tue, 29 Apr 2025 03:58:10 -0400 Received: from silvi (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA id 584C31FF54; Tue, 29 Apr 2025 09:58:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=erlikon.ch; s=20250312; t=1745913482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O7NhRmQtW8w+HA4Ua6cOTSzy0z5xj1zQux6Qxfphxgw=; b=ChRbtHU+EQIPlqgS5KtWLrFpyHEai4pj9BVcAO85w6doK8fMjcPBvoBaHJuorwDLwTf7lh KzCKnYPlLqL+Wl2nZ8H7xhIhg66NvKXwxc/O2zabgwHnsIdU9UHF1GDrxVxqrDETOiH3h7 3uMQUlSmScZy+zdl6prBzUlG+8hhSfulXnpsd2iIcFkI5tR54o48FHyN28NYnzjE5SAHYh N5C1d8mHJUHxxr6/9/ULz3QQSIFvBDU6AT1PRXPUcrUjNQFtLDuTg9i8f3/x4W2K4wazPx /6aSIdWMMM6XwixhSpHRP+wgJztoG16UM9Txd3iuor2mVtQlzzPHzOOpedr9kiESOqM5LZ DWCs4d5rwRQu+p+JKohmlU3Tglru3TOsUKlukVEtE1VED4qN4gCoiEu7vfCWR48zwbx8wX o1Jn3Xw/ZcMiYEKd3EeMpaq2GelLxmAWetZThhcKJV9gEZWaj8+eZWAWBxawXcuKqbTdWw pIoqKceB+xeGrDOIAicRteQFd804yQcx7LN9kWFCl9Ag8rI3bZqfKQHUt/cVRPbWcJHZnW N1kV5mw8SMQimNob6Py0AeIQaIJxnXUM9mowpzeMzIwE7TTr6dhVvZgMHNovblLrt31BqA nuDa1R9nzTk/3bgdhBDlek/wD0gUet+sGYxnw9pgkRj9k/OgPM2BY= Date: Tue, 29 Apr 2025 09:57:59 +0200 From: Gabriel Wicki To: Maxim Cournoyer Subject: Re: [bug#78102] [PATCH] gnu: Add redumper. Message-ID: <2vdzd63rhzp37fv2g6zjoztoyce4pyvsrec7hee2gp55zcipdc@smyuxaqa7cc3> References: <9966a347ee398a118b13a1febfcf62d7f77d0cc8.1745808541.git.maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9966a347ee398a118b13a1febfcf62d7f77d0cc8.1745808541.git.maxim.cournoyer@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: 78102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) LGTM but unfortunately the 'adjust-CPLUS_INCLUDE_PATH phase does not work in cross-compilation context. do you think it is possible to get this to work? that would be really awesome. the error i'm getting says: > error: in phase 'adjust-CPLUS_INCLUDE_PATH': uncaught exception: > wrong-type-arg "string-append" "Wrong type (expecting ~A): ~S" ("string" #f) (#f) thanks for your time and effort! g From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 11:32:11 2025 Received: (at 78102) by debbugs.gnu.org; 29 Apr 2025 15:32:11 +0000 Received: from localhost ([127.0.0.1]:58135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9mwM-0006Hx-N0 for submit@debbugs.gnu.org; Tue, 29 Apr 2025 11:32:11 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:48419) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9mwI-0006Gv-4M for 78102@debbugs.gnu.org; Tue, 29 Apr 2025 11:32:06 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-7396f13b750so6804206b3a.1 for <78102@debbugs.gnu.org>; Tue, 29 Apr 2025 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745940719; x=1746545519; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nSXfXjEHKF6UtXz6io7MhJLBtSGZH6EB4wmo4caJETQ=; b=fulxbc5eF7dW8/+7nZv9bg9JAztkxV+GDWJjgpn+piyigjl89NF3xgF+TfsRmEaGOS IT9ZJdvRJLt6zij5AwJ2nFTvIFnUY6uS1AHD4QVbVJchkFO1WBZCSqNogWHTKIPOfv93 oeJi0loY+xzGh2mu9iVQAV6vWIegXmqKTUs63BmQ3m5D1gZFp3sCSopohgWY+iauUq+q hQern25SELu2iKtHzUFUsTa+UOmqjqZecgGG6dUdhmkiXn+OdvWkyL6aFKNW4mVDIpqs jIaURTFfYfdaNnUy1Il4kgahPId61PCRbe9az2kUWsUAaAo0SskvKnf6nu66NhAXPZMm dfCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745940719; x=1746545519; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nSXfXjEHKF6UtXz6io7MhJLBtSGZH6EB4wmo4caJETQ=; b=sfBq9WI+/m1Ea7aRyjLHc8xHii3WlzQHD2NpVHOykHsw3yqqzFGmZ5ilGAiIKn9fFB tTFzJXPfykyqqN47ZhF7zoNTbzMpTjEf6EzrsLh+3lWByDAN8WasBPPS/izKc3kt0kxS lUfndOvJV3P0I+pY153moYEcYuS5jviJfwIz8k+tIq3uUwZfSlH0oHF2cAQO8LW2X7Xd vo8ugY+tUSGSlABwyLvOhA4L+tAuQMdZac11n3FvJbmX8/rV0fIAOxrh68uOILK/+NRf B1jCsLJZyEZy7hXufAqYRKh1YRZD7WMddk3MM6knh7ZBfVnXz2g2o7YwA5XyovCW98Ow TXgQ== X-Gm-Message-State: AOJu0YwoTESJfr6KuPO0R0T+J8yNeSJ2HD6i1/22vpytUKlKHclzlPZ7 nr0LjwwHv/JqiHbH++aKCof+1H5DHc9Tw19ObuPN7a4pYCRn6DpP/HM+7A== X-Gm-Gg: ASbGncuU2DkLkJYer+RnAwoQCHpiq4d3cnb+Miw5SuW48xGsT6mOYMNEcnLl6kXQ+SF E5thT04GqzfqBdExfsEf5SZv1z4Y/10JH/TCsjC/67uBDPG2jffoOl8drZ8b8BcJyVnrIJ+R0sp 3r9iYx2LggXJcJIFjDuRIpkeaiAnzKkSJLCRJ8UNm1pAb6pp5kpnyW5NJl7aWsguvgm7//Qm/Km 6vP0pqcOOCw0bZ+4vZS4ikve1NQtzI1GcIuKBR3LRRxUklIGOyN6J6Y/AYQaTJTyUt/epzStKVq qftPUQ9ynWQ3t7OvB33gmJPKY2SvrOmOh1E68jDjkGVtsp0nJ9jJVpThpq68QYIIBhnaqTY= X-Google-Smtp-Source: AGHT+IG2Q0MGB5MjWOAw2omTchVGzmLroCVG2hNjn6w903qtWem4Km3d2ywNjw21NbkS2+Dks/24Yg== X-Received: by 2002:a05:6a00:1942:b0:736:a8db:93b8 with SMTP id d2e1a72fcca58-7402925e549mr4869370b3a.3.1745940719210; Tue, 29 Apr 2025 08:31:59 -0700 (PDT) Received: from localhost.localdomain ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a420sm10303533b3a.107.2025.04.29.08.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 08:31:57 -0700 (PDT) From: Maxim Cournoyer To: 78102@debbugs.gnu.org Subject: [PATCH v2 1/3] build/cmake: Add #:implicit-inputs? and #:implicit-cross-inputs? arguments. Date: Wed, 30 Apr 2025 00:31:37 +0900 Message-ID: <7e9be31603f35d063e9568fe7650be901e671951.1745940699.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Maxim Cournoyer , Gabriel Wicki Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/build-system/cmake.scm (lower) <#:implicit-inputs?> <#:implicit-cross-inputs?>: New arguments. Change-Id: I1f077f78f5836ce325827e7ef8d58ba554a8ed4f --- guix/build-system/cmake.scm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/guix/build-system/cmake.scm b/guix/build-system/cmake.scm index 9d757c0d061..8b1889e36bc 100644 --- a/guix/build-system/cmake.scm +++ b/guix/build-system/cmake.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2013 Cyril Roelandt ;;; Copyright © 2017 Ricardo Wurmus ;;; Copyright © 2020 Efraim Flashner +;;; Copyright © 2025 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -65,12 +66,14 @@ (define (default-cmake target) (define* (lower name #:key source inputs native-inputs outputs system target + (implicit-inputs? #t) (implicit-cross-inputs? #t) (cmake (default-cmake target)) #:allow-other-keys #:rest arguments) "Return a bag for NAME." (define private-keywords `(#:cmake #:inputs #:native-inputs + #:implicit-inputs? #:implicit-cross-inputs? ,@(if target '() '(#:target)))) (bag @@ -83,13 +86,15 @@ (define* (lower name ,@`(("cmake" ,cmake)) ,@native-inputs ,@(if target '() inputs) - ,@(if target + ,@(if (and target implicit-cross-inputs?) ;; Use the standard cross inputs of ;; 'gnu-build-system'. (standard-cross-packages target 'host) '()) ;; Keep the standard inputs of 'gnu-build-system'. - ,@(standard-packages))) + ,@(if implicit-inputs? + (standard-packages system) + '()))) (host-inputs (if target inputs '())) ;; The cross-libc is really a target package, but for bootstrapping @@ -97,7 +102,7 @@ (define* (lower name ;; native package, so it would end up using a "native" variant of ;; 'cross-libc' (built with 'gnu-build'), whereas all the other packages ;; would use a target variant (built with 'gnu-cross-build'.) - (target-inputs (if target + (target-inputs (if (and target implicit-cross-inputs?) (standard-cross-packages target 'target) '())) (outputs outputs) base-commit: 2b4680c6c17bd6470f78a1f39d2f7af8b05e279f -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 11:32:21 2025 Received: (at 78102) by debbugs.gnu.org; 29 Apr 2025 15:32:21 +0000 Received: from localhost ([127.0.0.1]:58139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9mwT-0006JE-5g for submit@debbugs.gnu.org; Tue, 29 Apr 2025 11:32:21 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:61478) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9mwN-0006Hm-SM for 78102@debbugs.gnu.org; Tue, 29 Apr 2025 11:32:13 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-736c3e7b390so6268445b3a.2 for <78102@debbugs.gnu.org>; Tue, 29 Apr 2025 08:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745940725; x=1746545525; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cDdWP0OOnsgpnLzCcVMtZS5uuxbrR3GvNMSquv71eEE=; b=T8VDfG5Z8f9TgiQ4pzD9uZk/ADb4tlym5kel+CI4wEMwSy/Kk5qRSxYRbWOJoDbS16 8hvRUUO66o3/uKFT/27m/2t4SC+0FJEjwmhoWFPRI35AM8aekGvJCe77BJ4CWpiQoqFA tg/l2PuROECbyyodjCqFEqimQDwRJ/fEstr24FEenEZ2Wheold9SiwaRaW81KHJSCc8b DiYJDXiI95xCXNm0IIaIlYHv+28+MG1ElyrKP2iuV3bBVifeIFRLvqUP06vpgIVWoz0O ltX1fLHbMnFtWcgNZIWYZ77Pv0d07H/9TQUTo+xwSPhIoGeAh9YyddNfatmv7pmVCktK CYFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745940725; x=1746545525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cDdWP0OOnsgpnLzCcVMtZS5uuxbrR3GvNMSquv71eEE=; b=TZ+vUrAMpDmPasrMIlN4so1D7S2wLg+J81qVd1PE67VM5yHJfbB5bA/yupcAfGh6iL +n+irwd8am99flUCpZeF3oftZbtNsyJVy1vrH+bXaYyhKCXHLIm7TI/HROyJr3dZCRzP iYuYHBtI7gTsvIYFTIl43OdhBn9dqUxmSzsWwxAPZRYW3dnZEsDO9ziKagmXz3zfl9dO a10JRJppA7vB+JVYuXlEB/P06FFK8ehew7m38/Eq2CwrKABrekSf55F/st1AuFPCceqY u34Horoe7MSeega4Lix7WgUytNZNGCDTDWVqOmVDMrS0dVuQAf/rC3K3+8gAGdot27i3 H7EA== X-Gm-Message-State: AOJu0YwTD5Nge/WTK3y/bCNhYFR701QNG0k4vEGU9d60c4mAAIqxZFAn +gXUQM5N5I05mEvgxCIikpufE3xEcVYalpuqLkdrsVT+lb65jIt6zfWzpQ== X-Gm-Gg: ASbGncvXdH98KnAfq6lSU3hLZ4PXbKWTuoyJPEGTVa6ruSZNSRP1p9KsVoygfYC9xqi HxbX06CuPasn3QzWhJHqwBl00fNDAZ65MI6WHtXv7b7zFCfzTtirtLHKXDxEGQKtr1yZL40/8Ke Ez5eBpA5QKSHaO1Vn8mS1qw9/2IbjiRU3oIuQuK8KMWspEYp351q9OAb52VoNixIRWQHTNdO/TO iOCrxi8FT3f7aHYGvJ5TZHWf9XRfwbyyo05hzUdEjGBtncybomZH2b7Za9kUsAk6yb5ySquSKyy YpF4bc6sDLpgJavxA6TIMl8a9e1CTnDNERQFS1UsY7nZKYM38OPB/gyT3O3u X-Google-Smtp-Source: AGHT+IFHzVY0WGdg1ypwwf6DbMfAjTOymL+zIb2QTF+UREGVOKn/6S4phSb8y9So1EB/1lvBLnBzpQ== X-Received: by 2002:a05:6a00:3927:b0:732:2923:b70f with SMTP id d2e1a72fcca58-740271689ffmr5462349b3a.11.1745940725031; Tue, 29 Apr 2025 08:32:05 -0700 (PDT) Received: from localhost.localdomain ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a420sm10303533b3a.107.2025.04.29.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 08:32:04 -0700 (PDT) From: Maxim Cournoyer To: 78102@debbugs.gnu.org Subject: [PATCH v2 2/3] gnu: libcxx: Fix cross-compilation build. Date: Wed, 30 Apr 2025 00:31:38 +0900 Message-ID: <47cce130906c96519b8f1505897c3986663b6276.1745940699.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <7e9be31603f35d063e9568fe7650be901e671951.1745940699.git.maxim.cournoyer@gmail.com> References: <7e9be31603f35d063e9568fe7650be901e671951.1745940699.git.maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-Debbugs-Cc: Maxim Cournoyer , Gabriel Wicki Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/llvm.scm (libcxx) [arguments] <#:implicit-inputs?>: Set to #f. <#:phases>: Remove adjust-CPLUS_INCLUDE_PATH. [native-inputs]: Explicitly provide standard inputs, filtering out gcc. Change-Id: I8cbc73ef90dce0a57bf2f8198c3176932bf24185 --- gnu/packages/llvm.scm | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index a0f47447bee..49b6e27bff9 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -17,7 +17,7 @@ ;;; Copyright © 2020 Giacomo Leidi ;;; Copyright © 2020 Jakub Kądziołka ;;; Copyright © 2021, 2022 Maxime Devos -;;; Copyright © 2020, 2021, 2022, 2024 Maxim Cournoyer +;;; Copyright © 2020-2022, 2024-2025 Maxim Cournoyer ;;; Copyright © 2021 Julien Lepiller ;;; Copyright © 2021 Lars-Dominik Braun ;;; Copyright © 2021, 2022 Guillaume Le Vaillant @@ -52,6 +52,7 @@ (define-module (gnu packages llvm) #:use-module (guix memoization) #:use-module (guix search-paths) #:use-module (guix utils) + #:use-module (guix build-system gnu) #:use-module (guix build-system cmake) #:use-module (guix build-system emacs) #:use-module (guix build-system python) @@ -1905,6 +1906,7 @@ (define-public libcxx (build-system cmake-build-system) (arguments (list + #:implicit-inputs? #f ;to avoid conflicting GCC headers #:tests? #f #:configure-flags #~(list "-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi;libunwind" @@ -1920,23 +1922,14 @@ (define-public libcxx #~(modify-phases %standard-phases (add-after 'unpack 'enter-subdirectory (lambda _ - (chdir "runtimes"))) - (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH - (lambda* (#:key inputs #:allow-other-keys) - (let ((gcc (assoc-ref inputs "gcc"))) - ;; Hide GCC's C++ headers so that they do not interfere with - ;; the ones we are attempting to build. - (setenv "CPLUS_INCLUDE_PATH" - (string-join (delete (string-append gcc "/include/c++") - (string-split (getenv "CPLUS_INCLUDE_PATH") - #\:)) - ":")) - (format #t - "environment variable `CPLUS_INCLUDE_PATH' changed to ~a~%" - (getenv "CPLUS_INCLUDE_PATH")) - #t)))))) + (chdir "runtimes")))))) (native-inputs - (list clang-19 libunwind-headers llvm python)) + (append (list clang-19 libunwind-headers llvm python) + ;; Remove GCC from the build environment, to avoid its C++ + ;; headers (include/c++), which would interfere and cause build + ;; failures. + (map second + (alist-delete "gcc" (standard-packages))))) (home-page "https://libcxx.llvm.org") (synopsis "C++ standard library") (description -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 11:34:39 2025 Received: (at 78102) by debbugs.gnu.org; 29 Apr 2025 15:34:39 +0000 Received: from localhost ([127.0.0.1]:58186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9myk-0006Ya-Cy for submit@debbugs.gnu.org; Tue, 29 Apr 2025 11:34:39 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:57451) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9myh-0006Y8-Ck for 78102@debbugs.gnu.org; Tue, 29 Apr 2025 11:34:36 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-736c1cf75e4so5269513b3a.2 for <78102@debbugs.gnu.org>; Tue, 29 Apr 2025 08:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745940868; x=1746545668; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9suYX6bQhGhvMf2qaST/+nFqSz11aJEYPv2RWrL2JiA=; b=YYubBISMOwdRbsLMOYYtxW7ZDsgPxuoACqBwa+pA2tkpkw7eVfsL1cuBHjiQAx24Sh KQLQwzOnWZMLWTqNMXAAmXUyUzxvQuVuQvVMio2dffsj8gWHZj6wzSeZQ1GBjFKklsYG QMKSOcEmHy9R0rt6xUCyApgzOgnXKBeL76FBckKpVRv0QHcKEOJZPjqmLW8m+q2Fa/+y 7QNdSHquOuorbTKzx+z/nl9yjohFev0tjoT5IbMEl/G8btYDUwzB9x5BK+/Dlt4yak3f +5N290CMpDZBfyMmuo9ES298DcVGtmOssJos6/Ey1sqYJJBnrLADyqH4HieLF0UJuuqz 2NMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745940868; x=1746545668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9suYX6bQhGhvMf2qaST/+nFqSz11aJEYPv2RWrL2JiA=; b=b+f7BIxJ2SfR9GFJkCm5ojVL7beh1pfIIjf5dP/ijd6IbfzV6OheoP47NbqG3wjlAe /XrM0UEzCpuBk/nnCARbnMDywbpChZ39B7PhuHylBbVr89xFTa6G0O8M1zz0iGgfhPef vy55GGOOMesVCBRqOIYN5II3tioYDY8m1rBggG3/Uf3JpCLxvDkeuxMW1cp7uZOd9FjP PZ6pAT3q2NIO+DTi+g2ODA5g9rLz7Lkcm3UDuI3ADWP7S9zmsCLT9T4RCJuhUpH+SoB+ TS5nX0/NO5GGe8BKkhffghbctbKlC86qlwvRim+Yg0B1sREWeYP+5cgFyBLsbTKS+Top /yaw== X-Gm-Message-State: AOJu0YyY/Y01Cv2lLlLM+PWlmNN+MRi0FAfUWPXPYYg5cV+3ciCzTURs MMg39mLUtBkKYVn1ANXKFdsXCexACJjBIlH/CLWtoSKz1O9sPRuu6doJfQ== X-Gm-Gg: ASbGncuj/xwRwWn6J+bqqYFE2Nh9UXa5HHiHWNpZA4ase8j8TAg2OKz/VB+Hsbjf/fa 1u+szGnTUnzVYHNQtubxL9mKt3pRXjDp5yUKiZ8io6yAThR0iIk/Tw9PYZwykUDMYVf8Inba9cg BgZV1cB469KL7i/AfrJCSym5+GUSX/sa+X40/WxaWum0ZGBttwLfMcr7whC8dQSiVYezqV2IEuM h2lTxPMob01JnLKyoDg6mWHgJCNKBhOfxUc8o+0lup31MvYj+FQm5oR2m7szEqVo8YYs0kMyUG4 3xECV1y3h60Oj9Q9dv/5cPW5if52jJQ/6nbNjK8zu3bqUJpnMB3PouCS1/aMPRj8nKxXy94= X-Google-Smtp-Source: AGHT+IGh24J4f0SfRtppVbvFJeBVZOa8Ywl3xYXHzsex6CC/J36f7WWeB89S20S0xf/has3Y0v0I+g== X-Received: by 2002:a05:6a00:4f85:b0:736:32d2:aa82 with SMTP id d2e1a72fcca58-740272324femr5422751b3a.23.1745940868396; Tue, 29 Apr 2025 08:34:28 -0700 (PDT) Received: from localhost.localdomain ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a420sm10303533b3a.107.2025.04.29.08.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 08:34:26 -0700 (PDT) From: Maxim Cournoyer To: 78102@debbugs.gnu.org Subject: [PATCH v2 3/3] gnu: Add redumper. Date: Wed, 30 Apr 2025 00:31:40 +0900 Message-ID: <7fc835e9456493c2d85fca94bfde7a87e25cbd29.1745940699.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <7e9be31603f35d063e9568fe7650be901e671951.1745940699.git.maxim.cournoyer@gmail.com> References: <7e9be31603f35d063e9568fe7650be901e671951.1745940699.git.maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-Debbugs-Cc: Maxim Cournoyer , Gabriel Wicki Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/audio.scm (redumper): New variable. Change-Id: I3740c6941d1ab11ac38993775a8004618636513c --- I was not able to fix cross-compilation when using clang, as it fails to detect the glibc library objects needed. Here's an attempt: ;; The build system uses CMake modules features that are only available ;; when using Ninja. - #:configure-flags #~(list "-GNinja" - "-DREDUMPER_CLANG_USE_LIBCPP=ON" - (string-append "-DREDUMPER_VERSION_BUILD=" - #$version) - "-DCMAKE_BUILD_TYPE=Release") + #:configure-flags + #~(list "-GNinja" + "-DCMAKE_CXX_COMPILER=clang++" + #$@(if (%current-target-system) + (list (string-append "-DCMAKE_CXX_COMPILER_TARGET=" + (%current-target-system))) + '()) + "-DREDUMPER_CLANG_USE_LIBCPP=ON" + (string-append "-DREDUMPER_VERSION_BUILD=" + #$version) + "-DCMAKE_BUILD_TYPE=Release") #:phases #~(modify-phases %standard-phases (add-after 'unpack 'patch-build-system Which errors like: Run Build Command(s): /gnu/store/w02489mcgfg5mj9z4c6nmnh3185v5xlv-ninja-1.11.1/bin/ninja -v cmTC_aa843 [1/2] /gnu/store/dfi5zbk288grsj5xnxpcihyy235sb2zv-clang-toolchain-19.1.7/bin/clang++ --target=i686-linux-gnu -MD -MT CMakeFiles/cmTC_aa843.dir/testCXXCompiler.cxx.o -MF CMakeFiles/cmTC_aa843.dir/testCXXCompiler.cxx.o.d -o CMakeFiles/cmTC_aa843.dir/testCXXCompiler.cxx.o -c /tmp/guix-build-redumper-561.drv-0/build/CMakeFiles/CMakeScratch/TryCompile-he4ad3/testCXXCompiler.cxx [2/2] : && /gnu/store/dfi5zbk288grsj5xnxpcihyy235sb2zv-clang-toolchain-19.1.7/bin/clang++ --target=i686-linux-gnu CMakeFiles/cmTC_aa843.dir/testCXXCompiler.cxx.o -o cmTC_aa843 && : FAILED: cmTC_aa843 : && /gnu/store/dfi5zbk288grsj5xnxpcihyy235sb2zv-clang-toolchain-19.1.7/bin/clang++ --target=i686-linux-gnu CMakeFiles/cmTC_aa843.dir/testCXXCompiler.cxx.o -o cmTC_aa843 && : /gnu/store/m8nars4f5d5x0sfhdlz69nc5blfyym1q-binutils-cross-i686-linux-gnu-2.41/bin/i686-linux-gnu-ld: cannot find crtbeginS.o: No such file or directory /gnu/store/m8nars4f5d5x0sfhdlz69nc5blfyym1q-binutils-cross-i686-linux-gnu-2.41/bin/i686-linux-gnu-ld: cannot find -lstdc++: No such file or directory gnu/packages/audio.scm | 76 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 03867b2da36..3850b916ca5 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -126,6 +126,7 @@ (define-module (gnu packages audio) #:use-module (gnu packages music) #:use-module (gnu packages ncurses) #:use-module (gnu packages networking) + #:use-module (gnu packages ninja) #:use-module (gnu packages onc-rpc) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) @@ -4082,6 +4083,81 @@ (define-public libshout-idjc ;; GNU Library (not Lesser) General Public License. (license license:lgpl2.0+))) +(define-public redumper + (package + (name "redumper") + (version "561") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/superg/redumper") + (commit (string-append "build_" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1r0wfi0fn3rq7s28p89rkgpgf567akd8z25l8r9sj7p4p3xp9m91")))) + (build-system cmake-build-system) + (arguments + (list + #:cmake cmake-next + #:build-type "Release" + ;; The build system uses CMake modules features that are only available + ;; when using Ninja. + #:configure-flags #~(list "-GNinja" + "-DREDUMPER_CLANG_USE_LIBCPP=ON" + (string-append "-DREDUMPER_VERSION_BUILD=" + #$version) + "-DCMAKE_BUILD_TYPE=Release") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-build-system + (lambda _ + ;; The CMAKE_SYSTEM_VERSION is undefined when cross-compiling. + (substitute* "CMakeLists.txt" + (("\\$\\{CMAKE_SYSTEM_VERSION}") + "\"${CMAKE_SYSTEM_VERSION}\"")))) + (add-after 'unpack 'adjust-CPLUS_INCLUDE_PATH + ;; The libcxx include/c++/v1 directory is not exposed via + ;; CPLUS_INCLUDE_PATH by default, causing errors like + ;; "fatal error: 'format' file not found". + (lambda* (#:key native-inputs inputs #:allow-other-keys) + (setenv "CPLUS_INCLUDE_PATH" + (string-append + (search-input-directory inputs + "/include/c++/v1") + ":" (getenv "CPLUS_INCLUDE_PATH"))))) + (replace 'build + (lambda* (#:key parallel-build? #:allow-other-keys) + (invoke "cmake" "--build" "." + "-j" (number->string + (if parallel-build? + (parallel-job-count) + 1))))) + (replace 'check + (lambda* (#:key build-type parallel-tests? tests? + #:allow-other-keys) + (when tests? + (invoke "ctest" "-C" build-type + "-j" (number->string + (if parallel-tests? + (parallel-job-count) + 1)))))) + (replace 'install + (lambda _ + ;; There is no CMake install target; manually install the + ;; binary. + (install-file "redumper" + (string-append #$output "/bin"))))))) + (native-inputs (list ninja clang-toolchain-19)) + (inputs (list libcxx)) + (home-page "https://github.com/superg/redumper") + (synopsis "Low-level CD/DVD dumper") + (description "@command{redumper} is a low-level byte perfect CD disc +dumper. It supports incremental dumps, advanced SCSI/C2 repair, intelligent +audio CD offset detection, among other features. @command{redumper} is also a +general purpose DVD/HD-DVD/Blu-ray disc dumper.") + (license license:gpl3+))) + (define-public resample (package (name "resample") -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 11:37:39 2025 Received: (at 78102) by debbugs.gnu.org; 29 Apr 2025 15:37:40 +0000 Received: from localhost ([127.0.0.1]:58249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9n1c-0006xK-VO for submit@debbugs.gnu.org; Tue, 29 Apr 2025 11:37:39 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:44371) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9n1Z-0006wS-Hb for 78102@debbugs.gnu.org; Tue, 29 Apr 2025 11:37:34 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-223fb0f619dso69251565ad.1 for <78102@debbugs.gnu.org>; Tue, 29 Apr 2025 08:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745941046; x=1746545846; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aw14rrljk4eSue9xZsN7TzNUfsu8mK2iz6CZIQOgPks=; b=WR9r+ReDLtcfzWXZdmozCZuKRQ68WSQvJwCp66RULMrgOy2xocuHVBnmyl2MbkgUNn 0jo6bgtKFycyfGpjUUusamh+Ow5m05VQdSoioj4mRxmzL9Jj2+gQtRTxenNRVxZ58HK+ tC0Un+/NQUihPEftiQNKj8U/Fj0YZ2qe2X7gwv6HLBzQfiGhaof9v5JxjkSTRTKEk4IJ AmOGQSBcAHAyItZW715fcFEgoCs3/ERXgxwppRZmvHqwuJz0xgO3TCNwZmAWvqHiy4Pd EvHCzQo75pv860FjpOw7zfUSDTdL1/9+6U1j1fDRSsWm4p6Cy6de/dp4YyC+gxoacdvj zzGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745941046; x=1746545846; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aw14rrljk4eSue9xZsN7TzNUfsu8mK2iz6CZIQOgPks=; b=Njy8qHtM7rKKIKPqwzroziMqrbpsYZloIC3omzQGYK7NLhK+/FwQbWZ2t2gywI3O7/ kM0VeZObTsgKpFT3tL6CL42kp6n+U1+9SIwWMCpwHU6IBiJMhYMwEwdVdYv+9ItWcmPD k6akKQVViP8usrKMqLuHAlAl4Xwe5/1E700mBeRAElh7Yh6eh27PB396vB+xEEYnNd8M 9jcrM9ytlahOebGH0PmYfdzMNscNNeJbUQXrEyK61u//ce844CmpYs33s7SDlNH9vaGX 36naEC6hbwTmReHobPkywOmphPV8osLbV1+qV/V1zoVRyu5pIGV5DR93LNTO2kvf9yoB mx3g== X-Gm-Message-State: AOJu0YwgwJxvqqTaJieSM4nLd48cKD8na3TregBH2jb1Urh5NZ7jQDPY jh/kEMA+6izEDVenCplkdgt3OaAB8AW4bz5wmp0rFwOzoxfaTy6HMj/0pQ== X-Gm-Gg: ASbGncuPTPVefFfduTBfump91eZc8MPFmB1dm/gQbocmaTXCabJOqhTsJOuLST8XlSw /LrkcViLhf6VbTwXAJ/tUWMKO88VrvdYrEry5J8CnBxs/ZYvgUsK7lv+Jx7uY6Fsu5D7JpJl1m0 AAaTmvprU9heKaJ0sUblBl/k4FmdRsK07wFCpFNhNAJdphhcLkMTLa565hakhb7DOM2qCjH2CQ4 tzxSN0hhXeCLLIqiiRVW+edwNwI4jyGun9uxdB9SlxxjtPUVxPcDmN8UzQpiH4ouH15+O+3VTSa KUN+Fg6O5a8+cqysZiBNR1sPvHxSIGRvsxeGp1k= X-Google-Smtp-Source: AGHT+IF8ruc/Vw+pbWly5j+5aGXWBpYbXyi4Xwjw5GClzrbAtR5xbJgnQYmGZ52zTTrGYa/MmfSqAQ== X-Received: by 2002:a17:903:1948:b0:22c:3609:97ed with SMTP id d9443c01a7336-22de6eb552bmr44001245ad.30.1745941046562; Tue, 29 Apr 2025 08:37:26 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db52163d6sm104034995ad.214.2025.04.29.08.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 08:37:25 -0700 (PDT) From: Maxim Cournoyer To: Gabriel Wicki Subject: Re: [bug#78102] [PATCH] gnu: Add redumper. In-Reply-To: <2vdzd63rhzp37fv2g6zjoztoyce4pyvsrec7hee2gp55zcipdc@smyuxaqa7cc3> (Gabriel Wicki's message of "Tue, 29 Apr 2025 09:57:59 +0200") References: <9966a347ee398a118b13a1febfcf62d7f77d0cc8.1745808541.git.maxim.cournoyer@gmail.com> <2vdzd63rhzp37fv2g6zjoztoyce4pyvsrec7hee2gp55zcipdc@smyuxaqa7cc3> Date: Wed, 30 Apr 2025 00:37:22 +0900 Message-ID: <87zffz9dxp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: 78102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Gabriel Wicki writes: > LGTM Thanks for the review. > but unfortunately the 'adjust-CPLUS_INCLUDE_PATH phase does not work in > cross-compilation context. do you think it is possible to get this to > work? that would be really awesome. The problem was cross-compiling libcxx, which I've now resolved (see the v2 I just sent). > the error i'm getting says: >> error: in phase 'adjust-CPLUS_INCLUDE_PATH': uncaught exception: >> wrong-type-arg "string-append" "Wrong type (expecting ~A): ~S" ("string" #f) (#f) Now we actually get to the cross-compilation of redumper, and it fails. clang seems unable to locate what it needs from the glibc, as in this bug report: . I'll punt on the cross-compilation part. Let me know what you think of the other changes in v2! -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 14:03:11 2025 Received: (at 78102) by debbugs.gnu.org; 29 Apr 2025 18:03:11 +0000 Received: from localhost ([127.0.0.1]:60788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9pIV-0005qA-1i for submit@debbugs.gnu.org; Tue, 29 Apr 2025 14:03:11 -0400 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]:43253) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9pIR-0005p3-QE for 78102@debbugs.gnu.org; Tue, 29 Apr 2025 14:03:08 -0400 Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA id 4C9881FECA; Tue, 29 Apr 2025 20:02:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=erlikon.ch; s=20250312; t=1745949776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uZljkNIyKDoEXErrJ9fCPUWhkJLGLlhKtjHSInlNJic=; b=CQOS6Qxtc4yUXNhphVis0jjamNHUD7BzckWYjXXEvcVykn8nxM/aTyfBVxyrx/MjB6Qc1j sEYcwU6GVBy6+rVD889ELLdCab9dG5US9RoxiKUsfR9TU9R/iY4CexC4L1ljAtlDqTiJZq Ftx6dt9sMiGfBH4fEgIw1FMe6Xwdyj0aRYxzlArweh2K/tmaXmFVmOb/mcbG2ymsaKYpfY 2jyAJpJTHBfWS8cIN8CYpA/9KMAG5ZCcTNtAgm3PiSl8AZK7T00sZm5K8TSnSkFePnfZUO WGC6glOgH5W5FFbjsnrLTGr+jObCYM8TAqy6lPeW6aKmNsIr05XHbLmEmAgIk+vqKLUgRu fXr+vsgF+vXg2vx58OJvYGkJsTQ3vhqtCWzB8e1FbCQpRusYE8k+vxCmo6bAUa8Q/LuitT cdukLG7FeSfpP+xoEECmC1G+i4X9cD/VQDYz2lchxzL9vzy4rjUAbsB+epV1OTbbipFuE3 m0MrGAPTgN+zIIKN24qLQqS+r6POJ/P5vOpf7KKPnNrZLBFSB2/ihaT6F2NleVgEzOLCjD NHhCFbOi6ilU72rSpESmLU41xwpsSzhofV+V7AvWEnsu8Az3u4vG/dDmfbJFG/QCdN+6po Ed+i4qx5+r4b51bFB2W9xCh54jYscBOW9BtbGQbtEDVBB4xuGEEBg= Date: Tue, 29 Apr 2025 20:02:53 +0200 From: Gabriel Wicki To: Maxim Cournoyer , code@greghogan.com Subject: Re: [bug#78102] [PATCH] gnu: Add redumper. Message-ID: References: <9966a347ee398a118b13a1febfcf62d7f77d0cc8.1745808541.git.maxim.cournoyer@gmail.com> <2vdzd63rhzp37fv2g6zjoztoyce4pyvsrec7hee2gp55zcipdc@smyuxaqa7cc3> <87zffz9dxp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zffz9dxp.fsf@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: 78102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey Maxim and Greg On Wed, Apr 30, 2025 at 12:37:22AM +0900, Maxim Cournoyer wrote: > > but unfortunately the 'adjust-CPLUS_INCLUDE_PATH phase does not work in > > cross-compilation context. do you think it is possible to get this to > > work? that would be really awesome. > > The problem was cross-compiling libcxx, which I've now resolved (see the > v2 I just sent). Looks good, though I must admit that reviewing changes in our cmake build system is somewhat out of my realm - maybe some other devs want to chime in on the issue (C++ team, maybe - I CC you, Greg, for that)? > > the error i'm getting says: > >> error: in phase 'adjust-CPLUS_INCLUDE_PATH': uncaught exception: > >> wrong-type-arg "string-append" "Wrong type (expecting ~A): ~S" ("string" #f) (#f) > > Now we actually get to the cross-compilation of redumper, and it fails. > clang seems unable to locate what it needs from the glibc, as in this > bug report: . > > I'll punt on the cross-compilation part. So, IIUC, the bug may (hopefully) eventually be fixed by an upstream clang version bump, since it seems to affect various cross-compilation contexts and is not tied to our project? Thanks for your time and effort! g From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 19:38:56 2025 Received: (at 78102) by debbugs.gnu.org; 29 Apr 2025 23:38:56 +0000 Received: from localhost ([127.0.0.1]:37379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9uXQ-0005NF-7G for submit@debbugs.gnu.org; Tue, 29 Apr 2025 19:38:56 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:44368) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u9uXN-0005Mw-86 for 78102@debbugs.gnu.org; Tue, 29 Apr 2025 19:38:53 -0400 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-223fb0f619dso74401625ad.1 for <78102@debbugs.gnu.org>; Tue, 29 Apr 2025 16:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745969926; x=1746574726; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1uCyn6qxss0XQ9n7SeCRWsr6d6Z8ClBzj2V7TLqmuys=; b=jcBMGoADBpIGRndkhoWQXcoHBLmLUEBui4DPfSdYr8FiSv+VEGC/ONbGH70Gfy4xgJ NVnL4cl7DW13hfLsQrO8rJOoMnKdOGtwkOSfl9sPPCGnDss0rNmR33Ow2fXhwuXXv2HD a24KTsHArB66ywJVovuhiDWJTqoxzu/x3DPLcwGplQx6L5ktBJojPJ4qb8mU/Y30vmeI X5hz9TXadebzI9SdJN1xDCfDTD2LnWf8mxH44wwS15buWqupnzVeWXj5q4whO7HZ1ccB owBIoZLSgi8RvppQiCI+QMKQl59h8/XoXZI5qf8BTE3DY41uoMfyyqg/sVPouHoOCS4C IH2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745969926; x=1746574726; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1uCyn6qxss0XQ9n7SeCRWsr6d6Z8ClBzj2V7TLqmuys=; b=qptsgzJDeeClyVUugMLr5jO1WpCTIMEmZFO+wRN9pCMDKEPhRkvQbY7Md4KAGi1axL OggRJQpj2jRk0enAzo/1cRrrrJpzyzxAS7U3lQCanCWq4rlGpQtJnwf2j3bM8oO1dUMh jRJWyIR3g732jf19SBEQORKQgkQbgw8s/ILuHn71T5nwbUsxfcp9s9w8Z0hFjxvuPx66 iKLtepniSXsAl28Ka6trNqVwDMZaIiX/GdiTCPHdCsS2OTRUXlwLB+5pf6coxU0QIn58 dj2VioC+tCm26gze+oxCW25bK/TQFDtk8JAKkZrMeuIVoEJTcKVFZ2NAKyX/YIFlAcpt Ah4A== X-Forwarded-Encrypted: i=1; AJvYcCXdWfayZgGJqKqwsmGIdpTHqfi5ZyK1toqn6TTCiY7Y5zAY4aYDc7hsLGOlI9EXqoY5XJ6Aiw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzCjh/aXESuusGrP2UK2+/3kvXjXUsZ1Q9L3u13K9UsmKw5rQzO GwCFYcK62AszQmhhbnG/8AcgPACidLR2x7VbUJuTpHXAYy74i4xZy1p+iQ== X-Gm-Gg: ASbGncucIJ06jJJeKwzwQLdMkiVrk9TvErm3uwasFSX1NLYRn3Jd6S05Iv5+YbG7fs4 NVjy/odtKTcvxBIVCtWWKcJMTJhPWUeH0Tv1NdEITc7ufTVu4+0me6gp0V2SshothSEF4LqnnhJ HiaBHudJNRKthC9Lh/oJdtlPyu7Pi/gpHUPXSRJSeDB6/bQjtsYwD+XlJhGvaPWNUEa0XRy0ivm XYOsFEeDdHL7H1erZODsZWgssw/LZfNczpU+bJnr/VX33k54QtwNm8MaEEX2xKYf+9DcI2ulh9u WM54izLuiMQ4nGYNrH+aWmQU8bdFtD2rXoMjS5o= X-Google-Smtp-Source: AGHT+IHNXI239iqjTXO86Mpur2gUzUu4jiu9wdrg8wb8vAMWNUl7L4gGmwa82T0AjYLaCS9ag2JHGg== X-Received: by 2002:a17:903:2308:b0:226:3781:379d with SMTP id d9443c01a7336-22df358fdd0mr16525075ad.33.1745969926616; Tue, 29 Apr 2025 16:38:46 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4d76e16sm108662975ad.44.2025.04.29.16.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 16:38:46 -0700 (PDT) From: Maxim Cournoyer To: Gabriel Wicki Subject: Re: [bug#78102] [PATCH] gnu: Add redumper. In-Reply-To: (Gabriel Wicki's message of "Tue, 29 Apr 2025 20:02:53 +0200") References: <9966a347ee398a118b13a1febfcf62d7f77d0cc8.1745808541.git.maxim.cournoyer@gmail.com> <2vdzd63rhzp37fv2g6zjoztoyce4pyvsrec7hee2gp55zcipdc@smyuxaqa7cc3> <87zffz9dxp.fsf@gmail.com> Date: Wed, 30 Apr 2025 08:38:43 +0900 Message-ID: <877c32a67w.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: 78102@debbugs.gnu.org, code@greghogan.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Gabriel, Gabriel Wicki writes: [...] >> The problem was cross-compiling libcxx, which I've now resolved (see the >> v2 I just sent). > Looks good, though I must admit that reviewing changes in our cmake > build system is somewhat out of my realm - maybe some other devs want to > chime in on the issue (C++ team, maybe - I CC you, Greg, for that)? Note that, interestingly, this doesn't cause a world rebuild because the change lives on the 'host' side and the default values means the same usual inputs are used, which means the existing derivations don't change. >> > the error i'm getting says: >> >> error: in phase 'adjust-CPLUS_INCLUDE_PATH': uncaught exception: >> >> wrong-type-arg "string-append" "Wrong type (expecting ~A): ~S" ("string" #f) (#f) >> >> Now we actually get to the cross-compilation of redumper, and it fails. >> clang seems unable to locate what it needs from the glibc, as in this >> bug report: . >> >> I'll punt on the cross-compilation part. > So, IIUC, the bug may (hopefully) eventually be fixed by an upstream > clang version bump, since it seems to affect various cross-compilation > contexts and is not tied to our project? That's my expectation, yes. > Thanks for your time and effort! No worries! I'll wait a couple days for Greg to chime in, and otherwise push. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 12:09:21 2025 Received: (at 78102) by debbugs.gnu.org; 1 May 2025 16:09:21 +0000 Received: from localhost ([127.0.0.1]:52514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAWTM-0004P1-Tb for submit@debbugs.gnu.org; Thu, 01 May 2025 12:09:20 -0400 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]:61620) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAWTJ-0004Ok-9c for 78102@debbugs.gnu.org; Thu, 01 May 2025 12:09:15 -0400 Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-72b0626c785so945869a34.2 for <78102@debbugs.gnu.org>; Thu, 01 May 2025 09:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1746115747; x=1746720547; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w4nVvDomlmFR7pCtdhdRL/shk17pAfcqgDtP0i/eeBY=; b=BKjhl/cpyKu7qOmxUYMj/zVYgSki5ZrHMVDCPLqmvuVecHUcxhxlKlDA5va2MP3jDh Ao/wpu+Ew3i2A9sv+ND682plxB+q5aV47Ze/6Lq1Eri4JUpIjW7JR2G618AlUxoQCpUS Zz2HQHUgHUNQJXOkvrvktWIXEq1hqq7+JFp1oyV6xhwFMK5KkKpM6JQw2M8xvxw/Wu9s +m8xQZOZ3baZQWWDsFPSEqDdNgldSTQWrjYCZCUZqbr2FMbX5qSx0FLsmm85NDcmz9Gc k1VmL5cfHuUSmFfb/S5WPDJ8yy76IWeL41zGoH13xpaAqd7bNGKhS4Tiv4CWqU45L1Gy z0fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746115747; x=1746720547; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w4nVvDomlmFR7pCtdhdRL/shk17pAfcqgDtP0i/eeBY=; b=GjWqP7UIIi9YHJsvCzShGqiVUj9W5RGRgdC3oI2GPqw9ngvavNhaLxMdx9laOBIsbv xAznFLsYV9lrg2XTFTvSIS8Ig3jbgnowt/SfeuD6/+2Re8XG/L1AVwuu9eUM74Z/CQgg Yh2iEBkr9jq+3gVEngyv9lyX47Z9bPfQkfyr+n6ePKQc6kOLtErPeee3Tx/v/G3I5oqS L63d2FUsPv+k2YkB9a8zrE2n7p5ST1ZN+fzGYuMm4RClQDHGylz9FzAqM2Xugx8s9INa aRSdYW+2I2Wb2zTY5FsHyzsw/heXNAWwhfKwmpqbKe/T2M87YXBucDamGPbH3kRhovcm DQ7Q== X-Gm-Message-State: AOJu0YwkGL+3QpK2FNI7dGjRkImz9sRCGyiy0+WHttJOr8ocyLp1nDNb C+ibpT2LE6btdMMeVdKiin/jp+C7eJGRs6XeBjgXfQ1XUE7b9pEZMzthSs8IGpPuVoPOYIkSyJz 0R6O80xiV17dlVklXCyHu6Jbq4nIkjjBs+3Hz3g== X-Gm-Gg: ASbGncvZQzHrA9N3m/w3+/a+dFm+8t2TQLj8Ulx7eBoQd5PuXdf9TBp4hhVXm45B1bw cUMusU+2pZseSjxP2ZzpMNmelp6f4wYgB6a7euWIrMClIYz/KEG+RMe/vEtpuqaEYrBG0W/1wVG LlpRuYyWwLyGCulAy2DIxv+w== X-Google-Smtp-Source: AGHT+IHRcFXWYs0FXBaN4s1qkSoCFPGAQbKbid1huczcSnNr3dZDxXzecNY4shD4PKHLBsQY1cOx0/pZE+Nh9GRQqcA= X-Received: by 2002:a05:6830:6205:b0:72b:98f8:5c96 with SMTP id 46e09a7af769-731ce312bedmr2410287a34.8.1746115747193; Thu, 01 May 2025 09:09:07 -0700 (PDT) MIME-Version: 1.0 References: <7e9be31603f35d063e9568fe7650be901e671951.1745940699.git.maxim.cournoyer@gmail.com> <47cce130906c96519b8f1505897c3986663b6276.1745940699.git.maxim.cournoyer@gmail.com> In-Reply-To: <47cce130906c96519b8f1505897c3986663b6276.1745940699.git.maxim.cournoyer@gmail.com> From: Greg Hogan Date: Thu, 1 May 2025 12:08:55 -0400 X-Gm-Features: ATxdqUHZJYWHQiPOJOycv_hOA0xcEczzlQbwZNKH0w3E0clV-WHAd8TTgYq25OQ Message-ID: Subject: Re: [bug#78102] [PATCH v2 2/3] gnu: libcxx: Fix cross-compilation build. To: Maxim Cournoyer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: Gabriel Wicki , 78102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Apr 29, 2025 at 11:33=E2=80=AFAM Maxim Cournoyer wrote: > > * gnu/packages/llvm.scm (libcxx) [arguments] <#:implicit-inputs?>: Set to= #f. > <#:phases>: Remove adjust-CPLUS_INCLUDE_PATH. > [native-inputs]: Explicitly provide standard inputs, filtering out gcc. > > Change-Id: I8cbc73ef90dce0a57bf2f8198c3176932bf24185 > --- > gnu/packages/llvm.scm | 27 ++++++++++----------------- > 1 file changed, 10 insertions(+), 17 deletions(-) > > diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm > index a0f47447bee..49b6e27bff9 100644 > --- a/gnu/packages/llvm.scm > +++ b/gnu/packages/llvm.scm > @@ -17,7 +17,7 @@ > ;;; Copyright =C2=A9 2020 Giacomo Leidi > ;;; Copyright =C2=A9 2020 Jakub K=C4=85dzio=C5=82ka > ;;; Copyright =C2=A9 2021, 2022 Maxime Devos > -;;; Copyright =C2=A9 2020, 2021, 2022, 2024 Maxim Cournoyer > +;;; Copyright =C2=A9 2020-2022, 2024-2025 Maxim Cournoyer > ;;; Copyright =C2=A9 2021 Julien Lepiller > ;;; Copyright =C2=A9 2021 Lars-Dominik Braun > ;;; Copyright =C2=A9 2021, 2022 Guillaume Le Vaillant > @@ -52,6 +52,7 @@ (define-module (gnu packages llvm) > #:use-module (guix memoization) > #:use-module (guix search-paths) > #:use-module (guix utils) > + #:use-module (guix build-system gnu) Should we keep this build-system section sorted? > #:use-module (guix build-system cmake) > #:use-module (guix build-system emacs) > #:use-module (guix build-system python) > @@ -1905,6 +1906,7 @@ (define-public libcxx > (build-system cmake-build-system) > (arguments > (list > + #:implicit-inputs? #f ;to avoid conflicting GCC header= s > #:tests? #f > #:configure-flags > #~(list "-DLLVM_ENABLE_RUNTIMES=3Dlibcxx;libcxxabi;libunwind" > @@ -1920,23 +1922,14 @@ (define-public libcxx > #~(modify-phases %standard-phases > (add-after 'unpack 'enter-subdirectory > (lambda _ > - (chdir "runtimes"))) > - (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH > - (lambda* (#:key inputs #:allow-other-keys) > - (let ((gcc (assoc-ref inputs "gcc"))) > - ;; Hide GCC's C++ headers so that they do not interfere = with > - ;; the ones we are attempting to build. > - (setenv "CPLUS_INCLUDE_PATH" > - (string-join (delete (string-append gcc "/includ= e/c++") > - (string-split (getenv "CPLU= S_INCLUDE_PATH") > - #\:)) > - ":")) > - (format #t > - "environment variable `CPLUS_INCLUDE_PATH' chang= ed to ~a~%" > - (getenv "CPLUS_INCLUDE_PATH")) > - #t)))))) > + (chdir "runtimes")))))) > (native-inputs > - (list clang-19 libunwind-headers llvm python)) > + (append (list clang-19 libunwind-headers llvm python) Does this work to combine clang-19 with llvm-13? > + ;; Remove GCC from the build environment, to avoid its C++ > + ;; headers (include/c++), which would interfere and cause b= uild > + ;; failures. > + (map second With the map are we not also dropping the package output as the third field? So we wind up with a second "libc" but no "libc:static". It might not matter here but this kind of trick is often copied into additional packages. Can we use modify-inputs on standard-packages, delete "gcc", and append the list of additional packages? Or revert to the old-style inputs. > + (alist-delete "gcc" (standard-packages))))) There is an extra space after alist-delete. > (home-page "https://libcxx.llvm.org") > (synopsis "C++ standard library") > (description > -- > 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 12:09:26 2025 Received: (at 78102) by debbugs.gnu.org; 1 May 2025 16:09:26 +0000 Received: from localhost ([127.0.0.1]:52517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAWTW-0004PR-21 for submit@debbugs.gnu.org; Thu, 01 May 2025 12:09:26 -0400 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:54383) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAWTS-0004P2-Uo for 78102@debbugs.gnu.org; Thu, 01 May 2025 12:09:23 -0400 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-72c7336ed99so279438a34.0 for <78102@debbugs.gnu.org>; Thu, 01 May 2025 09:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1746115757; x=1746720557; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1Z5702y9D81fHGUYqcoPtmYbkIpEHqQ1vJws+UO+ujE=; b=I4V0FB48G/LcgrFQkXGOJe9I7z7u9OgrAP5Oo7uvKK25E/gR04OfMDOibEOZ3gy0jG T8NrlEzh+Rz4a1E/n8I85O/HMaTnhJi4gwmCtdv/Nhy5+jOUJgFV4fqRE2DXpbcO2KxR 5LiAXkaFGMKvaIhCmWIHKtODy5I+7o7oPdaHXAcW4XwP1mFZSDHeTJtFqLD1mQwW3VNo /goiibhwc21ThKEP1WSCUgT0n90bsU7Fp6bpRy1gpp16QGif6Rrp9N9rbR96ZsYUJuoj 0G3IpdGUqSYwrFEPvecC1LExnPDO0dnfEeAJS/EIIewj4nKp6UdbR2+Gu305ksnE26HD 64Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746115757; x=1746720557; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Z5702y9D81fHGUYqcoPtmYbkIpEHqQ1vJws+UO+ujE=; b=JefmN5H/VQ2hBCoNosl0j0j5NTjbLbjUgcjudejzV2A6qCVprWEyuaW4WBZOfpO+AP wq5aVJaMdY1eTjcewG8m2XrlPj+oYUxlCaer2vO6rhFLKl37b0nyjDrTOobP3S+deJFa ptmpzw56TT4DEPCEYRnhPWMk06dJqEBDh8Toro4YCouM/3K2a/in8w7cTOABWw73kFwq sYdxWqwJpDUCfJ9Gz8oRufosgPf9J8wEQt61bO0QFNjTqGlKIxU4qWnt7nmudthOcnhg 0YKVzcH2mz77fAjJn7Yp4MxTqtDQc/6lamgQTQL849eI9mo1i6UMUBihpF38XAGyoEou e5aA== X-Forwarded-Encrypted: i=1; AJvYcCU8HKt/ESapbxaHrofRwIYFaDm3/Er2BsaA2oz1of4+SVTKVO27xcar9t+d+bE0A2oKkzkG5w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwZ18Jz1Z/ivahvvH7NhgwxDOXm3A7ET1RlGw81XJ0QgmNEwCR9 aEEDZCib5EYlp0Ioa+tPh91v+S2aDVEMmbDbJIqKFSwzHHyVhno4O0KueZfoXijRPg0c+QDkSJE 4YVfJ8wvnbOJeO16+WKYP5wrsbPyq9WxJUC2onw== X-Gm-Gg: ASbGncsCbvaV9COtajkJvANawsZ/Z9z85wHFzy0m8z0IX6G43+l9Gar+uO0Vb/PL9ta FJYUqgdXMEKG11k5+S8CgBvw2RUvNjBkmYdhimyrekGBwOSvUBe+k/RVuYR8uRMn7KHwtXVEQYv /3ta6BtskXpwn2tgReJx7n5w== X-Google-Smtp-Source: AGHT+IEpqYPzR2H0/4CRhrumNLZTbMYBH6PK8OLo+mA5APsJU2ld4Joo5gyrJakPevWTf5JZ1SaXHMBfyT7Z/N29XOs= X-Received: by 2002:a05:6830:258a:b0:72b:8974:e3e6 with SMTP id 46e09a7af769-731c2592521mr4946523a34.28.1746115757119; Thu, 01 May 2025 09:09:17 -0700 (PDT) MIME-Version: 1.0 References: <9966a347ee398a118b13a1febfcf62d7f77d0cc8.1745808541.git.maxim.cournoyer@gmail.com> <2vdzd63rhzp37fv2g6zjoztoyce4pyvsrec7hee2gp55zcipdc@smyuxaqa7cc3> <87zffz9dxp.fsf@gmail.com> <877c32a67w.fsf@gmail.com> In-Reply-To: <877c32a67w.fsf@gmail.com> From: Greg Hogan Date: Thu, 1 May 2025 12:09:05 -0400 X-Gm-Features: ATxdqUEwzO0tjGjneYCHYUZZdMyO5-7MsXhmUq-eVvjADLp068NF1QvsMZAlhdE Message-ID: Subject: Re: [bug#78102] [PATCH] gnu: Add redumper. To: Maxim Cournoyer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: 78102@debbugs.gnu.org, Gabriel Wicki X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Apr 29, 2025 at 7:38=E2=80=AFPM Maxim Cournoyer wrote: > > Hi Gabriel, > > Gabriel Wicki writes: > > [...] > > >> The problem was cross-compiling libcxx, which I've now resolved (see t= he > >> v2 I just sent). > > Looks good, though I must admit that reviewing changes in our cmake > > build system is somewhat out of my realm - maybe some other devs want t= o > > chime in on the issue (C++ team, maybe - I CC you, Greg, for that)? > > Note that, interestingly, this doesn't cause a world rebuild because the > change lives on the 'host' side and the default values means the same > usual inputs are used, which means the existing derivations don't > change. > > >> > the error i'm getting says: > >> >> error: in phase 'adjust-CPLUS_INCLUDE_PATH': uncaught exception: > >> >> wrong-type-arg "string-append" "Wrong type (expecting ~A): ~S" ("st= ring" #f) (#f) > >> > >> Now we actually get to the cross-compilation of redumper, and it fails= . > >> clang seems unable to locate what it needs from the glibc, as in this > >> bug report: . > >> > >> I'll punt on the cross-compilation part. > > So, IIUC, the bug may (hopefully) eventually be fixed by an upstream > > clang version bump, since it seems to affect various cross-compilation > > contexts and is not tied to our project? > > That's my expectation, yes. > > > Thanks for your time and effort! > > No worries! I'll wait a couple days for Greg to chime in, and otherwise > push. > > -- > Thanks, > Maxim This is fantastic. I had not come across implicit-inputs but I am now using this to build clang-toolchain with an updated gcc. I can't speak to the cross-compilation but have added some comments (questions) on the libcxx patch. Greg From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 20:33:39 2025 Received: (at 78102) by debbugs.gnu.org; 2 May 2025 00:33:39 +0000 Received: from localhost ([127.0.0.1]:54438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAeLS-0008US-LO for submit@debbugs.gnu.org; Thu, 01 May 2025 20:33:39 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:54529) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAeLM-0008U7-OI for 78102@debbugs.gnu.org; Thu, 01 May 2025 20:33:36 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2241053582dso24433895ad.1 for <78102@debbugs.gnu.org>; Thu, 01 May 2025 17:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746146006; x=1746750806; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PiRYvqHKl7v7NfyHbIjuC47TIa1TtZFKf7iDfsuYSzE=; b=MWL3AxmJYM4VtNh3pmqWeJVzebA4laMkJRO4u5XWBv3tS69sYwFdsIoVUoXAmXoLIw NYOTtkB3WCvZwdsV43zhrxxMNcoxC5LIPdC/ZfFylX564rTLLJf5LmfEDQTjRNav9n+q U7EVu1iYV+BoYfHemEIL5i4rzGQPUsJiDq2p1u8nFCfktHlof5pkPlMuu1bSohA4Rquk h0a7jtnnU+NrNPeLx/Fm3dSYQnqmPlhSyhJsAuysW/zmfPuxiWAT2ZRWN+KYWMNM6EKi vOMsJyt0RqPC3QwNic1EOXbuVomxozvJFzDfl2IoruSho/w9i+Lv2AiVZclDuP2di3WB y/KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746146006; x=1746750806; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PiRYvqHKl7v7NfyHbIjuC47TIa1TtZFKf7iDfsuYSzE=; b=SQ6G14HJVlxVpqB8UwcHTw1M6bnTzGz0AOz9LVW7edtfOxIo85L/G8b4NyHLKUR0uC MdX6YhFqVPcfYrqf9UCO+WaPjf0IywXEA8lnPy+dR+PrnTR8eCaIi87ZQOG5BW9r9WOp pLm+kdd4pJTGyKUHOlQPv6S6cgHKo3p4OdE1JpexrB1QPFTAR4T5GrGk+JuJzFBPh+wh rxQg23MORjYIfDd9NbECeISvWmRTC0cD6urgVMQlN3qzR/1E34kynMhAsydlxmvJRakv bq7FVHAy1jPW13Tuzl0DXqCYtmlty8G724eH64/lF2pjFickcVhYchXhAeTs8ypJO/Qy 5UfA== X-Gm-Message-State: AOJu0Yy0dEyxOhsq1PQwL6r581tz1yvfmxRs79DbkoTsImQfVSY9T2xM pJf0qE5zWX9mfXYy1wcXyqoN8WuAUsqFMHmUcG/m1zKGhLXf9Usp X-Gm-Gg: ASbGncvfHtU0+bhTHiayjDJ616tCYWTvKFp63vnOIPIKzdd97U3gLuYflhDh1fDHD/S 8xHRtr9ZzYoyxw4273MpnmFG4+q5uBKlChOaYw8FtbMJD3Cof8LOQj9n03wT/1s7hYZWSN0gyC0 oaxFXudzojjpSTQvX8PgQWWlHR70yGU03xnNL/UYUjqPODmNT0eVd1/uIL9H6g286DDROIZ3BwB amYlE+hIFZzOzC2cW6bmUi4XlwYM0S9gZgJm4P8bXDUdgYy1NivwB1Nvgt3hwyfK2uE+ARhagbx MCdndmnv7qSe4NopTbJ65jOOPI8a4usW6JQeum8= X-Google-Smtp-Source: AGHT+IE2wMrsC4O/jd+WN3K1gKAeNIdaYiED9cGjpqooC3qm+d9K187iCLVATAFhbwqkM4M85MJkzw== X-Received: by 2002:a17:902:e752:b0:21f:617a:f1b2 with SMTP id d9443c01a7336-22e10343c30mr12870875ad.46.1746146006453; Thu, 01 May 2025 17:33:26 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e108fb86dsm2454005ad.113.2025.05.01.17.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 17:33:25 -0700 (PDT) From: Maxim Cournoyer To: Greg Hogan Subject: Re: [bug#78102] [PATCH v2 2/3] gnu: libcxx: Fix cross-compilation build. In-Reply-To: (Greg Hogan's message of "Thu, 1 May 2025 12:08:55 -0400") References: <7e9be31603f35d063e9568fe7650be901e671951.1745940699.git.maxim.cournoyer@gmail.com> <47cce130906c96519b8f1505897c3986663b6276.1745940699.git.maxim.cournoyer@gmail.com> Date: Fri, 02 May 2025 09:33:22 +0900 Message-ID: <87seln6ect.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102 Cc: Gabriel Wicki , 78102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Greg, Thanks for the review. Greg Hogan writes: [...] >> @@ -52,6 +52,7 @@ (define-module (gnu packages llvm) >> #:use-module (guix memoization) >> #:use-module (guix search-paths) >> #:use-module (guix utils) >> + #:use-module (guix build-system gnu) > > Should we keep this build-system section sorted? Definitely! Done. >> #:use-module (guix build-system cmake) >> #:use-module (guix build-system emacs) >> #:use-module (guix build-system python) >> @@ -1905,6 +1906,7 @@ (define-public libcxx >> (build-system cmake-build-system) >> (arguments >> (list >> + #:implicit-inputs? #f ;to avoid conflicting GCC headers >> #:tests? #f >> #:configure-flags >> #~(list "-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi;libunwind" >> @@ -1920,23 +1922,14 @@ (define-public libcxx >> #~(modify-phases %standard-phases >> (add-after 'unpack 'enter-subdirectory >> (lambda _ >> - (chdir "runtimes"))) >> - (add-after 'set-paths 'adjust-CPLUS_INCLUDE_PATH >> - (lambda* (#:key inputs #:allow-other-keys) >> - (let ((gcc (assoc-ref inputs "gcc"))) >> - ;; Hide GCC's C++ headers so that they do not interfere with >> - ;; the ones we are attempting to build. >> - (setenv "CPLUS_INCLUDE_PATH" >> - (string-join (delete (string-append gcc "/include/c++") >> - (string-split (getenv "CPLUS_INCLUDE_PATH") >> - #\:)) >> - ":")) >> - (format #t >> - "environment variable `CPLUS_INCLUDE_PATH' changed to ~a~%" >> - (getenv "CPLUS_INCLUDE_PATH")) >> - #t)))))) >> + (chdir "runtimes")))))) >> (native-inputs >> - (list clang-19 libunwind-headers llvm python)) >> + (append (list clang-19 libunwind-headers llvm python) > > Does this work to combine clang-19 with llvm-13? Good catch. It worked, because both llvm and libunwind-headers appeared to be extraneous inputs, which I've now removed. > >> + ;; Remove GCC from the build environment, to avoid its C++ >> + ;; headers (include/c++), which would interfere and cause build >> + ;; failures. >> + (map second > > With the map are we not also dropping the package output as the third > field? So we wind up with a second "libc" but no "libc:static". It > might not matter here but this kind of trick is often copied into > additional packages. Can we use modify-inputs on standard-packages, > delete "gcc", and append the list of additional packages? Or revert to > the old-style inputs. Good point, I've rewritten it to use modify-inputs. I don't think we should use old-style inputs in any case now. >> + (alist-delete "gcc" (standard-packages))))) > > There is an extra space after alist-delete. Fixed! Thanks again for the review! I'll push shortly. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 21:23:38 2025 Received: (at 78102-done) by debbugs.gnu.org; 2 May 2025 01:23:38 +0000 Received: from localhost ([127.0.0.1]:54615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAf7q-0002dm-9z for submit@debbugs.gnu.org; Thu, 01 May 2025 21:23:38 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:60818) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uAf7l-0002dC-4v for 78102-done@debbugs.gnu.org; Thu, 01 May 2025 21:23:36 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-7369ce5d323so1475181b3a.1 for <78102-done@debbugs.gnu.org>; Thu, 01 May 2025 18:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746149006; x=1746753806; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WyHduUFSWs1Zl4Krnc2LPeQ9M+in169fgvD86A6fvJ4=; b=MYFlqmXOXRexD/ROgXBoWN8p3qnhwTwUruH55qV2zpxn45CmTr5txh+Dz7JEsbqNEU I1RJ8bzyzF0FmLWcAqL7L+N7V8v1OEPY7EkpUP6VYF5fqQCj8K4MC668LCBPX5QXBnnS C4P+/2TlC+nbUpZ2kP/bZrX47k2idhisMX9ECy2zhcxE5bVcv93oSjGknsSB4HInDUP1 JPWa4GMXSt3DVh9jtLQnq7TVQ3m6wbrmcL94BhI6STqJPoatThHhc7RC1XEegHo2Z/pm dH9AVFsnQ+p2G5WG66rS4CCHRK0tNG3t97YBhB1CRTBUca09GetIlVYjXjlBWUwA+0kQ zhjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746149006; x=1746753806; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WyHduUFSWs1Zl4Krnc2LPeQ9M+in169fgvD86A6fvJ4=; b=Y0vVW9Yhmpmn70yx7O7KD4UkbNFPB0AIuysHXhbkxnzDAHEhNeD6YSCHZ4gnA35+Zd Py6/+Sh3EfT/RMyi9+LXK4qRa81RNkOWvtyH7WGYxT7I3YNIZZPwkPiY7ogiyUR/cMN6 ddKDK1onpyZmeaShtMm/pyjJU/qYYw5MnEC/fvH4Vn8yQ4fjo/czqiVn53j8P01n452q QaiB9FvIK/zSdHuo7auBMfSECBjmIjOKPyrMJVV3GilPkrisToUrj2FT+0cVWq+ErXYr l70vwfF2KCuVPN+LHuoZOc3R0vKopcc/2pIv8rGfAK6ypUZqBS64zM7RCcEUfZUmRtdP L3cg== X-Forwarded-Encrypted: i=1; AJvYcCXAesHj3y0rYloS1WdQYXxDvRS1fOLzLM6GOKup8SncVFYsqRLkAK/xElaZcaWy4v6BB7QjNZezPCP7@debbugs.gnu.org X-Gm-Message-State: AOJu0YxPIXKfXSkmh/C3z9vywwi7ZZabJW25IGSxtO66Qb5d7k9JxefW Dy1sK7cFt4bZPfkLeo94TQlgEPPv5uLJ0PhcBaUieCUkvpILNE55ZI7tCl/W X-Gm-Gg: ASbGncuXUBp8MI2FZ69c6J4v6OzGdGnse2fQELMNLFPHPUjSpVGWUeXSuaBfCRVnVAT H3L+fBaiCU03RCSVJrvydzlW5yJ2irCz36gIjAZQs7vWymGhyziW9JPpeR7RKM2GYf4D0teYHiZ UjftWuqsSm67SdPrYxOyRUGmgHgyVeNoQP8S00UwcHVvSYFlkWX8auwYK20UC11amVovZY5SAW5 qbI53VwxJWUmcB6781Xrb07su6iXIcwvGAQxg4rPev3XxxodANkQHKJwsgTPpy4Ak/uymhyQHIE 2G9hNuJfKRQIRc5/CyYCXBNjlFZI1BzRETzsqpb/qBu9rj0aWA== X-Google-Smtp-Source: AGHT+IF/IWBsyoXCdYJ5HNjv1wI2RytGyBZs4kW+qkdBHNysyIR7KwquMqZ8YLjPC7Z5r7ftg9cbyg== X-Received: by 2002:a05:6a21:920d:b0:1f5:6c94:2cc1 with SMTP id adf61e73a8af0-20cdee3adcbmr1493474637.21.1746149005741; Thu, 01 May 2025 18:23:25 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74058d7ae1bsm356163b3a.34.2025.05.01.18.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 18:23:25 -0700 (PDT) From: Maxim Cournoyer To: Greg Hogan Subject: Re: [bug#78102] [PATCH] gnu: Add redumper. In-Reply-To: (Greg Hogan's message of "Thu, 1 May 2025 12:09:05 -0400") References: <9966a347ee398a118b13a1febfcf62d7f77d0cc8.1745808541.git.maxim.cournoyer@gmail.com> <2vdzd63rhzp37fv2g6zjoztoyce4pyvsrec7hee2gp55zcipdc@smyuxaqa7cc3> <87zffz9dxp.fsf@gmail.com> <877c32a67w.fsf@gmail.com> Date: Fri, 02 May 2025 10:23:22 +0900 Message-ID: <87o6wb6c1h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78102-done Cc: Gabriel Wicki , 78102-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Greg, Greg Hogan writes: [...] > This is fantastic. I had not come across implicit-inputs but I am now > using this to build clang-toolchain with an updated gcc. > > I can't speak to the cross-compilation but have added some comments > (questions) on the libcxx patch. Glad it will be useful outside of libcxx. I wasn't sure of the added value. Thanks for your input! I've now push this series, taking into account your comments about libcxx; see commit 94593917394. Thanks to both of you for the reviews! -- Thanks, Maxim From unknown Fri Jun 20 07:25:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 30 May 2025 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator