GNU bug report logs - #78100
[PATCH] guix: gtk-icon-themes: Generate output if no icons

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: 宋文武 <iyzsong <at> envs.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#78100: closed ([PATCH] guix: gtk-icon-themes: Generate output
 if no icons)
Date: Mon, 28 Apr 2025 13:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 28 Apr 2025 21:06:27 +0800
with message-id <87ikmoqvu4.fsf <at> envs.net>
and subject line Re: [bug#78100] [PATCH] guix: gtk-icon-themes: Generate output if no icons
has caused the debbugs.gnu.org bug report #78100,
regarding [PATCH] guix: gtk-icon-themes: Generate output if no icons
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
78100: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78100
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Rutherther <rutherther <at> ditigal.xyz>
To: guix-patches <at> gnu.org
Cc: Rutherther <rutherther <at> ditigal.xyz>
Subject: [PATCH] guix: gtk-icon-themes: Generate output if no icons
Date: Sun, 27 Apr 2025 23:05:25 +0200

When there are no icon themes, but gtk+ is referenced in the manifest,
the output won't be produced in the gtk-icon-themes derivation.
This will lead to an error.

The problem has been reported by lilyp on IRC. I can't find any packages in
Guix that use gtk+ in inputs and don't have any icons, but this low-effort
package replicates the issue:
```
(package
  (inherit bash)
  (inputs
    (modify-inputs
      (package-inputs bash)
      (append gtk+))))
```

* guix/profiles.scm (gtk-icon-themes): Produce output when no icon cache is created.

Change-Id: I2aa5ab0023c9c584182c67f79102fb66b46a3a7d
---
 guix/profiles.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/profiles.scm b/guix/profiles.scm
index 64d669c353..086280329e 100644
--- a/guix/profiles.scm
+++ b/guix/profiles.scm
@@ -1379,6 +1379,9 @@ (define* (gtk-icon-themes manifest #:optional system)
                          (srfi srfi-26)
                          (ice-9 ftw))
 
+            ;; Ensure output is produced when no cache files are created.
+            (mkdir-p #$output)
+
             (let* ((destdir  (string-append #$output "/share/icons"))
                    (icondirs (filter file-exists?
                                      (map (cut string-append <> "/share/icons")

base-commit: 4e79ec48af8173f0f2a86fa2c8f971dc8234b941
-- 
2.49.0

[Message part 3 (message/rfc822, inline)]

From: 宋文武 <iyzsong <at> envs.net>
To: Rutherther <rutherther <at> ditigal.xyz>
Cc: 78100-done <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#78100] [PATCH] guix: gtk-icon-themes: Generate output if
 no icons
Date: Mon, 28 Apr 2025 21:06:27 +0800

Rutherther <rutherther <at> ditigal.xyz> writes:

> When there are no icon themes, but gtk+ is referenced in the manifest,
> the output won't be produced in the gtk-icon-themes derivation.
> This will lead to an error.
>
> The problem has been reported by lilyp on IRC. I can't find any packages in
> Guix that use gtk+ in inputs and don't have any icons, but this low-effort
> package replicates the issue:

Pushed to master as commit d47379b8dc6fb, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.