From unknown Fri Jun 20 20:09:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#78100] [PATCH] guix: gtk-icon-themes: Generate output if no icons Resent-From: Rutherther Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, zimon.toutoune@gmail.com, me@tobias.gr, liliana.prikler@gmail.com, iyzsong@envs.net, guix-patches@gnu.org Resent-Date: Sun, 27 Apr 2025 21:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78100 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 78100@debbugs.gnu.org Cc: Rutherther , Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=83=C2=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice , Liliana Marie Prikler , X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=83=C2=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice , Liliana Marie Prikler , Received: via spool by submit@debbugs.gnu.org id=B.174578838419391 (code B ref -1); Sun, 27 Apr 2025 21:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Apr 2025 21:13:04 +0000 Received: from localhost ([127.0.0.1]:45314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u99J9-00052h-Hn for submit@debbugs.gnu.org; Sun, 27 Apr 2025 17:13:03 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45874) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u99J6-000520-VL for submit@debbugs.gnu.org; Sun, 27 Apr 2025 17:13:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u99Ix-0008DJ-Ep for guix-patches@gnu.org; Sun, 27 Apr 2025 17:12:51 -0400 Received: from ditigal.xyz ([2a01:4f8:1c1b:6a1c::] helo=mail.ditigal.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1u99Iv-0000YB-UJ for guix-patches@gnu.org; Sun, 27 Apr 2025 17:12:51 -0400 Received: by cerebrum (OpenSMTPD) with ESMTPSA id 30bbc8ef (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 27 Apr 2025 21:12:43 +0000 (UTC) From: Rutherther Date: Sun, 27 Apr 2025 23:05:25 +0200 Message-ID: <6a181010b8ad2c22063a64ab848303bc243e5f79.1745787923.git.rutherther@ditigal.xyz> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz; i=@ditigal.xyz; q=dns/txt; s=20240917; t=1745788363; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=GoNckcE0Sw72NR4lZYw1IDc+WRCNDaJHGipu7aWBnMc=; b=XsiZaisedEbyf/E+WOaya7J3NHvjsRoDZXJfKar9jnj772MftnYhRimtLMOuxuhs/7eqq xeVK91unKUxmKwz3s0+yurKyJmV/irq7WvW2ZdkL28KuS7fJVhDiUZ772N20C6iQsikXcxd vnZerItUsHvcSaWpP7lngBEKVX9K340= Received-SPF: pass client-ip=2a01:4f8:1c1b:6a1c::; envelope-from=rutherther@ditigal.xyz; helo=mail.ditigal.xyz X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.997, PDS_OTHER_BAD_TLD=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.4 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When there are no icon themes, but gtk+ is referenced in the manifest, the output won't be produced in the gtk-icon-themes derivation. This will lead to an error. The problem has been reported by lilyp on IRC. I can't find any packages in Guix that use gtk+ in inputs and don't have any icons, but this low-effort package replicates the issue: ``` (package (inher [...] Content analysis details: (3.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=rutherther%40ditigal.xyz; ip=2001%3A470%3A142%3A%3A17; r=debbugs.gnu.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ditigal.xyz (xyz)] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) When there are no icon themes, but gtk+ is referenced in the manifest, the output won't be produced in the gtk-icon-themes derivation. This will lead to an error. The problem has been reported by lilyp on IRC. I can't find any packages in Guix that use gtk+ in inputs and don't have any icons, but this low-effort package replicates the issue: ``` (package (inherit bash) (inputs (modify-inputs (package-inputs bash) (append gtk+)))) ``` * guix/profiles.scm (gtk-icon-themes): Produce output when no icon cache is created. Change-Id: I2aa5ab0023c9c584182c67f79102fb66b46a3a7d --- guix/profiles.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/guix/profiles.scm b/guix/profiles.scm index 64d669c353..086280329e 100644 --- a/guix/profiles.scm +++ b/guix/profiles.scm @@ -1379,6 +1379,9 @@ (define* (gtk-icon-themes manifest #:optional system) (srfi srfi-26) (ice-9 ftw)) + ;; Ensure output is produced when no cache files are created. + (mkdir-p #$output) + (let* ((destdir (string-append #$output "/share/icons")) (icondirs (filter file-exists? (map (cut string-append <> "/share/icons") base-commit: 4e79ec48af8173f0f2a86fa2c8f971dc8234b941 -- 2.49.0 From unknown Fri Jun 20 20:09:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Rutherther Subject: bug#78100: closed (Re: [bug#78100] [PATCH] guix: gtk-icon-themes: Generate output if no icons) Message-ID: References: <87ikmoqvu4.fsf@envs.net> <6a181010b8ad2c22063a64ab848303bc243e5f79.1745787923.git.rutherther@ditigal.xyz> X-Gnu-PR-Message: they-closed 78100 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 78100@debbugs.gnu.org Date: Mon, 28 Apr 2025 13:02:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1745845322-19902-1" This is a multi-part message in MIME format... ------------=_1745845322-19902-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #78100: [PATCH] guix: gtk-icon-themes: Generate output if no icons which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 78100@debbugs.gnu.org. --=20 78100: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78100 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1745845322-19902-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 78100-done) by debbugs.gnu.org; 28 Apr 2025 13:01:48 +0000 Received: from localhost ([127.0.0.1]:55083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9O7H-00059S-Ec for submit@debbugs.gnu.org; Mon, 28 Apr 2025 09:01:47 -0400 Received: from mail.envs.net ([5.199.136.28]:45922) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9O7E-000596-G0 for 78100-done@debbugs.gnu.org; Mon, 28 Apr 2025 09:01:45 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 9656538A40C6; Mon, 28 Apr 2025 13:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1745845302; bh=l+mXyHnLrsOzST9fh9M3nt6kOrncqqg3QGTqXxoWUfM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=STLOPJWmggrATB+P9la0+rNgakWanPAdooTF2ZeNkzrJ2PfHmdmzZFWfUA/b2wfod 7rO9F5vgo0pPFf9JEjxPfPBOxaz0Sr5eHZqo2hxrh9s73W0F9gOzNPs9M4ro5C5yiA AkDKZfP68hMeadfgBIaIS7gFUuMlzhXrG9ySno6A+t9mJNy9JJf2oi9FOHHAhCmQKT 8r7OWXzbYHULxRUDGyokY5JmC+KeO7F5+jl33uq4czIRLkLoiql+QYJk5mtHq9MoL7 OV+Ut5VR4zL5wrfChfbky7ind6bz8WjHj2MHFZtlEYfsid2M79ur3NsQ52NPx8KZhu pZUC3C9cyr4E/qg/9y0kTbkgKG/KjWw85pqLhapDys0E7EkaKaifOTSc9BCb5JHrYh tFZShKOUOoxV7O8iLcGYxx0dfO9VNymZ78mFxxRkRFhz3eLixrt5obJt5h4zLv79t/ fQxuH9p7QIbIUMfHECSyQwY/x8+pVMh6vhImqToJzl+xsAEMzVHthJQ7fYrAvDuDCp BIB+iQhSMchDf4FfiTxLCxNxmNG1kQE+9KrqVBoxuzg2FJiv/B6Twau/V/ltiJx+rr xyY0I2SdUCTcKTQhmHajzzPYAH9Xr4IrYMc937zIWH8QEwbmK3c/n+8bptgJG6P8KZ yqx4kxxi7wVUzDnyXrxM/af0= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sM5A-bm82ksT; Mon, 28 Apr 2025 13:01:29 +0000 (UTC) Received: from localhost (unknown [112.44.106.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Mon, 28 Apr 2025 13:01:28 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 855164e3; Mon, 28 Apr 2025 13:06:27 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Rutherther Subject: Re: [bug#78100] [PATCH] guix: gtk-icon-themes: Generate output if no icons In-Reply-To: <6a181010b8ad2c22063a64ab848303bc243e5f79.1745787923.git.rutherther@ditigal.xyz> (rutherther@ditigal.xyz's message of "Sun, 27 Apr 2025 23:05:25 +0200") References: <6a181010b8ad2c22063a64ab848303bc243e5f79.1745787923.git.rutherther@ditigal.xyz> Date: Mon, 28 Apr 2025 21:06:27 +0800 Message-ID: <87ikmoqvu4.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78100-done Cc: 78100-done@debbugs.gnu.org, Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rutherther writes: > When there are no icon themes, but gtk+ is referenced in the manifest, > the output won't be produced in the gtk-icon-themes derivation. > This will lead to an error. > > The problem has been reported by lilyp on IRC. I can't find any packages in > Guix that use gtk+ in inputs and don't have any icons, but this low-effort > package replicates the issue: Pushed to master as commit d47379b8dc6fb, thank you! ------------=_1745845322-19902-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Apr 2025 21:13:04 +0000 Received: from localhost ([127.0.0.1]:45314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u99J9-00052h-Hn for submit@debbugs.gnu.org; Sun, 27 Apr 2025 17:13:03 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45874) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u99J6-000520-VL for submit@debbugs.gnu.org; Sun, 27 Apr 2025 17:13:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u99Ix-0008DJ-Ep for guix-patches@gnu.org; Sun, 27 Apr 2025 17:12:51 -0400 Received: from ditigal.xyz ([2a01:4f8:1c1b:6a1c::] helo=mail.ditigal.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1u99Iv-0000YB-UJ for guix-patches@gnu.org; Sun, 27 Apr 2025 17:12:51 -0400 Received: by cerebrum (OpenSMTPD) with ESMTPSA id 30bbc8ef (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 27 Apr 2025 21:12:43 +0000 (UTC) From: Rutherther To: guix-patches@gnu.org Subject: [PATCH] guix: gtk-icon-themes: Generate output if no icons Date: Sun, 27 Apr 2025 23:05:25 +0200 Message-ID: <6a181010b8ad2c22063a64ab848303bc243e5f79.1745787923.git.rutherther@ditigal.xyz> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: =?utf-8?q?Christopher_Baines_=3Cguix=40cbaines=2Enet=3E=2C_Josselin_Poiret_=3Cdev=40jpoiret=2Exyz=3E=2C_Ludovic_Court=C3=83=C2=A8s_=3Cludo=40gnu=2Eorg=3E=2C_Mathieu_Othacehe_=3Cothacehe=40gnu=2Eorg=3E=2C_Simon_Tournier_=3Czimon=2Etoutoune=40gmail=2Ecom=3E=2C_Tobias_Geerinckx-Rice_=3Cme=40tobias=2Egr=3E=2C_Liliana_Marie_Prikler_=3Cliliana=2Eprikler=40gmail=2Ecom=3E=2C_=3Ciyzsong=40envs=2Enet=3E?= Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz; i=@ditigal.xyz; q=dns/txt; s=20240917; t=1745788363; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=GoNckcE0Sw72NR4lZYw1IDc+WRCNDaJHGipu7aWBnMc=; b=XsiZaisedEbyf/E+WOaya7J3NHvjsRoDZXJfKar9jnj772MftnYhRimtLMOuxuhs/7eqq xeVK91unKUxmKwz3s0+yurKyJmV/irq7WvW2ZdkL28KuS7fJVhDiUZ772N20C6iQsikXcxd vnZerItUsHvcSaWpP7lngBEKVX9K340= Received-SPF: pass client-ip=2a01:4f8:1c1b:6a1c::; envelope-from=rutherther@ditigal.xyz; helo=mail.ditigal.xyz X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.997, PDS_OTHER_BAD_TLD=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.4 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When there are no icon themes, but gtk+ is referenced in the manifest, the output won't be produced in the gtk-icon-themes derivation. This will lead to an error. The problem has been reported by lilyp on IRC. I can't find any packages in Guix that use gtk+ in inputs and don't have any icons, but this low-effort package replicates the issue: ``` (package (inher [...] Content analysis details: (3.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=rutherther%40ditigal.xyz; ip=2001%3A470%3A142%3A%3A17; r=debbugs.gnu.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ditigal.xyz (xyz)] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-Debbugs-Envelope-To: submit Cc: Rutherther X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) When there are no icon themes, but gtk+ is referenced in the manifest, the output won't be produced in the gtk-icon-themes derivation. This will lead to an error. The problem has been reported by lilyp on IRC. I can't find any packages in Guix that use gtk+ in inputs and don't have any icons, but this low-effort package replicates the issue: ``` (package (inherit bash) (inputs (modify-inputs (package-inputs bash) (append gtk+)))) ``` * guix/profiles.scm (gtk-icon-themes): Produce output when no icon cache is created. Change-Id: I2aa5ab0023c9c584182c67f79102fb66b46a3a7d --- guix/profiles.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/guix/profiles.scm b/guix/profiles.scm index 64d669c353..086280329e 100644 --- a/guix/profiles.scm +++ b/guix/profiles.scm @@ -1379,6 +1379,9 @@ (define* (gtk-icon-themes manifest #:optional system) (srfi srfi-26) (ice-9 ftw)) + ;; Ensure output is produced when no cache files are created. + (mkdir-p #$output) + (let* ((destdir (string-append #$output "/share/icons")) (icondirs (filter file-exists? (map (cut string-append <> "/share/icons") base-commit: 4e79ec48af8173f0f2a86fa2c8f971dc8234b941 -- 2.49.0 ------------=_1745845322-19902-1--