Subject: bug#78076: closed (Re: [bug#78076] [PATCH v2] gnu: nvc: Update to 1.16.0.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 28 Apr 2025 07:24:06 +0000

Your bug report

#78076: [PATCH electronics-team] gnu: nvc: Update to 1.16.0.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
78076: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78076
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#78076] [PATCH v2] gnu: nvc: Update to 1.16.0.
From: Christopher Baines <[email-masked]>
To: Cayetano Santos via Guix-patches via <[email-masked]>
Cc: [email-masked], Maxim Cournoyer <[email-masked]>, Cayetano Santos <[email-masked]>, Ekaitz Zarraga <[email-masked]>
Date: Mon, 28 Apr 2025 08:23:36 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Cayetano Santos via Guix-patches via <[email-masked]> writes:

> From: Cayetano Santos via Guix-patches via <[email-masked]>
>
> * gnu/packages/fpga.scm (nvc): Update to 1.16.0.
>
> Change-Id: If781ed403cd769db85f8265fc242d0f1608d737e
>
> ---
>
> This v2 includes the missing module gnu/packages/ruby.
>
> [arguments] <#:configure-flags> Remove --enable-{vhpi,gcov}.
> [native-inputs]: Add python and perl; sort.
> [inputs]: Remove elfutils; sort.
>
> Note that:
>
> --enable-gcov is intended for debug/development of the simulator itself and should not be enabled in release builds
>
> - VHPI is now always enabled at build time and the `--enable-vhpi` configure option has no effect.
>
>  gnu/packages/fpga.scm | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)

Thanks for the patch, I've pushed this to master as
f1ce653b13b300a8022da587541917941fdbbcaa.

Chris

Subject: [PATCH electronics-team] gnu: nvc: Update to 1.16.0.
From: Cayetano Santos <[email-masked]>
To: [email-masked]
Cc: Cayetano Santos <[email-masked]>
Date: Sat, 26 Apr 2025 18:28:58 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/fpga.scm (nvc): Update to 1.16.0.

Change-Id: If781ed403cd769db85f8265fc242d0f1608d737e
---

[arguments] <#:configure-flags> Remove --enable-{vhpi,gcov}.
[native-inputs]: Add python and perl; sort.
[inputs]: Remove elfutils; sort.

Note that:

--enable-gcov is intended for debug/development of the simulator itself and should not be enabled in release builds

- VHPI is now always enabled at build time and the `--enable-vhpi` configure option has no effect.

 gnu/packages/fpga.scm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
index dfbe1a2894..2d3c265950 100644
--- a/gnu/packages/fpga.scm
+++ b/gnu/packages/fpga.scm
@@ -551,7 +551,7 @@ (define-public python-vunit
 (define-public nvc
   (package
     (name "nvc")
-    (version "1.15.2")
+    (version "1.16.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -560,12 +560,11 @@ (define-public nvc
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1r6ba5jw4ja0hv366686d8haakm57h3fl95w81hda8haq6g0dj0q"))))
+                "1hi1mqhjbj7r3wcdkjr6yazwpc7y9lqc0b8bj4ikfgdfsmakm3s4"))))
     (build-system gnu-build-system)
     (arguments
      (list #:out-of-source? #t
-           #:configure-flags #~(list "--enable-vhpi" "--enable-tcl" "--enable-gcov"
-                                     "--enable-llvm")
+           #:configure-flags #~(list "--enable-tcl" "--enable-llvm")
            #:phases #~(modify-phases %standard-phases
                         (add-after 'unpack 'clean-up
                           (lambda _
@@ -573,16 +572,17 @@ (define-public nvc
     (native-inputs
      (list automake
            autoconf
+           check ; for the tests
            flex
            gettext-minimal
            libtool
            pkg-config
-           which
-           check)) ; for the tests
+           python
+           ruby
+           which))
     (inputs
-     (list elfutils
+     (list libffi
            llvm
-           libffi
            readline
            tcl
            `(,zstd "lib")))

base-commit: edeafb19c4a83eb81fe7e47a6a94f238db9cccf1
--
2.49.0