GNU bug report logs - #78066
[PATCH 0/2] Fix fail2ban build

Previous Next

Full log

View this message in rfc822 format

From: Andreas Enge <andreas <at> enge.fr>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 78066 <at> debbugs.gnu.org, Rodion Goritskov <rodion <at> goritskov.com>
Subject: [bug#78066] [PATCH v2 1/5] gnu: fail2ban: Move file deletion to source snippet.
Date: Tue, 29 Apr 2025 10:00:24 +0200

Hello Nicolas,

thanks for the update!

Am Sun, Apr 27, 2025 at 11:08:08AM +0200 schrieb Nicolas Graves:
> * gnu/packages/admin.scm (fail2ban)
>   [arguments]<phases>: Move multiple file deletion from here...
>   [source]<snippet>: ...to here.
> +                  ;; deleting things that are not feasible to fix
> +                  ;; or won't be used any way

What is the motivation for this change? I think we always remove
non-free code and often bundled libraries in a snippet, but changes only
related to the idiosyncrasies of Guix usually occur in the phases. In this
way, "guix build -S" returns essentially the source code of a package.

But this is not written policy, so no hard obstacle to pushing the
commit; I just do not see why a snippet would be better than a phase.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.