GNU bug report logs - #78034
[PATCH] guix: transformations: git source transformations honour RECURSIVE?.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
To: Romain GARBAGE <romain.garbage <at> inria.fr>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Simon Tournier <zimon.toutoune <at> gmail.com>, 78034 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>, ludovic.courtes <at> inria.fr, Mathieu Othacehe <othacehe <at> gnu.org>, Christopher Baines <guix <at> cbaines.net>
Subject: [bug#78034] [PATCH] guix: transformations: git source transformations honour RECURSIVE?.
Date: Thu, 24 Apr 2025 16:33:35 +0200

Hello!

Overall LGTM!  Minor suggestions:

Romain GARBAGE <romain.garbage <at> inria.fr> writes:

> +                      ;; Try to propagate RECURSIVE? from the package source when it
> +                      ;; is a git-checkout or a git-reference, keeping TRUE as
> +                      ;; default in other cases.
> +                      (let ((url recursive? (guard (c ((formatted-message? c )
> +                                                       (values url #t)))
> +                                              (package-git-url+recursive? old))))

Instead of catching ‘formatted-message?’, I would rather add an ‘if’ for
origin + git-reference or git-checkout.

> --- a/tests/transformations.scm
> +++ b/tests/transformations.scm
> @@ -217,8 +217,7 @@ (define-module (test-transformations)
>  
>  (test-equal "options->transformation, with-branch"
>    (git-checkout (url "https://example.org")
> -                (branch "devel")
> -                (recursive? #t))
> +                (branch "devel"))

IWBN to add a test where (recursive? #t) is inherited.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.