From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 23 09:18:09 2025 Received: (at submit) by debbugs.gnu.org; 23 Apr 2025 13:18:09 +0000 Received: from localhost ([127.0.0.1]:55635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7ZzM-0003dT-QK for submit@debbugs.gnu.org; Wed, 23 Apr 2025 09:18:09 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46056) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7ZzI-0003bK-Qs for submit@debbugs.gnu.org; Wed, 23 Apr 2025 09:18:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7ZzC-0004qk-I4 for guix-patches@gnu.org; Wed, 23 Apr 2025 09:17:58 -0400 Received: from devianza.investici.org ([2c0f:f930:0:4::108]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7Zz9-0001UV-Bj for guix-patches@gnu.org; Wed, 23 Apr 2025 09:17:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1745414262; bh=ocsi5mFyo1MQDAv6A4wGSU1eh1ADaEY7wHPpttb0oKU=; h=From:To:Cc:Subject:Date:From; b=WcAX6Mlw0hWOMZBXYFueUnTIeSURZ5gMWzTinW/GW13KeUShOPH9cNyZKA1QAEeBm LzqBiinZxM+zQ2ZB8i/cr9dYUQFLBeV1EXWD9uzxdotG7KqU9lXata2DcUu6d4z+8v zPU02SwTVP4ckZaeQJNhEXxOM5wiBgfJZF6daJow= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4ZjKQt1lt5z6vRn; Wed, 23 Apr 2025 13:17:42 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZjKQt0Gxbz6vPC; Wed, 23 Apr 2025 13:17:41 +0000 (UTC) From: Cayetano Santos To: guix-patches@gnu.org Subject: [PATCH electronics-team] gnu: Add opensta. Date: Wed, 23 Apr 2025 15:14:20 +0200 Message-ID: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Cayetano Santos , Ekaitz Zarraga , Maxim Cournoyer Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2c0f:f930:0:4::108; envelope-from=csantosb@inventati.org; helo=devianza.investici.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Cayetano Santos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/electronics.scm (opensta): New variable. Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7 --- gnu/packages/electronics.scm | 41 ++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm index 12e44f234a..1b733a5a1f 100644 --- a/gnu/packages/electronics.scm +++ b/gnu/packages/electronics.scm @@ -38,6 +38,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) #:use-module (gnu packages base) + #:use-module (gnu packages bison) #:use-module (gnu packages boost) #:use-module (gnu packages c) #:use-module (gnu packages check) @@ -45,6 +46,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages compression) #:use-module (gnu packages documentation) #:use-module (gnu packages embedded) + #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) #:use-module (gnu packages gl) #:use-module (gnu packages glib) @@ -53,6 +55,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages libftdi) #:use-module (gnu packages libusb) #:use-module (gnu packages linux) + #:use-module (gnu packages maths) #:use-module (gnu packages m4) #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) @@ -65,6 +68,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages sqlite) #:use-module (gnu packages stb) #:use-module (gnu packages swig) + #:use-module (gnu packages tcl) #:use-module (gnu packages tls) #:use-module (gnu packages toolkits) #:use-module (gnu packages version-control)) @@ -415,6 +419,43 @@ (define-public openboardview @end itemize") (license license:expat))) +(define-public opensta + (let ((commit "400c473fe384773a4788ee8378238462b4291fe3") + (revision "0")) + (package + (name "opensta") + (version (git-version "2.6.2" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/parallaxsw/OpenSTA/") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "091np9jnhfzggc7f5q9kx7kfa1fxjrj7d1mnw6q4gniqbs5hwrg5")))) + (build-system cmake-build-system) + (arguments + (list + #:tests? #f ; no tests + #:out-of-source? #t + #:configure-flags + #~(list + (string-append "-DCUDD_DIR=" #$cudd) + (string-append "-DCMAKE_INSTALL_PREFIX=" #$output)) + #:make-flags + #~(list (string-append "CC=" #$(cc-for-target)) + (string-append "CXX=" #$(cxx-for-target)) + (string-append "PREFIX=" #$output)))) + (native-inputs (list swig bison flex)) + (inputs (list tcl tcllib zlib cudd eigen)) + (synopsis "Parallax Static Timing Analyzer") + (description + "OpenSTA is a gate level static timing verifier. As a stand-alone executable +it can be used to verify the timing of a design using standard file formats.") + (home-page "https://github.com/parallaxsw/OpenSTA/") + (license license:gpl3+)))) + (define-public pulseview (package (name "pulseview") base-commit: 699ce22ed812cf8cfcdd8d0341829f8fac2c864a -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 24 22:59:09 2025 Received: (at 78011) by debbugs.gnu.org; 25 Apr 2025 02:59:10 +0000 Received: from localhost ([127.0.0.1]:44056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u89HP-0004NA-QX for submit@debbugs.gnu.org; Thu, 24 Apr 2025 22:59:09 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:48621) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u89HJ-0004LI-Ez for 78011@debbugs.gnu.org; Thu, 24 Apr 2025 22:59:05 -0400 Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-301a4d5156aso2213238a91.1 for <78011@debbugs.gnu.org>; Thu, 24 Apr 2025 19:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745549935; x=1746154735; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Xf+hzEeBUjXuPIjvWg1977YvJNKFo3pWYok+X/N/Osk=; b=hEtsjnh05VxpUySCkQ40fQCGwBy5KxaRsBIC3I4ElOWaP6LH9gVIltgWxHy/iOkRJA d6JPZM26aVMs7cRuonJIjY70bGZGkkvFmA+mcHanpbA7BwztXhug8pL+6z153/UQcgiI mVAy34n/9e0FyCBHtTSyHiqdxC3th//1ww6WGez7AdX39Bn8lSTif9yqEkMlXMLyWFlY ADDGv4EyAS+7aVX9La/k0F416K9KxNan1O6L3rIRaFgskj5fDa2EFDrQVn+MTQ71ph0v oipGItGOg5HfzYpSThWKVcAg1lg7R/HBNZI96Szvvi1oQcpHTSzK/oTJLW9sRSnwrb29 JJvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745549935; x=1746154735; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xf+hzEeBUjXuPIjvWg1977YvJNKFo3pWYok+X/N/Osk=; b=tK06yVSuPRwj6/+vPMmg42rzAvy/IgePAZ/tQnBL2fmZRl975sfEJ4l9GNZBl9Hah7 9jvqACQHKhxVbgi/dIljh+OL4YY3iuntPV/0z5c8Scbl3zaE8NBZ1GEdH+Ar20YYEBDo pyizT1q4znEWyTE2muAIs5OOpS16Oc2CciuDqsHxTLlxOB0smeHsS7FYmgN2hPOpvEBn 6Kp0NRIxyKn4DN1b87x+hCKXEOTirgq9qGHAwW/HTOFK0CXS4URLuVo7mBz2phFihZHq eerTNsfAfGPOrpX+GNnWYS4LyGoH2rEtg2JyJgj/JK9++YKY8amus/3EwdyQVfVJQEjd Ys5g== X-Gm-Message-State: AOJu0YzLeGKz9vfv8uf26HwCciPmcFFuFg20i8mxt7tJ4K12W7tlR693 qsWZXARzTADdgDzN1FJfKPobI80Xp7VhigfRl8dvKNYG7Nh82hLkuWUcJQ== X-Gm-Gg: ASbGncuMXWiZC45gwtsXR5ZO0R8Vr7nbShVmRup5lWb7esJ/ub4U8tkFJ7MjLLUn6uV 9ETsmHRfbyZHl3fKvlhGnU91x3Iddxjiw2gAXLAL+Jl0o2M2P5ogImlFUeoIlOYfBm+A7UtsXWB HVHysCZXBVcyXY73ZGXaDrCnvD1rPbNfmM7Ah1T7P1nSVJl+hDmJutk36WRVvZyf6irI9IQua9G 3DvSOSRo2eErYCxKVEiYEfo+/o/cKau62FKmGsXDZnskYgOJLOlGCIWDVaJKvRuL/zdxmWreMic 6mJGaP3LtGKUsTng0rkqg6bZG9tzks1DBP4yHgg= X-Google-Smtp-Source: AGHT+IEXn8vieU/Z6dVszKOTFTeKeDVVz64VHeHoNVYAbcmWUapM3Mh4snXgNSC2HGnoy7LV/lSflA== X-Received: by 2002:a17:90b:3944:b0:301:98fc:9b5a with SMTP id 98e67ed59e1d1-309f7da6d2fmr1299944a91.6.1745549934825; Thu, 24 Apr 2025 19:58:54 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4dbd3f9sm21426055ad.89.2025.04.24.19.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 19:58:54 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta. In-Reply-To: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> (Cayetano Santos's message of "Wed, 23 Apr 2025 15:14:20 +0200") References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> Date: Fri, 25 Apr 2025 11:58:51 +0900 Message-ID: <87frhxrlp0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78011 Cc: 78011@debbugs.gnu.org, Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! Cayetano Santos writes: > * gnu/packages/electronics.scm (opensta): New variable. > > Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7 > --- [...] > +(define-public opensta It's good to include a comment about why a precise commit is used, e.g. "Use the latest commit as they included unreleased fixes." > + (let ((commit "400c473fe384773a4788ee8378238462b4291fe3") > + (revision "0")) > + (package > + (name "opensta") > + (version (git-version "2.6.2" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/parallaxsw/OpenSTA/") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "091np9jnhfzggc7f5q9kx7kfa1fxjrj7d1mnw6q4gniqbs5hwrg5")))) > + (build-system cmake-build-system) > + (arguments > + (list > + #:tests? #f ; no tests There are tests; their Jenkinsfile runs them via the 'test/regression' script. You'll need to override the check phase as it's not registered as a CMake test target. > + #:out-of-source? #t No need to explicit this; it's the default for cmake-build-system. > + #:configure-flags > + #~(list > + (string-append "-DCUDD_DIR=" #$cudd) It'd be better if this referred to the same cudd package that is provided as an input (otherwise it cannot be rewritten via package transformations). You can refer to it within this gexp with #$(this-package-input "cudd") > + (string-append "-DCMAKE_INSTALL_PREFIX=" #$output)) No need for this, as it's also the default. > + #:make-flags > + #~(list (string-append "CC=" #$(cc-for-target)) > + (string-append "CXX=" #$(cxx-for-target)) > + (string-append "PREFIX=" #$output)))) I doubt these are needed; our cmake build system should know how to cross-compile without this being manually set. > + (native-inputs (list swig bison flex)) > + (inputs (list tcl tcllib zlib cudd eigen)) > + (synopsis "Parallax Static Timing Analyzer") > + (description > + "OpenSTA is a gate level static timing verifier. As a stand-alone executable Please fold your paragraphs so they stay within < 80 columns, our coding style guideline (M-q in Emacs). > +it can be used to verify the timing of a design using standard file formats.") > + (home-page "https://github.com/parallaxsw/OpenSTA/") > + (license license:gpl3+)))) Otherwise it LGTM. Could you please send a v2 with the above comments taken into account? -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 24 23:31:16 2025 Received: (at 78011) by debbugs.gnu.org; 25 Apr 2025 03:31:16 +0000 Received: from localhost ([127.0.0.1]:44337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u89mU-0002FO-Qm for submit@debbugs.gnu.org; Thu, 24 Apr 2025 23:31:15 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:51569) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u89mO-0002Dy-30 for 78011@debbugs.gnu.org; Thu, 24 Apr 2025 23:31:12 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-7394945d37eso1509457b3a.3 for <78011@debbugs.gnu.org>; Thu, 24 Apr 2025 20:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745551862; x=1746156662; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=5Bd76aPWaOI4RWTPJXfK0uwS8VtsHKpqf3hLpv9nvNQ=; b=nbTemZk8zDeR0AUiBEkwNBNYWu894KEQ9ifK53wgCq99LhmvIggH3Ctue6HHu+u99n mqouBGOxi/cVF/UHRrv0QOF58LGGfQ4c6TV0uef6wZudaQdvI5iiEkAO5FUaq+hggJmc z/blySEkwbti3ufMC7s4uk1mRtENdXMw9co/dV5FW5vx2taXbh0ZU53EoFeMY3+MjxoZ ukSprxMCwpaHuJYsqm+sgxX0mcyd33fHbYk/6TWqinKWxP5Wks+CLHjJS9B41pqtDBFY b4zJnqahQ0aOpHjtTaHnRnx4peYHqkf84gSBdeSuX0qeIX3LvH4PWEY3DA4J3EYKtngU PGkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745551862; x=1746156662; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Bd76aPWaOI4RWTPJXfK0uwS8VtsHKpqf3hLpv9nvNQ=; b=rcNHvWezCudvD4Fri2OvN++K3RX1PQDFbh7Jk6F8hjkyefUVf+lC/4wHCm080jn6y4 958uj2x1U4YtnZSSN9B4G/JtB/AqUMPL8YUZx5Fs6JenhkAMX2jYCYiwl3a2FCUXu4AZ Yb4oIuTXBR+x5qU8kvBUBC4Wr9CLskch7iT23MakxrwLKht3UGkBKl7Z5+Cq7fyT+MeQ ZGQRP8qnJXNSpk0ChX8Xo0zh5FCbRM0ea5XFLblJGxoLGnfxAoNS1ha9TnhcBDV3RjF1 QpK+CZPBBY99gUJXH+ngKcpBfCLFtrRFeYcNAV7jy+E1dvHNCXMTYl+ypE7GP/X4I85t i0ZA== X-Gm-Message-State: AOJu0YwPaxMfbtXBbl0qZH3GDxo3sNuPbnnxbV/n5qabrVu/xgqurMsT uUCeHtsPpwtnXTLbxvl3/niTv4AOjvCKpCFq/W6oaG3Qn8TMN7lz X-Gm-Gg: ASbGncuB7b1faz7MgxXMmStGE/hXNvuj1/zW+4XPJBhFnJy7o1NwwNWKcXnyrYSgbbx XwHhaJN/2VDmWwuZiAtO8Wu71DnWy5b+nBJlAZIK3bXri5qAqxv2bB7YOb52/c0SZ5pFP3HgDmb +uzuqm7jL2cVJf1I+sNbK/L3LleavRjT9tl12nRA+sWNFwdlSe94mjYICJ2EoMVg51Qozi2WstO qMPF4nahNeZljVhxxBRM5Y8LgayC9QCrLnKkSJHNj5QTm6e57tggXkZ2uBy0OXdd9XLqcYUKbJM fEinxGWaF0Q6CsBtzFsZ4YxbcjbCdi8cxDZakGM= X-Google-Smtp-Source: AGHT+IF3LVhA74ccNEvzyCpkKmnj+dLdPaD//m4Iibf1lKIrbAPYPduotqV3vtH4PK6ebcZjlHfsiQ== X-Received: by 2002:a05:6a00:853:b0:73e:2340:4b07 with SMTP id d2e1a72fcca58-73fd876f916mr941444b3a.18.1745551861678; Thu, 24 Apr 2025 20:31:01 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6aa52sm2267550b3a.94.2025.04.24.20.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 20:31:01 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta. In-Reply-To: <87frhxrlp0.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 25 Apr 2025 11:58:51 +0900") References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> <87frhxrlp0.fsf@gmail.com> Date: Fri, 25 Apr 2025 12:30:58 +0900 Message-ID: <878qnosyrx.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78011 Cc: 78011@debbugs.gnu.org, Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Something like this: --8<---------------cut here---------------start------------->8--- 1 file changed, 11 insertions(+), 10 deletions(-) gnu/packages/electronics.scm | 21 +++++++++++---------- modified gnu/packages/electronics.scm @@ -423,10 +423,12 @@ (define-public openboardview (license license:expat))) (define-public opensta + ;; There are no releases; use the latest commit. (let ((commit "400c473fe384773a4788ee8378238462b4291fe3") (revision "0")) (package (name "opensta") + ;; The version string is taken from the CMakeLists.txt. (version (git-version "2.6.2" revision commit)) (source (origin @@ -440,18 +442,17 @@ (define-public opensta (build-system cmake-build-system) (arguments (list - #:tests? #f ; no tests - #:out-of-source? #t #:configure-flags #~(list - (string-append "-DCUDD_DIR=" #$cudd) - (string-append "-DCMAKE_INSTALL_PREFIX=" #$output)) - #:make-flags - #~(list (string-append "CC=" #$(cc-for-target)) - (string-append "CXX=" #$(cxx-for-target)) - (string-append "PREFIX=" #$output)))) - (native-inputs (list swig bison flex)) - (inputs (list tcl tcllib zlib cudd eigen)) + (string-append "-DCUDD_DIR=" #$(this-package-input "cudd")) + (string-append "-DBUILD_SHARED_LIBS=YES")) + #:phases #~(modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "../source/test/regression"))))))) + (native-inputs (list bison flex swig)) + (inputs (list cudd eigen tcl tcllib zlib)) (synopsis "Parallax Static Timing Analyzer") (description "OpenSTA is a gate level static timing verifier. As a stand-alone executable --8<---------------cut here---------------end--------------->8--- I note that the package doesn't cross-build currently due to a problem finding flex, but that's not the above definition's fault. The BUILD_SHARED_LIBS=YES builds a .so library which cuts the space used by half about. The inputs are sorted lexicographically and some comments are added, with the extraneous flags/arguments pruned. Hope that helps, -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 25 08:47:30 2025 Received: (at 78011) by debbugs.gnu.org; 25 Apr 2025 12:47:31 +0000 Received: from localhost ([127.0.0.1]:48664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8ISo-00015q-IL for submit@debbugs.gnu.org; Fri, 25 Apr 2025 08:47:30 -0400 Received: from latitanza.investici.org ([82.94.249.234]:38273) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8ISk-00015f-Ha for 78011@debbugs.gnu.org; Fri, 25 Apr 2025 08:47:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1745585244; bh=mllzsHBwZMRw1tbwAN9EBkqiYArGvKLNOxgrK1Ux4vc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IjZ6dI28AdSUsi2AnfN+RjCatzS5ieAfZ60y0bxKeq+brJtn0ah1S9JTyLfsNLgAl JJ0QTw1kUoivsWGGMNiXji0/weBexHjS/nBaQ7hNNFNcl/ZMTIDlqSeLH8Ae/UOZOs bepu81JtKknQNR6GcuG1EMh6RV26Zsc/Dc6J7eCQ= Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4ZkXg01NWHzGp3p; Fri, 25 Apr 2025 12:47:24 +0000 (UTC) Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZkXfz6b03zGp3n; Fri, 25 Apr 2025 12:47:23 +0000 (UTC) From: Cayetano Santos To: Maxim Cournoyer Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta. In-Reply-To: <87frhxrlp0.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 25 Apr 2025 11:58:51 +0900") References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> <87frhxrlp0.fsf@gmail.com> User-Agent: mu4e 1.12.9; emacs 29.4 Date: Fri, 25 Apr 2025 14:47:22 +0200 Message-ID: <87selwqug5.fsf@inventati.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78011 Cc: 78011@debbugs.gnu.org, Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >ven. 25 avril 2025 at 11:58, Maxim Cournoyer wrote: Hi Maxim, > Please fold your paragraphs so they stay within < 80 columns, our coding > style guideline (M-q in Emacs). The .editorconfig file in guix states "max_line_length = 85", which the corresponding emacs package honors. Is this correct ? C. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaAuEWhccY3NhbnRvc2JA aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgjI/AQCSqvZFQaI/Bka1ucScOyaiGsnW mQF5+bDv5E8Yilo/rgD/VfRIW5gAmJF29VqLEWvjAtMDmWxTUP0RNDrVcp5dtwE= =vpUK -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 25 09:26:08 2025 Received: (at 78011) by debbugs.gnu.org; 25 Apr 2025 13:26:08 +0000 Received: from localhost ([127.0.0.1]:48877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8J4C-0003sZ-9r for submit@debbugs.gnu.org; Fri, 25 Apr 2025 09:26:08 -0400 Received: from devianza.investici.org ([198.167.222.108]:43337) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8J47-0003sH-BP for 78011@debbugs.gnu.org; Fri, 25 Apr 2025 09:26:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1745587561; bh=E13LoT1HrwjruAPjd9AxYUcr1qFikPeQefuGQtnaNCc=; h=From:To:Cc:Subject:Date:From; b=ctbFsUxU7gLHCdzm/bCowhWk07xdmiky5eSRhx875tYf+USlS0EMo8m9EAAIngM7E dc5cclWEg9KyKb45g8Gsu0Fn6TsuJFbtT7DSjZpkgPBdskyRlhvSNSH4788/5wRBuS a1+FtsLKYJq2vDnHauxWaMH9r/8hdHW4r92bS0Uk= Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4ZkYWY5NQzz6vNZ; Fri, 25 Apr 2025 13:26:01 +0000 (UTC) Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZkYWY1fJ7z6vLc; Fri, 25 Apr 2025 13:26:01 +0000 (UTC) From: Cayetano Santos To: 78011@debbugs.gnu.org Subject: [PATCH v2] gnu: Add opensta. Date: Fri, 25 Apr 2025 15:24:30 +0200 Message-ID: <2bf33bae3435d88a889a40e212102e9604af51ed.1745587470.git.csantosb@inventati.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Cayetano Santos , Ekaitz Zarraga , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78011 Cc: Cayetano Santos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/electronics.scm (opensta): New variable. Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7 --- gnu/packages/electronics.scm | 41 ++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm index 12e44f234a..63782661ee 100644 --- a/gnu/packages/electronics.scm +++ b/gnu/packages/electronics.scm @@ -38,6 +38,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) #:use-module (gnu packages base) + #:use-module (gnu packages bison) #:use-module (gnu packages boost) #:use-module (gnu packages c) #:use-module (gnu packages check) @@ -45,6 +46,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages compression) #:use-module (gnu packages documentation) #:use-module (gnu packages embedded) + #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) #:use-module (gnu packages gl) #:use-module (gnu packages glib) @@ -53,6 +55,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages libftdi) #:use-module (gnu packages libusb) #:use-module (gnu packages linux) + #:use-module (gnu packages maths) #:use-module (gnu packages m4) #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) @@ -65,6 +68,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages sqlite) #:use-module (gnu packages stb) #:use-module (gnu packages swig) + #:use-module (gnu packages tcl) #:use-module (gnu packages tls) #:use-module (gnu packages toolkits) #:use-module (gnu packages version-control)) @@ -415,6 +419,43 @@ (define-public openboardview @end itemize") (license license:expat))) +(define-public opensta + ;; There are no releases, we use last commit. + (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f") + (revision "0")) + (package + (name "opensta") + (version (git-version "2.6.2" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/parallaxsw/OpenSTA/") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5")))) + (build-system cmake-build-system) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (replace 'check + (lambda* (#:key (tests? #t) #:allow-other-keys) + (when tests? + (invoke "../source/test/regression"))))) + #:configure-flags + #~(list + (string-append "-DCUDD_DIR=" #$(this-package-input "cudd"))))) + (native-inputs (list swig bison flex)) + (inputs (list tcl tcllib zlib cudd eigen)) + (synopsis "Parallax Static Timing Analyzer") + (description + "OpenSTA is a gate level static timing verifier. As a stand-alone executable +it can be used to verify the timing of a design using standard file formats.") + (home-page "https://github.com/parallaxsw/OpenSTA/") + (license license:gpl3)))) + (define-public pulseview (package (name "pulseview") base-commit: 501a9603f5e3cda07f3be8e7fecac31f7af5ce52 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 26 08:26:10 2025 Received: (at 78011) by debbugs.gnu.org; 26 Apr 2025 12:26:10 +0000 Received: from localhost ([127.0.0.1]:59129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8ebh-0007n9-K9 for submit@debbugs.gnu.org; Sat, 26 Apr 2025 08:26:10 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:53339) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u8ebd-0007mO-BJ for 78011@debbugs.gnu.org; Sat, 26 Apr 2025 08:26:06 -0400 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-3012a0c8496so2509575a91.2 for <78011@debbugs.gnu.org>; Sat, 26 Apr 2025 05:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745670359; x=1746275159; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=18eoQnHs9Sm9WVbyCqEVHrUrEgbAln6nRtaDCSuUcu0=; b=aYV++8FuskwYaZfi+Wg9k5FQFZRlRW7OUacW8VfberM6LVrpecJk25jNPZoeU55a0f qX6UIMUZD7ePnJ/bURAOvd65fjJE0kslZSDTHN8EjfAQFxIfySo1AY/UnYyBLO5pBDQS d3VtfP0ICmFR+MPceXQyi4H9OONWuwQbx+AeFF3lxSjHuzGdaj+cIuBFbzWknBj3xfw5 ul1x2fkeQcvAYI+quLhcU8hvEiDb6vPnSWaIK4JaN5w+epQPEkiDt2lB9aEDJBbj+o48 6jXxZzkYK10EoyrUCHgM7ThbwmpobTfvgTM9YgWoK+Clkw8/+beL2jlFOjmwGh0rXe8k i+Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745670359; x=1746275159; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=18eoQnHs9Sm9WVbyCqEVHrUrEgbAln6nRtaDCSuUcu0=; b=qo15eJGMa3IJmREyNMm5k7zgpvZM1U97CvPPFOh5MU1Xq1cZ9gYaTXu27xHqc+rgxG BVZsLJ3ugcCGHkeK31RC/o6lQ48spzFHEMDe8Ym0w5GS5nUML47gQc2dNhFVWDPPZ0IG oVrmYfTCf2dhLDETJxeiKcZkJsK27aE4NgWmUePXX3u+YhD1pczSLvOmFulECfBACDS/ Y5R0ppgNe4dys13s10VwQ3cCYApJEeQE/eRtXvhQW9jYy1W3BEvd9SZueMT+s0yAvURd 4bBxbBe9z8XX5xm/7KanX5dMWn8hlF542BnAhoOcXjV52+HhhTaC3IAlnJTCanlc4A/9 cnRw== X-Gm-Message-State: AOJu0YxtgDV5tn/lyoLa7VcaQgnoxEBHXIL2rfBh8V/HRciyKrpa0VnO p/2O5FlvFrRRtxM3g9kujrgmqBVgDHbUPzICxAZwtFXhnhiDYClV X-Gm-Gg: ASbGncuPm8l9tLrkgNF/xNN1zJdEdDPSibnHm8RQfJeQe9cs1rZLsAYM1dwW34hmlBi D09wqF8Sr/WDlCmMsb8OmGO2t2ytAYJXpJ7+Sdsd5/XrAmGoV7hPHeO7icoRQ45pArE+sIssABN 52WoyZYzQuDEfPw6Vi2PVH7mlu3WWnugaLW/vuEWWG8L/Zplm1s9b9mTuTK9bCtxdnpKMwiOo35 8zeJ9jTHyoSsby5aFZzNVqiffxu1Ga5OnuPDQwh3vif1ZHBsyDgMGc0rqKC5A9Wri+ITkEsbikG 1cOEy1OmapkUHgFrw6sTCu0uw0PbdGQw98oIy6Q= X-Google-Smtp-Source: AGHT+IEVQT1BoFnxNxnWQbeDS5qWpHqX436CsN3nGMKnq1SSUgnP0xYh1IZ9u51gdfeukuVDrWdgmA== X-Received: by 2002:a17:90b:4b4e:b0:301:1d03:93cd with SMTP id 98e67ed59e1d1-30a013988efmr4669533a91.24.1745670359122; Sat, 26 Apr 2025 05:25:59 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309f784ac3fsm3429044a91.45.2025.04.26.05.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Apr 2025 05:25:58 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta. In-Reply-To: <87selwqug5.fsf@inventati.org> (Cayetano Santos's message of "Fri, 25 Apr 2025 14:47:22 +0200") References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> <87frhxrlp0.fsf@gmail.com> <87selwqug5.fsf@inventati.org> Date: Sat, 26 Apr 2025 21:25:55 +0900 Message-ID: <875xirds8c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78011 Cc: 78011@debbugs.gnu.org, Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Cayetano Santos writes: >>ven. 25 avril 2025 at 11:58, Maxim Cournoyer wrote: > > Hi Maxim, > >> Please fold your paragraphs so they stay within < 80 columns, our coding >> style guideline (M-q in Emacs). > > The .editorconfig file in guix states "max_line_length = 85", which the > corresponding emacs package honors. Is this correct ? It was not. It should be 80. Fixed in commit e018fb6f61a. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 26 08:44:27 2025 Received: (at 78011) by debbugs.gnu.org; 26 Apr 2025 12:44:27 +0000 Received: from localhost ([127.0.0.1]:59235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8etO-0000WY-Kr for submit@debbugs.gnu.org; Sat, 26 Apr 2025 08:44:26 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:55668) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u8etL-0000WI-Dm for 78011@debbugs.gnu.org; Sat, 26 Apr 2025 08:44:24 -0400 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-309f3bf23b8so3103889a91.3 for <78011@debbugs.gnu.org>; Sat, 26 Apr 2025 05:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745671457; x=1746276257; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qh4CARRhoyLlyM3rIKEhWOVcuXZLSkF80hDZ4nTQvDo=; b=ibpDotihgSs/2f0YgAtbUAurLa7nJsMJTNisMF/CDKitrAgOdUaU+K8XMyNxEQCUHZ Mm4inM7hzDuaTOW0eQ5AnGq+DmKSaJPf+WmrUCkINDTuhb7jruqHAOdVaRjXwsQ7W+f4 WberQgPP1SeH/Niu887rik37OGoojLIJTrcYDQ2lA+mCe6C15Mm1YCrqOYiQ5qBhzE74 B3gOiYPfrUWTscAYRqihLypac4aHFeWdItModO2+2mC06zvzfVxUHOewuiePy2lDyCn1 hU9vC1KeJ+zD7O3740KPoY8u9XXLd5x/7bH4qDbGdV+OReWqrsgHevsgP2j0yW3RhVD2 uU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745671457; x=1746276257; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qh4CARRhoyLlyM3rIKEhWOVcuXZLSkF80hDZ4nTQvDo=; b=oQ+ktWShitCzhmyMcAMIVc/yLHXmVZWUvWOmTqmANA73nUa4FY5zsL/MKbEJsjOs3F OvpwnoAD+A8Torc6Li5EK2NUcp+k6ZYkI4Nj/qKzYgtn27mwBthic87cmcvjY6AXDUod JunlQW+a2IWY0n03znGm59inWA5AV0SSto9hqvBEf4AsW2FCE6N4YDu7Fx4cHInq59tt OX7Ro9YpOcXEy+EMgpNPaKqx/oJBkzwGi0CSa5HQpMcCT9sQGUW640wg4Cs9wsuE5hyw TooLm+1iHS3ybWd87ImOkgwPDqOLyI/Va0OINin95dqmS7+HMN/H/UzS7Ee6OH3Qpr6O JR5A== X-Gm-Message-State: AOJu0YxBD1wdURmLjeebS48Tk/ZdVooBCABLPJLEuLwA0RJW7MV5lQfV oDj7xnrYGz/VeDixHeMTBVermfGXbYKZ9/mW6vXWe10fjoF4+biI X-Gm-Gg: ASbGnct8RsVSdPcXKPwX7+/d8ZO/dOWblXqb6e03iXpoNJKZIPXVBeeodDH3CVUnq5+ RT71cT8CrhxPkEPRIkzDIw4Bj/AwN6oF0PA1+G8INgLC+dzOU+omgcxOijw1ynV5kZXiWPAWEyf LzDQdYfNIl+Txxjqggz6NMby3RtI0OXwHLHpCDpG86dRMxO6j9EDVcYvmRfGFTdhCBz7nq1Qw4J 7pB0VWu+xcu7DeC4BC2ywAskDXRg7uqg91qM2Rlh+ukMjjYThe2o+PBrZxUc8E3oA62J85ywJ2a TBclBNaT2O7wykT4dRjs1f8jZdYS4Lc7hOPu8rIAntoie7cXIw== X-Google-Smtp-Source: AGHT+IEThQmiQTNmMd5NYKXUiigml+Mv149zCaqxTJb9q+Am/hn5tYaKXY+ceXobjPrcj2K/xXkgVQ== X-Received: by 2002:a17:90b:57e8:b0:2ff:58b8:5c46 with SMTP id 98e67ed59e1d1-30a013275a8mr3955656a91.8.1745671457187; Sat, 26 Apr 2025 05:44:17 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef03c806sm5243557a91.8.2025.04.26.05.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Apr 2025 05:44:16 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta. In-Reply-To: <2bf33bae3435d88a889a40e212102e9604af51ed.1745587470.git.csantosb@inventati.org> (Cayetano Santos's message of "Fri, 25 Apr 2025 15:24:30 +0200") References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> <2bf33bae3435d88a889a40e212102e9604af51ed.1745587470.git.csantosb@inventati.org> Date: Sat, 26 Apr 2025 21:44:14 +0900 Message-ID: <871ptfdrdt.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78011 Cc: 78011@debbugs.gnu.org, Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Cayetano Santos writes: [...] > +(define-public opensta > + ;; There are no releases, we use last commit. > + (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f") > + (revision "0")) > + (package > + (name "opensta") > + (version (git-version "2.6.2" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/parallaxsw/OpenSTA/") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5")))) > + (build-system cmake-build-system) > + (arguments > + (list Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested to reduce the output size, as suggested in my original review. > + #:phases > + #~(modify-phases %standard-phases > + (replace 'check > + (lambda* (#:key (tests? #t) #:allow-other-keys) Please do not set default values for arguments to this anonymous procedure; it just clutters the view (#:tests? is always passed by the build system -- it is it which holds the default value). > + (when tests? > + (invoke "../source/test/regression"))))) > + #:configure-flags > + #~(list > + (string-append "-DCUDD_DIR=" #$(this-package-input "cudd"))))) > + (native-inputs (list swig bison flex)) > + (inputs (list tcl tcllib zlib cudd eigen)) It looks like you overlooked my suggestion to sort the native-inputs/inputs. > + (synopsis "Parallax Static Timing Analyzer") > + (description > + "OpenSTA is a gate level static timing verifier. As a stand-alone executable > +it can be used to verify the timing of a design using standard file formats.") > + (home-page "https://github.com/parallaxsw/OpenSTA/") > + (license license:gpl3)))) Why the license change from gpl3+ to gpl3? The former was correct. Otherwise, LGTM. Could you send a v3? -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 26 15:25:49 2025 Received: (at 78011) by debbugs.gnu.org; 26 Apr 2025 19:25:50 +0000 Received: from localhost ([127.0.0.1]:35225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8l9p-0003K6-Fm for submit@debbugs.gnu.org; Sat, 26 Apr 2025 15:25:49 -0400 Received: from confino.investici.org ([93.190.126.19]:23135) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8l9a-0003JM-Li for 78011@debbugs.gnu.org; Sat, 26 Apr 2025 15:25:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1745695531; bh=4y+J6AWSITXiHaCO+2Ts0a+sBAjItd5fxRHrraT0EBc=; h=From:To:Cc:Subject:Date:From; b=EM15DcDLlskZVc5QozpoIn4i4s2LA6v4VJ2P38/85W6X9Bko1kODg/hjM9m57kTrF GAaSvorD+BvdevDBL4XC5pERVoclERyG6k0y50QbJjvpMIGr1h6kos0gLpnqpqo6Dy iAt0y5cqVJH6qyUW34SrVM0TbIsMXEvf/D2/VAWU= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4ZlKRv2jmYz11F1; Sat, 26 Apr 2025 19:25:31 +0000 (UTC) Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZlKRv08gFz11DK; Sat, 26 Apr 2025 19:25:30 +0000 (UTC) From: Cayetano Santos To: 78011@debbugs.gnu.org Subject: [PATCH v3] gnu: Add opensta. Date: Sat, 26 Apr 2025 21:25:23 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Cayetano Santos , Ekaitz Zarraga , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78011 Cc: Cayetano Santos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/electronics.scm (opensta): New variable. Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7 --- gnu/packages/electronics.scm | 44 ++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm index 12e44f234a..e32bad9c9d 100644 --- a/gnu/packages/electronics.scm +++ b/gnu/packages/electronics.scm @@ -38,6 +38,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) #:use-module (gnu packages base) + #:use-module (gnu packages bison) #:use-module (gnu packages boost) #:use-module (gnu packages c) #:use-module (gnu packages check) @@ -45,6 +46,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages compression) #:use-module (gnu packages documentation) #:use-module (gnu packages embedded) + #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) #:use-module (gnu packages gl) #:use-module (gnu packages glib) @@ -53,6 +55,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages libftdi) #:use-module (gnu packages libusb) #:use-module (gnu packages linux) + #:use-module (gnu packages maths) #:use-module (gnu packages m4) #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) @@ -65,6 +68,7 @@ (define-module (gnu packages electronics) #:use-module (gnu packages sqlite) #:use-module (gnu packages stb) #:use-module (gnu packages swig) + #:use-module (gnu packages tcl) #:use-module (gnu packages tls) #:use-module (gnu packages toolkits) #:use-module (gnu packages version-control)) @@ -415,6 +419,46 @@ (define-public openboardview @end itemize") (license license:expat))) +(define-public opensta + ;; There are no releases, we use last commit. + (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f") + (revision "0")) + (package + (name "opensta") + ;; The version string is taken from the CMakeLists.txt. + (version (git-version "2.6.2" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/parallaxsw/OpenSTA/") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5")))) + (build-system cmake-build-system) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "../source/test/regression"))))) + #:configure-flags + #~(list + (string-append "-DCUDD_DIR=" #$(this-package-input "cudd")) + (string-append "-DBUILD_SHARED_LIBS=YES")))) + (native-inputs (list bison flex swig)) + (inputs (list cudd eigen tcl tcllib zlib)) + (synopsis "Parallax Static Timing Analyzer") + (description + "OpenSTA is a gate level static timing verifier. As a stand-alone +executable it can be used to verify the timing of a design using standard file +formats.") + (home-page "https://github.com/parallaxsw/OpenSTA/") + (license license:gpl3+)))) + (define-public pulseview (package (name "pulseview") base-commit: edeafb19c4a83eb81fe7e47a6a94f238db9cccf1 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 26 15:28:02 2025 Received: (at 78011) by debbugs.gnu.org; 26 Apr 2025 19:28:02 +0000 Received: from localhost ([127.0.0.1]:35238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8lBx-0003Ok-No for submit@debbugs.gnu.org; Sat, 26 Apr 2025 15:28:02 -0400 Received: from latitanza.investici.org ([82.94.249.234]:24197) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8lBv-0003OL-HF for 78011@debbugs.gnu.org; Sat, 26 Apr 2025 15:28:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1745695678; bh=udT8w/CBEVeL4JHhnAZM5Rr6fClqW63FzSez6cqonmA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hPkhbv/TDAS3cjfOMbUF4bv7KvlFkELoc24OFtijbGBB9+nd3AGTxuGaqOEio4hvI 8O5sDPyENCCb8BDHehLdbMUYlGbaMJhL2plpO+wXgKsR4nRB51jNyPm+5raNjeZK9S Feu2EEnwMVPEDbWh1or1IcMhMJIv7CDZK2jEKWOw= Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4ZlKVk0MhxzGp3t; Sat, 26 Apr 2025 19:27:58 +0000 (UTC) Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: cayetano.santos@inventati.org) by localhost (Postfix) with ESMTPSA id 4ZlKVj4P5kzGnsp; Sat, 26 Apr 2025 19:27:57 +0000 (UTC) From: Cayetano Santos To: Maxim Cournoyer Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta. In-Reply-To: <871ptfdrdt.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Sat, 26 Apr 2025 21:44:14 +0900") References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> <2bf33bae3435d88a889a40e212102e9604af51ed.1745587470.git.csantosb@inventati.org> <871ptfdrdt.fsf_-_@gmail.com> User-Agent: mu4e 1.12.9; emacs 29.4 Date: Sat, 26 Apr 2025 21:27:56 +0200 Message-ID: <87ikmqoh8j.fsf@inventati.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 78011 Cc: 78011@debbugs.gnu.org, Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >sam. 26 avril 2025 at 21:44, Maxim Cournoyer wrote: > Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested > to reduce the output size, as suggested in my original review. Sorry about that ! For some reason, I completely missed your second reply: v3 sent, hopefully, including all suggestions. Thanks for your patience ! C. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaA0zvBccY3NhbnRvc2JA aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgofqAQCxCX0ZZamXw/fRQT077awRAwRK POwc0RqVi3ePZX7XhgEA7upQLwtiG/TLKTMKWLAsob3VBBFWTyXm9rKlGBhdmAw= =Om7z -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 26 20:10:39 2025 Received: (at 78011-done) by debbugs.gnu.org; 27 Apr 2025 00:10:39 +0000 Received: from localhost ([127.0.0.1]:36381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8pbT-0006JX-6H for submit@debbugs.gnu.org; Sat, 26 Apr 2025 20:10:39 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:50448) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u8pbP-0006JI-Eb for 78011-done@debbugs.gnu.org; Sat, 26 Apr 2025 20:10:37 -0400 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-308702998fbso2992576a91.1 for <78011-done@debbugs.gnu.org>; Sat, 26 Apr 2025 17:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745712629; x=1746317429; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WlNLrrF5xhc3dQSk0mPMh9UmZyPgGC67MKUFv9dexh8=; b=fdEb0hH6nAaSA7aJRI34oH6d/ZxRw8z+q8JvdwfqXMGV8Shn7R7asdW2cm7CTgJ5k3 ZlJ4YY61z+7XjpJLfI6D/CgUnmKe8O7fG7HVdY1ivSbh/i01oJnkqLhl3SGmmVhl4B1G 1ABTeIGDryowwg/wNkbgXmGBLXhZuC5hVQf+5eTsG6jW3/xg+Iq9vDh6Lz1cmbGTXa7Z yH7OvDgMW2zwp9Vlc86QiAhXLV5rNGPfzFBSls+sfas3SayLqHZv00oeVcSrVCVuGqR7 9WnZ9IIBfTBHwlX0IPq+WDtyTnc1sFCJssCO7q0iAjpLSAIy1UZnuGYaMkb4P4uajIw+ N3vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745712629; x=1746317429; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WlNLrrF5xhc3dQSk0mPMh9UmZyPgGC67MKUFv9dexh8=; b=obDsetlIHbbTyloiKke8BUzh4tUG/I8cJrpfDTu0SgrCSuiKWdoLHXgXTxE3HWuI2F ojuCuLG9h+WKd4neZTPNrlwfvaqtINcwXAcYGkssuIpfPn5Egsg99R+jdaLgB6GOZtsJ MtSqtcr46ovIwwjCcR9YAuaGmPFaO4N96+YltvPGUxodalRect/h4mHCkb/F1HACrZg3 dwkdBmWp9kS/72VDIXqfuVZLkJNE2fs/Svnenaq/vDwJhejSY6BeihXo63bk7M0drzCy N9rs2Tkr+vGbMj9GTgyA77ghi51y1d0Xtbc7VeVgupci8og3W6Y9ISDiXuEM8HvE8OLq WbDQ== X-Gm-Message-State: AOJu0Yy3/4LAb15hc1vK3RoW4UbvDIMMsT9MsL9UyKY1OCES0vOvcAD1 D69yeqD5MGBtzK/6v9U6rSeMSYSpduAAnoUwFstUVkLa41adAwnSqImpG0hU X-Gm-Gg: ASbGncuyqsYOfIib7HTlKPqz849l1/2bzHWb8vEHyCJuBXqkPQx+2ohaFetkdtSPAqd lp2wba8aNvgYCerMNOin28oZSdbhW12ihAhHi3WK6tk3SVA5epbXLx2/vxJXsy84nmyHTpA04HI XAov5rFzuBzMGs4TkzB6EvdAP/D2elWRh3XUeJf6Xb1IKzDXA9ddZVA/KLU4hT/2TbhKp5Y+C+2 x3HUT2Ti9OrwxUzasldial2/mScDwF8Q815woB1c1tWX5kA1XfbsTB2/s+drVfOyE8/PPXevVGl Ru8usSx8hTkMkpXcHFSrGMHe57+ji0h2d74BO0s= X-Google-Smtp-Source: AGHT+IFEq9gQsFYsrCeFQcQBkArTi/e11xnXIAoQhqcU8s2f3rUE84m/APUSIsWiobwq2cbGjQphlw== X-Received: by 2002:a17:90b:2dd2:b0:2fe:9581:fbea with SMTP id 98e67ed59e1d1-30a013bcc03mr5758280a91.29.1745712628964; Sat, 26 Apr 2025 17:10:28 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309f7763edbsm4185085a91.22.2025.04.26.17.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Apr 2025 17:10:28 -0700 (PDT) From: Maxim Cournoyer To: Cayetano Santos Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta. In-Reply-To: <87ikmqoh8j.fsf@inventati.org> (Cayetano Santos's message of "Sat, 26 Apr 2025 21:27:56 +0200") References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@inventati.org> <2bf33bae3435d88a889a40e212102e9604af51ed.1745587470.git.csantosb@inventati.org> <871ptfdrdt.fsf_-_@gmail.com> <87ikmqoh8j.fsf@inventati.org> Date: Sun, 27 Apr 2025 09:10:25 +0900 Message-ID: <87r01eea6m.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 78011-done Cc: 78011-done@debbugs.gnu.org, Ekaitz Zarraga X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello! Cayetano Santos writes: >>sam. 26 avril 2025 at 21:44, Maxim Cournoyer wrote: > >> Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested >> to reduce the output size, as suggested in my original review. > > Sorry about that ! For some reason, I completely missed your second > reply: v3 sent, hopefully, including all suggestions. > > Thanks for your patience ! No worries, I just applied your v3 as b8e2d556d9b. Thanks for your patience as well! -- Thanks, Maxim From unknown Sun Jun 15 08:54:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 May 2025 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator