GNU bug report logs - #78011
[PATCH electronics-team] gnu: Add opensta.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 78011 in the body.
You can then email your comments to 78011 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH electronics-team] gnu: Add opensta.
Date: Wed, 23 Apr 2025 15:14:20 +0200

* gnu/packages/electronics.scm (opensta): New variable.

Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7
---
 gnu/packages/electronics.scm | 41 ++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 12e44f234a..1b733a5a1f 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages c)
   #:use-module (gnu packages check)
@@ -45,6 +46,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
@@ -53,6 +55,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages libftdi)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages maths)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -65,6 +68,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages stb)
   #:use-module (gnu packages swig)
+  #:use-module (gnu packages tcl)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages toolkits)
   #:use-module (gnu packages version-control))
@@ -415,6 +419,43 @@ (define-public openboardview
 @end itemize")
     (license license:expat)))
 
+(define-public opensta
+  (let ((commit "400c473fe384773a4788ee8378238462b4291fe3")
+        (revision "0"))
+    (package
+      (name "opensta")
+      (version (git-version "2.6.2" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/parallaxsw/OpenSTA/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "091np9jnhfzggc7f5q9kx7kfa1fxjrj7d1mnw6q4gniqbs5hwrg5"))))
+      (build-system cmake-build-system)
+      (arguments
+       (list
+        #:tests? #f ; no tests
+        #:out-of-source? #t
+        #:configure-flags
+        #~(list
+           (string-append "-DCUDD_DIR=" #$cudd)
+           (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))
+        #:make-flags
+        #~(list (string-append "CC=" #$(cc-for-target))
+                (string-append "CXX=" #$(cxx-for-target))
+                (string-append "PREFIX=" #$output))))
+      (native-inputs (list swig bison flex))
+      (inputs (list tcl tcllib zlib cudd eigen))
+      (synopsis "Parallax Static Timing Analyzer")
+      (description
+       "OpenSTA is a gate level static timing verifier.  As a stand-alone executable
+it can be used to verify the timing of a design using standard file formats.")
+      (home-page "https://github.com/parallaxsw/OpenSTA/")
+      (license license:gpl3+))))
+
 (define-public pulseview
   (package
     (name "pulseview")

base-commit: 699ce22ed812cf8cfcdd8d0341829f8fac2c864a
-- 
2.49.0

Message #8 received at 78011 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta.
Date: Fri, 25 Apr 2025 11:58:51 +0900

Hi!

Cayetano Santos <csantosb <at> inventati.org> writes:

> * gnu/packages/electronics.scm (opensta): New variable.
>
> Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7
> ---

[...]

> +(define-public opensta

It's good to include a comment about why a precise commit is used,
e.g. "Use the latest commit as they included unreleased fixes."
> +  (let ((commit "400c473fe384773a4788ee8378238462b4291fe3")
> +        (revision "0"))
> +    (package
> +      (name "opensta")
> +      (version (git-version "2.6.2" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/parallaxsw/OpenSTA/")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "091np9jnhfzggc7f5q9kx7kfa1fxjrj7d1mnw6q4gniqbs5hwrg5"))))
> +      (build-system cmake-build-system)
> +      (arguments
> +       (list
> +        #:tests? #f ; no tests

There are tests; their Jenkinsfile runs them via the 'test/regression'
script.  You'll need to override the check phase as it's not registered
as a CMake test target.

> +        #:out-of-source? #t

No need to explicit this; it's the default for cmake-build-system.

> +        #:configure-flags
> +        #~(list
> +           (string-append "-DCUDD_DIR=" #$cudd)

It'd be better if this referred to the same cudd package that is
provided as an input (otherwise it cannot be rewritten via package
transformations).  You can refer to it within this gexp with

#$(this-package-input "cudd")

> +           (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))

No need for this, as it's also the default.

> +        #:make-flags
> +        #~(list (string-append "CC=" #$(cc-for-target))
> +                (string-append "CXX=" #$(cxx-for-target))
> +                (string-append "PREFIX=" #$output))))

I doubt these are needed; our cmake build system should know how to
cross-compile without this being manually set.

> +      (native-inputs (list swig bison flex))
> +      (inputs (list tcl tcllib zlib cudd eigen))
> +      (synopsis "Parallax Static Timing Analyzer")
> +      (description
> +       "OpenSTA is a gate level static timing verifier.  As a stand-alone executable

Please fold your paragraphs so they stay within < 80 columns, our coding
style guideline (M-q in Emacs).

> +it can be used to verify the timing of a design using standard file formats.")
> +      (home-page "https://github.com/parallaxsw/OpenSTA/")
> +      (license license:gpl3+))))

Otherwise it LGTM.  Could you please send a v2 with the above comments
taken into account?

-- 
Thanks,
Maxim

Message #11 received at 78011 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta.
Date: Fri, 25 Apr 2025 12:30:58 +0900

Hi,

Something like this:

--8<---------------cut here---------------start------------->8---
1 file changed, 11 insertions(+), 10 deletions(-)
gnu/packages/electronics.scm | 21 +++++++++++----------

modified   gnu/packages/electronics.scm
@@ -423,10 +423,12 @@ (define-public openboardview
     (license license:expat)))
 
 (define-public opensta
+  ;; There are no releases; use the latest commit.
   (let ((commit "400c473fe384773a4788ee8378238462b4291fe3")
         (revision "0"))
     (package
       (name "opensta")
+      ;; The version string is taken from the CMakeLists.txt.
       (version (git-version "2.6.2" revision commit))
       (source
        (origin
@@ -440,18 +442,17 @@ (define-public opensta
       (build-system cmake-build-system)
       (arguments
        (list
-        #:tests? #f ; no tests
-        #:out-of-source? #t
         #:configure-flags
         #~(list
-           (string-append "-DCUDD_DIR=" #$cudd)
-           (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))
-        #:make-flags
-        #~(list (string-append "CC=" #$(cc-for-target))
-                (string-append "CXX=" #$(cxx-for-target))
-                (string-append "PREFIX=" #$output))))
-      (native-inputs (list swig bison flex))
-      (inputs (list tcl tcllib zlib cudd eigen))
+           (string-append "-DCUDD_DIR=" #$(this-package-input "cudd"))
+           (string-append "-DBUILD_SHARED_LIBS=YES"))
+        #:phases #~(modify-phases %standard-phases
+                     (replace 'check
+                       (lambda* (#:key tests? #:allow-other-keys)
+                         (when tests?
+                           (invoke "../source/test/regression")))))))
+      (native-inputs (list bison flex swig))
+      (inputs (list cudd eigen tcl tcllib zlib))
       (synopsis "Parallax Static Timing Analyzer")
       (description
        "OpenSTA is a gate level static timing verifier.  As a stand-alone executable
--8<---------------cut here---------------end--------------->8---

I note that the package doesn't cross-build currently due to a problem
finding flex, but that's not the above definition's fault.

The BUILD_SHARED_LIBS=YES builds a .so library which cuts the space used
by half about.

The inputs are sorted lexicographically and some comments are added,
with the extraneous flags/arguments pruned.

Hope that helps,

-- 
Thanks,
Maxim

Message #14 received at 78011 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta.
Date: Fri, 25 Apr 2025 14:47:22 +0200

[Message part 1 (text/plain, inline)]

>ven. 25 avril 2025 at 11:58, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

Hi Maxim,

> Please fold your paragraphs so they stay within < 80 columns, our coding
> style guideline (M-q in Emacs).

The .editorconfig file in guix states "max_line_length = 85", which the
corresponding emacs package honors. Is this correct ?

C.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 78011 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78011 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v2] gnu: Add opensta.
Date: Fri, 25 Apr 2025 15:24:30 +0200

* gnu/packages/electronics.scm (opensta): New variable.

Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7

---
 gnu/packages/electronics.scm | 41 ++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 12e44f234a..63782661ee 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages c)
   #:use-module (gnu packages check)
@@ -45,6 +46,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
@@ -53,6 +55,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages libftdi)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages maths)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -65,6 +68,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages stb)
   #:use-module (gnu packages swig)
+  #:use-module (gnu packages tcl)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages toolkits)
   #:use-module (gnu packages version-control))
@@ -415,6 +419,43 @@ (define-public openboardview
 @end itemize")
     (license license:expat)))
 
+(define-public opensta
+  ;; There are no releases, we use last commit.
+  (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f")
+        (revision "0"))
+    (package
+      (name "opensta")
+      (version (git-version "2.6.2" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/parallaxsw/OpenSTA/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5"))))
+      (build-system cmake-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (replace 'check
+              (lambda* (#:key (tests? #t) #:allow-other-keys)
+                (when tests?
+                  (invoke "../source/test/regression")))))
+        #:configure-flags
+        #~(list
+           (string-append "-DCUDD_DIR=" #$(this-package-input "cudd")))))
+      (native-inputs (list swig bison flex))
+      (inputs (list tcl tcllib zlib cudd eigen))
+      (synopsis "Parallax Static Timing Analyzer")
+      (description
+       "OpenSTA is a gate level static timing verifier.  As a stand-alone executable
+it can be used to verify the timing of a design using standard file formats.")
+      (home-page "https://github.com/parallaxsw/OpenSTA/")
+      (license license:gpl3))))
+
 (define-public pulseview
   (package
     (name "pulseview")

base-commit: 501a9603f5e3cda07f3be8e7fecac31f7af5ce52
--
2.49.0

Message #20 received at 78011 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta.
Date: Sat, 26 Apr 2025 21:25:55 +0900

Hi,

Cayetano Santos <csantosb <at> inventati.org> writes:

>>ven. 25 avril 2025 at 11:58, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
> Hi Maxim,
>
>> Please fold your paragraphs so they stay within < 80 columns, our coding
>> style guideline (M-q in Emacs).
>
> The .editorconfig file in guix states "max_line_length = 85", which the
> corresponding emacs package honors. Is this correct ?

It was not.  It should be 80.  Fixed in commit e018fb6f61a.

-- 
Thanks,
Maxim

Message #23 received at 78011 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta.
Date: Sat, 26 Apr 2025 21:44:14 +0900

Hi,

Cayetano Santos <csantosb <at> inventati.org> writes:

[...]

> +(define-public opensta
> +  ;; There are no releases, we use last commit.
> +  (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f")
> +        (revision "0"))
> +    (package
> +      (name "opensta")
> +      (version (git-version "2.6.2" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/parallaxsw/OpenSTA/")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5"))))
> +      (build-system cmake-build-system)
> +      (arguments
> +       (list

Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested
to reduce the output size, as suggested in my original review.

> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (replace 'check
> +              (lambda* (#:key (tests? #t) #:allow-other-keys)

Please do not set default values for arguments to this anonymous
procedure; it just clutters the view (#:tests? is always passed by the
build system -- it is it which holds the default value).

> +                (when tests?
> +                  (invoke "../source/test/regression")))))
> +        #:configure-flags
> +        #~(list
> +           (string-append "-DCUDD_DIR=" #$(this-package-input "cudd")))))
> +      (native-inputs (list swig bison flex))
> +      (inputs (list tcl tcllib zlib cudd eigen))

It looks like you overlooked my suggestion to sort the
native-inputs/inputs.

> +      (synopsis "Parallax Static Timing Analyzer")
> +      (description
> +       "OpenSTA is a gate level static timing verifier.  As a stand-alone executable
> +it can be used to verify the timing of a design using standard file formats.")
> +      (home-page "https://github.com/parallaxsw/OpenSTA/")
> +      (license license:gpl3))))

Why the license change from gpl3+ to gpl3?  The former was correct.

Otherwise, LGTM.

Could you send a v3?

-- 
Thanks,
Maxim

Message #26 received at 78011 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 78011 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v3] gnu: Add opensta.
Date: Sat, 26 Apr 2025 21:25:23 +0200

* gnu/packages/electronics.scm (opensta): New variable.

Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7
---
 gnu/packages/electronics.scm | 44 ++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 12e44f234a..e32bad9c9d 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages c)
   #:use-module (gnu packages check)
@@ -45,6 +46,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
@@ -53,6 +55,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages libftdi)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages maths)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -65,6 +68,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages stb)
   #:use-module (gnu packages swig)
+  #:use-module (gnu packages tcl)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages toolkits)
   #:use-module (gnu packages version-control))
@@ -415,6 +419,46 @@ (define-public openboardview
 @end itemize")
     (license license:expat)))
 
+(define-public opensta
+  ;; There are no releases, we use last commit.
+  (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f")
+        (revision "0"))
+    (package
+      (name "opensta")
+      ;; The version string is taken from the CMakeLists.txt.
+      (version (git-version "2.6.2" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/parallaxsw/OpenSTA/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5"))))
+      (build-system cmake-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (replace 'check
+              (lambda* (#:key tests? #:allow-other-keys)
+                (when tests?
+                  (invoke "../source/test/regression")))))
+        #:configure-flags
+        #~(list
+           (string-append "-DCUDD_DIR=" #$(this-package-input "cudd"))
+           (string-append "-DBUILD_SHARED_LIBS=YES"))))
+      (native-inputs (list bison flex swig))
+      (inputs (list cudd eigen tcl tcllib zlib))
+      (synopsis "Parallax Static Timing Analyzer")
+      (description
+       "OpenSTA is a gate level static timing verifier.  As a stand-alone
+executable it can be used to verify the timing of a design using standard file
+formats.")
+      (home-page "https://github.com/parallaxsw/OpenSTA/")
+      (license license:gpl3+))))
+
 (define-public pulseview
   (package
     (name "pulseview")

base-commit: edeafb19c4a83eb81fe7e47a6a94f238db9cccf1
-- 
2.49.0

Message #29 received at 78011 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta.
Date: Sat, 26 Apr 2025 21:27:56 +0200

[Message part 1 (text/plain, inline)]

>sam. 26 avril 2025 at 21:44, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

> Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested
> to reduce the output size, as suggested in my original review.

Sorry about that ! For some reason, I completely missed your second
reply: v3 sent, hopefully, including all suggestions.

Thanks for your patience !

C.

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 78011-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 78011-done <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz <at> elenq.tech>
Subject: Re: bug#78011: [PATCH electronics-team] gnu: Add opensta.
Date: Sun, 27 Apr 2025 09:10:25 +0900

Hello!

Cayetano Santos <csantosb <at> inventati.org> writes:

>>sam. 26 avril 2025 at 21:44, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>> Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested
>> to reduce the output size, as suggested in my original review.
>
> Sorry about that ! For some reason, I completely missed your second
> reply: v3 sent, hopefully, including all suggestions.
>
> Thanks for your patience !

No worries, I just applied your v3 as b8e2d556d9b.  Thanks for your
patience as well!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.