From unknown Sun Jun 22 00:46:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#78008: [PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpolation expressions correctly Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Apr 2025 08:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 78008 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 78008@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174539745615649 (code B ref -1); Wed, 23 Apr 2025 08:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Apr 2025 08:37:36 +0000 Received: from localhost ([127.0.0.1]:52821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7Vbs-00044E-1Y for submit@debbugs.gnu.org; Wed, 23 Apr 2025 04:37:36 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38544) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7Vbo-000431-Sz for submit@debbugs.gnu.org; Wed, 23 Apr 2025 04:37:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7Vbj-0004Ka-3M for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2025 04:37:27 -0400 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7Vbg-0001Ts-1p for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2025 04:37:26 -0400 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id 030AE11402E8 for ; Wed, 23 Apr 2025 04:37:22 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Wed, 23 Apr 2025 04:37:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm1; t=1745397441; x=1745483841; bh=GH1ppSiiS5 vXoy+jjf4YBp+Pdvld6M3dEeNoIgN2OpY=; b=DM6KEV/yZu/uMS40nDRPCngiw0 y+NrJH+JSdKWOa8OmwxPugJJt06R8blhZGDutjbxS8LEuWUt2TlHwaVF3bTm0KC9 co5GMKI1CJCxyR6KLWANqLKMtd2vh5bDTnfaVAi6CQnCDMU6AbOsU2VxhJU9hl9f u1bcdJRboV6w7ETvzgpqvD9x1NexwzTAYz9+LxcUMabN5BpnAkv/AgKers1rCkUo E/d9G5MBvpafuY+SD3UXihlOkvGqIjrSBni9gY2VIBC7BoORBShOhxj2orEmND0Q 4F/0nm3HBnfmRLXymYcrj0Ew4rQ81aDo3cUe9JZJ9uzb1OCE3ziOslgl8m5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1745397441; x= 1745483841; bh=GH1ppSiiS5vXoy+jjf4YBp+Pdvld6M3dEeNoIgN2OpY=; b=V TzXDKGwU4oC4kiDaj7mfhLybvOGCi9B1vpCQOHacq8EKte+HWWavrqfSRwUgcF3L f1cCFR5xIWOUEi9wKPdAwX4HY2+OsQrWHOWLj86WS4IzJcoPMg3+Q/mGnaq/NEpx 8qDuMalzLm/SyyEeLvgtKdXk5g+FaXumO+Upm4Eln4KUkHzen48x31WerpWq+16E IxkQo8H7ykDEZRER71OcWLtRw+1DHjMhO97B/ylC2kqVlwzOcF0XIHVf0fnSaCl5 OGzKo1R32BuTL5v055XINbCzw7N9/wvuAw9WXBq//xJJUp4sX4A94/Q8bK55bjDr N295APVcsXqKuLfzNy5vw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeeiudegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhtg gguffkfffvofesrgdtmherhhdtjeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhg shgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqne cuggftrfgrthhtvghrnhepffdtieegteeggffhkefgtdelffdufffgffefvdefffeghedu vdejvdfhvdffveeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhn sggprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqd hgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 23 Apr 2025 04:37:21 -0400 (EDT) From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Content-Type: multipart/alternative; boundary="Apple-Mail=_80ACE8A3-85DE-4F28-8143-7A125BD96746" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Message-Id: <8251D941-32CB-42DE-A016-50567CB9441A@secure.kjonigsen.net> Date: Wed, 23 Apr 2025 10:37:09 +0200 X-Mailer: Apple Mail (2.3826.400.131.1.6) Received-SPF: pass client-ip=103.168.172.155; envelope-from=jostein@secure.kjonigsen.net; helo=fhigh-a4-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --Apple-Mail=_80ACE8A3-85DE-4F28-8143-7A125BD96746 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hey everyone! Using csharp-ts-mode, string-interpolation expressions correctly. = Basically the entire string-interpolation expression is fontified as a = continuous string. This seems to be caused be a few selectors which are too wide, capturing = non-string content, and a mix of missing selectors as well. Attached is a patch which fixes this. =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen =EF=BF=BC= --Apple-Mail=_80ACE8A3-85DE-4F28-8143-7A125BD96746 Content-Type: multipart/mixed; boundary="Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87" --Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Hey = everyone!

Using csharp-ts-mode, = string-interpolation expressions correctly. Basically the entire = string-interpolation expression is fontified as a continuous = string.

This seems to be caused be a few = selectors which are too wide, capturing non-string content, and a mix of = missing selectors as well.

Attached is a patch = which fixes this.

=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen

= --Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87 Content-Disposition: attachment; filename=0001-csharp-mode.el-Improve-fontification-of-string-inter.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-csharp-mode.el-Improve-fontification-of-string-inter.patch" Content-Transfer-Encoding: quoted-printable =46rom=204ef0f17d4d65fd5d61cdc09847b5c1e9fd5ed842=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Jostein=3D20Kj=3DC3=3DB8nigsen?=3D=20= =0ADate:=20Wed,=2023=20Apr=202025=2010:32:30=20= +0200=0ASubject:=20[PATCH]=20csharp-mode.el:=20Improve=20fontification=20= of=20string-interpolation=0A=20exprs=0A=0A= csharp-ts-mode--font-lock-settings:=20remove=20too=20wide=20selector.=0A= causing=20non-string=20content=20to=20be=20fonitified=20as=20strings.=0A=0A= Add=20additional=20eselectors=20to=20highlight=20variables=20inside=0A= interpolation-expressions=20too.=0A---=0A=20= lisp/progmodes/csharp-mode.el=20|=2015=20+++++++++++----=0A=201=20file=20= changed,=2011=20insertions(+),=204=20deletions(-)=0A=0Adiff=20--git=20= a/lisp/progmodes/csharp-mode.el=20b/lisp/progmodes/csharp-mode.el=0A= index=205e9b8d680eb..479d951157c=20100644=0A---=20= a/lisp/progmodes/csharp-mode.el=0A+++=20b/lisp/progmodes/csharp-mode.el=0A= @@=20-790,11=20+790,19=20@@=20csharp-ts-mode--font-lock-settings=0A=20=20= =20=20:feature=20'expression=0A=20=20=20=20'((conditional_expression=20= (identifier)=20@font-lock-variable-use-face)=0A=20=20=20=20=20=20= (postfix_unary_expression=20(identifier)*=20= @font-lock-variable-use-face)=0A-=20=20=20=20=20(initializer_expression=20= (assignment_expression=20left:=20(identifier)=20= @font-lock-variable-use-face)))=0A+=20=20=20=20=20= (initializer_expression=20(assignment_expression=20left:=20(identifier)=20= @font-lock-variable-use-face))=0A+=20=20=20=20=20= (interpolated_string_expression=0A+=20=20=20=20=20=20(interpolation=0A+=20= =20=20=20=20=20=20(identifier)=20@font-lock-variable-use-face))=0A+=20=20= =20=20=20(interpolated_string_expression=0A+=20=20=20=20=20=20= (interpolation=0A+=20=20=20=20=20=20=20(member_access_expression=0A+=20=20= =20=20=20=20=20=20expression:=20(identifier)=20= @font-lock-variable-use-face=0A+=20=20=20=20=20=20=20=20name:=20= (identifier)=20@font-lock-property-use-face))))=0A=20=0A=20=20=20=20= :language=20'c-sharp=0A=20=20=20=20:feature=20'bracket=0A-=20=20=20= '((["("=20")"=20"["=20"]"=20"{"=20"}"])=20@font-lock-bracket-face)=0A+=20= =20=20'((["("=20")"=20"["=20"]"=20"{"=20"}"=20(interpolation_brace)])=20= @font-lock-bracket-face)=0A=20=0A=20=20=20=20:language=20'c-sharp=0A=20=20= =20=20:feature=20'delimiter=0A@@=20-852,8=20+860,7=20@@=20= csharp-ts-mode--font-lock-settings=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20"$\""=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"@$\""=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20"$@\"")=0A-=20=20=20=20=20=20=20= =20=20=20'((interpolated_string_expression)=0A-=20=20=20=20=20=20=20=20=20= =20=20=20(interpolation_start)=0A+=20=20=20=20=20=20=20=20=20=20= '((interpolation_start)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= (interpolation_quote)))]=0A=20=20=20=20=20=20@font-lock-string-face)=0A=20= =0A--=20=0A2.49.0=0A=0A= --Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii --Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87-- --Apple-Mail=_80ACE8A3-85DE-4F28-8143-7A125BD96746-- From unknown Sun Jun 22 00:46:20 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Subject: bug#78008: closed (Re: bug#78008: [PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpolation expressions correctly) Message-ID: References: <86h62bt5nl.fsf@gnu.org> <8251D941-32CB-42DE-A016-50567CB9441A@secure.kjonigsen.net> X-Gnu-PR-Message: they-closed 78008 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 78008@debbugs.gnu.org Date: Sat, 26 Apr 2025 13:28:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1745674083-3389-1" This is a multi-part message in MIME format... ------------=_1745674083-3389-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #78008: [PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpola= tion expressions correctly which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 78008@debbugs.gnu.org. --=20 78008: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78008 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1745674083-3389-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 78008-done) by debbugs.gnu.org; 26 Apr 2025 13:27:07 +0000 Received: from localhost ([127.0.0.1]:59488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8fYf-0000ow-Vr for submit@debbugs.gnu.org; Sat, 26 Apr 2025 09:27:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35632) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8fYc-0000oS-Vh for 78008-done@debbugs.gnu.org; Sat, 26 Apr 2025 09:27:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8fYX-0004lw-4F; Sat, 26 Apr 2025 09:26:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=uaCrUE4uiTrC5IhEIiJM2RN2TIsg3VnrJYJi7xm7RMw=; b=S4YTD1Z1xZn2SL2KDKoL eIYaeTyDgf1j9QoQwv19XfRrlb8W84W9XhECgwEiSemUoljsz6+xmjCD9J7t0AyjIfQfkjsfBTiZJ DhgcYjKaekAafDXt95j0J8Ey6BGEBHRCo46KPI279FxMkcpVBPveLFbs+u3maQnwV37tOcosD12Es S2P3g1FNt8oDbUMf1K1V9RIyZ96oTSZqtJEYRLEmmVCxrOUQDAkvUT8I1y8K+Kca65GSEZFgi8zQU rX+swR7B8OkUnQjKYjcB9WWz5CjESV7UlCcz5hDleDtUXmPec3W6nMQGFddLHJmbViuq7Qa4rr10l k8Clx3/jjHQ67A==; Date: Sat, 26 Apr 2025 16:26:54 +0300 Message-Id: <86h62bt5nl.fsf@gnu.org> From: Eli Zaretskii To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <8251D941-32CB-42DE-A016-50567CB9441A@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Wed, 23 Apr 2025 10:37:09 +0200) Subject: Re: bug#78008: [PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpolation expressions correctly References: <8251D941-32CB-42DE-A016-50567CB9441A@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 78008-done Cc: 78008-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jostein Kjønigsen > Date: Wed, 23 Apr 2025 10:37:09 +0200 > > Using csharp-ts-mode, string-interpolation expressions correctly. Basically the entire string-interpolation expression is fontified as a continuous string. > > This seems to be caused be a few selectors which are too wide, capturing non-string content, and a mix of missing selectors as well. > > Attached is a patch which fixes this. Thanks, now installed on the master branch, and closing the bug. ------------=_1745674083-3389-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Apr 2025 08:37:36 +0000 Received: from localhost ([127.0.0.1]:52821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7Vbs-00044E-1Y for submit@debbugs.gnu.org; Wed, 23 Apr 2025 04:37:36 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38544) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7Vbo-000431-Sz for submit@debbugs.gnu.org; Wed, 23 Apr 2025 04:37:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7Vbj-0004Ka-3M for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2025 04:37:27 -0400 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7Vbg-0001Ts-1p for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2025 04:37:26 -0400 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id 030AE11402E8 for ; Wed, 23 Apr 2025 04:37:22 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Wed, 23 Apr 2025 04:37:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm1; t=1745397441; x=1745483841; bh=GH1ppSiiS5 vXoy+jjf4YBp+Pdvld6M3dEeNoIgN2OpY=; b=DM6KEV/yZu/uMS40nDRPCngiw0 y+NrJH+JSdKWOa8OmwxPugJJt06R8blhZGDutjbxS8LEuWUt2TlHwaVF3bTm0KC9 co5GMKI1CJCxyR6KLWANqLKMtd2vh5bDTnfaVAi6CQnCDMU6AbOsU2VxhJU9hl9f u1bcdJRboV6w7ETvzgpqvD9x1NexwzTAYz9+LxcUMabN5BpnAkv/AgKers1rCkUo E/d9G5MBvpafuY+SD3UXihlOkvGqIjrSBni9gY2VIBC7BoORBShOhxj2orEmND0Q 4F/0nm3HBnfmRLXymYcrj0Ew4rQ81aDo3cUe9JZJ9uzb1OCE3ziOslgl8m5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1745397441; x= 1745483841; bh=GH1ppSiiS5vXoy+jjf4YBp+Pdvld6M3dEeNoIgN2OpY=; b=V TzXDKGwU4oC4kiDaj7mfhLybvOGCi9B1vpCQOHacq8EKte+HWWavrqfSRwUgcF3L f1cCFR5xIWOUEi9wKPdAwX4HY2+OsQrWHOWLj86WS4IzJcoPMg3+Q/mGnaq/NEpx 8qDuMalzLm/SyyEeLvgtKdXk5g+FaXumO+Upm4Eln4KUkHzen48x31WerpWq+16E IxkQo8H7ykDEZRER71OcWLtRw+1DHjMhO97B/ylC2kqVlwzOcF0XIHVf0fnSaCl5 OGzKo1R32BuTL5v055XINbCzw7N9/wvuAw9WXBq//xJJUp4sX4A94/Q8bK55bjDr N295APVcsXqKuLfzNy5vw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeeiudegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhtg gguffkfffvofesrgdtmherhhdtjeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhg shgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqne cuggftrfgrthhtvghrnhepffdtieegteeggffhkefgtdelffdufffgffefvdefffeghedu vdejvdfhvdffveeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhn sggprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqd hgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 23 Apr 2025 04:37:21 -0400 (EDT) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Content-Type: multipart/alternative; boundary="Apple-Mail=_80ACE8A3-85DE-4F28-8143-7A125BD96746" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: [PATCH] 31.0.50; csharp-ts-mode does not highlight string-interpolation expressions correctly Message-Id: <8251D941-32CB-42DE-A016-50567CB9441A@secure.kjonigsen.net> Date: Wed, 23 Apr 2025 10:37:09 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3826.400.131.1.6) Received-SPF: pass client-ip=103.168.172.155; envelope-from=jostein@secure.kjonigsen.net; helo=fhigh-a4-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --Apple-Mail=_80ACE8A3-85DE-4F28-8143-7A125BD96746 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hey everyone! Using csharp-ts-mode, string-interpolation expressions correctly. = Basically the entire string-interpolation expression is fontified as a = continuous string. This seems to be caused be a few selectors which are too wide, capturing = non-string content, and a mix of missing selectors as well. Attached is a patch which fixes this. =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen =EF=BF=BC= --Apple-Mail=_80ACE8A3-85DE-4F28-8143-7A125BD96746 Content-Type: multipart/mixed; boundary="Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87" --Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Hey = everyone!

Using csharp-ts-mode, = string-interpolation expressions correctly. Basically the entire = string-interpolation expression is fontified as a continuous = string.

This seems to be caused be a few = selectors which are too wide, capturing non-string content, and a mix of = missing selectors as well.

Attached is a patch = which fixes this.

=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen

= --Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87 Content-Disposition: attachment; filename=0001-csharp-mode.el-Improve-fontification-of-string-inter.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-csharp-mode.el-Improve-fontification-of-string-inter.patch" Content-Transfer-Encoding: quoted-printable =46rom=204ef0f17d4d65fd5d61cdc09847b5c1e9fd5ed842=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Jostein=3D20Kj=3DC3=3DB8nigsen?=3D=20= =0ADate:=20Wed,=2023=20Apr=202025=2010:32:30=20= +0200=0ASubject:=20[PATCH]=20csharp-mode.el:=20Improve=20fontification=20= of=20string-interpolation=0A=20exprs=0A=0A= csharp-ts-mode--font-lock-settings:=20remove=20too=20wide=20selector.=0A= causing=20non-string=20content=20to=20be=20fonitified=20as=20strings.=0A=0A= Add=20additional=20eselectors=20to=20highlight=20variables=20inside=0A= interpolation-expressions=20too.=0A---=0A=20= lisp/progmodes/csharp-mode.el=20|=2015=20+++++++++++----=0A=201=20file=20= changed,=2011=20insertions(+),=204=20deletions(-)=0A=0Adiff=20--git=20= a/lisp/progmodes/csharp-mode.el=20b/lisp/progmodes/csharp-mode.el=0A= index=205e9b8d680eb..479d951157c=20100644=0A---=20= a/lisp/progmodes/csharp-mode.el=0A+++=20b/lisp/progmodes/csharp-mode.el=0A= @@=20-790,11=20+790,19=20@@=20csharp-ts-mode--font-lock-settings=0A=20=20= =20=20:feature=20'expression=0A=20=20=20=20'((conditional_expression=20= (identifier)=20@font-lock-variable-use-face)=0A=20=20=20=20=20=20= (postfix_unary_expression=20(identifier)*=20= @font-lock-variable-use-face)=0A-=20=20=20=20=20(initializer_expression=20= (assignment_expression=20left:=20(identifier)=20= @font-lock-variable-use-face)))=0A+=20=20=20=20=20= (initializer_expression=20(assignment_expression=20left:=20(identifier)=20= @font-lock-variable-use-face))=0A+=20=20=20=20=20= (interpolated_string_expression=0A+=20=20=20=20=20=20(interpolation=0A+=20= =20=20=20=20=20=20(identifier)=20@font-lock-variable-use-face))=0A+=20=20= =20=20=20(interpolated_string_expression=0A+=20=20=20=20=20=20= (interpolation=0A+=20=20=20=20=20=20=20(member_access_expression=0A+=20=20= =20=20=20=20=20=20expression:=20(identifier)=20= @font-lock-variable-use-face=0A+=20=20=20=20=20=20=20=20name:=20= (identifier)=20@font-lock-property-use-face))))=0A=20=0A=20=20=20=20= :language=20'c-sharp=0A=20=20=20=20:feature=20'bracket=0A-=20=20=20= '((["("=20")"=20"["=20"]"=20"{"=20"}"])=20@font-lock-bracket-face)=0A+=20= =20=20'((["("=20")"=20"["=20"]"=20"{"=20"}"=20(interpolation_brace)])=20= @font-lock-bracket-face)=0A=20=0A=20=20=20=20:language=20'c-sharp=0A=20=20= =20=20:feature=20'delimiter=0A@@=20-852,8=20+860,7=20@@=20= csharp-ts-mode--font-lock-settings=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20"$\""=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"@$\""=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20"$@\"")=0A-=20=20=20=20=20=20=20= =20=20=20'((interpolated_string_expression)=0A-=20=20=20=20=20=20=20=20=20= =20=20=20(interpolation_start)=0A+=20=20=20=20=20=20=20=20=20=20= '((interpolation_start)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= (interpolation_quote)))]=0A=20=20=20=20=20=20@font-lock-string-face)=0A=20= =0A--=20=0A2.49.0=0A=0A= --Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii --Apple-Mail=_88F8EDDE-99AA-41DD-9DBE-970EF29BDA87-- --Apple-Mail=_80ACE8A3-85DE-4F28-8143-7A125BD96746-- ------------=_1745674083-3389-1--