GNU bug report logs - #77990
[PATCH] gnu: Add emacs-ffi.

Previous Next

Full log

View this message in rfc822 format

From: Suhail Singh <suhailsingh247 <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Ian Eure <ian <at> retrospec.tv>, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, Liliana Marie Prikler <liliana.prikler <at> gmail.com>, Andrew Tropin <andrew <at> trop.in>, Hilton Chain <hako <at> ultrarare.space>, 77990 <at> debbugs.gnu.org, Divya Ranjan Pattanaik <divya <at> subvertising.org>, Suhail Singh <suhailsingh247 <at> gmail.com>
Subject: [bug#77990] [PATCH v2] gnu: Add emacs-ffi.
Date: Tue, 22 Apr 2025 22:32:28 -0400

Cayetano Santos <csantosb <at> inventati.org> writes:

>> +              ;; Install the shared object file into /lib.
>> +              (install-file "build/lib/ffi-module.so"
>> +                            (string-append #$output "/lib"))))
>
> I have a doubt about where do we  put .so files.
>
> - lib
> - lib/package
> - lib/emacs (see emacs-jinx)
>
> Other than this, LFTM.

IIUC the standard place for shared libraries is in #$output/lib.  I
don't know of any reason to deviate from that in this case.  To the
extent it matters, at least one other dynamic module (emacs-sqlite3-api)
also uses that convention.

I'm no authority, but it seems that Emacs dynamic modules are simply
less consistent about storing libraries in the standard location, rather
than there being a principled reason against using the standard
convention.

Thanks for the review.

-- 
Suhail

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.