GNU bug report logs - #77982
[PATCH] gnu: profanity: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77982 in the body.
You can then email your comments to 77982 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: guix-patches <at> gnu.org
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [PATCH] gnu: profanity: Fix build.
Date: Tue, 22 Apr 2025 10:26:19 +0200

* gnu/packages/messaging.scm (profanity)[arguments]: Remove a phase
deprecated by the upgrade to Python 3.11.

Change-Id: Iac74fb082fbdcea36c9eef0d2918f85fad1fee8a
---
 gnu/packages/messaging.scm | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 57c6976193..5c48c5ff73 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2283,14 +2283,7 @@ (define-public profanity
            "--enable-otr"
            "--enable-pgp"
            "--enable-omemo"
-           "--enable-icons-and-clipboard")
-       #:phases
-       #~(modify-phases %standard-phases
-           (add-after 'unpack 'patch-python-plugins
-             (lambda _
-               ;; Py_XDECREF is a macro in Python 3.10
-               (substitute* "src/plugins/python_plugins.c"
-                 (("Py_XDECREF") "_Py_XDECREF")))))))
+           "--enable-icons-and-clipboard")))
     (native-inputs
      (list autoconf
            autoconf-archive

base-commit: c6ee7b0f79632d50ad491b75c240547be8f40c31
-- 
2.49.0

Message #8 received at 77982 <at> debbugs.gnu.org (full text, mbox):

From: "Ashish SHUKLA" <ashish.is <at> lostca.se>
To: <77982 <at> debbugs.gnu.org>
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: Re: [PATCH] gnu: profanity: Fix build.
Date: Tue, 22 Apr 2025 10:38:57 +0000

[Message part 1 (text/plain, inline)]

> * gnu/packages/messaging.scm (profanity)[arguments]: Remove a phase
> deprecated by the upgrade to Python 3.11.
> 
> Change-Id: Iac74fb082fbdcea36c9eef0d2918f85fad1fee8a
> ---
>  gnu/packages/messaging.scm | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 57c6976193..5c48c5ff73 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -2283,14 +2283,7 @@ (define-public profanity
>             "--enable-otr"
>             "--enable-pgp"
>             "--enable-omemo"
> -           "--enable-icons-and-clipboard")
> -       #:phases
> -       #~(modify-phases %standard-phases
> -           (add-after 'unpack 'patch-python-plugins
> -             (lambda _
> -               ;; Py_XDECREF is a macro in Python 3.10
> -               (substitute* "src/plugins/python_plugins.c"
> -                 (("Py_XDECREF") "_Py_XDECREF")))))))
> +           "--enable-icons-and-clipboard")))
>      (native-inputs
>       (list autoconf
>             autoconf-archive
> 
> base-commit: c6ee7b0f79632d50ad491b75c240547be8f40c31
> -- 
> 2.49.0

Thanks, this patch builds fine here. Much appreciated.

-- 
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 77982 <at> debbugs.gnu.org (full text, mbox):

From: Frank Pursel <frank.pursel <at> gmail.com>
To: 77982 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: profanity: Fix build.
Date: Tue, 22 Apr 2025 08:48:15 -0700

The patch also builds for me.

Thanks,
Frank

Message #14 received at 77982 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Tanguy Le Carrour <tanguy <at> bioneland.org>
Cc: 77982 <at> debbugs.gnu.org
Subject: Re: [bug#77982] [PATCH] gnu: profanity: Fix build.
Date: Thu, 24 Apr 2025 17:13:37 -0700

Hi Tanguy,

Pushed as c10daeaec3.

Thank you for the fix!

 -- Ian

Message #19 received at 77982 <at> debbugs.gnu.org (full text, mbox):

From: "Tanguy Le Carrour" <tanguy <at> bioneland.org>
To: "Ian Eure" <ian <at> retrospec.tv>
Cc: 77982 <at> debbugs.gnu.org
Subject: Re: [bug#77982] [PATCH] gnu: profanity: Fix build.
Date: Fri, 25 Apr 2025 08:14:56 +0200

Hi Ian,


On Fri Apr 25, 2025 at 2:13 AM CEST, Ian Eure wrote:
> Pushed as c10daeaec3.
>
> Thank you for the fix!

Thanks!

-- 
Tanguy

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.