From unknown Sat Jun 14 05:10:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77971: [PATCH] client: Support opening a particular issue in the web browser. Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: bug-mumi@gnu.org Resent-Date: Mon, 21 Apr 2025 19:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77971 X-GNU-PR-Package: mumi X-GNU-PR-Keywords: patch To: 77971@debbugs.gnu.org Cc: jgart X-Debbugs-Original-To: bug-mumi@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174526268927829 (code B ref -1); Mon, 21 Apr 2025 19:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Apr 2025 19:11:29 +0000 Received: from localhost ([127.0.0.1]:38819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6wYC-0007Em-JA for submit@debbugs.gnu.org; Mon, 21 Apr 2025 15:11:29 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58422) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6wYA-0007EU-3c for submit@debbugs.gnu.org; Mon, 21 Apr 2025 15:11:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6wY2-000816-0D for bug-mumi@gnu.org; Mon, 21 Apr 2025 15:11:18 -0400 Received: from mx2.dismail.de ([159.69.191.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6wXz-00015o-HK for bug-mumi@gnu.org; Mon, 21 Apr 2025 15:11:17 -0400 Received: from mx2.dismail.de (localhost [127.0.0.1]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 8f89f4cb for ; Mon, 21 Apr 2025 21:11:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=PSxHdYvwXXyhmQrw9lLj5v8LVWPfOPg9lRw9PJVScME=; b= B/09tpiT+H49vwUmDEPa1tz1uuwNSPCDpLEV+9oZfe1exM4IVVB6lGjm6rKrMRLp ffL6A/62Z24j0BQajF2woF97QjlAZLmLl48cCsQUu2r6qF7IayLdDtvUWzrQVgmF rsBRpN+ptik+kPKCiXCr5Q67gpQ/zIr/hx2c0IlKmOupl9/0z4rt0ZFTNDSwimdv PIGJQ6nI0JOUe/Xkw0akuDGdSRFoBtzw93yb6EyqCR0dpwAVTzh8ia7g6/fo3uNX AreMAYLVx/7BrTxIK87QXPzurYGvN+9t2JJ4CaJDDsRH6JnmMRiDFoA72tyx6DtL O1s8RuHg2fw5G5QGN+04ug== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 90ac52c4 for ; Mon, 21 Apr 2025 21:11:12 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 5f4dea87 for ; Mon, 21 Apr 2025 21:11:12 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id ad04c512 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 21 Apr 2025 21:11:11 +0200 (CEST) From: jgart Date: Mon, 21 Apr 2025 14:10:46 -0500 Message-ID: <20250421191103.88036-1-jgart@dismail.de> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=159.69.191.136; envelope-from=jgart@dismail.de; helo=mx2.dismail.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * mumi/client.scm (www): Add support for passing in an issue number. * scripts/mumi.in (show-mumi-usage): Update CLI documentation to reflect above change. * scripts/mumi.in: Update top-level match to include the case where an issue-number is passed in. --- mumi/client.scm | 10 ++++++---- scripts/mumi.in | 6 ++++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/mumi/client.scm b/mumi/client.scm index 1116c56..8fe5f4d 100644 --- a/mumi/client.scm +++ b/mumi/client.scm @@ -302,13 +302,15 @@ if it exits non-locally. Return the value returned by PROC." (unless (zero? (apply system* args)) (error "Command invocation failed" args))) -(define (www) - "Open current issue in a web browser." - (let ((issue-number (current-issue-number))) +(define* (www #:optional (issue-number (current-issue-number))) + "Open current issue number or given ISSUE-NUMBER in a web browser." + (let ((issue-number (if (string? issue-number) + issue-number + (number->string issue-number)))) (if issue-number (invoke (%config 'xdg-open) (uri->string - (build-mumi-uri (string-append "/" (number->string issue-number))))) + (build-mumi-uri (string-append "/" issue-number)))) (begin (format (current-error-port) "No current issue!~%") (exit #f))))) diff --git a/scripts/mumi.in b/scripts/mumi.in index 960fb9b..749fdfc 100644 --- a/scripts/mumi.in +++ b/scripts/mumi.in @@ -151,8 +151,8 @@ `mumi new': clear current issue presumably to open a new one. - `mumi www': - open current issue in a web browser. + `mumi www [ISSUE-NUMBER]': + open given issue or current issue in a web browser. `mumi compose [--close|--done]': compose email to debbugs. @@ -221,6 +221,8 @@ elements after the DELIMITER." (client:git-send-email-headers patch)) (("www") (client:www)) + (("www" issue-number) + (client:www issue-number)) (("compose" . args) (let ((args (args-fold args (list (option '("close") #f #f -- 2.49.0