GNU bug report logs - #77946
master d283db57733: Fix window selection after log-edit-show-diff, again

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> linkov.net>
Subject: bug#77946: closed (Re: bug#77946: master d283db57733: Fix window
 selection after log-edit-show-diff, again)
Date: Tue, 29 Apr 2025 02:05:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#77946: master d283db57733: Fix window selection after log-edit-show-diff, again

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 77946 <at> debbugs.gnu.org.

-- 
77946: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77946
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Juri Linkov <juri <at> linkov.net>, 77946-done <at> debbugs.gnu.org
Subject: Re: bug#77946: master d283db57733: Fix window selection after
 log-edit-show-diff, again
Date: Tue, 29 Apr 2025 10:03:50 +0800

Version: 31.1

Hello,

This should be fixed now.  Thanks again for the discussion.

-- 
Sean Whitton

[Message part 3 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: master d283db57733: Fix window selection after log-edit-show-diff,
 again
Date: Sun, 20 Apr 2025 20:53:00 +0300

> diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el
> index 0da0b90975c..3c3288777c8 100644
> --- a/lisp/vc/log-edit.el
> +++ b/lisp/vc/log-edit.el
> @@ -857,7 +857,8 @@ vc-log-fileset
>  (defun log-edit-diff-fileset ()
>    "Display diffs for the files to be committed."
>    (interactive)
> -  (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset)))
> +  (save-selected-window
> +    (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset))))

This change broke the command 'log-edit-show-diff' ('C-c C-d').
Previously it selected the diff window.  Now it always stays in the vc-log window.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.