Subject: bug#77946: closed (Re: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 29 Apr 2025 02:05:02 +0000

Your bug report

#77946: master d283db57733: Fix window selection after log-edit-show-diff, again

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
77946: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77946
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again
From: Sean Whitton <[email-masked]>
To: Juri Linkov <[email-masked]>, [email-masked]
Date: Tue, 29 Apr 2025 10:03:50 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 31.1

Hello,

This should be fixed now.  Thanks again for the discussion.

-- 
Sean Whitton

Subject: master d283db57733: Fix window selection after log-edit-show-diff, again
From: Juri Linkov <[email-masked]>
To: [email-masked]
Date: Sun, 20 Apr 2025 20:53:00 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el
> index 0da0b90975c..3c3288777c8 100644
> --- a/lisp/vc/log-edit.el
> +++ b/lisp/vc/log-edit.el
> @@ -857,7 +857,8 @@ vc-log-fileset
>  (defun log-edit-diff-fileset ()
>    "Display diffs for the files to be committed."
>    (interactive)
> -  (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset)))
> +  (save-selected-window
> +    (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset))))

This change broke the command 'log-edit-show-diff' ('C-c C-d').
Previously it selected the diff window.  Now it always stays in the vc-log window.