From unknown Thu Aug 14 22:20:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: spwhitton@spwhitton.name, bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Apr 2025 17:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 77946@debbugs.gnu.org Cc: Sean Whitton X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Sean Whitton Received: via spool by submit@debbugs.gnu.org id=B.17451717155230 (code B ref -1); Sun, 20 Apr 2025 17:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Apr 2025 17:55:15 +0000 Received: from localhost ([127.0.0.1]:52746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6Yss-0001LN-5A for submit@debbugs.gnu.org; Sun, 20 Apr 2025 13:55:14 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38274) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6Yrv-0001AE-6I for submit@debbugs.gnu.org; Sun, 20 Apr 2025 13:54:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6Yro-0007G2-Bd for bug-gnu-emacs@gnu.org; Sun, 20 Apr 2025 13:54:09 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6Yrl-0002jY-Jk for bug-gnu-emacs@gnu.org; Sun, 20 Apr 2025 13:54:08 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 9DF7E41BC0 for ; Sun, 20 Apr 2025 17:54:01 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET Date: Sun, 20 Apr 2025 20:53:00 +0300 Message-ID: <87bjsq90ub.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: 0 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvfeekheekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvufhofffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeejgffgtddthfelteejkeejueegvdekgfdufffgtdehvddtkeetveehgfffjeeuteenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepuddprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::226; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) > diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el > index 0da0b90975c..3c3288777c8 100644 > --- a/lisp/vc/log-edit.el > +++ b/lisp/vc/log-edit.el > @@ -857,7 +857,8 @@ vc-log-fileset > (defun log-edit-diff-fileset () > "Display diffs for the files to be committed." > (interactive) > - (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset))) > + (save-selected-window > + (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset)))) This change broke the command 'log-edit-show-diff' ('C-c C-d'). Previously it selected the diff window. Now it always stays in the vc-log window. From unknown Thu Aug 14 22:20:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Apr 2025 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 77946@debbugs.gnu.org, spwhitton@spwhitton.name Received: via spool by 77946-submit@debbugs.gnu.org id=B77946.174517699232386 (code B ref 77946); Sun, 20 Apr 2025 19:24:02 +0000 Received: (at 77946) by debbugs.gnu.org; 20 Apr 2025 19:23:12 +0000 Received: from localhost ([127.0.0.1]:53800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6aG0-0008QH-Ei for submit@debbugs.gnu.org; Sun, 20 Apr 2025 15:23:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48118) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6aFw-0008Pl-Oi for 77946@debbugs.gnu.org; Sun, 20 Apr 2025 15:23:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6aFq-0007SY-K1; Sun, 20 Apr 2025 15:23:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YmzvKH6qKDVVfWYLJMUz0NmaHZaYFRKyMR79TLhy5VM=; b=i6N6iSA12q2Y MwJQaBtd9t2zmmQDF06LvLOyeoQHTf0WIcB8Yde4mEnPqH4fA/DVZLd1xywryk5VNwt5ZWZrmvHS4 nnf1PilzyYkHkYTXnIjL/LXn4zcGvLHIyYOBIq6FsOJ0stygDer+o9uMZXhF+tv/u0w/Le4lWy7NM irvdwxbymWhZ+OKWYoxNR0qUH4Qz8sEbkP2bl8gn1c0Tu4MsU3nUQDlu+7DbAv69Pdtw2w7He5m3u y1yFnhxF1CjlSX/7unnBm1qoMyYf7lLF0q3jcehVSKuzIz0uK60csdikK6szGDBJmK3V36Gjo2U/7 wEERzixPIAnKNmykhTQ3rA==; Date: Sun, 20 Apr 2025 22:22:54 +0300 Message-Id: <86a58a63jl.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87bjsq90ub.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 20 Apr 2025 20:53:00 +0300) References: <87bjsq90ub.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Sean Whitton > From: Juri Linkov > Date: Sun, 20 Apr 2025 20:53:00 +0300 > > > diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el > > index 0da0b90975c..3c3288777c8 100644 > > --- a/lisp/vc/log-edit.el > > +++ b/lisp/vc/log-edit.el > > @@ -857,7 +857,8 @@ vc-log-fileset > > (defun log-edit-diff-fileset () > > "Display diffs for the files to be committed." > > (interactive) > > - (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset))) > > + (save-selected-window > > + (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset)))) > > This change broke the command 'log-edit-show-diff' ('C-c C-d'). > Previously it selected the diff window. Now it always stays in the vc-log window. Isn't it a bug in log-edit-show-diff? Why does it assume that it will be put in the diff window? It should instead switch there. From unknown Thu Aug 14 22:20:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Apr 2025 01:54:09 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 77946@debbugs.gnu.org, Juri Linkov Received: via spool by 77946-submit@debbugs.gnu.org id=B77946.174520043326273 (code B ref 77946); Mon, 21 Apr 2025 01:54:09 +0000 Received: (at 77946) by debbugs.gnu.org; 21 Apr 2025 01:53:53 +0000 Received: from localhost ([127.0.0.1]:57494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6gLz-0006p8-G0 for submit@debbugs.gnu.org; Sun, 20 Apr 2025 21:53:52 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:56258) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6gLg-0006mT-HB for 77946@debbugs.gnu.org; Sun, 20 Apr 2025 21:53:39 -0400 DKIM-Signature: a=rsa-sha256; b=U30FZLdZ6ZPbKzxT2wKSw4k90pMlRW5f01excr4opqVOVKR22onCvqt6gNjkAmLFwEs6yaK+8LnC0fT4Jzcya9l/vOE9mA8So3VZuEqWDo3gEgq2WsWCI1kWuv2QmGPCgsg6ADDmtUVrwtJ9va3W6fLvVX+ATY/1ZU2dy2ApBz3Bb1V8BFLidPg18fDVyinhcpbkCz7qK012fGN0lq09beaRJBwwsNs+ImBZOz0HIu2CHj158m/3EAVT7Bx25WvfbX0TR2IADwUWt/jyKR1KecZjDTbmFCTVN64ivZxJI4KUmAu1TevU/5WgL4FYLtUlbSjLXzqnitIy69NorBknAA==; s=purelymail3; d=spwhitton.name; v=1; bh=JN+k1WunZBFjPYwIGt2n6LsAX5kGkcSwie38kV7/Tyg=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=i3IZgo7PlKWdF41/bBKJxrqRXm58RGVYa8XNWooH7n4DHVjoVpPPtg9wLYqweKfA3ikZYi8MyPuDN0JMhJN+DfI2sklgf09Ou2UR4pyMojaGUn/kkuQd9/WdhugDnrJEZWmOa6KMcL6Z709z3gP4nSplnp+MDAeCcfUob0xzmxKQ5WWUtmS8ecLAt/Sg3tW/yajkvzAXE95OfvqL/ieGNpNHhK9nqtZGnEuiCJgWNyD64zRTgiomtCdW/sHwsVZECWgKmiJ2gG4VavPRv1WiQLyQHZOWdO8GTn4IUQQ+YzF7KNScCPSGwHa+cCUEPoLbJbhZhUTuGZ0SSNTmy9u0Rg==; s=purelymail3; d=purelymail.com; v=1; bh=JN+k1WunZBFjPYwIGt2n6LsAX5kGkcSwie38kV7/Tyg=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77946@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 957779717; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 21 Apr 2025 01:53:17 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 92F4A7F2862; Mon, 21 Apr 2025 09:53:10 +0800 (CST) From: Sean Whitton In-Reply-To: <86a58a63jl.fsf@gnu.org> References: <87bjsq90ub.fsf@mail.linkov.net> <86a58a63jl.fsf@gnu.org> Date: Mon, 21 Apr 2025 09:53:10 +0800 Message-ID: <87ldrugu0p.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Sun 20 Apr 2025 at 10:22pm +03, Eli Zaretskii wrote: >> Cc: Sean Whitton >> From: Juri Linkov >> Date: Sun, 20 Apr 2025 20:53:00 +0300 >> >> > diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el >> > index 0da0b90975c..3c3288777c8 100644 >> > --- a/lisp/vc/log-edit.el >> > +++ b/lisp/vc/log-edit.el >> > @@ -857,7 +857,8 @@ vc-log-fileset >> > (defun log-edit-diff-fileset () >> > "Display diffs for the files to be committed." >> > (interactive) >> > - (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset))) >> > + (save-selected-window >> > + (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset)))) >> >> This change broke the command 'log-edit-show-diff' ('C-c C-d'). >> Previously it selected the diff window. Now it always stays in the vc-log window. > > Isn't it a bug in log-edit-show-diff? Why does it assume that it will > be put in the diff window? It should instead switch there. Yes, I think you're basically right, but I think we should have two things: - a command, bound to C-c C-d, that both displays and selects the window - a function, an option for log-edit-hook, that only displays the window So the changes required are: - write a new command that both dispalys and selects the window, bind it to C-c C-d - add log-edit-show-diff to the customisation options for log-edit-hook. -- Sean Whitton From unknown Thu Aug 14 22:20:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Apr 2025 06:54:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: Eli Zaretskii , 77946@debbugs.gnu.org Received: via spool by 77946-submit@debbugs.gnu.org id=B77946.174521841713765 (code B ref 77946); Mon, 21 Apr 2025 06:54:06 +0000 Received: (at 77946) by debbugs.gnu.org; 21 Apr 2025 06:53:37 +0000 Received: from localhost ([127.0.0.1]:59506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6l26-0003Zj-M8 for submit@debbugs.gnu.org; Mon, 21 Apr 2025 02:53:36 -0400 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:53749) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6l21-0003YX-Qs for 77946@debbugs.gnu.org; Mon, 21 Apr 2025 02:53:31 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7FC00441FE; Mon, 21 Apr 2025 06:53:22 +0000 (UTC) From: Juri Linkov In-Reply-To: <87ldrugu0p.fsf@melete.silentflame.com> Organization: LINKOV.NET References: <87bjsq90ub.fsf@mail.linkov.net> <86a58a63jl.fsf@gnu.org> <87ldrugu0p.fsf@melete.silentflame.com> Date: Mon, 21 Apr 2025 09:28:11 +0300 Message-ID: <87plh63un0.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgedtudejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopeejjeelgeeiseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> > diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el >>> > index 0da0b90975c..3c3288777c8 100644 >>> > --- a/lisp/vc/log-edit.el >>> > +++ b/lisp/vc/log-edit.el >>> > @@ -857,7 +857,8 @@ vc-log-fileset >>> > (defun log-edit-diff-fileset () >>> > "Display diffs for the files to be committed." >>> > (interactive) >>> > - (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset))) >>> > + (save-selected-window >>> > + (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset)))) >>> >>> This change broke the command 'log-edit-show-diff' ('C-c C-d'). >>> Previously it selected the diff window. Now it always stays in the vc-log window. >> >> Isn't it a bug in log-edit-show-diff? Why does it assume that it will >> be put in the diff window? It should instead switch there. > > Yes, I think you're basically right, but I think we should have two > things: > > - a command, bound to C-c C-d, that both displays and selects the window > - a function, an option for log-edit-hook, that only displays the window > > So the changes required are: > > - write a new command that both dispalys and selects the window, bind it > to C-c C-d > > - add log-edit-show-diff to the customisation options for log-edit-hook. Please note that the decision whether to select the window can be customized by the users with 'post-command-select-window' in 'display-buffer-alist'. So preferably the commands should just call the plain 'display-buffer' or 'pop-to-buffer'. I suppose for the required changes above you meant using 'pop-to-buffer' for the first and 'display-buffer' for the second. From unknown Thu Aug 14 22:20:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Apr 2025 00:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Eli Zaretskii , 77946@debbugs.gnu.org Received: via spool by 77946-submit@debbugs.gnu.org id=B77946.174528139024566 (code B ref 77946); Tue, 22 Apr 2025 00:24:01 +0000 Received: (at 77946) by debbugs.gnu.org; 22 Apr 2025 00:23:10 +0000 Received: from localhost ([127.0.0.1]:41228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u71Pp-0006OA-NC for submit@debbugs.gnu.org; Mon, 21 Apr 2025 20:23:10 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:52844) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u71Pl-0006NL-EF for 77946@debbugs.gnu.org; Mon, 21 Apr 2025 20:23:07 -0400 DKIM-Signature: a=rsa-sha256; b=TIr9rAo/g9BKMjTMGDLPyUaO74voBatAqeJE6NGPXMDOGjiQF7J/u29ODXHqpXxwGRSSiJcuXW2dYW3azjXZDshMKpfTjziuWsKmFiKXsKYfW3Wn50ntEFTbPfiw1eWcong5unhIsVLavcvTodIXyMq1JPLVbWi2lseX92vW04E+3W65xQMjzZySeKH52FyfgJnW1qVOVA9g4eswtTqlqyIWChxOpGmfBdAlaEi3etNrGQO2K219FpIHjmsLZoIAawf3NVqIkrTPcPZDbtUgg/AXXbaoLhzyZH+AbEl4kx9VhbuaAGJGHi8nVjwPMPxc+7Phg7+OTOZbCi5G5uZBlg==; s=purelymail3; d=spwhitton.name; v=1; bh=ztuf8wSZjAtLNAnrIROmuBCUCIJgdDmBNol4QWzLYog=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=bsFsN5fB86Bg8nSroKripsKYVAhTqhGOqaFWeuErxrnhhfCoyIEYVVq5POu2WJBiZyeIKwkaIdvNEzVcMCcfRXbzWYCqDpbc3gXlDYyBzVT6yvGbJx+fXD8x/jKxSxzXQ3+cuHSIbLIXD/ao3RfZaCqHtMJMky7Rvpw7rk09gYJLv9G4VCUgb85/b92u6rR5lSxhtwgK25LwqkTySTL5c8hAguS7IkGE2nuE1rDsRaOGoGT5sP6jaMKQJGcR+9tTfCjAanzIgjbBW6L0ml5D7hfG8WCbfPS0GKoZrdHmLjI39qUU3ewSyNtHPfk7Vn9A4hxWd7sRWy2Xy3g8eDMAgg==; s=purelymail3; d=purelymail.com; v=1; bh=ztuf8wSZjAtLNAnrIROmuBCUCIJgdDmBNol4QWzLYog=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77946@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1733423097; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 22 Apr 2025 00:22:58 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 0E1047E06D6; Tue, 22 Apr 2025 08:22:55 +0800 (CST) From: Sean Whitton In-Reply-To: <87plh63un0.fsf@mail.linkov.net> References: <87bjsq90ub.fsf@mail.linkov.net> <86a58a63jl.fsf@gnu.org> <87ldrugu0p.fsf@melete.silentflame.com> <87plh63un0.fsf@mail.linkov.net> Date: Tue, 22 Apr 2025 08:22:55 +0800 Message-ID: <87h62hgi3k.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Mon 21 Apr 2025 at 09:28am +03, Juri Linkov wrote: > Please note that the decision whether to select the window > can be customized by the users with 'post-command-select-window' > in 'display-buffer-alist'. So preferably the commands should just > call the plain 'display-buffer' or 'pop-to-buffer'. I suppose > for the required changes above you meant using 'pop-to-buffer' > for the first and 'display-buffer' for the second. Thanks for the pointer. I'll try to figure out an optimal solution. -- Sean Whitton From unknown Thu Aug 14 22:20:38 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#77946: closed (Re: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again) Message-ID: References: <87selrd8qh.fsf@melete.silentflame.com> <87bjsq90ub.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 77946 X-Gnu-PR-Package: emacs Reply-To: 77946@debbugs.gnu.org Date: Tue, 29 Apr 2025 02:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1745892302-32724-1" This is a multi-part message in MIME format... ------------=_1745892302-32724-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #77946: master d283db57733: Fix window selection after log-edit-show-diff, = again which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 77946@debbugs.gnu.org. --=20 77946: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77946 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1745892302-32724-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 77946-done) by debbugs.gnu.org; 29 Apr 2025 02:04:08 +0000 Received: from localhost ([127.0.0.1]:41617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9aKM-0008Pg-J5 for submit@debbugs.gnu.org; Mon, 28 Apr 2025 22:04:08 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:58680) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9aKG-0008O5-Ok for 77946-done@debbugs.gnu.org; Mon, 28 Apr 2025 22:04:03 -0400 DKIM-Signature: a=rsa-sha256; b=b23Lvd3oyqqu4pku1SUr7M5xnLRP9GCVJKyiZpaFlX7agTBwONzIH2ah9YhE7kpnAeCRmLccRqHs37/rc/vMaDM/pTA4RiNt1i7v7vV3kghH61o9AA8PUO34ag3zM/kHFlYaWlCia6ypNB85E4GFr2IlWViBwYYPn93mosGLgVP3TZVu4f7xML2bRVUk3pN4HczY8yczGsDd4SzG4w5lV26Pr0tcAL9PUcMfZyXzGXistuRGacDMtsYieh08PFPxh8T99VWX8wFnEdaaIk+qEnUM+7cH/FiE5GrQOPvxJAzbyVhvDzq8mVgp/lhCVe/LCYs7lxBow8slL9tQI8Bp7g==; s=purelymail1; d=spwhitton.name; v=1; bh=BsIw6/QL1WoIgVfC1RJUq7hj41P3vtzAkzU9DqcZlQg=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=OyLyEuTCMrLR1XEbzY3BP801EPF1l4L+i0wsCsuyw1v+vN62RND7q8wwRfMSbaXeS0kL8evVV1APi/K4UtHV+sc69PJYJKGRBwpSU1gUfM0v9gqKKWQOD8blVkXsGBDILA2CouSy3345Qr1CQJgq5zEOpsgKg8hwBxmPByIlYw+xZNFIoakpp+R/2dS7mFhqVbroLmwTcjOhFciomKMYbtXB0Iv4L2vMwno++5u0qwiFgwh/BK+Z5nyGajBy1DuuiifPPEHY2Soo3IkbKYvyGKth3qjfUnyw8kT6olyUDz98wvKyMVDK/eSny6rVmNYlkmU8eC2dgq/YTwwdQ7Ykhg==; s=purelymail1; d=purelymail.com; v=1; bh=BsIw6/QL1WoIgVfC1RJUq7hj41P3vtzAkzU9DqcZlQg=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77946-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 6816175; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 29 Apr 2025 02:03:54 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 1527A7E4058; Tue, 29 Apr 2025 10:03:50 +0800 (CST) From: Sean Whitton To: Juri Linkov , 77946-done@debbugs.gnu.org Subject: Re: bug#77946: master d283db57733: Fix window selection after log-edit-show-diff, again In-Reply-To: <87bjsq90ub.fsf@mail.linkov.net> References: <87bjsq90ub.fsf@mail.linkov.net> Date: Tue, 29 Apr 2025 10:03:50 +0800 Message-ID: <87selrd8qh.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77946-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Hello, This should be fixed now. Thanks again for the discussion. -- Sean Whitton ------------=_1745892302-32724-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Apr 2025 17:55:15 +0000 Received: from localhost ([127.0.0.1]:52746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6Yss-0001LN-5A for submit@debbugs.gnu.org; Sun, 20 Apr 2025 13:55:14 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38274) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6Yrv-0001AE-6I for submit@debbugs.gnu.org; Sun, 20 Apr 2025 13:54:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6Yro-0007G2-Bd for bug-gnu-emacs@gnu.org; Sun, 20 Apr 2025 13:54:09 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6Yrl-0002jY-Jk for bug-gnu-emacs@gnu.org; Sun, 20 Apr 2025 13:54:08 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 9DF7E41BC0 for ; Sun, 20 Apr 2025 17:54:01 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: master d283db57733: Fix window selection after log-edit-show-diff, again Organization: LINKOV.NET X-Debbugs-Cc: Sean Whitton Date: Sun, 20 Apr 2025 20:53:00 +0300 Message-ID: <87bjsq90ub.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: 0 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvfeekheekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvufhofffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeejgffgtddthfelteejkeejueegvdekgfdufffgtdehvddtkeetveehgfffjeeuteenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepuddprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::226; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) > diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el > index 0da0b90975c..3c3288777c8 100644 > --- a/lisp/vc/log-edit.el > +++ b/lisp/vc/log-edit.el > @@ -857,7 +857,8 @@ vc-log-fileset > (defun log-edit-diff-fileset () > "Display diffs for the files to be committed." > (interactive) > - (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset))) > + (save-selected-window > + (vc-diff nil nil (list log-edit-vc-backend vc-log-fileset)))) This change broke the command 'log-edit-show-diff' ('C-c C-d'). Previously it selected the diff window. Now it always stays in the vc-log window. ------------=_1745892302-32724-1--