GNU bug report logs - #77932
[PATCH] gnu: Upgrade guile-srfi-133 package definition.

Previous Next

Package: guix-patches;

Reported by: Yuval Langer <yuval.langer <at> gmail.com>

Date: Sun, 20 Apr 2025 05:43:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

To reply to this bug, email your comments to 77932 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#77932; Package guix-patches. (Sun, 20 Apr 2025 05:43:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Yuval Langer <yuval.langer <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 20 Apr 2025 05:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuval Langer <yuval.langer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Yuval Langer <yuval.langer <at> gmail.com>
Subject: [PATCH] gnu: Upgrade guile-srfi-133 package definition.
Date: Sun, 20 Apr 2025 08:41:44 +0300
* gnu/packages/guile-xyz.scm (guile-srfi-133): Update source to the latest commit hash.
* gnu/packages/guile-xyz.scm (guile-srfi-133): Bump version number to "1.0.0"
* gnu/packages/guile-xyz.scm (guile-srfi-133): New run-tests phase - all 106 pass.
---
 gnu/packages/guile-xyz.scm | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 537e84d3f82..494ab5a86d8 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -4254,17 +4254,17 @@ structures.  This package re-uses the SRFI sample implementation.")
 (define-public guile-srfi-133
   (package
     (name "guile-srfi-133")
-    (version "0.0.1")
+    (version "1.0.0")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
              (url "https://github.com/scheme-requests-for-implementation/srfi-133")
-             (commit "db81a114cd3e23375f024baec15482614ec90453")))
+             (commit "4204de98b0945e7419975ed259803848de23cbf1")))
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "0a7srl72291yah0aj6rwddhj041v2spximhknjj7hczlparsrm7f"))))
+         "1arnjbcxa126mcmdnyhgkbsbfqknzal0ynrnbgvdcfl2kfz93ng9"))))
     (build-system guile-build-system)
     (arguments
      (list
@@ -4273,7 +4273,7 @@ structures.  This package re-uses the SRFI sample implementation.")
           (add-after 'unpack 'move-create-and-delete-files
             (lambda _
               (rename-file "vectors" "srfi")
-              (rename-file "srfi/vectors-test.scm" "srfi/srfi-test.scm")
+              (rename-file "srfi/vectors-test.scm" "tests/tests.scm")
               (rename-file "srfi/vectors-impl.scm" "srfi/srfi-impl.scm")
               (with-output-to-file "srfi/srfi-133.scm"
                 (lambda ()
@@ -4310,11 +4310,13 @@ structures.  This package re-uses the SRFI sample implementation.")
             vector->string string->vector))
 
 (include \"srfi-impl.scm\")")))
-              (for-each (lambda (filename)
-                          (delete-file filename))
-                        '("tests/run.scm"
+              (for-each delete-file
+                        '("srfi/vectors.scm"
                           "srfi/vectors.sld"
-                          "srfi/vectors.scm")))))))
+                          "tests/run.scm"))))
+          (add-after 'build 'run-tests
+            (lambda _
+              (system* "guile" "tests/tests.scm"))))))
     (native-inputs
      (list guile-3.0))
     (home-page "https://github.com/scheme-requests-for-implementation/srfi-133")
-- 
2.30.2





Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Wed, 11 Jun 2025 13:09:02 GMT) Full text and rfc822 format available.

Notification sent to Yuval Langer <yuval.langer <at> gmail.com>:
bug acknowledged by developer. (Wed, 11 Jun 2025 13:09:03 GMT) Full text and rfc822 format available.

Message #10 received at 77932-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Yuval Langer <yuval.langer <at> gmail.com>
Cc: 77932-done <at> debbugs.gnu.org
Subject: Re: [bug#77932] [PATCH] gnu: Upgrade guile-srfi-133 package
 definition.
Date: Wed, 11 Jun 2025 14:08:12 +0100
[Message part 1 (text/plain, inline)]
Yuval Langer <yuval.langer <at> gmail.com> writes:

> * gnu/packages/guile-xyz.scm (guile-srfi-133): Update source to the latest commit hash.
> * gnu/packages/guile-xyz.scm (guile-srfi-133): Bump version number to "1.0.0"
> * gnu/packages/guile-xyz.scm (guile-srfi-133): New run-tests phase - all 106 pass.
> ---
>  gnu/packages/guile-xyz.scm | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)

Thanks for the patch, I've made some tweaks and pushed this to master as
d276296a6f8d09cc8fcbe927abb67dca52a71667.

Chris
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 8 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.