GNU bug report logs - #77928
[PATCH] use-package :custom-face is meant to behave like custom-set-face

Previous Next

Full log

View this message in rfc822 format

From: John Wiegley <johnw <at> gnu.org>
To: Steven Allen <steven <at> stebalien.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, shields <at> msrl.com, 77928 <at> debbugs.gnu.org
Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces
Date: Sun, 08 Jun 2025 10:46:14 -0700

>>>>> Steven Allen <steven <at> stebalien.com> writes:

> It would help to better understand how it was intended to behave:

> - Should :custom-face override the theme or should the theme override
>   :custom-face?

I’ve never used themes before, so I wasn’t thinking of them at all when the
feature was added. Someone who uses themes a lot, and customizes them, should
be asked this question.

> - Should customizations made via :custom-face be merged with the original
>   face definition (as with `custom-set-faces') or should they completely
>   replace the underlying face.

I would expect the behavior to be whatever `custom-set-faces' does. Since
use-package is only intended to expand to “best practice” Emacs Lisp, it
shouldn’t add any new behavior in my opinion.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.