GNU bug report logs - #77928
[PATCH] use-package :custom-face is meant to behave like custom-set-face

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Steven Allen <steven <at> stebalien.com>
Cc: 77928 <at> debbugs.gnu.org, johnw <at> gnu.org, shields <at> msrl.com
Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces
Date: Sat, 07 Jun 2025 12:49:12 +0300

> From: Steven Allen <steven <at> stebalien.com>
> Cc: johnw <at> gnu.org, shields <at> msrl.com, 77928 <at> debbugs.gnu.org
> Date: Wed, 04 Jun 2025 12:07:12 -0700
> 
> There are two parts to this report:
> 
> 1. Bug: use-package's ":custom-face" no longer overrides themed
>   faces.
> 2. Opinion: ":custom-face" SHOULD merge the user-specified face spec
>   with the underlying face spec (contrary to the original report).

I'm not sure I agree.  I think the concept is that themes override any
other face definitions, otherwise themes couldn't have done their main
job.

> IMO, :custom-face SHOULD behave like "custom-set-faces".

Not sure I agree, but maybe John could state his opinions on that?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.