GNU bug report logs - #77928
[PATCH] use-package :custom-face is meant to behave like custom-set-face

Previous Next

Full log

Message #70 received at 77928 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andy Moreton <andrewjmoreton <at> gmail.com>
Cc: 77928 <at> debbugs.gnu.org, Steven Allen <steven <at> stebalien.com>,
 shields <at> msrl.com
Subject: Re: bug#77928: 31.0.50;
 ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces
Date: Sat, 31 May 2025 09:44:23 +0300

> From: Andy Moreton <andrewjmoreton <at> gmail.com>
> Date: Fri, 30 May 2025 19:23:38 +0100
> 
> On Wed 28 May 2025, Eli Zaretskii wrote:
> 
> > Unfortunately, what you say above seems to assume the level of
> > detailed knowledge in themes, use-package, and their interactions with
> > Customize that I don't have.  I think I know how faces work and how
> > face merging works, but after reading your explanations and examples
> > several times I'm sorry to say that I'm utterly confused by what you
> > say and don't have any clear idea about the problem, its consequences,
> > and your analysis of the original issue and its fix.
> >
> > So either someone explains this to me in terms I can understand and
> > reason about, or we will need to wait for someone more knowledgeable
> > in this stuff to pick up the gauntlet.
> >
> > Alternatively, if you convince John and Michael that the changes you
> > think should be done are indeed the way to go, I will gladly delegate
> > the decision to you three.
> >
> > Sorry I couldn't be of more help.
> 
> I'm not at all expert, but this effect is easily reproducible.
> Using the mingw64 build on Windows:
> 
> a) build from master, and start with "runemacs.exe -Q"
> b) in the scratch buffer, evaluate:
>   (use-package faces
>     :custom-face
>     (default
>      ((((class color)) :font "DejaVu Sans Mono-9" :background "gray85")))
>     (variable-pitch
>      ((((class color)) :font "Liberation Sans-10"))) )
> 
> c) Display a tooltip e.g. from moving the mouse over the major mode
>    indicator on the modeline. The tooltip is shown using a monospaced
>    font, even though the tooltip face inherits from variable-pitch.
> 
> d) "M-x describe-face RET tooltip RET" shows the tooltip face as
>    expected, with the sample text in a variable pitch font.
> 
> e) Repeat all steps, but instead of (b), evaluate:
>   (use-package faces
>     :init
>     (apply #'face-spec-set
>            '(variable-pitch
>              ((((class color)) :font "Liberation Sans-11"))))
>     :custom-face
>     (default
>      ((((class color)) :font "DejaVu Sans Mono-9" :background "gray85")))
>     )
> 
>    That produces the expected variable pitch font for the tooltip.
> 
> 
> Thus this is not working properly, even without interaction with themes.

Thanks.  Unfortunately, I'm not a bit wiser after reading your recipe
for several times (I don't have the Liberation Sans font here to fully
reproduce it).  You are showing the results using use-package, which I
don't use and know very little about, and John did agree with the
original patch back when it was proposed.

So I'm still unable to decide what to do with this, because I don't
understands well enough what is going on and what is being claimed.

But maybe someone else of the participants (whom you elided, and I
added back now) could understand better what you said, and explain it
or suggest a solution.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.